[jira] [Commented] (TINKERPOP-1648) XyzPropertyChangedEvent contains incomplete data

[Daniel Kuppitz (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925391#comment-15925391
 ] 

Daniel Kuppitz commented on TINKERPOP-1648:
---

Î created a development branch (branched off of {{tp31/}}) and added 
{{EmptyProperty.of(key)}} as well as {{EmptyVertexProperty.of(key)}}. I've used 
the local build in a side project where I'm using {{EventStrategy}} and it all 
worked well. However, I'm not sure how to write a proper test for it in 
TinkerPop.

> XyzPropertyChangedEvent contains incomplete data
> 
>
> Key: TINKERPOP-1648
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1648
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.1.6
>Reporter: Daniel Kuppitz
>Assignee: stephen mallette
>
> https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/AddPropertyStep.java#L94-L98
> In case of new properties we create events that only contain the new value of 
> the new property, but the actual property key is unknown.
> Haven't set the affected version(s) as it affects all versions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1644) Improve script compilation process and include metrics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15925109#comment-15925109
 ] 

ASF GitHub Bot commented on TINKERPOP-1644:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/570
  
VOTE: +1


> Improve script compilation process and include metrics
> --
>
> Key: TINKERPOP-1644
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1644
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>
> Currently there is no synchronisation around script compilation. This means 
> that if a particularly heavy script is in use, many threads may end up 
> compiling the same script.
> It would seem like a good idea to have some some sort of synchronisation to 
> prevent ever getting to this stage.
> In addition, there will be cases where users will repeatedly submit broken 
> scripts to the server. In this case it is useful to log the error the first 
> time the script compilation is attempted and then cache the error for 
> subsequent runs.
> Finally I have found some scripts take in excess of 30 seconds to compile. To 
> aid performance debugging the script compilation times should be included in 
> the logs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #570: TINKERPOP-1644 Improve script compilation process and ...

[dkuppitz]

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/570
  
VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1366) TraversalStrategy.isApplicable(Traversal root)

[Marko A. Rodriguez (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924957#comment-15924957
 ] 

Marko A. Rodriguez commented on TINKERPOP-1366:
---

To make this pure, we should first implement 
https://issues.apache.org/jira/browse/TINKERPOP-1568

> TraversalStrategy.isApplicable(Traversal root)
> --
>
> Key: TINKERPOP-1366
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1366
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.0-incubating
>Reporter: Marko A. Rodriguez
>
> This is a non-breaking update to the {{TraversalStrategy}} API. There are 
> currently 2 strategies that need to analyze the traversal from the root 
> traversal to know if the strategy should be applied. The problem, strategies 
> work on a per-traversal basis -- not on the entire traversal as a whole. To 
> make it more efficient for these global analysis traversal, we should have a 
> {{boolean TraversalStrategy.isApplicable(Traversal root)}} which will run 
> once and only run to determine if the strategy should be applied to all 
> nested traversals.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1644) Improve script compilation process and include metrics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924875#comment-15924875
 ] 

ASF GitHub Bot commented on TINKERPOP-1644:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/570
  
Works now. 

VOTE +1



> Improve script compilation process and include metrics
> --
>
> Key: TINKERPOP-1644
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1644
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>
> Currently there is no synchronisation around script compilation. This means 
> that if a particularly heavy script is in use, many threads may end up 
> compiling the same script.
> It would seem like a good idea to have some some sort of synchronisation to 
> prevent ever getting to this stage.
> In addition, there will be cases where users will repeatedly submit broken 
> scripts to the server. In this case it is useful to log the error the first 
> time the script compilation is attempted and then cache the error for 
> subsequent runs.
> Finally I have found some scripts take in excess of 30 seconds to compile. To 
> aid performance debugging the script compilation times should be included in 
> the logs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #570: TINKERPOP-1644 Improve script compilation process and ...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/570
  
Works now. 

VOTE +1



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1644) Improve script compilation process and include metrics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924857#comment-15924857
 ] 

ASF GitHub Bot commented on TINKERPOP-1644:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/570
  
Should work if you use the `CompilationOptionsCustomizerProvider` in your 
gremlin-server.yaml as you tried to do with the `CompilationOptionsCustomizer` 
previously:

```text

"org.apache.tinkerpop.gremlin.groovy.jsr223.customizer.CompilationOptionsCustomizerProvider":[10],
```

I just pushed another commit with a few lines of additional docs related to 
that configuration option.


> Improve script compilation process and include metrics
> --
>
> Key: TINKERPOP-1644
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1644
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>
> Currently there is no synchronisation around script compilation. This means 
> that if a particularly heavy script is in use, many threads may end up 
> compiling the same script.
> It would seem like a good idea to have some some sort of synchronisation to 
> prevent ever getting to this stage.
> In addition, there will be cases where users will repeatedly submit broken 
> scripts to the server. In this case it is useful to log the error the first 
> time the script compilation is attempted and then cache the error for 
> subsequent runs.
> Finally I have found some scripts take in excess of 30 seconds to compile. To 
> aid performance debugging the script compilation times should be included in 
> the logs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #570: TINKERPOP-1644 Improve script compilation process and ...

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/570
  
Should work if you use the `CompilationOptionsCustomizerProvider` in your 
gremlin-server.yaml as you tried to do with the `CompilationOptionsCustomizer` 
previously:

```text

"org.apache.tinkerpop.gremlin.groovy.jsr223.customizer.CompilationOptionsCustomizerProvider":[10],
```

I just pushed another commit with a few lines of additional docs related to 
that configuration option.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1644) Improve script compilation process and include metrics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924836#comment-15924836
 ] 

ASF GitHub Bot commented on TINKERPOP-1644:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/570
  
@spmallette If you could just clarify if compilation timeout is 
configurable in 3.2? if so, how?


> Improve script compilation process and include metrics
> --
>
> Key: TINKERPOP-1644
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1644
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>
> Currently there is no synchronisation around script compilation. This means 
> that if a particularly heavy script is in use, many threads may end up 
> compiling the same script.
> It would seem like a good idea to have some some sort of synchronisation to 
> prevent ever getting to this stage.
> In addition, there will be cases where users will repeatedly submit broken 
> scripts to the server. In this case it is useful to log the error the first 
> time the script compilation is attempted and then cache the error for 
> subsequent runs.
> Finally I have found some scripts take in excess of 30 seconds to compile. To 
> aid performance debugging the script compilation times should be included in 
> the logs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #570: TINKERPOP-1644 Improve script compilation process and ...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/570
  
@spmallette If you could just clarify if compilation timeout is 
configurable in 3.2? if so, how?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1648) XyzPropertyChangedEvent contains incomplete data

[Jason Plurad (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924636#comment-15924636
 ] 

Jason Plurad commented on TINKERPOP-1648:
-

Possible duplicate of https://issues.apache.org/jira/browse/TINKERPOP-1504

> XyzPropertyChangedEvent contains incomplete data
> 
>
> Key: TINKERPOP-1648
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1648
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.1.6
>Reporter: Daniel Kuppitz
>Assignee: stephen mallette
>
> https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/AddPropertyStep.java#L94-L98
> In case of new properties we create events that only contain the new value of 
> the new property, but the actual property key is unknown.
> Haven't set the affected version(s) as it affects all versions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (TINKERPOP-1649) TinkerGraph performance enhancements

[stephen mallette (JIRA)]

stephen mallette created TINKERPOP-1649:
---

 Summary: TinkerGraph performance enhancements
 Key: TINKERPOP-1649
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1649
 Project: TinkerPop
  Issue Type: Improvement
  Components: tinkergraph
Affects Versions: 3.2.4
Reporter: stephen mallette
Assignee: stephen mallette


In doing TINKERPOP-1642 I noticed an area or two where there could be some 
improvements made to the performance of TinkerGraph. So as not to confuse the 
performance improvements of gremlin-core in TINKERPOP-1642 I decided to create 
a separate issue for TinkrGraph specific performance enhancements.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1644) Improve script compilation process and include metrics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924547#comment-15924547
 ] 

ASF GitHub Bot commented on TINKERPOP-1644:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/570
  
Changes have been pushed - hopefully I have all issues addressed now.


> Improve script compilation process and include metrics
> --
>
> Key: TINKERPOP-1644
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1644
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>
> Currently there is no synchronisation around script compilation. This means 
> that if a particularly heavy script is in use, many threads may end up 
> compiling the same script.
> It would seem like a good idea to have some some sort of synchronisation to 
> prevent ever getting to this stage.
> In addition, there will be cases where users will repeatedly submit broken 
> scripts to the server. In this case it is useful to log the error the first 
> time the script compilation is attempted and then cache the error for 
> subsequent runs.
> Finally I have found some scripts take in excess of 30 seconds to compile. To 
> aid performance debugging the script compilation times should be included in 
> the logs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #570: TINKERPOP-1644 Improve script compilation process and ...

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/570
  
Changes have been pushed - hopefully I have all issues addressed now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1644) Improve script compilation process and include metrics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924543#comment-15924543
 ] 

ASF GitHub Bot commented on TINKERPOP-1644:
---

Github user spmallette commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/570#discussion_r105962373
  
--- Diff: 
gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/customizer/CompilationOptionsCustomizerProvider.java
 ---
@@ -31,13 +31,17 @@
 @Deprecated
 public class CompilationOptionsCustomizerProvider implements 
CompilerCustomizerProvider {
 
-private final int expectedCompilationTime;
+private final long expectedCompilationTime;
 
-public CompilationOptionsCustomizerProvider(final int 
expectedCompilationTime) {
-this.expectedCompilationTime = expectedCompilationTime;
+public CompilationOptionsCustomizerProvider(final Integer 
expectedCompilationTime) {
+this.expectedCompilationTime = expectedCompilationTime.longValue();
 }
 
-public int getExpectedCompilationTime() {
+public CompilationOptionsCustomizerProvider(final Long 
expectedCompilationTime) {
+this.expectedCompilationTime = expectedCompilationTime.intValue();
--- End diff --

ffs


> Improve script compilation process and include metrics
> --
>
> Key: TINKERPOP-1644
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1644
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>
> Currently there is no synchronisation around script compilation. This means 
> that if a particularly heavy script is in use, many threads may end up 
> compiling the same script.
> It would seem like a good idea to have some some sort of synchronisation to 
> prevent ever getting to this stage.
> In addition, there will be cases where users will repeatedly submit broken 
> scripts to the server. In this case it is useful to log the error the first 
> time the script compilation is attempted and then cache the error for 
> subsequent runs.
> Finally I have found some scripts take in excess of 30 seconds to compile. To 
> aid performance debugging the script compilation times should be included in 
> the logs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop pull request #570: TINKERPOP-1644 Improve script compilation proce...

[spmallette]

Github user spmallette commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/570#discussion_r105962373
  
--- Diff: 
gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/customizer/CompilationOptionsCustomizerProvider.java
 ---
@@ -31,13 +31,17 @@
 @Deprecated
 public class CompilationOptionsCustomizerProvider implements 
CompilerCustomizerProvider {
 
-private final int expectedCompilationTime;
+private final long expectedCompilationTime;
 
-public CompilationOptionsCustomizerProvider(final int 
expectedCompilationTime) {
-this.expectedCompilationTime = expectedCompilationTime;
+public CompilationOptionsCustomizerProvider(final Integer 
expectedCompilationTime) {
+this.expectedCompilationTime = expectedCompilationTime.longValue();
 }
 
-public int getExpectedCompilationTime() {
+public CompilationOptionsCustomizerProvider(final Long 
expectedCompilationTime) {
+this.expectedCompilationTime = expectedCompilationTime.intValue();
--- End diff --

ffs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (TINKERPOP-1648) XyzPropertyChangedEvent contains incomplete data

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette updated TINKERPOP-1648:

Affects Version/s: 3.1.6

Just pick the oldest version you know of that it affects - I set it to 3.1.6

> XyzPropertyChangedEvent contains incomplete data
> 
>
> Key: TINKERPOP-1648
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1648
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.1.6
>Reporter: Daniel Kuppitz
>Assignee: stephen mallette
>
> https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/AddPropertyStep.java#L94-L98
> In case of new properties we create events that only contain the new value of 
> the new property, but the actual property key is unknown.
> Haven't set the affected version(s) as it affects all versions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1644) Improve script compilation process and include metrics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924526#comment-15924526
 ] 

ASF GitHub Bot commented on TINKERPOP-1644:
---

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/570#discussion_r105959819
  
--- Diff: 
gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/customizer/CompilationOptionsCustomizerProvider.java
 ---
@@ -31,13 +31,17 @@
 @Deprecated
 public class CompilationOptionsCustomizerProvider implements 
CompilerCustomizerProvider {
 
-private final int expectedCompilationTime;
+private final long expectedCompilationTime;
 
-public CompilationOptionsCustomizerProvider(final int 
expectedCompilationTime) {
-this.expectedCompilationTime = expectedCompilationTime;
+public CompilationOptionsCustomizerProvider(final Integer 
expectedCompilationTime) {
+this.expectedCompilationTime = expectedCompilationTime.longValue();
 }
 
-public int getExpectedCompilationTime() {
+public CompilationOptionsCustomizerProvider(final Long 
expectedCompilationTime) {
+this.expectedCompilationTime = expectedCompilationTime.intValue();
--- End diff --

Did you mean `.longValue()`?


> Improve script compilation process and include metrics
> --
>
> Key: TINKERPOP-1644
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1644
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>
> Currently there is no synchronisation around script compilation. This means 
> that if a particularly heavy script is in use, many threads may end up 
> compiling the same script.
> It would seem like a good idea to have some some sort of synchronisation to 
> prevent ever getting to this stage.
> In addition, there will be cases where users will repeatedly submit broken 
> scripts to the server. In this case it is useful to log the error the first 
> time the script compilation is attempted and then cache the error for 
> subsequent runs.
> Finally I have found some scripts take in excess of 30 seconds to compile. To 
> aid performance debugging the script compilation times should be included in 
> the logs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop pull request #570: TINKERPOP-1644 Improve script compilation proce...

[robertdale]

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/570#discussion_r105959819
  
--- Diff: 
gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/customizer/CompilationOptionsCustomizerProvider.java
 ---
@@ -31,13 +31,17 @@
 @Deprecated
 public class CompilationOptionsCustomizerProvider implements 
CompilerCustomizerProvider {
 
-private final int expectedCompilationTime;
+private final long expectedCompilationTime;
 
-public CompilationOptionsCustomizerProvider(final int 
expectedCompilationTime) {
-this.expectedCompilationTime = expectedCompilationTime;
+public CompilationOptionsCustomizerProvider(final Integer 
expectedCompilationTime) {
+this.expectedCompilationTime = expectedCompilationTime.longValue();
 }
 
-public int getExpectedCompilationTime() {
+public CompilationOptionsCustomizerProvider(final Long 
expectedCompilationTime) {
+this.expectedCompilationTime = expectedCompilationTime.intValue();
--- End diff --

Did you mean `.longValue()`?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1644) Improve script compilation process and include metrics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924520#comment-15924520
 ] 

ASF GitHub Bot commented on TINKERPOP-1644:
---

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/570#discussion_r105959185
  
--- Diff: 
gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/CompilationOptionsCustomizer.java
 ---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.tinkerpop.gremlin.groovy.jsr223;
+
+import org.apache.tinkerpop.gremlin.jsr223.Customizer;
+
+/**
+ * Provides some custom compilation options to the {@link 
GremlinGroovyScriptEngine}.
+ *
+ * @author Stephen Mallette (http://stephen.genoprime.com)
+ */
+class CompilationOptionsCustomizer implements Customizer {
+
+private final int expectedCompilationTime;
+
+public CompilationOptionsCustomizer(final int expectedCompilationTime) 
{
--- End diff --

Ok. I'm just trying to figure out how to test the compilation timeout 
without having a 5-second script.  I would like to set the timeout to 1ms.  
Even using the deprecated config doesn't seem to work for me. 
```
compilerCustomizerProviders: {
  
"org.apache.tinkerpop.gremlin.groovy.jsr223.customizer.CompilationOptionsCustomizerProvider":
 [1]}
```
Error:
```
[WARN] ScriptEngines - Could not instantiate CompilerCustomizerProvider 
implementation 
[org.apache.tinkerpop.gremlin.groovy.jsr223.customizer.CompilationOptionsCustomizerProvider].
  It will not be applied.
java.lang.IllegalStateException: Could not configure 
org.apache.tinkerpop.gremlin.groovy.jsr223.customizer.ConfigurationCustomizerProvider
 with the supplied options [1]
at 
org.apache.tinkerpop.gremlin.groovy.engine.ScriptEngines.lambda$createScriptEngine$15(ScriptEngines.java:418)
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at 
org.apache.tinkerpop.gremlin.groovy.engine.ScriptEngines.createScriptEngine(ScriptEngines.java:399)
at 
org.apache.tinkerpop.gremlin.groovy.engine.ScriptEngines.reload(ScriptEngines.java:187)
at 
org.apache.tinkerpop.gremlin.groovy.engine.GremlinExecutor.lambda$createScriptEngines$13(GremlinExecutor.java:512)
```


> Improve script compilation process and include metrics
> --
>
> Key: TINKERPOP-1644
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1644
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>
> Currently there is no synchronisation around script compilation. This means 
> that if a particularly heavy script is in use, many threads may end up 
> compiling the same script.
> It would seem like a good idea to have some some sort of synchronisation to 
> prevent ever getting to this stage.
> In addition, there will be cases where users will repeatedly submit broken 
> scripts to the server. In this case it is useful to log the error the first 
> time the script compilation is attempted and then cache the error for 
> subsequent runs.
> Finally I have found some scripts take in excess of 30 seconds to compile. To 
> aid performance debugging the script compilation times should be included in 
> the logs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop pull request #570: TINKERPOP-1644 Improve script compilation proce...

[robertdale]

Github user robertdale commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/570#discussion_r105959185
  
--- Diff: 
gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/CompilationOptionsCustomizer.java
 ---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.tinkerpop.gremlin.groovy.jsr223;
+
+import org.apache.tinkerpop.gremlin.jsr223.Customizer;
+
+/**
+ * Provides some custom compilation options to the {@link 
GremlinGroovyScriptEngine}.
+ *
+ * @author Stephen Mallette (http://stephen.genoprime.com)
+ */
+class CompilationOptionsCustomizer implements Customizer {
+
+private final int expectedCompilationTime;
+
+public CompilationOptionsCustomizer(final int expectedCompilationTime) 
{
--- End diff --

Ok. I'm just trying to figure out how to test the compilation timeout 
without having a 5-second script.  I would like to set the timeout to 1ms.  
Even using the deprecated config doesn't seem to work for me. 
```
compilerCustomizerProviders: {
  
"org.apache.tinkerpop.gremlin.groovy.jsr223.customizer.CompilationOptionsCustomizerProvider":
 [1]}
```
Error:
```
[WARN] ScriptEngines - Could not instantiate CompilerCustomizerProvider 
implementation 
[org.apache.tinkerpop.gremlin.groovy.jsr223.customizer.CompilationOptionsCustomizerProvider].
  It will not be applied.
java.lang.IllegalStateException: Could not configure 
org.apache.tinkerpop.gremlin.groovy.jsr223.customizer.ConfigurationCustomizerProvider
 with the supplied options [1]
at 
org.apache.tinkerpop.gremlin.groovy.engine.ScriptEngines.lambda$createScriptEngine$15(ScriptEngines.java:418)
at java.util.LinkedHashMap.forEach(LinkedHashMap.java:684)
at 
org.apache.tinkerpop.gremlin.groovy.engine.ScriptEngines.createScriptEngine(ScriptEngines.java:399)
at 
org.apache.tinkerpop.gremlin.groovy.engine.ScriptEngines.reload(ScriptEngines.java:187)
at 
org.apache.tinkerpop.gremlin.groovy.engine.GremlinExecutor.lambda$createScriptEngines$13(GremlinExecutor.java:512)
```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1644) Improve script compilation process and include metrics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15924484#comment-15924484
 ] 

ASF GitHub Bot commented on TINKERPOP-1644:
---

Github user spmallette commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/570#discussion_r105952425
  
--- Diff: 
gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/CompilationOptionsCustomizer.java
 ---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.tinkerpop.gremlin.groovy.jsr223;
+
+import org.apache.tinkerpop.gremlin.jsr223.Customizer;
+
+/**
+ * Provides some custom compilation options to the {@link 
GremlinGroovyScriptEngine}.
+ *
+ * @author Stephen Mallette (http://stephen.genoprime.com)
+ */
+class CompilationOptionsCustomizer implements Customizer {
+
+private final int expectedCompilationTime;
+
+public CompilationOptionsCustomizer(final int expectedCompilationTime) 
{
--- End diff --

I'm converting the integers to longs just to be consistent with other times 
being in long milliseconds. The new plugin system doesn't work in the same way 
as the old so trying to push a `CompilationOptionsCustomizer` into the list of 
`compilerCustomizerProviders` won't work.  I don't really think we should 
promote the new plugin system until 3.3.0, but if you really want to give it a 
shot you'll need to look at the SNAPSHOT docs and revised config files for 
gremlin-server on the master branch that show how these new configurations go 
in place. You can get an idea of how this will work under this new model here:


https://github.com/apache/tinkerpop/blob/master/gremlin-server/conf/gremlin-server-secure.yaml#L36

You would basically add a config option to that line for 
`expectedCompilationTime` and it will configure the 
`CompilationOptionsCustomizer` into the `GremlinScriptEngine`.


When I go to merge this to master, I'll need to update docs to reflect how 
this configuration setting works. I will comment back here as soon as I've 
pushed the latest changed.


> Improve script compilation process and include metrics
> --
>
> Key: TINKERPOP-1644
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1644
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>
> Currently there is no synchronisation around script compilation. This means 
> that if a particularly heavy script is in use, many threads may end up 
> compiling the same script.
> It would seem like a good idea to have some some sort of synchronisation to 
> prevent ever getting to this stage.
> In addition, there will be cases where users will repeatedly submit broken 
> scripts to the server. In this case it is useful to log the error the first 
> time the script compilation is attempted and then cache the error for 
> subsequent runs.
> Finally I have found some scripts take in excess of 30 seconds to compile. To 
> aid performance debugging the script compilation times should be included in 
> the logs.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop pull request #570: TINKERPOP-1644 Improve script compilation proce...

[spmallette]

Github user spmallette commented on a diff in the pull request:

https://github.com/apache/tinkerpop/pull/570#discussion_r105952425
  
--- Diff: 
gremlin-groovy/src/main/java/org/apache/tinkerpop/gremlin/groovy/jsr223/CompilationOptionsCustomizer.java
 ---
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.tinkerpop.gremlin.groovy.jsr223;
+
+import org.apache.tinkerpop.gremlin.jsr223.Customizer;
+
+/**
+ * Provides some custom compilation options to the {@link 
GremlinGroovyScriptEngine}.
+ *
+ * @author Stephen Mallette (http://stephen.genoprime.com)
+ */
+class CompilationOptionsCustomizer implements Customizer {
+
+private final int expectedCompilationTime;
+
+public CompilationOptionsCustomizer(final int expectedCompilationTime) 
{
--- End diff --

I'm converting the integers to longs just to be consistent with other times 
being in long milliseconds. The new plugin system doesn't work in the same way 
as the old so trying to push a `CompilationOptionsCustomizer` into the list of 
`compilerCustomizerProviders` won't work.  I don't really think we should 
promote the new plugin system until 3.3.0, but if you really want to give it a 
shot you'll need to look at the SNAPSHOT docs and revised config files for 
gremlin-server on the master branch that show how these new configurations go 
in place. You can get an idea of how this will work under this new model here:


https://github.com/apache/tinkerpop/blob/master/gremlin-server/conf/gremlin-server-secure.yaml#L36

You would basically add a config option to that line for 
`expectedCompilationTime` and it will configure the 
`CompilationOptionsCustomizer` into the `GremlinScriptEngine`.


When I go to merge this to master, I'll need to update docs to reflect how 
this configuration setting works. I will comment back here as soon as I've 
pushed the latest changed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (TINKERPOP-1648) XyzPropertyChangedEvent contains incomplete data

[Daniel Kuppitz (JIRA)]

Daniel Kuppitz created TINKERPOP-1648:
-

 Summary: XyzPropertyChangedEvent contains incomplete data
 Key: TINKERPOP-1648
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1648
 Project: TinkerPop
  Issue Type: Bug
  Components: process
Reporter: Daniel Kuppitz
Assignee: stephen mallette


https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/sideEffect/AddPropertyStep.java#L94-L98

In case of new properties we create events that only contain the new value of 
the new property, but the actual property key is unknown.

Haven't set the affected version(s) as it affects all versions.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Blog Post: Graphoendodonticology

[Marko Rodriguez]

Hello,

Want to see Furnace in a nurse outfit? I know I do.

https://twitter.com/twarko/status/841658567522320384 


Marko.

http://markorodriguez.com