[jira] [Commented] (TINKERPOP-1670) End type lost when using promise()

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985835#comment-15985835
 ] 

ASF GitHub Bot commented on TINKERPOP-1670:
---

Github user mpollmeier commented on the issue:

https://github.com/apache/tinkerpop/pull/604
  
VOTE +1
related: https://github.com/mpollmeier/gremlin-scala/issues/203


> End type lost when using promise()
> --
>
> Key: TINKERPOP-1670
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1670
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.4
>Reporter: Andy Tolbert
>
> The {{Traversal.promise}} method loses type information when used so the type 
> of the returned future is not as complete as it could be.
> For example:
> {code:java}
> g.V().hasLabel("person").has("name", "marko").promise(Traversal::next);
> {code}
> Returns a {{CompletableFuture}} instead of 
> {{CompletableFuture}}.
> {code:java}
> g.V().hasLabel("person").promise(Traversal::toList);
> {code}
> Returns a {{CompletableFuture}} instead of 
> {{CompletableFuture}}.
> The fix for this could be as simple as adding the start and end (S,E) types 
> to the traversal that is the input of the function:
> {code:java}
> public default  CompletableFuture promise(final Function 
> traversalFunction)
> {code}
> to:
> {code:java}
> public default  CompletableFuture promise(final 
> Function, T> traversalFunction)
> {code}
> Need to test this a bit more though, but I think that should work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #604: TINKERPOP-1670 Maintain Traversal type information in ...

[mpollmeier]

Github user mpollmeier commented on the issue:

https://github.com/apache/tinkerpop/pull/604
  
VOTE +1
related: https://github.com/mpollmeier/gremlin-scala/issues/203


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [TinkerPop] New PMC Member: Robert Dale

[Jean-Baptiste Musso]

Cheers Robert!

Jean-Baptiste

On Tue, Apr 18, 2017 at 5:16 PM, Stephen Mallette 
wrote:

> We would like to announce that Robert Dale is now a member of the Apache
> TinkerPop PMC. Robert has been a helpful to the TinkerPop community in a
> variety of ways for some time now as a committer and has demonstrated
> ongoing interest in the growth of the project which makes him a welcome
> member to the PMC.
>
> As per tradition, I include with this announcement the TinkerPop Guild
> portrait as a reminder of the olden and golden days of doing graphs:
>
> https://upload.wikimedia.org/wikipedia/commons/c/ce/Jan_de_Bray_002.jpg
>
> Welcome to the PMC, Robert - we'll have to get the portrait amended to
> include you. Or you can just be the guy with the big cookie thing.
>
> --
> You received this message because you are subscribed to the Google Groups
> "Gremlin-users" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to gremlin-users+unsubscr...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/
> msgid/gremlin-users/CAA-H438zY86jjnKK1XD241%3DUorZA1tKoacXUbdSRfq4g1zETYQ%
> 40mail.gmail.com
> 
> .
> For more options, visit https://groups.google.com/d/optout.
>

[jira] [Commented] (TINKERPOP-1670) End type lost when using promise()

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15985270#comment-15985270
 ] 

ASF GitHub Bot commented on TINKERPOP-1670:
---

GitHub user tolbertam opened a pull request:

https://github.com/apache/tinkerpop/pull/604

TINKERPOP-1670 Maintain Traversal type information in promise()

For [TINKERPOP-1670](https://issues.apache.org/jira/browse/TINKERPOP-1670).

Adds start and end step generic type information in the Traversal type
that is input to the Function given to Traversal.promise().

Also updates test to use full type information to ensure this change
maintains the type information.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tolbertam/tinkerpop TINKERPOP-1670

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/604.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #604






> End type lost when using promise()
> --
>
> Key: TINKERPOP-1670
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1670
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.4
>Reporter: Andy Tolbert
>
> The {{Traversal.promise}} method loses type information when used so the type 
> of the returned future is not as complete as it could be.
> For example:
> {code:java}
> g.V().hasLabel("person").has("name", "marko").promise(Traversal::next);
> {code}
> Returns a {{CompletableFuture}} instead of 
> {{CompletableFuture}}.
> {code:java}
> g.V().hasLabel("person").promise(Traversal::toList);
> {code}
> Returns a {{CompletableFuture}} instead of 
> {{CompletableFuture}}.
> The fix for this could be as simple as adding the start and end (S,E) types 
> to the traversal that is the input of the function:
> {code:java}
> public default  CompletableFuture promise(final Function 
> traversalFunction)
> {code}
> to:
> {code:java}
> public default  CompletableFuture promise(final 
> Function, T> traversalFunction)
> {code}
> Need to test this a bit more though, but I think that should work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop pull request #604: TINKERPOP-1670 Maintain Traversal type informat...

[tolbertam]

GitHub user tolbertam opened a pull request:

https://github.com/apache/tinkerpop/pull/604

TINKERPOP-1670 Maintain Traversal type information in promise()

For [TINKERPOP-1670](https://issues.apache.org/jira/browse/TINKERPOP-1670).

Adds start and end step generic type information in the Traversal type
that is input to the Function given to Traversal.promise().

Also updates test to use full type information to ensure this change
maintains the type information.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/tolbertam/tinkerpop TINKERPOP-1670

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/604.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #604






---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Updated] (TINKERPOP-1670) End type lost when using promise()

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette updated TINKERPOP-1670:

Component/s: process

> End type lost when using promise()
> --
>
> Key: TINKERPOP-1670
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1670
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.4
>Reporter: Andy Tolbert
>
> The {{Traversal.promise}} method loses type information when used so the type 
> of the returned future is not as complete as it could be.
> For example:
> {code:java}
> g.V().hasLabel("person").has("name", "marko").promise(Traversal::next);
> {code}
> Returns a {{CompletableFuture}} instead of 
> {{CompletableFuture}}.
> {code:java}
> g.V().hasLabel("person").promise(Traversal::toList);
> {code}
> Returns a {{CompletableFuture}} instead of 
> {{CompletableFuture}}.
> The fix for this could be as simple as adding the start and end (S,E) types 
> to the traversal that is the input of the function:
> {code:java}
> public default  CompletableFuture promise(final Function 
> traversalFunction)
> {code}
> to:
> {code:java}
> public default  CompletableFuture promise(final 
> Function, T> traversalFunction)
> {code}
> Need to test this a bit more though, but I think that should work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Created] (TINKERPOP-1670) End type lost when using promise()

[Andy Tolbert (JIRA)]

Andy Tolbert created TINKERPOP-1670:
---

 Summary: End type lost when using promise()
 Key: TINKERPOP-1670
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1670
 Project: TinkerPop
  Issue Type: Bug
Affects Versions: 3.2.4
Reporter: Andy Tolbert


The {{Traversal.promise}} method loses type information when used so the type 
of the returned future is not as complete as it could be.

For example:

{code:java}
g.V().hasLabel("person").has("name", "marko").promise(Traversal::next);
{code}

Returns a {{CompletableFuture}} instead of 
{{CompletableFuture}}.

{code:java}
g.V().hasLabel("person").promise(Traversal::toList);
{code}

Returns a {{CompletableFuture}} instead of 
{{CompletableFuture}}.

The fix for this could be as simple as adding the start and end (S,E) types to 
the traversal that is the input of the function:

{code:java}
public default  CompletableFuture promise(final Function 
traversalFunction)
{code}

to:

{code:java}
public default  CompletableFuture promise(final Function, 
T> traversalFunction)
{code}

Need to test this a bit more though, but I think that should work.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Closed] (TINKERPOP-1666) NPE in FileSandboxExtension if staticVariableTypes is empty in supplied YAML file

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1666?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette closed TINKERPOP-1666.
---

> NPE in FileSandboxExtension if staticVariableTypes is empty in supplied YAML 
> file
> -
>
> Key: TINKERPOP-1666
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1666
> Project: TinkerPop
>  Issue Type: Bug
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: David Pitera
>Assignee: stephen mallette
>Priority: Minor
> Fix For: 3.2.5
>
>
> Currently, we have code that assumes that this variable is not empty in the 
> supplied YAML file:
> 1. 
> https://github.com/apache/tinkerpop/blob/tp32/gremlin-groovy/src/main/groovy/org/apache/tinkerpop/gremlin/groovy/jsr223/customizer/FileSandboxExtension.groovy#L66
>  (We get an NPE if we call collectEntries() on a null object)
> 2. 
> https://github.com/apache/tinkerpop/blob/tp32/gremlin-groovy/src/main/groovy/org/apache/tinkerpop/gremlin/groovy/jsr223/customizer/AbstractSandboxExtension.groovy#L54
>  (need to check if staticVariableTyping is null or we throw NPE trying to 
> call containsKey() on a null object)
> I propose to add some null checks here so that users who do not wish to 
> statically type any variables can now do so.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Re: Publish home issue

[Daniel Kuppitz]

The changes look good to me. Unfortunately I haven't had many opportunities
to try out different scenarios, so it might be, that some of these errors
come up again in the future; however, the solution should always be as
simple as your 3 line fix.

Cheers,
Daniel


On Tue, Apr 25, 2017 at 10:31 PM, Robert Dale  wrote:

> Daniel,
>
> When I used pushlish-home.sh to push the new JanusGraph changes, it missed
> the new logo.
>
> Summary of updates:
> >   Updated 'js' to r1792636.
> >   Updated 'images' to r1792636.
> >   Updated 'css' to r1792636.
> > cp: cannot stat '../site/*home/home*/images/logos/janusgraph-logo.png':
> > No such file or directory
> > A home
> > A home/images
> > A home/images/logos
> > svn: warning: W155010:
> > '/home/rdale/git/forks/tinkerpop/target/svn/home/
> images/logos/janusgraph-logo.png'
> > not found
> > svn: E29: Could not add all targets because some targets don't exist
> > svn: E29: Illegal target for the requested operation
> > Adding home
> > Adding home/images
> > Adding home/images/logos
> > Sendingindex.html
> > Sendingproviders.html
> > Transmitting file data ..done
> > Committing transaction...
> > Committed revision 1792637.
>
>
> Note the double home/home/
>
> So I made a change that explicitly checks for ../site/home/ and removes it.
>
> https://github.com/apache/tinkerpop/commit/d5a74b905fef4d0fd0b366fcec2349
> dc40747a33
>
> This seems to work but I am hoping you can take a look to improve it or see
> if there are any other cases it might break.
>
>
> Robert Dale
>