[jira] [Commented] (TINKERPOP-786) Patterns for DSL Development

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023985#comment-16023985
 ] 

ASF GitHub Bot commented on TINKERPOP-786:
--

Github user n-tran commented on the issue:

https://github.com/apache/tinkerpop/pull/610
  
+1


> Patterns for DSL Development
> 
>
> Key: TINKERPOP-786
> URL: https://issues.apache.org/jira/browse/TINKERPOP-786
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: documentation
>Affects Versions: 3.0.2-incubating
>Reporter: stephen mallette
>Assignee: stephen mallette
> Fix For: 3.2.5
>
>
> Develop and document the patterns for custom DSLs.  The method previously 
> described and under consideration at 3.0.0 seems a bit cumbersome to deal 
> with.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #610: TINKERPOP-786 Gremlin DSL Support

[n-tran]

Github user n-tran commented on the issue:

https://github.com/apache/tinkerpop/pull/610
  
+1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #606: Corrected copy-paste error in until step for predicate...

[mpollmeier]

Github user mpollmeier commented on the issue:

https://github.com/apache/tinkerpop/pull/606
  
In theory, yes. But it seems to behave fine as it is. Here's a scenario for 
the gremlin-groovy shell:

```
g = TinkerGraph.open()
v0 = g.addVertex("x", 1)
v1 = g.addVertex("x", 2)
v2 = g.addVertex("x", 2)
v0.addEdge("edge", v1)
v1.addEdge("edge", v2)
g.traversal().V(v0.id).repeat(out()).until(has("x", 2)).path()
```

If `until` would incorrectly behave like `emit`, I would assume that we'd 
see all three nodes in the path. Instead we only see v0 and v1, which is the 
correct behavious for repeat/until. Is our scenario missing something?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1675) RemoteStep#processNextStart() throws CompletionException instead of underlying exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023638#comment-16023638
 ] 

ASF GitHub Bot commented on TINKERPOP-1675:
---

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/609
  
VOTE +1.


> RemoteStep#processNextStart() throws CompletionException instead of 
> underlying exception
> 
>
> Key: TINKERPOP-1675
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1675
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.4
>Reporter: Andy Tolbert
>
> There is a slight behavior change in TinkerPop 3.2.4 as it pertains to an 
> exception thrown when processing a traversal on a remote traversal source.
> In 3.2.3, if an unchecked exception is thrown, it is propagated directly to 
> the user.
> However, in 3.2.4, since RemoteStep#processNextStart() now calls 
> RemoteStep#promise() and joins on the returning futures result, if the future 
> fails a {{CompletionException}} is thrown wrapping the cause, instead of the 
> cause itself.
> For consistency, if that exception is an unchecked exception, it should be 
> thrown directly, otherwise it should be wrapped in an 
> {{IllegalStateException}} as it did before.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #609: TINKERPOP-1675 Throw underlying unchecked exception in...

[okram]

Github user okram commented on the issue:

https://github.com/apache/tinkerpop/pull/609
  
VOTE +1.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Re: [DISCUSS] Scala 2.11 and Spark 2.0 support

[Robert Dale]

RERO +1

Robert Dale

On Wed, May 24, 2017 at 4:17 PM, Stephen Mallette 
wrote:

> well - i guess i'm realizing that i was thinking a lot of big things for
> 3.3.0 but it's almost 6 months into the year and i don't think everything i
> wanted to see is going to get done. then you add in the Spark 2.0 stuff you
> already mentioned which is more reason to release. smaybe it's best
> to clean up 3.3.0, tack in a few critical things that will carry 3.3.x for
> 12 months of dev and release sooner than later. there's always 3.4.0 for
> more big deal stuffs.
>
> On Wed, May 24, 2017 at 4:07 PM, Jason Plurad  wrote:
>
> > Thanks Stephen. If we can get 3.3 better mapped out, that would be great.
> > Your response on that other thread made it sound like 3.3 was a no-go for
> > this year.
> >
> > On Wed, May 24, 2017 at 3:59 PM, Stephen Mallette 
> > wrote:
> >
> > > Interesting you brought this up. I was going to start a discussion on
> it
> > > actually next week when I started another discussion about 3.2.5/3.1.7
> > > release. I think we should just talk about how to release 3.3.0. Let's
> > just
> > > figure out what things need to absolutely go in 3.3.0 and then aim for
> a
> > > release date.
> > >
> > > On Wed, May 24, 2017 at 3:45 PM, Jason Plurad 
> wrote:
> > >
> > > > This question
> > > >  > f1OdIFvBAwAJ>
> > > > on
> > > > TinkerPop 3.3 on the Gremlin users list ultimately comes back to
> Scala
> > > 2.11
> > > > support
> > > >  > > UypKyqnWqzc/eaQUOR2IDAAJ
> > > > >.
> > > > I can understand that some features slated for 3.3 might be far off (
> > > > TINKERPOP-1564  > >),
> > > > but
> > > > I don't think we should hold up on updating core dependencies such as
> > > > Spark+Scala.
> > > >
> > > > Azure Cosmos DB (based on TP 3.2.4) recently published
> > > >  > connector-graph>
> > > > about connecting
> > > > it to Spark, and it tells the developer to build TinkerPop master (TP
> > > > 3.3.0-SNAPSHOT) because Azure HDInsight uses Spark 2.0.
> > > >
> > > > We ran into a similar issue when TInkerPop 3.0 came out with the
> > Hadoop 1
> > > > dependency rather than Hadoop 2, and I think a lot of users had
> already
> > > > moved
> > > > to Hadoop 2
> > > >  > iEr2qoxFAQAJ>
> > > > by
> > > > then. Side note, I don't know what the schedule for Hadoop 3 is, but
> > they
> > > > already have alpha versions available.
> > > >
> > > > Spark 2.0 came out in July 2016, and it has been integrated on master
> > > > since September
> > > > 2016
> > > >  > QNWaFC3ABQAJ
> > > >.
> > > > Spark 2 builds with Scala 2.11 by default. If we can't get the next
> > > > TinkerPop release until next year, TinkerPop's Spark+Scala
> dependencies
> > > > will be very far out of date.
> > > >
> > > > Would it make sense to cherry pick Spark 2.0 support into the tp32
> > > branch?
> > > >
> > >
> >
>

Re: [DISCUSS] Scala 2.11 and Spark 2.0 support

[Stephen Mallette]

well - i guess i'm realizing that i was thinking a lot of big things for
3.3.0 but it's almost 6 months into the year and i don't think everything i
wanted to see is going to get done. then you add in the Spark 2.0 stuff you
already mentioned which is more reason to release. smaybe it's best
to clean up 3.3.0, tack in a few critical things that will carry 3.3.x for
12 months of dev and release sooner than later. there's always 3.4.0 for
more big deal stuffs.

On Wed, May 24, 2017 at 4:07 PM, Jason Plurad  wrote:

> Thanks Stephen. If we can get 3.3 better mapped out, that would be great.
> Your response on that other thread made it sound like 3.3 was a no-go for
> this year.
>
> On Wed, May 24, 2017 at 3:59 PM, Stephen Mallette 
> wrote:
>
> > Interesting you brought this up. I was going to start a discussion on it
> > actually next week when I started another discussion about 3.2.5/3.1.7
> > release. I think we should just talk about how to release 3.3.0. Let's
> just
> > figure out what things need to absolutely go in 3.3.0 and then aim for a
> > release date.
> >
> > On Wed, May 24, 2017 at 3:45 PM, Jason Plurad  wrote:
> >
> > > This question
> > >  f1OdIFvBAwAJ>
> > > on
> > > TinkerPop 3.3 on the Gremlin users list ultimately comes back to Scala
> > 2.11
> > > support
> > >  > UypKyqnWqzc/eaQUOR2IDAAJ
> > > >.
> > > I can understand that some features slated for 3.3 might be far off (
> > > TINKERPOP-1564  >),
> > > but
> > > I don't think we should hold up on updating core dependencies such as
> > > Spark+Scala.
> > >
> > > Azure Cosmos DB (based on TP 3.2.4) recently published
> > >  connector-graph>
> > > about connecting
> > > it to Spark, and it tells the developer to build TinkerPop master (TP
> > > 3.3.0-SNAPSHOT) because Azure HDInsight uses Spark 2.0.
> > >
> > > We ran into a similar issue when TInkerPop 3.0 came out with the
> Hadoop 1
> > > dependency rather than Hadoop 2, and I think a lot of users had already
> > > moved
> > > to Hadoop 2
> > >  iEr2qoxFAQAJ>
> > > by
> > > then. Side note, I don't know what the schedule for Hadoop 3 is, but
> they
> > > already have alpha versions available.
> > >
> > > Spark 2.0 came out in July 2016, and it has been integrated on master
> > > since September
> > > 2016
> > >  QNWaFC3ABQAJ
> > >.
> > > Spark 2 builds with Scala 2.11 by default. If we can't get the next
> > > TinkerPop release until next year, TinkerPop's Spark+Scala dependencies
> > > will be very far out of date.
> > >
> > > Would it make sense to cherry pick Spark 2.0 support into the tp32
> > branch?
> > >
> >
>

Re: [DISCUSS] Scala 2.11 and Spark 2.0 support

[Jason Plurad]

Thanks Stephen. If we can get 3.3 better mapped out, that would be great.
Your response on that other thread made it sound like 3.3 was a no-go for
this year.

On Wed, May 24, 2017 at 3:59 PM, Stephen Mallette 
wrote:

> Interesting you brought this up. I was going to start a discussion on it
> actually next week when I started another discussion about 3.2.5/3.1.7
> release. I think we should just talk about how to release 3.3.0. Let's just
> figure out what things need to absolutely go in 3.3.0 and then aim for a
> release date.
>
> On Wed, May 24, 2017 at 3:45 PM, Jason Plurad  wrote:
>
> > This question
> > 
> > on
> > TinkerPop 3.3 on the Gremlin users list ultimately comes back to Scala
> 2.11
> > support
> >  UypKyqnWqzc/eaQUOR2IDAAJ
> > >.
> > I can understand that some features slated for 3.3 might be far off (
> > TINKERPOP-1564 ),
> > but
> > I don't think we should hold up on updating core dependencies such as
> > Spark+Scala.
> >
> > Azure Cosmos DB (based on TP 3.2.4) recently published
> > 
> > about connecting
> > it to Spark, and it tells the developer to build TinkerPop master (TP
> > 3.3.0-SNAPSHOT) because Azure HDInsight uses Spark 2.0.
> >
> > We ran into a similar issue when TInkerPop 3.0 came out with the Hadoop 1
> > dependency rather than Hadoop 2, and I think a lot of users had already
> > moved
> > to Hadoop 2
> > 
> > by
> > then. Side note, I don't know what the schedule for Hadoop 3 is, but they
> > already have alpha versions available.
> >
> > Spark 2.0 came out in July 2016, and it has been integrated on master
> > since September
> > 2016
> >  >.
> > Spark 2 builds with Scala 2.11 by default. If we can't get the next
> > TinkerPop release until next year, TinkerPop's Spark+Scala dependencies
> > will be very far out of date.
> >
> > Would it make sense to cherry pick Spark 2.0 support into the tp32
> branch?
> >
>

Re: [DISCUSS] Scala 2.11 and Spark 2.0 support

[Stephen Mallette]

Interesting you brought this up. I was going to start a discussion on it
actually next week when I started another discussion about 3.2.5/3.1.7
release. I think we should just talk about how to release 3.3.0. Let's just
figure out what things need to absolutely go in 3.3.0 and then aim for a
release date.

On Wed, May 24, 2017 at 3:45 PM, Jason Plurad  wrote:

> This question
> 
> on
> TinkerPop 3.3 on the Gremlin users list ultimately comes back to Scala 2.11
> support
>  >.
> I can understand that some features slated for 3.3 might be far off (
> TINKERPOP-1564 ),
> but
> I don't think we should hold up on updating core dependencies such as
> Spark+Scala.
>
> Azure Cosmos DB (based on TP 3.2.4) recently published
> 
> about connecting
> it to Spark, and it tells the developer to build TinkerPop master (TP
> 3.3.0-SNAPSHOT) because Azure HDInsight uses Spark 2.0.
>
> We ran into a similar issue when TInkerPop 3.0 came out with the Hadoop 1
> dependency rather than Hadoop 2, and I think a lot of users had already
> moved
> to Hadoop 2
> 
> by
> then. Side note, I don't know what the schedule for Hadoop 3 is, but they
> already have alpha versions available.
>
> Spark 2.0 came out in July 2016, and it has been integrated on master
> since September
> 2016
> .
> Spark 2 builds with Scala 2.11 by default. If we can't get the next
> TinkerPop release until next year, TinkerPop's Spark+Scala dependencies
> will be very far out of date.
>
> Would it make sense to cherry pick Spark 2.0 support into the tp32 branch?
>

[DISCUSS] Scala 2.11 and Spark 2.0 support

[Jason Plurad]

This question
 on
TinkerPop 3.3 on the Gremlin users list ultimately comes back to Scala 2.11
support
.
I can understand that some features slated for 3.3 might be far off (
TINKERPOP-1564 ), but
I don't think we should hold up on updating core dependencies such as
Spark+Scala.

Azure Cosmos DB (based on TP 3.2.4) recently published

about connecting
it to Spark, and it tells the developer to build TinkerPop master (TP
3.3.0-SNAPSHOT) because Azure HDInsight uses Spark 2.0.

We ran into a similar issue when TInkerPop 3.0 came out with the Hadoop 1
dependency rather than Hadoop 2, and I think a lot of users had already moved
to Hadoop 2
 by
then. Side note, I don't know what the schedule for Hadoop 3 is, but they
already have alpha versions available.

Spark 2.0 came out in July 2016, and it has been integrated on master
since September
2016
.
Spark 2 builds with Scala 2.11 by default. If we can't get the next
TinkerPop release until next year, TinkerPop's Spark+Scala dependencies
will be very far out of date.

Would it make sense to cherry pick Spark 2.0 support into the tp32 branch?

[jira] [Commented] (TINKERPOP-1676) Improve GraphSON Performance

[stephen mallette (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023305#comment-16023305
 ] 

stephen mallette commented on TINKERPOP-1676:
-

Just pushed the change that removes properties from a {{Path}} if they were 
present. Along with some other changes, {{Path}} serialization is much faster 
now and largely on par with Gryo. Note the DISCUSS thread 
[here|https://lists.apache.org/thread.html/7ad9e62d2ec1aad374541c26ffde031cee3381b721787cbb544899e7@%3Cdev.tinkerpop.apache.org%3E]

> Improve GraphSON Performance
> 
>
> Key: TINKERPOP-1676
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1676
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: io
>Affects Versions: 3.2.4
>Reporter: stephen mallette
>Assignee: stephen mallette
>  Labels: breaking
>
> Not sure what will happen here. Just wanted an issue where I could experiment 
> a bit with and gather feedback from others for collaboration in case others 
> had ideas. Right now, GraphSON reads are considerably slower than Gryo and 
> writes appear to be faster, so the focus will be on how to get reads more in 
> line with what Gryo can do. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Updated] (TINKERPOP-1676) Improve GraphSON Performance

[stephen mallette (JIRA)]

 [ 
https://issues.apache.org/jira/browse/TINKERPOP-1676?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette updated TINKERPOP-1676:

Labels: breaking  (was: )

> Improve GraphSON Performance
> 
>
> Key: TINKERPOP-1676
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1676
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: io
>Affects Versions: 3.2.4
>Reporter: stephen mallette
>Assignee: stephen mallette
>  Labels: breaking
>
> Not sure what will happen here. Just wanted an issue where I could experiment 
> a bit with and gather feedback from others for collaboration in case others 
> had ideas. Right now, GraphSON reads are considerably slower than Gryo and 
> writes appear to be faster, so the focus will be on how to get reads more in 
> line with what Gryo can do. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[DISCUSS] GraphSON serialization of Path

[Stephen Mallette]

In doing some performance enhancements to GraphSON I noticed a 'bug" in
GraphSON's serialization of Path. It is inconsistent with Gryo in that it
includes properties if elements are present. That's a massively expensive
operation and will obviously make GraphSON always lag behind Gryo in terms
of performance in that area.

I'd like to "fix" that for 3.2.5, but wanted to mention it here because it
might be a breaking change in the sense that if someone is exploiting the
"bug" as a "feature" their code will suddenly stop working. In my opinion,
I'd rather see Path consistent as a format for 3.2.5 so I think we should
accept the break and document it.

If there are no objections in the next 72 hours, I'll assume lazy consensus
and move forward.

[jira] [Commented] (TINKERPOP-1677) Bump Groovy to 2.4.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16023063#comment-16023063
 ] 

ASF GitHub Bot commented on TINKERPOP-1677:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/612
  
`docker/build.sh -i -t -n` success on tp31

VOTE +1


> Bump Groovy to 2.4.11
> -
>
> Key: TINKERPOP-1677
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1677
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Andrea Cosentino
> Fix For: 3.3.0, 3.2.5
>
>
> Just a minor release.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #612: TINKERPOP-1677 Bump Groovy to 2.4.11

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/612
  
`docker/build.sh -i -t -n` success on tp31

VOTE +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1677) Bump Groovy to 2.4.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022895#comment-16022895
 ] 

ASF GitHub Bot commented on TINKERPOP-1677:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/612
  
`docker/build.sh -i -t -n` success on master. Waiting for tp31 to finish.


> Bump Groovy to 2.4.11
> -
>
> Key: TINKERPOP-1677
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1677
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Andrea Cosentino
> Fix For: 3.3.0, 3.2.5
>
>
> Just a minor release.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #612: TINKERPOP-1677 Bump Groovy to 2.4.11

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/612
  
`docker/build.sh -i -t -n` success on master. Waiting for tp31 to finish.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1677) Bump Groovy to 2.4.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022784#comment-16022784
 ] 

ASF GitHub Bot commented on TINKERPOP-1677:
---

Github user oscerd commented on the issue:

https://github.com/apache/tinkerpop/pull/612
  
This seems to be fine.


> Bump Groovy to 2.4.11
> -
>
> Key: TINKERPOP-1677
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1677
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Andrea Cosentino
> Fix For: 3.3.0, 3.2.5
>
>
> Just a minor release.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #612: TINKERPOP-1677 Bump Groovy to 2.4.11

[oscerd]

Github user oscerd commented on the issue:

https://github.com/apache/tinkerpop/pull/612
  
This seems to be fine.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1677) Bump Groovy to 2.4.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022743#comment-16022743
 ] 

ASF GitHub Bot commented on TINKERPOP-1677:
---

Github user oscerd closed the pull request at:

https://github.com/apache/tinkerpop/pull/611


> Bump Groovy to 2.4.11
> -
>
> Key: TINKERPOP-1677
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1677
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Andrea Cosentino
> Fix For: 3.3.0, 3.2.5
>
>
> Just a minor release.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1677) Bump Groovy to 2.4.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022740#comment-16022740
 ] 

ASF GitHub Bot commented on TINKERPOP-1677:
---

GitHub user oscerd opened a pull request:

https://github.com/apache/tinkerpop/pull/612

TINKERPOP-1677 Bump Groovy to 2.4.11



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/oscerd/tinkerpop TINKERPOP-1677-tp31

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/612.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #612


commit 7a080776a81bf48b7405bb18fad604822b5d0c17
Author: Andrea Cosentino 
Date:   2017-05-24T11:37:21Z

TINKERPOP-1677 Bump Groovy to 2.4.11




> Bump Groovy to 2.4.11
> -
>
> Key: TINKERPOP-1677
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1677
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Andrea Cosentino
> Fix For: 3.3.0, 3.2.5
>
>
> Just a minor release.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1677) Bump Groovy to 2.4.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022742#comment-16022742
 ] 

ASF GitHub Bot commented on TINKERPOP-1677:
---

Github user oscerd commented on the issue:

https://github.com/apache/tinkerpop/pull/611
  
I'm closing this now. New PR here: 
https://github.com/apache/tinkerpop/pull/612


> Bump Groovy to 2.4.11
> -
>
> Key: TINKERPOP-1677
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1677
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Andrea Cosentino
> Fix For: 3.3.0, 3.2.5
>
>
> Just a minor release.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop pull request #611: TINKERPOP-1677 Bump Groovy to 2.4.11

[oscerd]

Github user oscerd closed the pull request at:

https://github.com/apache/tinkerpop/pull/611


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #611: TINKERPOP-1677 Bump Groovy to 2.4.11

[oscerd]

Github user oscerd commented on the issue:

https://github.com/apache/tinkerpop/pull/611
  
I'm closing this now. New PR here: 
https://github.com/apache/tinkerpop/pull/612


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #612: TINKERPOP-1677 Bump Groovy to 2.4.11

[oscerd]

GitHub user oscerd opened a pull request:

https://github.com/apache/tinkerpop/pull/612

TINKERPOP-1677 Bump Groovy to 2.4.11



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/oscerd/tinkerpop TINKERPOP-1677-tp31

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/612.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #612


commit 7a080776a81bf48b7405bb18fad604822b5d0c17
Author: Andrea Cosentino 
Date:   2017-05-24T11:37:21Z

TINKERPOP-1677 Bump Groovy to 2.4.11




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #611: TINKERPOP-1677 Bump Groovy to 2.4.11

[oscerd]

Github user oscerd commented on the issue:

https://github.com/apache/tinkerpop/pull/611
  
I already run a full build locally


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1677) Bump Groovy to 2.4.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022733#comment-16022733
 ] 

ASF GitHub Bot commented on TINKERPOP-1677:
---

Github user oscerd commented on the issue:

https://github.com/apache/tinkerpop/pull/611
  
I already run a full build locally


> Bump Groovy to 2.4.11
> -
>
> Key: TINKERPOP-1677
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1677
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Andrea Cosentino
> Fix For: 3.3.0, 3.2.5
>
>
> Just a minor release.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1675) RemoteStep#processNextStart() throws CompletionException instead of underlying exception

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022732#comment-16022732
 ] 

ASF GitHub Bot commented on TINKERPOP-1675:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/609
  
VOTE +1


> RemoteStep#processNextStart() throws CompletionException instead of 
> underlying exception
> 
>
> Key: TINKERPOP-1675
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1675
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.4
>Reporter: Andy Tolbert
>
> There is a slight behavior change in TinkerPop 3.2.4 as it pertains to an 
> exception thrown when processing a traversal on a remote traversal source.
> In 3.2.3, if an unchecked exception is thrown, it is propagated directly to 
> the user.
> However, in 3.2.4, since RemoteStep#processNextStart() now calls 
> RemoteStep#promise() and joins on the returning futures result, if the future 
> fails a {{CompletionException}} is thrown wrapping the cause, instead of the 
> cause itself.
> For consistency, if that exception is an unchecked exception, it should be 
> thrown directly, otherwise it should be wrapped in an 
> {{IllegalStateException}} as it did before.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #609: TINKERPOP-1675 Throw underlying unchecked exception in...

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/609
  
VOTE +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1677) Bump Groovy to 2.4.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022726#comment-16022726
 ] 

ASF GitHub Bot commented on TINKERPOP-1677:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/611
  
@spmallette I have this pull request building now. 


> Bump Groovy to 2.4.11
> -
>
> Key: TINKERPOP-1677
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1677
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Andrea Cosentino
> Fix For: 3.3.0, 3.2.5
>
>
> Just a minor release.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1677) Bump Groovy to 2.4.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022723#comment-16022723
 ] 

ASF GitHub Bot commented on TINKERPOP-1677:
---

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/611
  
Also - have you run a full build with integration tests to success? 


> Bump Groovy to 2.4.11
> -
>
> Key: TINKERPOP-1677
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1677
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Andrea Cosentino
> Fix For: 3.3.0, 3.2.5
>
>
> Just a minor release.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #611: TINKERPOP-1677 Bump Groovy to 2.4.11

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/611
  
@spmallette I have this pull request building now. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #611: TINKERPOP-1677 Bump Groovy to 2.4.11

[spmallette]

Github user spmallette commented on the issue:

https://github.com/apache/tinkerpop/pull/611
  
Also - have you run a full build with integration tests to success? 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1677) Bump Groovy to 2.4.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022702#comment-16022702
 ] 

ASF GitHub Bot commented on TINKERPOP-1677:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/611
  
@oscerd can you retarget your pull request to tp31 and add an entry in the 
CHANGELOG?

Changelogs:  

- [2.4.10](http://groovy-lang.org/changelogs/changelog-2.4.10.html)
- [2.4.11](http://groovy-lang.org/changelogs/changelog-2.4.11.html)



> Bump Groovy to 2.4.11
> -
>
> Key: TINKERPOP-1677
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1677
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Andrea Cosentino
> Fix For: 3.3.0, 3.2.5
>
>
> Just a minor release.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop issue #611: TINKERPOP-1677 Bump Groovy to 2.4.11

[robertdale]

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/611
  
@oscerd can you retarget your pull request to tp31 and add an entry in the 
CHANGELOG?

Changelogs:  

- [2.4.10](http://groovy-lang.org/changelogs/changelog-2.4.10.html)
- [2.4.11](http://groovy-lang.org/changelogs/changelog-2.4.11.html)



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Commented] (TINKERPOP-1677) Bump Groovy to 2.4.11

[Andrea Cosentino (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022461#comment-16022461
 ] 

Andrea Cosentino commented on TINKERPOP-1677:
-

PR opened:

https://github.com/apache/tinkerpop/pull/611

> Bump Groovy to 2.4.11
> -
>
> Key: TINKERPOP-1677
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1677
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Andrea Cosentino
> Fix For: 3.3.0, 3.2.5
>
>
> Just a minor release.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[jira] [Commented] (TINKERPOP-1677) Bump Groovy to 2.4.11

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022459#comment-16022459
 ] 

ASF GitHub Bot commented on TINKERPOP-1677:
---

GitHub user oscerd opened a pull request:

https://github.com/apache/tinkerpop/pull/611

TINKERPOP-1677 Bump Groovy to 2.4.11



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/oscerd/tinkerpop TINKERPOP-1677

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/611.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #611


commit 53c0ffcef93fbb348c3acaef2bb207d06957a4a5
Author: Andrea Cosentino 
Date:   2017-05-24T07:37:04Z

TINKERPOP-1677 Bump Groovy to 2.4.11




> Bump Groovy to 2.4.11
> -
>
> Key: TINKERPOP-1677
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1677
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: groovy
>Affects Versions: 3.2.4
>Reporter: Andrea Cosentino
> Fix For: 3.3.0, 3.2.5
>
>
> Just a minor release.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

[GitHub] tinkerpop pull request #611: TINKERPOP-1677 Bump Groovy to 2.4.11

[oscerd]

GitHub user oscerd opened a pull request:

https://github.com/apache/tinkerpop/pull/611

TINKERPOP-1677 Bump Groovy to 2.4.11



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/oscerd/tinkerpop TINKERPOP-1677

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/611.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #611


commit 53c0ffcef93fbb348c3acaef2bb207d06957a4a5
Author: Andrea Cosentino 
Date:   2017-05-24T07:37:04Z

TINKERPOP-1677 Bump Groovy to 2.4.11




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[jira] [Created] (TINKERPOP-1677) Bump Groovy to 2.4.11

[Andrea Cosentino (JIRA)]

Andrea Cosentino created TINKERPOP-1677:
---

 Summary: Bump Groovy to 2.4.11
 Key: TINKERPOP-1677
 URL: https://issues.apache.org/jira/browse/TINKERPOP-1677
 Project: TinkerPop
  Issue Type: Improvement
  Components: groovy
Affects Versions: 3.2.4
Reporter: Andrea Cosentino
 Fix For: 3.3.0, 3.2.5


Just a minor release.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)