[GitHub] tinkerpop pull request #707: TINKERPOP-1768 Bump to Jackson 2.8.10
GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/707 TINKERPOP-1768 Bump to Jackson 2.8.10 https://issues.apache.org/jira/browse/TINKERPOP-1768 Adds some key bug fixes. All tests pass with `docker/build.sh -t -n -i` for both tp32 and master VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1768 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/707.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #707 commit 0d494c08beb1832a68e0e9d646aaf2fb305c0abe Author: Stephen Mallette Date: 2017-09-06T19:15:27Z TINKERPOP-1768 Bump to Jackson 2.8.10 Adds some key bug fixes - one of those could be particularly useful to TINKERPOP-1509. ---
[jira] [Commented] (TINKERPOP-1768) Bump to Jackson 2.8.10
[ https://issues.apache.org/jira/browse/TINKERPOP-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156765#comment-16156765 ] ASF GitHub Bot commented on TINKERPOP-1768: --- GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/707 TINKERPOP-1768 Bump to Jackson 2.8.10 https://issues.apache.org/jira/browse/TINKERPOP-1768 Adds some key bug fixes. All tests pass with `docker/build.sh -t -n -i` for both tp32 and master VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1768 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/707.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #707 commit 0d494c08beb1832a68e0e9d646aaf2fb305c0abe Author: Stephen Mallette Date: 2017-09-06T19:15:27Z TINKERPOP-1768 Bump to Jackson 2.8.10 Adds some key bug fixes - one of those could be particularly useful to TINKERPOP-1509. > Bump to Jackson 2.8.10 > -- > > Key: TINKERPOP-1768 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1768 > Project: TinkerPop > Issue Type: Improvement > Components: io >Affects Versions: 3.2.6 >Reporter: stephen mallette >Assignee: stephen mallette > > Jackson 2.8.10 has some important bug fixes - hoping for a fix for > TINKERPOP-1509 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (TINKERPOP-1770) Remote traversal timeout
stephen mallette created TINKERPOP-1770:
---
Summary: Remote traversal timeout
Key: TINKERPOP-1770
URL: https://issues.apache.org/jira/browse/TINKERPOP-1770
Project: TinkerPop
Issue Type: Improvement
Components: server
Affects Versions: 3.2.6
Reporter: stephen mallette
Assignee: stephen mallette
Priority: Critical
Remote traversals do not respect {{scriptEvaluationTimeout}} so it is currently
possible to submit a traversal that runs indefinitely.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] tinkerpop issue #706: TINKERPOP-1767 Added Io.requiresVersion(Object)
Github user pietermartin commented on the issue: https://github.com/apache/tinkerpop/pull/706 All tests pass on Sqlg. VOTE +1 ---
[jira] [Commented] (TINKERPOP-1767) Method for graph providers to check an IO version and type
[
https://issues.apache.org/jira/browse/TINKERPOP-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156861#comment-16156861
]
ASF GitHub Bot commented on TINKERPOP-1767:
---
Github user pietermartin commented on the issue:
https://github.com/apache/tinkerpop/pull/706
All tests pass on Sqlg.
VOTE +1
> Method for graph providers to check an IO version and type
> --
>
> Key: TINKERPOP-1767
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1767
> Project: TinkerPop
> Issue Type: Improvement
> Components: io
>Affects Versions: 3.3.0
>Reporter: stephen mallette
>Assignee: stephen mallette
> Fix For: 3.3.1
>
>
> The basic problem is described here:
> https://lists.apache.org/thread.html/5d46643614c5306d38bfbec11cee3aa7653f440d276e7cbe189e@%3Cdev.tinkerpop.apache.org%3E
> but in summary, the graph provider needs a way to check the type of io and
> version so that they have the opportunity to assign the correct instance of
> their {{IoRegistry}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1737) Validate and throw an exception when maxContentLength overflows
[
https://issues.apache.org/jira/browse/TINKERPOP-1737?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16156977#comment-16156977
]
stephen mallette commented on TINKERPOP-1737:
-
[~jeromatron] which way were you setting {{maxContentLength}} to get this
error? I guessed that you meant with {{:remote connect}} so I bumped the
{{maxContentLength}} to something really big in the {{remote.yaml}} file and it
failed with a semi-reasonable error. also, I don't find that the error leaves
the console broken which is what i was more worried about. I was able to
correct the yaml file and issue the {{remote connect}} again and it worked
fine. Could you please clarify the problem you were seeing?
> Validate and throw an exception when maxContentLength overflows
> ---
>
> Key: TINKERPOP-1737
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1737
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.2.5
>Reporter: Jeremy Hanna
>Priority: Trivial
>
> If you set the {{maxContentLength}} to higher than {{Integer.MAX_VALUE}} it
> won't error out but the gremlin console is broken. We should probably do
> some sort of validation on startup and then fail fast with an appropriate
> error message instead.
> This can happen if people don't want to worry about the value and set it
> arbitrarily high and don't know that it's an integer.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1770) Remote traversal timeout
[
https://issues.apache.org/jira/browse/TINKERPOP-1770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157202#comment-16157202
]
ASF GitHub Bot commented on TINKERPOP-1770:
---
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/708
TINKERPOP-1770 Enable timeouts for remote traversals
https://issues.apache.org/jira/browse/TINKERPOP-1770
All tests pass with `docker/build.sh -t -n -i`
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1770
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/708.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #708
commit 21b815ecfca354ba1907e5c379184d2eb28795f7
Author: Stephen Mallette
Date: 2017-09-07T13:15:37Z
TINKERPOP-1770 Enable timeouts for remote traversals
> Remote traversal timeout
>
>
> Key: TINKERPOP-1770
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1770
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.2.6
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Critical
>
> Remote traversals do not respect {{scriptEvaluationTimeout}} so it is
> currently possible to submit a traversal that runs indefinitely.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] tinkerpop pull request #708: TINKERPOP-1770 Enable timeouts for remote trave...
GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/708 TINKERPOP-1770 Enable timeouts for remote traversals https://issues.apache.org/jira/browse/TINKERPOP-1770 All tests pass with `docker/build.sh -t -n -i` VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1770 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/708.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #708 commit 21b815ecfca354ba1907e5c379184d2eb28795f7 Author: Stephen Mallette Date: 2017-09-07T13:15:37Z TINKERPOP-1770 Enable timeouts for remote traversals ---
[jira] [Commented] (TINKERPOP-1697) Allow null values in config
[ https://issues.apache.org/jira/browse/TINKERPOP-1697?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157218#comment-16157218 ] stephen mallette commented on TINKERPOP-1697: - I'm not sure I can implement this as you would like. Gremlin Server uses reflection to detect the builder methods to call on the plugin when it is constructed. To do that it has to make some assumption that the user knows how to configure the plugin properly. Passing in an empty string for an integer just doesn't work with a reflection based approach - at least not without a lot of extra processing and further assumptions from the server. I think that the way to think about configuring plugins is to: 1. assume they have decent defaults (which they do afaik) 2. only set the value in the config if you intend to change something - i think "null" as a value may be a valid setting in some cases and not an indicator of a no-op or a default setting. Short of building out a much more advanced configuration system for the plugins I don't really see a way to make this work and for the effort involved it doesn't seem worth it. I'll leave this open for a bit in case anyone has further comment or other ideas, but I'm inclined to close this. > Allow null values in config > --- > > Key: TINKERPOP-1697 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1697 > Project: TinkerPop > Issue Type: Improvement > Components: server >Affects Versions: 3.3.0 >Reporter: Xian Yi Teng > > Under > scriptEngines/gremlin-groovy/plugins/org.apache.tinkerpop.gremlin.groovy.jsr223.GroovyCompilerGremlinPlugin: > extensions: null (x) > extensions: (x) > extensions: "" (/) > timedInterrupt: "" (x) > timedInterrupt: (x) > timedInterrupt: 0 (/) > Would be nice to streamline these. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] tinkerpop issue #706: TINKERPOP-1767 Added Io.requiresVersion(Object)
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/706 VOTE: +1 ---
[jira] [Commented] (TINKERPOP-1767) Method for graph providers to check an IO version and type
[
https://issues.apache.org/jira/browse/TINKERPOP-1767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157247#comment-16157247
]
ASF GitHub Bot commented on TINKERPOP-1767:
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/706
VOTE: +1
> Method for graph providers to check an IO version and type
> --
>
> Key: TINKERPOP-1767
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1767
> Project: TinkerPop
> Issue Type: Improvement
> Components: io
>Affects Versions: 3.3.0
>Reporter: stephen mallette
>Assignee: stephen mallette
> Fix For: 3.3.1
>
>
> The basic problem is described here:
> https://lists.apache.org/thread.html/5d46643614c5306d38bfbec11cee3aa7653f440d276e7cbe189e@%3Cdev.tinkerpop.apache.org%3E
> but in summary, the graph provider needs a way to check the type of io and
> version so that they have the opportunity to assign the correct instance of
> their {{IoRegistry}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] tinkerpop issue #707: TINKERPOP-1768 Bump to Jackson 2.8.10
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/707 VOTE: +1 ---
[jira] [Commented] (TINKERPOP-1768) Bump to Jackson 2.8.10
[ https://issues.apache.org/jira/browse/TINKERPOP-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157261#comment-16157261 ] ASF GitHub Bot commented on TINKERPOP-1768: --- Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/707 VOTE: +1 > Bump to Jackson 2.8.10 > -- > > Key: TINKERPOP-1768 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1768 > Project: TinkerPop > Issue Type: Improvement > Components: io >Affects Versions: 3.2.6 >Reporter: stephen mallette >Assignee: stephen mallette > > Jackson 2.8.10 has some important bug fixes - hoping for a fix for > TINKERPOP-1509 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] tinkerpop issue #707: TINKERPOP-1768 Bump to Jackson 2.8.10
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/707 Did it fix https://issues.apache.org/jira/browse/TINKERPOP-1509 ? ---
[jira] [Commented] (TINKERPOP-1768) Bump to Jackson 2.8.10
[ https://issues.apache.org/jira/browse/TINKERPOP-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157295#comment-16157295 ] ASF GitHub Bot commented on TINKERPOP-1768: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/707 Did it fix https://issues.apache.org/jira/browse/TINKERPOP-1509 ? > Bump to Jackson 2.8.10 > -- > > Key: TINKERPOP-1768 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1768 > Project: TinkerPop > Issue Type: Improvement > Components: io >Affects Versions: 3.2.6 >Reporter: stephen mallette >Assignee: stephen mallette > > Jackson 2.8.10 has some important bug fixes - hoping for a fix for > TINKERPOP-1509 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] tinkerpop issue #707: TINKERPOP-1768 Bump to Jackson 2.8.10
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/707 I don't think so, but I think I didn't go too deep into it. I just removed the ignore annotation on the test and it still failed. I think we needed this fix anyway though for something else, though I can't recall what immediately. I'll have to dig into it when I look at TINKERPOP-1509 directly. ---
[jira] [Commented] (TINKERPOP-1768) Bump to Jackson 2.8.10
[ https://issues.apache.org/jira/browse/TINKERPOP-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157319#comment-16157319 ] ASF GitHub Bot commented on TINKERPOP-1768: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/707 I don't think so, but I think I didn't go too deep into it. I just removed the ignore annotation on the test and it still failed. I think we needed this fix anyway though for something else, though I can't recall what immediately. I'll have to dig into it when I look at TINKERPOP-1509 directly. > Bump to Jackson 2.8.10 > -- > > Key: TINKERPOP-1768 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1768 > Project: TinkerPop > Issue Type: Improvement > Components: io >Affects Versions: 3.2.6 >Reporter: stephen mallette >Assignee: stephen mallette > > Jackson 2.8.10 has some important bug fixes - hoping for a fix for > TINKERPOP-1509 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] tinkerpop issue #707: TINKERPOP-1768 Bump to Jackson 2.8.10
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/707 VOTE +1 ---
[jira] [Commented] (TINKERPOP-1768) Bump to Jackson 2.8.10
[ https://issues.apache.org/jira/browse/TINKERPOP-1768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157345#comment-16157345 ] ASF GitHub Bot commented on TINKERPOP-1768: --- Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/707 VOTE +1 > Bump to Jackson 2.8.10 > -- > > Key: TINKERPOP-1768 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1768 > Project: TinkerPop > Issue Type: Improvement > Components: io >Affects Versions: 3.2.6 >Reporter: stephen mallette >Assignee: stephen mallette > > Jackson 2.8.10 has some important bug fixes - hoping for a fix for > TINKERPOP-1509 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] tinkerpop issue #708: TINKERPOP-1770 Enable timeouts for remote traversals
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/708 VOTE: +1 ---
[jira] [Commented] (TINKERPOP-1770) Remote traversal timeout
[
https://issues.apache.org/jira/browse/TINKERPOP-1770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157355#comment-16157355
]
ASF GitHub Bot commented on TINKERPOP-1770:
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/708
VOTE: +1
> Remote traversal timeout
>
>
> Key: TINKERPOP-1770
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1770
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.2.6
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Critical
>
> Remote traversals do not respect {{scriptEvaluationTimeout}} so it is
> currently possible to submit a traversal that runs indefinitely.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] tinkerpop issue #695: TINKERPOP-1489 JavaScript GLV
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/695 I think the need to figure out the language agnostic way to test GLVs is becoming more important. I was pretty close to getting nashorn to execute gremlin-javascript natively, but there's weird pathing issue and npm integration issues that just aren't making it easy (possible). I tried to hack my way around the pathing problems and while i was making progress it was just getting ugly. I'll need to think about the language agnostic approach a bit before I worry about trying to go any further in this direction. ---
[jira] [Commented] (TINKERPOP-1489) Provide a Javascript Gremlin Language Variant
[ https://issues.apache.org/jira/browse/TINKERPOP-1489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16157445#comment-16157445 ] ASF GitHub Bot commented on TINKERPOP-1489: --- Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/695 I think the need to figure out the language agnostic way to test GLVs is becoming more important. I was pretty close to getting nashorn to execute gremlin-javascript natively, but there's weird pathing issue and npm integration issues that just aren't making it easy (possible). I tried to hack my way around the pathing problems and while i was making progress it was just getting ugly. I'll need to think about the language agnostic approach a bit before I worry about trying to go any further in this direction. > Provide a Javascript Gremlin Language Variant > - > > Key: TINKERPOP-1489 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1489 > Project: TinkerPop > Issue Type: Improvement > Components: language-variant >Affects Versions: 3.2.5 >Reporter: Jorge Bay > > It would be nice to have a Javascript Gremlin Language Variant that could > work with any ES5 runtime, specially the ones that support > [CommonJs|http://requirejs.org/docs/commonjs.html], like Node.js. > Nashorn, the engine shipped with JDK 8+, does not implement CommonJs but > provides [additional > extensions|https://wiki.openjdk.java.net/display/Nashorn/Nashorn+extensions] > making modular JavaScript possible. Nashorn should be supported in order to > run glv tests under the same infrastructure (JDK8). -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[GitHub] tinkerpop issue #705: make TinkerGraph cloneable
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/705 there we go @spmallette @robertdale ---
