[jira] [Commented] (TINKERPOP-1731) Docker build does not appear to work for gremlin-dotnet
[
https://issues.apache.org/jira/browse/TINKERPOP-1731?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169320#comment-16169320
]
Florian Hockmann commented on TINKERPOP-1731:
-
I finally found the cause for this: The {{Gremlin.Net.csproj.template}} was
encoded in UTF-8 and contained a [byte order mark
(BOM)|https://en.wikipedia.org/wiki/Byte_order_mark]. Apparently the Groovy
template engine has a problem with some special characters like this and
replaces them with {{\?\?\?}} during the docker build. That resulted in a
csproj file that had {{\?\?\?}} as the first characters right before the
license header comment which is of course not a valid XML file anymore.
I just pushed
[3bf128ae9f9d6f73675705a958b7b4102572eaaa|https://github.com/apache/tinkerpop/commit/3bf128ae9f9d6f73675705a958b7b4102572eaaa]
which simply removes the BOM bytes from the template file. This fixes the
build of Gremlin.Net with Docker.
Unfortunately the csproj file still contains some {{\?\?\?}}, e.g.,
{{TinkerPop™}} becomes {{TinkerPop\?\?\?}} and {{application’s}} becomes
{{application\?\?\?s}}. So we should probably find a way to tell the template
engine to always use UTF-8 as the encoding which should fix this problem
completely.
> Docker build does not appear to work for gremlin-dotnet
> ---
>
> Key: TINKERPOP-1731
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1731
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release, dotnet
>Affects Versions: 3.3.0
>Reporter: stephen mallette
>Priority: Critical
>
> Docker won't build the gremlin-dotnet stuff. I pulled out the {{.glv}} files
> from that module so that docker would run properly until this can be fixed:
> https://github.com/apache/tinkerpop/blob/2d30a76aabdd009b9b926f83df2308b7578571c0/docker/scripts/build.sh#L71-L72
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[GitHub] tinkerpop issue #715: change behaviour of repeat step to be depth first sear...
Github user mpollmeier commented on the issue:
https://github.com/apache/tinkerpop/pull/715
`emit` modifies the behaviour of the repeat traversal, and I am unsure why
that is. Let me explain what I know and hopefully you or someone else can fill
the blanks.
Let's take my toy graph `v5 <- v3 <- v1 <- v0 -> v2 -> v4 -> v6` since it's
easier to see where you are with a simple println of the vertex. Without emit,
this PR does what it's supposed to do: DFS. First the even numbers, then the
odds.
```
graph = TinkerGraph.open()
v0 = graph.addVertex("l0")
v1 = graph.addVertex("l1")
v2 = graph.addVertex("l1")
v3 = graph.addVertex("l2")
v4 = graph.addVertex("l2")
v5 = graph.addVertex("l3")
v6 = graph.addVertex("l3")
v0.addEdge("e", v2)
v2.addEdge("e", v4)
v4.addEdge("e", v6)
v0.addEdge("e", v1)
v1.addEdge("e", v3)
v3.addEdge("e", v5)
graph.traversal().V(v0).repeat(sideEffect{println("inside repeat at " +
it)}.out()).times(3)
inside repeat at v[0]
inside repeat at v[2]
inside repeat at v[4]
==>v[6]
inside repeat at v[1]
inside repeat at v[3]
==>v[5]
```
However if I add an `emit()` it becomes BFS again:
```
graph.traversal().V(v0).emit().repeat(sideEffect{println("inside repeat at
" + it)}.out()).times(3)
==>v[0]
inside repeat at v[0]
==>v[2]
inside repeat at v[2]
==>v[1]
inside repeat at v[1]
==>v[4]
inside repeat at v[4]
==>v[6]
==>v[3]
inside repeat at v[3]
==>v[5]
```
I tried to understand it in the debugger, and the core difference seems to
be the behaviour of `this.starts.hasNext()` in
`RepeatEndStep.standardAlgorithm`, which is an `ExpandableStepIterator`.
* without emit, `hasNext` finds that
`this.hostStep.getPreviousStep().hasNext()` is true, because it asks it's
`previousStep` (which is a `VertexStep(OUT)`), which in turns has some results
for `processNextStart`.
* with emit, the above chain returns false, which in turn leads to a
NoSuchElementException, which short-circuits and `while (true)` loop, which
results in losing DFS semantics.
I don't know where these different semantics derive from.
---
[GitHub] tinkerpop issue #705: make TinkerGraph cloneable
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/705 @spmallette addressed your comments. VOTE +1 ---
[jira] [Created] (TINKERPOP-1786) Recipe and missing manifest items for Spark on Yarn
Marc de Lignie created TINKERPOP-1786: - Summary: Recipe and missing manifest items for Spark on Yarn Key: TINKERPOP-1786 URL: https://issues.apache.org/jira/browse/TINKERPOP-1786 Project: TinkerPop Issue Type: Improvement Components: hadoop Affects Versions: 3.2.6, 3.3.0 Environment: gremlin-console Reporter: Marc de Lignie Priority: Minor Fix For: 3.2.7, 3.3.1 Thorough documentation for running OLAP queries on Spark on Yarn has been missing, keeping some users from getting the benefits of this nice feature of the Tinkerpop stack and resulting in a significant number of questions on the gremlin users list. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (TINKERPOP-1786) Recipe and missing manifest items for Spark on Yarn
[ https://issues.apache.org/jira/browse/TINKERPOP-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Marc de Lignie updated TINKERPOP-1786: -- Affects Version/s: 3.1.8 > Recipe and missing manifest items for Spark on Yarn > --- > > Key: TINKERPOP-1786 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1786 > Project: TinkerPop > Issue Type: Improvement > Components: hadoop >Affects Versions: 3.3.0, 3.1.8, 3.2.6 > Environment: gremlin-console >Reporter: Marc de Lignie >Priority: Minor > Fix For: 3.2.7, 3.3.1 > > > Thorough documentation for running OLAP queries on Spark on Yarn has been > missing, keeping some users from getting the benefits of this nice feature of > the Tinkerpop stack and resulting in a significant number of questions on the > gremlin users list. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (TINKERPOP-1786) Recipe and missing manifest items for Spark on Yarn
[ https://issues.apache.org/jira/browse/TINKERPOP-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169628#comment-16169628 ] Marc de Lignie commented on TINKERPOP-1786: --- This issue was discussed on the [dev list|http://mail-archives.apache.org/mod_mbox/incubator-tinkerpop-dev/201707.mbox/browser] (July 6) and the approach suggested by Stephen Malette turns out to be perfectly possible. A future PR is in pretty good shape and can be previewed [here|https://github.com/vtslab/incubator-tinkerpop/commit/d2a7d9e85b76b2ccfda1c15d0c18def331fb75ea]. What I plan to do next: * merge this commit into a branch based on master (this will break things because of the differences between Spark 1.6 and Spark 2.0) * final test of the TP32 and TP33 versions on a real cluster * issue a PR with TP32 and TP33 feature branches and receive review comments Of course, any suggestions on the approach are also welcome at this stage. > Recipe and missing manifest items for Spark on Yarn > --- > > Key: TINKERPOP-1786 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1786 > Project: TinkerPop > Issue Type: Improvement > Components: hadoop >Affects Versions: 3.3.0, 3.1.8, 3.2.6 > Environment: gremlin-console >Reporter: Marc de Lignie >Priority: Minor > Fix For: 3.2.7, 3.3.1 > > > Thorough documentation for running OLAP queries on Spark on Yarn has been > missing, keeping some users from getting the benefits of this nice feature of > the Tinkerpop stack and resulting in a significant number of questions on the > gremlin users list. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (TINKERPOP-1786) Recipe and missing manifest items for Spark on Yarn
[ https://issues.apache.org/jira/browse/TINKERPOP-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16169628#comment-16169628 ] Marc de Lignie edited comment on TINKERPOP-1786 at 9/18/17 5:49 AM: This issue was discussed on the [dev list|http://mail-archives.apache.org/mod_mbox/incubator-tinkerpop-dev/201707.mbox/browser] (July 6) and the approach suggested by Stephen Mallette turns out to be perfectly possible. A future PR is in pretty good shape and can be previewed [here|https://github.com/vtslab/incubator-tinkerpop/commit/d2a7d9e85b76b2ccfda1c15d0c18def331fb75ea]. What I plan to do next: * merge this commit into a branch based on master (this will break things because of the differences between Spark 1.6 and Spark 2.0) * final test of the TP32 and TP33 versions on a real cluster * issue a PR with TP32 and TP33 feature branches and receive review comments Of course, any suggestions on the approach are also welcome at this stage. was (Author: hadoopmarc): This issue was discussed on the [dev list|http://mail-archives.apache.org/mod_mbox/incubator-tinkerpop-dev/201707.mbox/browser] (July 6) and the approach suggested by Stephen Malette turns out to be perfectly possible. A future PR is in pretty good shape and can be previewed [here|https://github.com/vtslab/incubator-tinkerpop/commit/d2a7d9e85b76b2ccfda1c15d0c18def331fb75ea]. What I plan to do next: * merge this commit into a branch based on master (this will break things because of the differences between Spark 1.6 and Spark 2.0) * final test of the TP32 and TP33 versions on a real cluster * issue a PR with TP32 and TP33 feature branches and receive review comments Of course, any suggestions on the approach are also welcome at this stage. > Recipe and missing manifest items for Spark on Yarn > --- > > Key: TINKERPOP-1786 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1786 > Project: TinkerPop > Issue Type: Improvement > Components: hadoop >Affects Versions: 3.3.0, 3.1.8, 3.2.6 > Environment: gremlin-console >Reporter: Marc de Lignie >Priority: Minor > Fix For: 3.2.7, 3.3.1 > > > Thorough documentation for running OLAP queries on Spark on Yarn has been > missing, keeping some users from getting the benefits of this nice feature of > the Tinkerpop stack and resulting in a significant number of questions on the > gremlin users list. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
