[GitHub] tinkerpop pull request #819: Use error-prone compiler
GitHub user leventov opened a pull request: https://github.com/apache/tinkerpop/pull/819 Use error-prone compiler See http://errorprone.info/. Fixes a number of bugs. This is just first step; maintainers of this project are encouraged to enable more checks eventually, e. g. "Experimental ERROR" patterns from here: http://errorprone.info/bugpatterns You can merge this pull request into a Git repository by running: $ git pull https://github.com/leventov/tinkerpop error-prone Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/819.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #819 commit 32ea0b1192b3cd2dfa8aa12fc0e55ef2ec48ccb1 Author: leventov Date: 2018-03-17T15:56:23Z Use error-prone compiler ---
[jira] [Created] (TINKERPOP-1926) Cannot build a project locally
Roman Leventov created TINKERPOP-1926: - Summary: Cannot build a project locally Key: TINKERPOP-1926 URL: https://issues.apache.org/jira/browse/TINKERPOP-1926 Project: TinkerPop Issue Type: Bug Reporter: Roman Leventov I cannot build a project locally with `mvn clean install`. It is related to "gremlin-shaded" module. When maven tries to compile gremlin-core module, it looks at gremlin-shaded/target/classes instead of the local repository, for some reason. I managed to work-around this by commenting-out `gremlin-shaded` line in the root pom after building gremlin-shaded, but this is an ugly solution. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] tinkerpop pull request #792: TINKERPOP-1854 Add Lambdas for Gremlin.Net
Github user FlorianHockmann commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/792#discussion_r175266150 --- Diff: gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs --- @@ -398,7 +398,7 @@ private static ITokenParameter ParseParameter(string text, ref int i) { return ParseNumber(text, ref i); } -if (text.Substring(i, 3).StartsWith("__.")) +if (text.Length >= i + 3 && text.Substring(i, 3).StartsWith("__.")) --- End diff -- Done ---
[jira] [Commented] (TINKERPOP-1854) Support lambdas in Gremlin.Net
[ https://issues.apache.org/jira/browse/TINKERPOP-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403678#comment-16403678 ] ASF GitHub Bot commented on TINKERPOP-1854: --- Github user FlorianHockmann commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/792#discussion_r175266150 --- Diff: gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Gherkin/TraversalEvaluation/TraversalParser.cs --- @@ -398,7 +398,7 @@ private static ITokenParameter ParseParameter(string text, ref int i) { return ParseNumber(text, ref i); } -if (text.Substring(i, 3).StartsWith("__.")) +if (text.Length >= i + 3 && text.Substring(i, 3).StartsWith("__.")) --- End diff -- Done > Support lambdas in Gremlin.Net > -- > > Key: TINKERPOP-1854 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1854 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Affects Versions: 3.3.0, 3.2.6 >Reporter: Florian Hockmann >Assignee: Florian Hockmann >Priority: Major > Fix For: 3.2.8, 3.3.2 > > > Gremlin.Net should support lambdas. We already discussed this in [the pull > request for TINKERPOP-1752|https://github.com/apache/tinkerpop/pull/712]. > Here is what [~spmallette] said over there: > {quote} > Any reason we don't support lambdas? Even if .NET can't support them natively > for some reason wouldn't we minimally support the ability to pass a > python/groovy/etc lambda? it's kinda weird that way, but i think back to the > point that kuppitz made on the dev list the other day where he stated that he > doesn't always find a way out of using lambdas in production systems he works > on - so ultimately users will need that kind of capability i think. > {quote} > C# lambdas would require some kind of C# parser on the server side, so at > least in the beginning a way to send lambdas from already supported languages > in Gremlin.Net should be enough. -- This message was sent by Atlassian JIRA (v7.6.3#76005)