[GitHub] [tinkerpop] spmallette commented on issue #968: TINKERPOP-2078 Added AnonymousTraversalSource

2018-10-25 Thread GitHub 
I dont' think i want to deprecate that as of yet even though we have a way 
create `TraversalSource` from local graphs this way.  I will make all of this 
much more clear in 3.4.0 docs since they will be `/current` docs on next 
release and they will be the focus of things. I just realized that i still 
might need to make changes to other language variants so that we have similar 
functionality over there.

[ Full content available at: https://github.com/apache/tinkerpop/pull/968 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #968: TINKERPOP-2078 Added AnonymousTraversalSource

2018-10-25 Thread GitHub 
I dont' think i want to deprecate that as of yet even though we have a way 
create `TraversalSource` from local graphs this way.  I will make all of this 
much more clear in 3.4.0 docs since they will be `/current` docs on next 
release and they will be the focus of things.

[ Full content available at: https://github.com/apache/tinkerpop/pull/968 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] newkek commented on issue #968: TINKERPOP-2078 Added AnonymousTraversalSource

2018-10-25 Thread GitHub 
Oh actually, I may have been confused. Is the goal of this to also deprecate 
`graph.traversal()`?

[ Full content available at: https://github.com/apache/tinkerpop/pull/968 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Created] (TINKERPOP-2080) Remove deprecated TraversalSource.withRemote()

2018-10-25 Thread stephen mallette (JIRA) 
stephen mallette created TINKERPOP-2080:
---

 Summary: Remove deprecated TraversalSource.withRemote()
 Key: TINKERPOP-2080
 URL: https://issues.apache.org/jira/browse/TINKERPOP-2080
 Project: TinkerPop
  Issue Type: Improvement
  Components: process
Affects Versions: 3.4.0
Reporter: stephen mallette
Assignee: stephen mallette
 Fix For: 3.4.0


{{TraversalSource.withRemote()}} was deprecated on 3.3.5 with TINKERPOP-2078 in 
favor of {{AnonymousTraversalSource}}. It can safely be removed for 3.4.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [tinkerpop] newkek commented on issue #968: TINKERPOP-2078 Added AnonymousTraversalSource

2018-10-25 Thread GitHub 
Oh actually, I may have gotten confused. Is the goal of this to also deprecate 
`graph.traversal()`?

[ Full content available at: https://github.com/apache/tinkerpop/pull/968 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Updated] (TINKERPOP-2078) Hide use of EmptyGraph or RemoteGraph behind a more unified method for TraversalSource construction

2018-10-25 Thread stephen mallette (JIRA) 


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

stephen mallette updated TINKERPOP-2078:

Labels: deprecation  (was: )

> Hide use of EmptyGraph or RemoteGraph behind a more unified method for 
> TraversalSource construction
> ---
>
> Key: TINKERPOP-2078
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2078
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: structure
>Affects Versions: 3.3.4
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
>  Labels: deprecation
>
> {{RemoteGraph}} was long ago deprecated for {{withRemote()}} typically 
> spawned from {{EmptyGraph}} which is weird. For GLVs, make sure 
> {{EmptyGraph}} didn't leak into them and deal with those issues as needed. 
> Update all docs to stop using {{EmptyGraph}}. Provide a way to unify 
> {{TraversalSource}} construction for both local and remote connected graphs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [tinkerpop] spmallette commented on issue #971: TINKERPOP-2062 added Traversal class to CoreImports

2018-10-25 Thread GitHub 
VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/971 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on pull request #968: TINKERPOP-2078 Added AnonymousTraversalSource

2018-10-25 Thread GitHub 
i thought i fixed that!

[ Full content available at: https://github.com/apache/tinkerpop/pull/968 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] newkek commented on pull request #968: TINKERPOP-2078 Added AnonymousTraversalSource

2018-10-25 Thread GitHub 
nit: "Anonymouse"

[ Full content available at: https://github.com/apache/tinkerpop/pull/968 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Commented] (TINKERPOP-2062) Add Traversal class to CoreImports

2018-10-25 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663837#comment-16663837
 ] 

ASF GitHub Bot commented on TINKERPOP-2062:
---

dkuppitz opened a new pull request #971: TINKERPOP-2062 added Traversal class 
to CoreImports
URL: https://github.com/apache/tinkerpop/pull/971
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-2062
   
   Not really worth a PR, could have been a CTR, but just in case someone has 
any complaints about adding this import.
   
   VOTE +1


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add Traversal class to CoreImports
> --
>
> Key: TINKERPOP-2062
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2062
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.3.3
>Reporter: Daniel Kuppitz
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> Apparently, some people like to copy Gremlin queries they've written in Java 
> and paste them into the Gremlin console. This should usually work pretty 
> well, however, there are some oddities in particular with {{union()}} step 
> which requires you to cast the child traversals to {{Traversal}} if they have 
> different return types, e.g.:
> {noformat}
> g.V().
> union(
>   __.identity(),
>   (Traversal)__.outE()
> )
> {noformat}
> This works in a local console session but fails if the query is sent to a 
> server as {{Traversal}} is not part of the core imports. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (TINKERPOP-2068) Bump Jackson Databind 2.9.7

2018-10-25 Thread Robert Dale (JIRA) 


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Dale updated TINKERPOP-2068:
---
Description: 
Jackson Databind vulnerability flagged by:
 * https://app.snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72451
 * [https://app.snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72449]
 * [https://app.snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72450]
 * https://app.snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72448

Jackson Databind Release Notes:  
[https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.9.7]

 

  was:Jackson Databind vulnerabily:  
https://cwe.mitre.org/data/definitions/502.html


> Bump Jackson Databind 2.9.7
> ---
>
> Key: TINKERPOP-2068
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2068
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: io
>Affects Versions: 3.3.4, 3.2.10
>Reporter: Robert Dale
>Assignee: Robert Dale
>Priority: Major
>  Labels: security
>
> Jackson Databind vulnerability flagged by:
>  * https://app.snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72451
>  * [https://app.snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72449]
>  * [https://app.snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72450]
>  * https://app.snyk.io/vuln/SNYK-JAVA-COMFASTERXMLJACKSONCORE-72448
> Jackson Databind Release Notes:  
> [https://github.com/FasterXML/jackson/wiki/Jackson-Release-2.9.7]
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [tinkerpop] jorgebay commented on issue #969: TINKERPOP-2068 bump jackson-databind to 2.9.7

2018-10-25 Thread GitHub 
VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/969 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] jorgebay commented on issue #970: TINKERPOP-2068 bump jackson-databind to 2.9.7 [master]

2018-10-25 Thread GitHub 
VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/970 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #970: TINKERPOP-2068 bump jackson-databind to 2.9.7 [master]

2018-10-25 Thread GitHub 
VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/970 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[GitHub] [tinkerpop] spmallette commented on issue #969: TINKERPOP-2068 bump jackson-databind to 2.9.7

2018-10-25 Thread GitHub 
VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/969 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Commented] (TINKERPOP-2078) Hide use of EmptyGraph or RemoteGraph behind a more unified method for TraversalSource construction

2018-10-25 Thread Robert Dale (JIRA) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663682#comment-16663682
 ] 

Robert Dale commented on TINKERPOP-2078:


Looks good. (y)

> Hide use of EmptyGraph or RemoteGraph behind a more unified method for 
> TraversalSource construction
> ---
>
> Key: TINKERPOP-2078
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2078
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: structure
>Affects Versions: 3.3.4
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
>
> {{RemoteGraph}} was long ago deprecated for {{withRemote()}} typically 
> spawned from {{EmptyGraph}} which is weird. For GLVs, make sure 
> {{EmptyGraph}} didn't leak into them and deal with those issues as needed. 
> Update all docs to stop using {{EmptyGraph}}. Provide a way to unify 
> {{TraversalSource}} construction for both local and remote connected graphs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [tinkerpop] robertdale opened pull request #970: TINKERPOP-2068 master merge

2018-10-25 Thread GitHub 
https://issues.apache.org/jira/browse/TINKERPOP-2068

security fix

`docker/build.sh -i -t -n` SUCCESS

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/970 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Commented] (TINKERPOP-2068) Bump Jackson Databind 2.9.7

2018-10-25 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663677#comment-16663677
 ] 

ASF GitHub Bot commented on TINKERPOP-2068:
---

robertdale opened a new pull request #970: TINKERPOP-2068 master merge
URL: https://github.com/apache/tinkerpop/pull/970
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-2068
   
   security fix
   
   `docker/build.sh -i -t -n` SUCCESS
   
   VOTE +1


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bump Jackson Databind 2.9.7
> ---
>
> Key: TINKERPOP-2068
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2068
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: io
>Affects Versions: 3.3.4, 3.2.10
>Reporter: Robert Dale
>Assignee: Robert Dale
>Priority: Major
>  Labels: security
>
> Jackson Databind vulnerabily:  https://cwe.mitre.org/data/definitions/502.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-2068) Bump Jackson Databind 2.9.7

2018-10-25 Thread ASF GitHub Bot (JIRA) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663676#comment-16663676
 ] 

ASF GitHub Bot commented on TINKERPOP-2068:
---

robertdale opened a new pull request #969: TINKERPOP-2068 bump jackson-databind 
to 2.9.7
URL: https://github.com/apache/tinkerpop/pull/969
 
 
   https://issues.apache.org/jira/browse/TINKERPOP-2068
   
   security fix
   
   `docker/build.sh -i -t -n` SUCCESS
   
   VOTE +1


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Bump Jackson Databind 2.9.7
> ---
>
> Key: TINKERPOP-2068
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2068
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: io
>Affects Versions: 3.3.4, 3.2.10
>Reporter: Robert Dale
>Assignee: Robert Dale
>Priority: Major
>  Labels: security
>
> Jackson Databind vulnerabily:  https://cwe.mitre.org/data/definitions/502.html



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (TINKERPOP-2078) Hide use of EmptyGraph or RemoteGraph behind a more unified method for TraversalSource construction

2018-10-25 Thread stephen mallette (JIRA) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663675#comment-16663675
 ] 

stephen mallette commented on TINKERPOP-2078:
-

Taking a quiet suggestion from [~newkek] - he came up with something good that 
provides a clear deprecation path. Syntax is not too different from what was 
proposed above, but works more nicely with the patterns we sorta already had:

{code}
gremlin> g = traversal().withGraph(TinkerFactory.createModern())
==>graphtraversalsource[tinkergraph[vertices:6 edges:6], standard]
gremlin> g = traversal().withRemote('conf/remote-graph.properties')
==>graphtraversalsource[emptygraph[empty], standard]
gremlin> g = 
traversal().withRemote(DriverRemoteConnection.using('localhost',8182))
==>graphtraversalsource[emptygraph[empty], standard]
{code}

Note that {{traversal()}} will have the {{traversal(Class)}} overload so that 
we can do DSLs. Basically, we've replicated the two traversal methods on 
{{Graph}} so that they can be called anonymously. 
{{TraversalSource.withRemote()}} can now be easily deprecated which sets things 
up to stop weird/confusing configurations like 
{{traversal().withGraph(graph).withRemote(...)}}

> Hide use of EmptyGraph or RemoteGraph behind a more unified method for 
> TraversalSource construction
> ---
>
> Key: TINKERPOP-2078
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2078
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: structure
>Affects Versions: 3.3.4
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
>
> {{RemoteGraph}} was long ago deprecated for {{withRemote()}} typically 
> spawned from {{EmptyGraph}} which is weird. For GLVs, make sure 
> {{EmptyGraph}} didn't leak into them and deal with those issues as needed. 
> Update all docs to stop using {{EmptyGraph}}. Provide a way to unify 
> {{TraversalSource}} construction for both local and remote connected graphs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [tinkerpop] robertdale opened pull request #969: TINKERPOP-2068 bump jackson-databind to 2.9.7

2018-10-25 Thread GitHub 
https://issues.apache.org/jira/browse/TINKERPOP-2068

security fix

`docker/build.sh -i -t -n` SUCCESS

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/969 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org

[jira] [Commented] (TINKERPOP-2078) Hide use of EmptyGraph or RemoteGraph behind a more unified method for TraversalSource construction

2018-10-25 Thread Jorge Bay (JIRA) 


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2078?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16663582#comment-16663582
 ] 

Jorge Bay commented on TINKERPOP-2078:
--

I like {{traversal().withRemote(...)}} as a way to hide EmptyGraph/RemoteGraph.

+1 on starting simple and adding overloads for {{traversal()}} in the future, 
if we find the need.

> Hide use of EmptyGraph or RemoteGraph behind a more unified method for 
> TraversalSource construction
> ---
>
> Key: TINKERPOP-2078
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2078
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: structure
>Affects Versions: 3.3.4
>Reporter: stephen mallette
>Assignee: stephen mallette
>Priority: Major
>
> {{RemoteGraph}} was long ago deprecated for {{withRemote()}} typically 
> spawned from {{EmptyGraph}} which is weird. For GLVs, make sure 
> {{EmptyGraph}} didn't leak into them and deal with those issues as needed. 
> Update all docs to stop using {{EmptyGraph}}. Provide a way to unify 
> {{TraversalSource}} construction for both local and remote connected graphs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)