[jira] [Commented] (TINKERPOP-2098) gremlin-server.sh start does not seem to work as advertised

2018-11-22 Thread Kelvin R. Lawrence (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696308#comment-16696308
 ] 

Kelvin R. Lawrence commented on TINKERPOP-2098:
---

If it’s working as designed I think a good enhancement would be for start to 
support a yaml file being specified as the script’s help text makes no mention 
of the environment variable. Alternatively I suggest adding mention of the 
environment variables to the help text. 

> gremlin-server.sh start does not seem to work as advertised
> ---
>
> Key: TINKERPOP-2098
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2098
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.3.4
>Reporter: Kelvin R. Lawrence
>Priority: Minor
>
> This may be as simple as a documentation issue but the help text for Gremlin 
> server implies that I should be able to do:
> {code:java}
> gremlin-server.sh start conf/myyaml.yaml{code}
> However when I do that it does not seem to actually be reading my YAML file 
> or if it is it is not reading it fully as I am specifying the WsAndHttp 
> channelizer in the YAML and when the server starts the HTTP endpoint is not 
> available.
>  
> If I start the server in the terminal with
>  
> {code:java}
>  gremlin-server.sh  conf/myyaml.yaml{code}
>  
> all is fine but I want to start it in the background.
>  
> I spoke to [~pluradj] and he had me try using the environment variable to 
> specify the YAML file name and that worked with the *start* keyword.
>  
> Is *gremlin-server.sh start conf/myyaml.yam*l supposed to work?
>  
> If not it would be good to change the help text for gremlin-server.sh which 
> currently reads as follows:
>  
>  
> {code:java}
> Usage: bin/gremlin-server.sh {start|stop|restart|status|console|install 
>   |}{code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


Re: Disable Nuget Question

2018-11-22 Thread Robert Dale
Could you add the suggestion to the main description page?
https://www.nuget.org/packages/Gremlin.Net

Please ask your questions in our Google Group gremlin-users:
https://groups.google.com/forum/#!forum/gremlin-users

Robert Dale


On Tue, Nov 20, 2018 at 10:12 AM Stephen Mallette 
wrote:

> sure - just checking that i didn't miss something. it doesn't happen often.
> i just don't like answering questions there as it's a one-to-one sort of
> discussion that doesn't benefit anyone on the user list.
>
> On Tue, Nov 20, 2018 at 10:04 AM Florian Hockmann 
> wrote:
>
> > I'm afraid not (or at least I'm not aware of a way and a quick search
> > didn't return anything in that direction), but we could just respond
> with a
> > default answer ala
> >
> > "Thanks for reaching out to us, but we don't answer usage questions here
> > directly. Please ask your questions instead in our Google Group
> > gremlin-users: https://groups.google.com/forum/#!forum/gremlin-users;
> >
> > That would at least avoid the message ping-pong we currently sometimes
> > have.
> >
> > -Ursprüngliche Nachricht-
> > Von: Stephen Mallette 
> > Gesendet: Dienstag, 20. November 2018 15:39
> > An: dev@tinkerpop.apache.org
> > Betreff: Disable Nuget Question
> >
> > Is there a way to disable those questions we get from "Contact Owners" in
> > nuget? I looked around and didn't see anything. Would prefer if folks
> came
> > to the mailing list with their issues.
> >
> >
>


[jira] [Commented] (TINKERPOP-2098) gremlin-server.sh start does not seem to work as advertised

2018-11-22 Thread Robert Dale (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696206#comment-16696206
 ] 

Robert Dale commented on TINKERPOP-2098:


The options are in a somewhat common command-line help format.
{noformat}
{start|stop|restart|status|console|install   |}{noformat}
reads as:
 'start'
 or 'stop'
 or 'restart'
 or 'status'
 or 'console'
 or 'install' with required, placeholder parameters 'group', 'artifact', 
'version'
 or placeholder 'conf file'

Using this format, if having 'conf file' were an option for 'start', it would 
have displayed
{noformat}
{start [conf file] | stop | }
{noformat}
*What would you suggest to make it more clear?*

It would also be great if you could pinpoint places in the docs where it's 
confusing. I couldn't find any instances where 'start' and 'conf file' were 
intermixed or implied one could be used with the other.

The first mention of starting Gremlin Server shows correct usage.
 * [http://tinkerpop.apache.org/docs/current/reference/#starting-gremlin-server]

Configuring describes each parameter and how to configure the env vars.
 * [http://tinkerpop.apache.org/docs/current/reference/#_configuring_2]

Just reading through that with your requirements in mind. If I want to run in 
the background, then I must use 'start' since it 'Start[s] the server in the 
background'. I can't use parameter 'conf file' because it starts in the 
foreground. If I want to override the default 'conf/gremlin-server.yaml', then 
I must "set GREMLIN_YAML in bin/gemlin-server.conf".

*What would you suggest to make it more clear?*

> gremlin-server.sh start does not seem to work as advertised
> ---
>
> Key: TINKERPOP-2098
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2098
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.3.4
>Reporter: Kelvin R. Lawrence
>Priority: Minor
>
> This may be as simple as a documentation issue but the help text for Gremlin 
> server implies that I should be able to do:
> {code:java}
> gremlin-server.sh start conf/myyaml.yaml{code}
> However when I do that it does not seem to actually be reading my YAML file 
> or if it is it is not reading it fully as I am specifying the WsAndHttp 
> channelizer in the YAML and when the server starts the HTTP endpoint is not 
> available.
>  
> If I start the server in the terminal with
>  
> {code:java}
>  gremlin-server.sh  conf/myyaml.yaml{code}
>  
> all is fine but I want to start it in the background.
>  
> I spoke to [~pluradj] and he had me try using the environment variable to 
> specify the YAML file name and that worked with the *start* keyword.
>  
> Is *gremlin-server.sh start conf/myyaml.yam*l supposed to work?
>  
> If not it would be good to change the help text for gremlin-server.sh which 
> currently reads as follows:
>  
>  
> {code:java}
> Usage: bin/gremlin-server.sh {start|stop|restart|status|console|install 
>   |}{code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [tinkerpop] dkuppitz commented on pull request #997: TINKERPOP-2095 GroupStep looks for irrelevant barrier steps

2018-11-22 Thread GitHub
I wanted to make it package private, but unfortunately `GroupSideEffectStep` 
resides in a different package. I prefer having it public instead of 
duplicating the code in `GroupSideEffectStep`.

[ Full content available at: https://github.com/apache/tinkerpop/pull/997 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[GitHub] [tinkerpop] dkuppitz commented on pull request #997: TINKERPOP-2095 GroupStep looks for irrelevant barrier steps

2018-11-22 Thread GitHub
I wanted to make it package private, but unfortunately `GroupSideEffectStep` 
resides in a different package.

[ Full content available at: https://github.com/apache/tinkerpop/pull/997 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[jira] [Updated] (TINKERPOP-2098) gremlin-server.sh start does not seem to work as advertised

2018-11-22 Thread Kelvin R. Lawrence (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Kelvin R. Lawrence updated TINKERPOP-2098:
--
Description: 
This may be as simple as a documentation issue but the help text for Gremlin 
server implies that I should be able to do:
{code:java}
gremlin-server.sh start conf/myyaml.yaml{code}
However when I do that it does not seem to actually be reading my YAML file or 
if it is it is not reading it fully as I am specifying the WsAndHttp 
channelizer in the YAML and when the server starts the HTTP endpoint is not 
available.

 

If I start the server in the terminal with

 
{code:java}
 gremlin-server.sh  conf/myyaml.yaml{code}
 

all is fine but I want to start it in the background.

 

I spoke to [~pluradj] and he had me try using the environment variable to 
specify the YAML file name and that worked with the *start* keyword.

 

Is *gremlin-server.sh start conf/myyaml.yam*l supposed to work?

 

If not it would be good to change the help text for gremlin-server.sh which 
currently reads as follows:

 

 
{code:java}
Usage: bin/gremlin-server.sh {start|stop|restart|status|console|install  
 |}{code}
 

  was:
This may be as simple as a documentation issue but the help text for Gremlin 
server implies that I should be able to do:


{code:java}
gremlin-server.sh start conf/myyaml.yam{code}

However when I do that it does not seem to actually be reading my YAML file or 
if it is it is not reading it fully as I am specifying the WsAndHttp 
channelizer in the YAML and when the server starts the HTTP endpoint is not 
available.

 

If I start the server in the terminal with

 
{code:java}
 gremlin-server.sh  conf/myyaml.yaml{code}
 

all is fine but I want to start it in the background.

 

I spoke to [~pluradj] and he had me try using the environment variable to 
specify the YAML file name and that worked with the *start* keyword.

 

Is *gremlin-server.sh start conf/myyaml.yam*l supposed to work?

 

If not it would be good to change the help text for gremlin-server.sh which 
currently reads as follows:

 

 
{code:java}
Usage: bin/gremlin-server.sh {start|stop|restart|status|console|install  
 |}{code}
 


> gremlin-server.sh start does not seem to work as advertised
> ---
>
> Key: TINKERPOP-2098
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2098
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: server
>Affects Versions: 3.3.4
>Reporter: Kelvin R. Lawrence
>Priority: Minor
>
> This may be as simple as a documentation issue but the help text for Gremlin 
> server implies that I should be able to do:
> {code:java}
> gremlin-server.sh start conf/myyaml.yaml{code}
> However when I do that it does not seem to actually be reading my YAML file 
> or if it is it is not reading it fully as I am specifying the WsAndHttp 
> channelizer in the YAML and when the server starts the HTTP endpoint is not 
> available.
>  
> If I start the server in the terminal with
>  
> {code:java}
>  gremlin-server.sh  conf/myyaml.yaml{code}
>  
> all is fine but I want to start it in the background.
>  
> I spoke to [~pluradj] and he had me try using the environment variable to 
> specify the YAML file name and that worked with the *start* keyword.
>  
> Is *gremlin-server.sh start conf/myyaml.yam*l supposed to work?
>  
> If not it would be good to change the help text for gremlin-server.sh which 
> currently reads as follows:
>  
>  
> {code:java}
> Usage: bin/gremlin-server.sh {start|stop|restart|status|console|install 
>   |}{code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (TINKERPOP-2098) gremlin-server.sh start does not seem to work as advertised

2018-11-22 Thread Kelvin R. Lawrence (JIRA)
Kelvin R. Lawrence created TINKERPOP-2098:
-

 Summary: gremlin-server.sh start does not seem to work as 
advertised
 Key: TINKERPOP-2098
 URL: https://issues.apache.org/jira/browse/TINKERPOP-2098
 Project: TinkerPop
  Issue Type: Improvement
  Components: server
Affects Versions: 3.3.4
Reporter: Kelvin R. Lawrence


This may be as simple as a documentation issue but the help text for Gremlin 
server implies that I should be able to do:


{code:java}
gremlin-server.sh start conf/myyaml.yam{code}

However when I do that it does not seem to actually be reading my YAML file or 
if it is it is not reading it fully as I am specifying the WsAndHttp 
channelizer in the YAML and when the server starts the HTTP endpoint is not 
available.

 

If I start the server in the terminal with

 
{code:java}
 gremlin-server.sh  conf/myyaml.yaml{code}
 

all is fine but I want to start it in the background.

 

I spoke to [~pluradj] and he had me try using the environment variable to 
specify the YAML file name and that worked with the *start* keyword.

 

Is *gremlin-server.sh start conf/myyaml.yam*l supposed to work?

 

If not it would be good to change the help text for gremlin-server.sh which 
currently reads as follows:

 

 
{code:java}
Usage: bin/gremlin-server.sh {start|stop|restart|status|console|install  
 |}{code}
 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [tinkerpop] otaviojava commented on issue #1001: uses the directly field instead of getter method

2018-11-22 Thread GitHub
Ops, You're right. My mistake sorry for that.
I created a new test class, that looks 10% faster than original code.

```java
@Warmup(iterations = 5, time = 1, timeUnit = TimeUnit.SECONDS)
@Measurement(iterations = 20, time = 1, timeUnit = TimeUnit.SECONDS)
@Fork(3)
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.NANOSECONDS)
@State(Scope.Thread)
public class ClientBenchmark {


private final ObjectMapper mapper = 
GraphSONMapper.build().version(GraphSONVersion.V3_0).create().createMapper();
private final Graph graph = TinkerFactory.createModern();
private final Vertex vertex = graph.traversal().V().next();

@Setup
public void setup() {
}

@Benchmark
public String write() throws JsonProcessingException {
return mapper.writeValueAsString(vertex);
}


}
```

Original code:avgt   60  1938,602 ± 50,353  ns/op
The code changed: avgt   60  2144,034 ± 51,190  ns/op  (10% faster)


[ Full content available at: https://github.com/apache/tinkerpop/pull/1001 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[GitHub] [tinkerpop] spmallette commented on issue #1001: uses the directly field instead of getter method

2018-11-22 Thread GitHub
That's not encouraging. Why are you serializing `Optional` though? Why not just 
serialize the `Vertex`:

```text
Vertex vertex = graph.traversal().V().next();
```





[ Full content available at: https://github.com/apache/tinkerpop/pull/1001 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[GitHub] [tinkerpop] jorgebay commented on pull request #997: TINKERPOP-2095 GroupStep looks for irrelevant barrier steps

2018-11-22 Thread GitHub
Do we have to expose this method or can it be a package private method?

[ Full content available at: https://github.com/apache/tinkerpop/pull/997 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org