[jira] [Commented] (TINKERPOP-2119) Validate C# code samples in docs
[ https://issues.apache.org/jira/browse/TINKERPOP-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730963#comment-16730963 ] ASF GitHub Bot commented on TINKERPOP-2119: --- FlorianHockmann commented on pull request #1025: TINKERPOP-2119 Add C# code examples in doc as code URL: https://github.com/apache/tinkerpop/pull/1025 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Validate C# code samples in docs > > > Key: TINKERPOP-2119 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2119 > Project: TinkerPop > Issue Type: Improvement > Components: documentation, dotnet >Affects Versions: 3.4.0 >Reporter: Florian Hockmann >Assignee: Florian Hockmann >Priority: Major > Fix For: 3.4.0 > > > The docs now contain a lot of C# code samples (thanks for that, Stephen and > Daniel). Unfortunately, some of these samples don't use proper C# syntax and > therefore won't compile. > Since I have already noticed in the past that some listings don't work any > more with more recent versions of Gremlin.Net, we should not only correct > these listings, but actually validate them automatically to ensure that we > notice once the listings don't work any more. > I limited the scope to C# here because I already noticed problems there, but > this could of course also be done later for the other GLVs that can't be > verified with the usual doc generation process. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (TINKERPOP-2119) Validate C# code samples in docs
[ https://issues.apache.org/jira/browse/TINKERPOP-2119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Florian Hockmann closed TINKERPOP-2119. --- Resolution: Fixed > Validate C# code samples in docs > > > Key: TINKERPOP-2119 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2119 > Project: TinkerPop > Issue Type: Improvement > Components: documentation, dotnet >Affects Versions: 3.4.0 >Reporter: Florian Hockmann >Assignee: Florian Hockmann >Priority: Major > Fix For: 3.4.0 > > > The docs now contain a lot of C# code samples (thanks for that, Stephen and > Daniel). Unfortunately, some of these samples don't use proper C# syntax and > therefore won't compile. > Since I have already noticed in the past that some listings don't work any > more with more recent versions of Gremlin.Net, we should not only correct > these listings, but actually validate them automatically to ensure that we > notice once the listings don't work any more. > I limited the scope to C# here because I already noticed problems there, but > this could of course also be done later for the other GLVs that can't be > verified with the usual doc generation process. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [tinkerpop] FlorianHockmann commented on issue #1025: TINKERPOP-2119 Add C# code examples in doc as code
> Maybe we can fix the indents in the docs post-processor and keep the code > files clean... That would of course be great. I don't think that we need to include that however in this PR, especially since we want to release next week. So, I'm going to merge this now as is. [ Full content available at: https://github.com/apache/tinkerpop/pull/1025 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] FlorianHockmann closed pull request #1025: TINKERPOP-2119 Add C# code examples in doc as code
[ pull request closed by FlorianHockmann ] [ Full content available at: https://github.com/apache/tinkerpop/pull/1025 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[jira] [Closed] (TINKERPOP-2113) P.Within() doesn't work when given a List argument
[
https://issues.apache.org/jira/browse/TINKERPOP-2113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Florian Hockmann closed TINKERPOP-2113.
---
Resolution: Fixed
Fix Version/s: 3.3.5
3.4.0
> P.Within() doesn't work when given a List argument
> --
>
> Key: TINKERPOP-2113
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2113
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
>Affects Versions: 3.2.10
>Reporter: Florian Hockmann
>Assignee: Florian Hockmann
>Priority: Minor
> Fix For: 3.4.0, 3.3.5
>
>
> In short, this test fails with the modern graph:
> {code:c#}
> var names = new List {"josh", "vadas"};
> var count = g.V().Has("name", P.Within(names)).Count().Next();
> Assert.Equal(2, count);
> {code}
> but this works:
> {code:c#}
> var count = g.V().Has("name", P.Within("josh", "vadas")).Count().Next();
> Assert.Equal(2, count);;
> {code}
> for which we already have a test case.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [tinkerpop] FlorianHockmann closed pull request #1024: TINKERPOP-2113 Fix P.Within() for list arguments in Gremlin.NET
[ pull request closed by FlorianHockmann ] [ Full content available at: https://github.com/apache/tinkerpop/pull/1024 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[jira] [Commented] (TINKERPOP-2113) P.Within() doesn't work when given a List argument
[
https://issues.apache.org/jira/browse/TINKERPOP-2113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16730952#comment-16730952
]
ASF GitHub Bot commented on TINKERPOP-2113:
---
FlorianHockmann commented on pull request #1024: TINKERPOP-2113 Fix P.Within()
for list arguments in Gremlin.NET
URL: https://github.com/apache/tinkerpop/pull/1024
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> P.Within() doesn't work when given a List argument
> --
>
> Key: TINKERPOP-2113
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2113
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
>Affects Versions: 3.2.10
>Reporter: Florian Hockmann
>Assignee: Florian Hockmann
>Priority: Minor
>
> In short, this test fails with the modern graph:
> {code:c#}
> var names = new List {"josh", "vadas"};
> var count = g.V().Has("name", P.Within(names)).Count().Next();
> Assert.Equal(2, count);
> {code}
> but this works:
> {code:c#}
> var count = g.V().Has("name", P.Within("josh", "vadas")).Count().Next();
> Assert.Equal(2, count);;
> {code}
> for which we already have a test case.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
