[GitHub] [tinkerpop] jorgebay commented on issue #1055: TINKERPOP-2150 Support configuring the registry builder in config

2019-02-06 Thread GitHub
I've updated the docs and added an entry to the CHANGELOG.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1055 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[GitHub] [tinkerpop] jorgebay closed pull request #1054: TINKERPOP-2149 Add fallback resolver to TypeSerializerRegistry

2019-02-06 Thread GitHub
[ pull request closed by jorgebay ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/1054 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[jira] [Commented] (TINKERPOP-2149) GraphBinary: Make type serializer resolution pluggable

2019-02-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761614#comment-16761614
 ] 

ASF GitHub Bot commented on TINKERPOP-2149:
---

jorgebay commented on pull request #1054: TINKERPOP-2149 Add fallback resolver 
to TypeSerializerRegistry
URL: https://github.com/apache/tinkerpop/pull/1054
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GraphBinary: Make type serializer resolution pluggable
> --
>
> Key: TINKERPOP-2149
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2149
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: io
>Affects Versions: 3.4.0
>Reporter: Jorge Bay
>Assignee: Jorge Bay
>Priority: Major
> Fix For: 3.4.1
>
>
> We should support providing your own logic to resolve type serializers, some 
> sort of "catch all" logic for type serializer implementations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (TINKERPOP-2149) GraphBinary: Make type serializer resolution pluggable

2019-02-06 Thread Jorge Bay (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2149?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jorge Bay closed TINKERPOP-2149.

Resolution: Done

> GraphBinary: Make type serializer resolution pluggable
> --
>
> Key: TINKERPOP-2149
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2149
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: io
>Affects Versions: 3.4.0
>Reporter: Jorge Bay
>Assignee: Jorge Bay
>Priority: Major
> Fix For: 3.4.1
>
>
> We should support providing your own logic to resolve type serializers, some 
> sort of "catch all" logic for type serializer implementations.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (TINKERPOP-2152) Path toString fails in Gremlin JavaScript

2019-02-06 Thread Jorge Bay (JIRA)
Jorge Bay created TINKERPOP-2152:


 Summary: Path toString fails in Gremlin JavaScript
 Key: TINKERPOP-2152
 URL: https://issues.apache.org/jira/browse/TINKERPOP-2152
 Project: TinkerPop
  Issue Type: Bug
  Components: javascript
Affects Versions: 3.3.5, 3.4.0
Reporter: Jorge Bay
 Fix For: 3.3.6, 3.4.1






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [tinkerpop] jorgebay commented on issue #1056: fix: Path#toString() variable reference bug

2019-02-06 Thread GitHub
Thanks @thefliik , I've filed a ticket to keep track of this: 
https://issues.apache.org/jira/browse/TINKERPOP-2152

Can you target branch `tp33` for this to be applied to the 3.3 line?

[ Full content available at: https://github.com/apache/tinkerpop/pull/1056 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


Re: ATTN Committers/PMC Members: Bio Update

2019-02-06 Thread Jorge Bay Gondra
I've updated my bio to include GraphBinary in CTR fashion.

On Tue, Feb 5, 2019 at 10:55 AM Florian Hockmann 
wrote:

> My bio is also still up-to-date.
>
> Regards,
> Florian
>
> -Ursprüngliche Nachricht-
> Von: Robert Dale 
> Gesendet: Sonntag, 3. Februar 2019 03:50
> An: dev@tinkerpop.apache.org
> Betreff: Re: ATTN Committers/PMC Members: Bio Update
>
> No change. Thanks.
>
> Robert Dale
>
>
> On Fri, Feb 1, 2019 at 4:14 PM Daniel Kuppitz  wrote:
>
> > I think my bio is still pretty accurate, no changes needed.
> >
> > Cheers,
> > Daniel
> >
> >
> > On Fri, Feb 1, 2019, 1:29 PM Stephen Mallette 
> > wrote:
> >
> > > I was hoping that an email to the dev list would have dealt with
> > > most of this administrative issue, but I haven't seen any updates
> > > directly to git or in the form of replies as of yet. I will begin
> > > reaching out directly
> > to
> > > folks next week.
> > >
> > > On Fri, Jan 25, 2019 at 8:44 AM Stephen Mallette
> > > 
> > > wrote:
> > >
> > > > To Committers/PMC Members,
> > > >
> > > > As an Apache TinkerPop committer and/or PMC member, your name is
> > > > listed
> > > on
> > > > the TinkerPop home page in the Contributor List[1] with your
> > > > "bio". If
> > > you
> > > > are active on the project, your "bio" reflects what you have been
> > working
> > > > on and what you expect to be working on with respect to TinkerPop
> > > > for recent times (i.e. for the previous six months and the
> > > > following six months). If you are currently inactive on the project,
> your "bio"
> > > reflects
> > > > the full scope of all your contributions throughout your active
> > > periods.[2]
> > > >
> > > > Please take a moment to update your bio directly in Git[2] or, if
> > > > you would prefer, please reply to this email with your bio update
> > > > and it
> > will
> > > > be added for you. If no changes are required, please reply to this
> > email
> > > to
> > > > confirm that this is the case. Feel free to email me directly if
> > > > you
> > > like.
> > > >
> > > > I think most bios need a bit of a refresh. Jorge, you should
> > > > definitely add GraphBinary to yours. I think "Release Manager"
> > > > might be a good one
> > > for
> > > > folks to add in given my recent work on the Downloads page. Thanks
> > > everyone!
> > > >
> > > > [1] http://tinkerpop.apache.org/#contributors
> > > > [2]
> > > >
> > >
> > http://tinkerpop.apache.org/docs/current/dev/developer/#contributor-li
> > sting
> > > > [3]
> > > >
> > >
> > https://github.com/apache/tinkerpop/blob/master/docs/site/home/index.h
> > tml
> > > >
> > >
> >
>
>


[GitHub] [tinkerpop] dkuppitz commented on issue #1055: TINKERPOP-2150 Support configuring the registry builder in config

2019-02-06 Thread GitHub
VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/1055 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[GitHub] [tinkerpop] jorgebay closed pull request #1055: TINKERPOP-2150 Support configuring the registry builder in config

2019-02-06 Thread GitHub
[ pull request closed by jorgebay ]

[ Full content available at: https://github.com/apache/tinkerpop/pull/1055 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[jira] [Commented] (TINKERPOP-2150) GraphBinary: Support configuring the TypeSerializerRegistry builder class in config

2019-02-06 Thread ASF GitHub Bot (JIRA)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16761779#comment-16761779
 ] 

ASF GitHub Bot commented on TINKERPOP-2150:
---

jorgebay commented on pull request #1055: TINKERPOP-2150 Support configuring 
the registry builder in config
URL: https://github.com/apache/tinkerpop/pull/1055
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GraphBinary: Support configuring the TypeSerializerRegistry builder class in 
> config
> ---
>
> Key: TINKERPOP-2150
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2150
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: io
>Affects Versions: 3.4.0
>Reporter: Jorge Bay
>Assignee: Jorge Bay
>Priority: Major
> Fix For: 3.4.1
>
>
> We currently only support providing custom serializers via configuration.
> It would be nice to be able to provide the builder itself, that way providers 
> can point to a class where all custom and default types are set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (TINKERPOP-2150) GraphBinary: Support configuring the TypeSerializerRegistry builder class in config

2019-02-06 Thread Jorge Bay (JIRA)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2150?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jorge Bay closed TINKERPOP-2150.

Resolution: Done

> GraphBinary: Support configuring the TypeSerializerRegistry builder class in 
> config
> ---
>
> Key: TINKERPOP-2150
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2150
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: io
>Affects Versions: 3.4.0
>Reporter: Jorge Bay
>Assignee: Jorge Bay
>Priority: Major
> Fix For: 3.4.1
>
>
> We currently only support providing custom serializers via configuration.
> It would be nice to be able to provide the builder itself, that way providers 
> can point to a class where all custom and default types are set.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] [tinkerpop] thefliik commented on issue #1056: fix: Path#toString() variable reference bug

2019-02-06 Thread GitHub
@jorgebay in the `tp33` branch it looks like the Path#toString() method has 
been removed entirely, so when/if that branch is merged into master this PR 
will be unnecessary. Feel free to close.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1056 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[GitHub] [tinkerpop] spmallette commented on issue #1056: fix: Path#toString() variable reference bug

2019-02-06 Thread GitHub
`tp33` continually merges to `master` - wonder why `toString()` isn't present 
on that branch

[ Full content available at: https://github.com/apache/tinkerpop/pull/1056 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[GitHub] [tinkerpop] thefliik commented on issue #1056: fix: Path#toString() variable reference bug

2019-02-06 Thread GitHub
The code in question on `tp33`:

https://github.com/apache/tinkerpop/blob/tp33/gremlin-javascript/src/main/javascript/gremlin-javascript/lib/structure/graph.js#L118-L139

[ Full content available at: https://github.com/apache/tinkerpop/pull/1056 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org