[jira] [Updated] (TINKERPOP-2262) Improve Netty protocol handling

2019-10-22 Thread Robert Dale (Jira)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Dale updated TINKERPOP-2262:
---
Summary: Improve Netty protocol handling  (was: Upgrade to Netty 4.1.37)

> Improve Netty protocol handling
> ---
>
> Key: TINKERPOP-2262
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2262
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: driver, server
>Affects Versions: 3.3.7, 3.4.2
>Reporter: Divij Vaidya
>Priority: Major
>
> 4.1.37 adds [https://github.com/netty/netty/pull/9116] which is critical to 
> the stability of the Java Client.
> After the upgrade a follow-up task would :
> 1. change the Java Client to set the newly introduced flag  
> "closeOnProtocolViolation" to false. This would prevent causing all the other 
> requests using the same channel to fail when a single request causes a 
> protocol violation.
> 2. introduce the protocol exception error handling code on the client to 
> handle protocol violation exceptions. Currently, the code force replaces the 
> channel, thus closing all the other requests being served on the channel.[
> https://netty.io/news/2019/06/28/4-1-37-Final.html]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (TINKERPOP-2262) Improve Netty protocol handling

2019-10-22 Thread Robert Dale (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957469#comment-16957469
 ] 

Robert Dale commented on TINKERPOP-2262:


Updated to Netty 4.1.42 outside of this ticket.

> Improve Netty protocol handling
> ---
>
> Key: TINKERPOP-2262
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2262
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: driver, server
>Affects Versions: 3.3.7, 3.4.2
>Reporter: Divij Vaidya
>Priority: Major
>
> 4.1.37 adds [https://github.com/netty/netty/pull/9116] which is critical to 
> the stability of the Java Client.
> After the upgrade a follow-up task would :
> 1. change the Java Client to set the newly introduced flag  
> "closeOnProtocolViolation" to false. This would prevent causing all the other 
> requests using the same channel to fail when a single request causes a 
> protocol violation.
> 2. introduce the protocol exception error handling code on the client to 
> handle protocol violation exceptions. Currently, the code force replaces the 
> channel, thus closing all the other requests being served on the channel.[
> https://netty.io/news/2019/06/28/4-1-37-Final.html]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (TINKERPOP-2262) Improve Netty protocol handling

2019-10-22 Thread Robert Dale (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16957471#comment-16957471
 ] 

Robert Dale commented on TINKERPOP-2262:


TP 3.3 uses Netty 4.0.x.  Does the affects version still apply?  I don't think 
we would update 3.3 to use Netty 4.1.x otherwise we would have done that.

> Improve Netty protocol handling
> ---
>
> Key: TINKERPOP-2262
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2262
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: driver, server
>Affects Versions: 3.3.7, 3.4.2
>Reporter: Divij Vaidya
>Priority: Major
>
> 4.1.37 adds [https://github.com/netty/netty/pull/9116] which is critical to 
> the stability of the Java Client.
> After the upgrade a follow-up task would :
> 1. change the Java Client to set the newly introduced flag  
> "closeOnProtocolViolation" to false. This would prevent causing all the other 
> requests using the same channel to fail when a single request causes a 
> protocol violation.
> 2. introduce the protocol exception error handling code on the client to 
> handle protocol violation exceptions. Currently, the code force replaces the 
> channel, thus closing all the other requests being served on the channel.[
> https://netty.io/news/2019/06/28/4-1-37-Final.html]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


Re: [DISCUSS] code freeze 3.3.9/3.4.4

2019-10-22 Thread Robert Dale
An update on the python README issue, I fixed the typos in the codebase and
simply renamed the README to have .rst so that it becomes renderable for
preview on github -
https://github.com/apache/tinkerpop/tree/master/gremlin-python/src/main/jython

Just have to remember to preview it on github before deploy. ;-)

Robert Dale


On Sat, Oct 19, 2019 at 6:53 AM Robert Dale  wrote:

> Looks like these are immutable so an updated release would be required.
> Going forward, we can use markdown and render for review, even just through
> github, before publishing.
>
> https://packaging.python.org/guides/making-a-pypi-friendly-readme/
>
> Robert Dale
>
>
> On Fri, Oct 18, 2019 at 8:43 PM Stephen Mallette 
> wrote:
>
>> it's the README -  https://pypi.org/project/gremlinpython/
>>
>> looks like there's just an extra backtick in there where they shouldn't be
>> one:
>>
>>
>> https://github.com/apache/tinkerpop/blob/master/gremlin-python/src/main/jython/README
>>
>>
>> stupid RST format
>>
>> On Fri, Oct 18, 2019 at 7:31 PM Robert Dale  wrote:
>>
>> > Can you provide the link to the page with the broken link?
>> >
>> > On Fri, Oct 18, 2019, 7:04 PM Stephen Mallette 
>> > wrote:
>> >
>> > > Just noticed that there's a broken link in the description for pypi -
>> > bah.
>> > > Not sure that this can be fixed outside of another deployment. So, I
>> > guess
>> > > it will look stupid for a while, unless someone knows how to deal with
>> > it.
>> > > I've already pushed a fix to github.
>> > >
>> > > I've updated the release branches to SNAPSHOT and they are now re-open
>> > for
>> > > business.
>> > >
>> > > I'll update the website and do release announcements on monday but
>> > artifact
>> > > deployments are already done.
>> > >
>> > >
>> > >
>> > > On Thu, Oct 10, 2019 at 8:27 AM Stephen Mallette <
>> spmalle...@gmail.com>
>> > > wrote:
>> > >
>> > > > Sorry, I sent that last post a bit too soon. I've published the last
>> > cut
>> > > > of the SNAPSHOT docs - please review so we can get any fixes in
>> prior
>> > to
>> > > > finding a mess after release:
>> > > >
>> > > > http://tinkerpop.apache.org/docs/3.3.9-SNAPSHOT/
>> > > > http://tinkerpop.apache.org/docs/3.4.4-SNAPSHOT/
>> > > >
>> > > > Thanks!
>> > > >
>> > > > On Thu, Oct 10, 2019 at 8:09 AM Stephen Mallette <
>> spmalle...@gmail.com
>> > >
>> > > > wrote:
>> > > >
>> > > >> I think I"m going to be reverting most of this change:
>> > > >>
>> > > >>
>> > > >>
>> > >
>> >
>> https://github.com/apache/tinkerpop/commit/aa955d56485483cb5b1901fd82783d5cdf969c7c#diff-402e09222db9327564f28924e1b39d0c
>> > > >>
>> > > >>
>> > > >> We'll keep the update to our shaded version of Jackson, but I'm
>> > finding
>> > > >> that the remaining changes caused problems with Spark. Robert Dale
>> has
>> > > >> already been of a mind that we not tackle CVEs this way anymore
>> and I
>> > > agree
>> > > >> with him at this point. We shouldn't be managing the CVE problems
>> of
>> > > >> upstream dependencies. If we need a CVE to go away then we need to
>> > take
>> > > the
>> > > >> problem to the originating project rather than try to deal with it
>> by
>> > > way
>> > > >> of exclusion.
>> > > >>
>> > > >> On Mon, Oct 7, 2019 at 8:36 AM Stephen Mallette <
>> spmalle...@gmail.com
>> > >
>> > > >> wrote:
>> > > >>
>> > > >>> I'm a bit late on the code freeze post, but here it is now - it
>> > > >>> technically started at the end of the day on Friday. For once we
>> > don't
>> > > have
>> > > >>> a glut of pull requests to merge so that's nice. Please use this
>> > > thread for
>> > > >>> release related issues as we look to get another one of these
>> > releases
>> > > out
>> > > >>> the door.
>> > > >>>
>> > > >>> Also for committers and/or PMC members, your name is listed on the
>> > > >>> TinkerPop home page in the Contributor List[1] with your "bio". If
>> > you
>> > > are
>> > > >>> active on the project, your "bio" reflects what you have been
>> working
>> > > on
>> > > >>> and what you expect to be working on with respect to TinkerPop for
>> > > recent
>> > > >>> times (i.e. for the previous six months and the following six
>> > months).
>> > > If
>> > > >>> you are currently inactive on the project, your "bio" reflects the
>> > full
>> > > >>> scope of all your contributions throughout your active periods.
>> You
>> > can
>> > > >>> refer to the contributor listing policy[2] for full details.
>> > > >>>
>> > > >>> Please take a moment to update your bio directly in Git[3] or, if
>> you
>> > > >>> would prefer, please reply to this post with your bio update and
>> it
>> > > will be
>> > > >>> added for you.
>> > > >>>
>> > > >>> [1] http://tinkerpop.apache.org/#contributors
>> > > >>> [2]
>> > > >>>
>> > >
>> >
>> http://tinkerpop.apache.org/docs/current/dev/developer/#contributor-listing
>> > > >>> [3]
>> > > >>>
>> > >
>> >
>> https://github.com/apache/tinkerpop/blob/master/docs/site/home/index.html
>> > > >>>
>> > > >>
>> > >
>> >
>>
>