Best practices Gremlin client connection pool c#

2019-11-26 Thread sabarish v
Hi all, with relevant to the below JIRA, 
https://issues.apache.org/jira/browse/TINKERPOP-2316
I would like to whats the issue in the latest driver 3.4.4 with cosmos db? Then 
how to find the matched driver version of the server? 


Re: Best practices Gremlin client connection pool c#

2019-11-26 Thread Stephen Mallette
This is the issue:

https://github.com/apache/tinkerpop/pull/1213

I would probably use 3.4.3, until 3.4.5 is released in the next month or so.

On Tue, Nov 26, 2019 at 6:29 AM sabarish v  wrote:

> Hi all, with relevant to the below JIRA,
> https://issues.apache.org/jira/browse/TINKERPOP-2316
> I would like to whats the issue in the latest driver 3.4.4 with cosmos db?
> Then how to find the matched driver version of the server?
>


[GitHub] [tinkerpop] spmallette commented on issue #1222: TINKERPOP-1733 Support g.E().properties().hasKey('xx') & hasValue('xx')

2019-11-26 Thread GitHub
looks like you've created a new PR at #1224 against `tp34`. closing this one 
and we can continue conversation over there. @dkuppitz we'll look for your 
comment over there.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1222 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[jira] [Commented] (TINKERPOP-1733) hasKey, hasValues should work on Element and Property

2019-11-26 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-1733?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982387#comment-16982387
 ] 

ASF GitHub Bot commented on TINKERPOP-1733:
---

spmallette commented on pull request #1222: TINKERPOP-1733 Support 
g.E().properties().hasKey('xx') & hasValue('xx')
URL: https://github.com/apache/tinkerpop/pull/1222
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> hasKey, hasValues should work on Element and Property
> -
>
> Key: TINKERPOP-1733
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1733
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.2.5
>Reporter: Robert Dale
>Priority: Major
>
> See thread 
> [https://lists.apache.org/thread.html/96b30fa453e3724ac77bc685d35116e6ccffd8cebf508ed74481dc91@%3Cdev.tinkerpop.apache.org%3E]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [tinkerpop] spmallette commented on pull request #1224: TINKERPOP-1733 Support g.E().properties().hasKey('xx') & hasValue('xx')

2019-11-26 Thread GitHub
This is a bit worrisome. Does this mean that if a user accesses an edge 
identifier in OLAP they won't get back their edge id, they will instead get a 
`StarEdgeId`?

[ Full content available at: https://github.com/apache/tinkerpop/pull/1224 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[jira] [Closed] (TINKERPOP-2314) Employ by(String) for Map when possible and improve errors around incorrect types

2019-11-26 Thread Stephen Mallette (Jira)


 [ 
https://issues.apache.org/jira/browse/TINKERPOP-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stephen Mallette closed TINKERPOP-2314.
---
Fix Version/s: 3.4.5
   3.5.0
   Resolution: Done

> Employ by(String) for Map when possible and improve errors around incorrect 
> types
> -
>
> Key: TINKERPOP-2314
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2314
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.3.9
>Reporter: Stephen Mallette
>Assignee: Stephen Mallette
>Priority: Major
> Fix For: 3.5.0, 3.4.5
>
>
> This bit of Gremlin demonstrates both problems for uses of {{by(String)}}:
> {code}
> gremlin> g.V().valueMap().project('x').by('name')
> java.util.LinkedHashMap cannot be cast to 
> org.apache.tinkerpop.gremlin.structure.Element
> Type ':help' or ':h' for help.
> Display stack trace? [yN]n
> {code}
> First, users typically expect this to work because they figure they are just 
> grabbing a keys value from a {{Map}} and then get the difficult to understand 
> message which doesn't tell you how to resolve. As a side note, the way to 
> resolve is with:
> {code}
> gremlin> g.V().valueMap().project('x').by(select('name'))
> ==>[x:[marko]]
> ==>[x:[stephen]]
> ==>[x:[matthias]]
> ==>[x:[daniel]]
> ==>[x:[gremlin]]
> ==>[x:[tinkergraph]]
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (TINKERPOP-2314) Employ by(String) for Map when possible and improve errors around incorrect types

2019-11-26 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/TINKERPOP-2314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16982406#comment-16982406
 ] 

ASF GitHub Bot commented on TINKERPOP-2314:
---

spmallette commented on pull request #1223: TINKERPOP-2314 Employ by(String) 
for Map when possible
URL: https://github.com/apache/tinkerpop/pull/1223
 
 
   
 

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Employ by(String) for Map when possible and improve errors around incorrect 
> types
> -
>
> Key: TINKERPOP-2314
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2314
> Project: TinkerPop
>  Issue Type: Improvement
>  Components: process
>Affects Versions: 3.3.9
>Reporter: Stephen Mallette
>Assignee: Stephen Mallette
>Priority: Major
>
> This bit of Gremlin demonstrates both problems for uses of {{by(String)}}:
> {code}
> gremlin> g.V().valueMap().project('x').by('name')
> java.util.LinkedHashMap cannot be cast to 
> org.apache.tinkerpop.gremlin.structure.Element
> Type ':help' or ':h' for help.
> Display stack trace? [yN]n
> {code}
> First, users typically expect this to work because they figure they are just 
> grabbing a keys value from a {{Map}} and then get the difficult to understand 
> message which doesn't tell you how to resolve. As a side note, the way to 
> resolve is with:
> {code}
> gremlin> g.V().valueMap().project('x').by(select('name'))
> ==>[x:[marko]]
> ==>[x:[stephen]]
> ==>[x:[matthias]]
> ==>[x:[daniel]]
> ==>[x:[gremlin]]
> ==>[x:[tinkergraph]]
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[GitHub] [tinkerpop] javeme commented on issue #1224: TINKERPOP-1733 Support g.E().properties().hasKey('xx') & hasValue('xx')

2019-11-26 Thread GitHub
> what's an example of the "same edges with two directions"?

Such as there are two vertices: `person1` and `person2`, one edge with id 
"follow_1_2" linked from `person1` to `person2`, it can be expressed like this: 
`person1 -- follow -> person2`.
When querying edges from vertex `person1` by `g.V(person1).outE()`, got an edge 
with OUT direction:
  `person1 -- follow -> person2`
and querying edges from vertex `person2` by `g.V(person2).inE()`, got an edge 
with IN direction:
  `person2 <- follow -- person1`. 
These two edges are essentially one edge, so it makes sense their comparison 
should be equal, but it's not equal for StarOutEdge and StarInEdge, no such 
issue for TinkerEdge.

There seem to be 2 ways to fix OUT & IN StarEdge comparison:

1. Override edge id of StarEdge, like [add StarEdgeId 
class](https://github.com/apache/tinkerpop/pull/1224/commits/8f604df919bdb9452068eb7ea41273e7aee5b2a7).
 (but there are still some problems: not registered kryo)
  ```c
org.apache.tinkerpop.gremlin.driver.exception.ResponseException: Error during 
serialization: java.lang.IllegalArgumentException: Class is not registered: 
org.apache.tinkerpop.gremlin.structure.util.star.StarGraph$StarEdgeId
Note: To register this class use: 
kryo.register(org.apache.tinkerpop.gremlin.structure.util.star.StarGraph$StarEdgeId.class);
at 
org.apache.tinkerpop.gremlin.server.GremlinResultSetIntegrateTest.shouldHandleTinkerGraphResult(GremlinResultSetIntegrateTest.java:207)
Caused by: org.apache.tinkerpop.gremlin.driver.exception.ResponseException: 
Error during serialization: java.lang.IllegalArgumentException: Class is not 
registered: 
org.apache.tinkerpop.gremlin.structure.util.star.StarGraph$StarEdgeId
Note: To register this class use: 
kryo.register(org.apache.tinkerpop.gremlin.structure.util.star.StarGraph$StarEdgeId.class);
```
2. Override StarEdge equals()

Which way is better, or any other ideas?

[ Full content available at: https://github.com/apache/tinkerpop/pull/1224 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


Re: Best practices Gremlin client connection pool c#

2019-11-26 Thread sabarish v
I just curious this issue is affected in 3.4.3 and fix is applied on 3.4.4, 
that is how https://issues.apache.org/jira/browse/TINKERPOP-2289 it is 
mentioned. If you don't mind could you please clarify it? 

On 2019/11/26 11:30:30, Stephen Mallette  wrote: 
> This is the issue:
> 
> https://github.com/apache/tinkerpop/pull/1213
> 
> I would probably use 3.4.3, until 3.4.5 is released in the next month or so.
> 
> On Tue, Nov 26, 2019 at 6:29 AM sabarish v  wrote:
> 
> > Hi all, with relevant to the below JIRA,
> > https://issues.apache.org/jira/browse/TINKERPOP-2316
> > I would like to whats the issue in the latest driver 3.4.4 with cosmos db?
> > Then how to find the matched driver version of the server?
> >
> 


Re: Best practices Gremlin client connection pool c#

2019-11-26 Thread Stephen Mallette
that issue might have been "fixed" in 3.4.4 but it created connection
problems for CosmosDB. if you read the referenced dev list post it explains
the "revert" of the "fix" and how things will proceed going forward:

https://lists.apache.org/thread.html/5a606bb428941faaac5c41c4df1526351406ec1ca90574dc9ced7fcd@%3Cdev.tinkerpop.apache.org%3E


in short, we will not support the functionality of TINKERPOP -2289 so there
is nothing to "fix". If you are using CosmosDB then you should use 3.4.3
until 3.4.5 releases (or use the 3.4.5-SNAPSHOT. Skip 3.4.4.

On Tue, Nov 26, 2019 at 10:39 AM sabarish v  wrote:

> I just curious this issue is affected in 3.4.3 and fix is applied on
> 3.4.4, that is how https://issues.apache.org/jira/browse/TINKERPOP-2289
> it is mentioned. If you don't mind could you please clarify it?
>
> On 2019/11/26 11:30:30, Stephen Mallette  wrote:
> > This is the issue:
> >
> > https://github.com/apache/tinkerpop/pull/1213
> >
> > I would probably use 3.4.3, until 3.4.5 is released in the next month or
> so.
> >
> > On Tue, Nov 26, 2019 at 6:29 AM sabarish v 
> wrote:
> >
> > > Hi all, with relevant to the below JIRA,
> > > https://issues.apache.org/jira/browse/TINKERPOP-2316
> > > I would like to whats the issue in the latest driver 3.4.4 with cosmos
> db?
> > > Then how to find the matched driver version of the server?
> > >
> >
>