Re: [VOTE] Accepting the gremlint donation
VOTE +1 On Thu, Feb 18, 2021 at 5:52 AM Divij Vaidya wrote: > Vote +1 > > On Thu, Feb 18, 2021 at 2:23 AM Stephen Mallette > wrote: > > > This vote is mostly a formality at this point as we had consensus[1][2] > > months ago on accepting the gremlint donation from Øyvind Sæbø and > Arqdoc. > > The Incubator IP Clearance form has been completed and can be found here > > and I will add a link to this thread to it once we are done: > > > > https://incubator.apache.org/ip-clearance/tinkerpop-gremlint.html > > > > This VOTE is open for the next 72 hours closing February 20, 2021 9:00pm > > ET. > > > > My VOTE is +1 > > > > [1] > > > > > https://lists.apache.org/thread.html/r5bc915ec5281b3678a62e0be91cb26e7089d8a23252b7a5efcac5023%40%3Cdev.tinkerpop.apache.org%3E > > [2] > > > > > https://lists.apache.org/thread.html/raaefce2315ce7c32a288faa0657a39819481dc0aff632bdabe0b9b71%40%3Cdev.tinkerpop.apache.org%3E > > > -- > Divij Vaidya >
AW: [VOTE] Accepting the gremlint donation
VOTE +1 -Ursprüngliche Nachricht- Von: Divij Vaidya Gesendet: Donnerstag, 18. Februar 2021 05:52 An: dev@tinkerpop.apache.org Betreff: Re: [VOTE] Accepting the gremlint donation Vote +1 On Thu, Feb 18, 2021 at 2:23 AM Stephen Mallette wrote: > This vote is mostly a formality at this point as we had > consensus[1][2] months ago on accepting the gremlint donation from Øyvind > Sæbø and Arqdoc. > The Incubator IP Clearance form has been completed and can be found > here and I will add a link to this thread to it once we are done: > > https://incubator.apache.org/ip-clearance/tinkerpop-gremlint.html > > This VOTE is open for the next 72 hours closing February 20, 2021 > 9:00pm ET. > > My VOTE is +1 > > [1] > > https://lists.apache.org/thread.html/r5bc915ec5281b3678a62e0be91cb26e7 > 089d8a23252b7a5efcac5023%40%3Cdev.tinkerpop.apache.org%3E > [2] > > https://lists.apache.org/thread.html/raaefce2315ce7c32a288faa0657a3981 > 9481dc0aff632bdabe0b9b71%40%3Cdev.tinkerpop.apache.org%3E > -- Divij Vaidya
Re: [VOTE] Accepting the gremlint donation
Been following this since I would eventually like to get gremlinbin back on its feet. Vote +1 On Thu 18 Feb 2021 at 06:58, wrote: > VOTE +1 > > -Ursprüngliche Nachricht- > Von: Divij Vaidya > Gesendet: Donnerstag, 18. Februar 2021 05:52 > An: dev@tinkerpop.apache.org > Betreff: Re: [VOTE] Accepting the gremlint donation > > Vote +1 > > On Thu, Feb 18, 2021 at 2:23 AM Stephen Mallette > wrote: > > > This vote is mostly a formality at this point as we had > > consensus[1][2] months ago on accepting the gremlint donation from > Øyvind Sæbø and Arqdoc. > > The Incubator IP Clearance form has been completed and can be found > > here and I will add a link to this thread to it once we are done: > > > > https://incubator.apache.org/ip-clearance/tinkerpop-gremlint.html > > > > This VOTE is open for the next 72 hours closing February 20, 2021 > > 9:00pm ET. > > > > My VOTE is +1 > > > > [1] > > > > https://lists.apache.org/thread.html/r5bc915ec5281b3678a62e0be91cb26e7 > > 089d8a23252b7a5efcac5023%40%3Cdev.tinkerpop.apache.org%3E > > [2] > > > > https://lists.apache.org/thread.html/raaefce2315ce7c32a288faa0657a3981 > > 9481dc0aff632bdabe0b9b71%40%3Cdev.tinkerpop.apache.org%3E > > > -- > Divij Vaidya > >
Re: [VOTE] Accepting the gremlint donation
whoa! Dylan Millikin! nice to see you back on the list. On Thu, Feb 18, 2021 at 8:44 AM Dylan Millikin wrote: > Been following this since I would eventually like to get gremlinbin back on > its feet. Vote +1 > > On Thu 18 Feb 2021 at 06:58, wrote: > > > VOTE +1 > > > > -Ursprüngliche Nachricht- > > Von: Divij Vaidya > > Gesendet: Donnerstag, 18. Februar 2021 05:52 > > An: dev@tinkerpop.apache.org > > Betreff: Re: [VOTE] Accepting the gremlint donation > > > > Vote +1 > > > > On Thu, Feb 18, 2021 at 2:23 AM Stephen Mallette > > wrote: > > > > > This vote is mostly a formality at this point as we had > > > consensus[1][2] months ago on accepting the gremlint donation from > > Øyvind Sæbø and Arqdoc. > > > The Incubator IP Clearance form has been completed and can be found > > > here and I will add a link to this thread to it once we are done: > > > > > > https://incubator.apache.org/ip-clearance/tinkerpop-gremlint.html > > > > > > This VOTE is open for the next 72 hours closing February 20, 2021 > > > 9:00pm ET. > > > > > > My VOTE is +1 > > > > > > [1] > > > > > > https://lists.apache.org/thread.html/r5bc915ec5281b3678a62e0be91cb26e7 > > > 089d8a23252b7a5efcac5023%40%3Cdev.tinkerpop.apache.org%3E > > > [2] > > > > > > https://lists.apache.org/thread.html/raaefce2315ce7c32a288faa0657a3981 > > > 9481dc0aff632bdabe0b9b71%40%3Cdev.tinkerpop.apache.org%3E > > > > > -- > > Divij Vaidya > > > > >
Re: [VOTE] Accepting the gremlint donation
VOTE +1 Kelvin Kelvin R. Lawrence On Thursday, February 18, 2021, 08:17:41 AM CST, Stephen Mallette wrote: whoa! Dylan Millikin! nice to see you back on the list. On Thu, Feb 18, 2021 at 8:44 AM Dylan Millikin wrote: > Been following this since I would eventually like to get gremlinbin back on > its feet. Vote +1 > > On Thu 18 Feb 2021 at 06:58, wrote: > > > VOTE +1 > > > > -Ursprüngliche Nachricht- > > Von: Divij Vaidya > > Gesendet: Donnerstag, 18. Februar 2021 05:52 > > An: dev@tinkerpop.apache.org > > Betreff: Re: [VOTE] Accepting the gremlint donation > > > > Vote +1 > > > > On Thu, Feb 18, 2021 at 2:23 AM Stephen Mallette > > wrote: > > > > > This vote is mostly a formality at this point as we had > > > consensus[1][2] months ago on accepting the gremlint donation from > > Øyvind Sæbø and Arqdoc. > > > The Incubator IP Clearance form has been completed and can be found > > > here and I will add a link to this thread to it once we are done: > > > > > > https://incubator.apache.org/ip-clearance/tinkerpop-gremlint.html > > > > > > This VOTE is open for the next 72 hours closing February 20, 2021 > > > 9:00pm ET. > > > > > > My VOTE is +1 > > > > > > [1] > > > > > > https://lists.apache.org/thread.html/r5bc915ec5281b3678a62e0be91cb26e7 > > > 089d8a23252b7a5efcac5023%40%3Cdev.tinkerpop.apache.org%3E > > > [2] > > > > > > https://lists.apache.org/thread.html/raaefce2315ce7c32a288faa0657a3981 > > > 9481dc0aff632bdabe0b9b71%40%3Cdev.tinkerpop.apache.org%3E > > > > > -- > > Divij Vaidya > > > > >
[jira] [Commented] (TINKERPOP-2514) Java client driver requests with same request ids hang
[
https://issues.apache.org/jira/browse/TINKERPOP-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17286706#comment-17286706
]
ASF GitHub Bot commented on TINKERPOP-2514:
---
spmallette opened a new pull request #1391:
URL: https://github.com/apache/tinkerpop/pull/1391
https://issues.apache.org/jira/browse/TINKERPOP-2514
The driver throws an error if the same request id is already pending in the
queue which is the solution suggested on the ticket. I think that largely
solves this specific problem. I suppose there might be ways to still to trick
out the server but I wonder if we need to try to account for that as this
doesn't seem like a normal operating condition. Perhaps this is a good enough
fix.
All tests pass with `mvn clean install && mvn verify -pl gremlin-server
-DskipIntegrationTests=false`
VOTE +1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Java client driver requests with same request ids hang
> --
>
> Key: TINKERPOP-2514
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2514
> Project: TinkerPop
> Issue Type: Bug
> Components: driver
>Affects Versions: 3.4.10
>Reporter: Saikiran Boga
>Priority: Major
>
> Reproducer:
>
> {code:java}
> // submit query1
> Future query1_result = client.submitAsync(,
> RequestOptions.build().overrideRequestId(UNIQUE_UUID_1).create());
> // Add buffer wait to ensure server gets time to start query1 and submit
> query2
> Thread.sleep(100);
> try {
> ResultSet query2_resultSet = this.client.submit(,
> RequestOptions.build().overrideRequestId(UNIQUE_UUID_1).create());
> query2_resultSet.all().get();
> } catch(Exception ex) {
> // ignore
> }
> // This never completes as the ResultSet tracked by driver at connection is
> // overridden when we submit the second query with same request id.
> // The ResultSet of the first query is orphaned and not updated, leaving the
> get() // to wait forever.
> query1_result.get();
> {code}
>
> I think the driver should reject the query when submitting the same request
> to prevent this from happening.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (TINKERPOP-2514) Java client driver requests with same request ids hang
[
https://issues.apache.org/jira/browse/TINKERPOP-2514?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Stephen Mallette reassigned TINKERPOP-2514:
---
Assignee: Stephen Mallette
> Java client driver requests with same request ids hang
> --
>
> Key: TINKERPOP-2514
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2514
> Project: TinkerPop
> Issue Type: Bug
> Components: driver
>Affects Versions: 3.4.10
>Reporter: Saikiran Boga
>Assignee: Stephen Mallette
>Priority: Major
>
> Reproducer:
>
> {code:java}
> // submit query1
> Future query1_result = client.submitAsync(,
> RequestOptions.build().overrideRequestId(UNIQUE_UUID_1).create());
> // Add buffer wait to ensure server gets time to start query1 and submit
> query2
> Thread.sleep(100);
> try {
> ResultSet query2_resultSet = this.client.submit(,
> RequestOptions.build().overrideRequestId(UNIQUE_UUID_1).create());
> query2_resultSet.all().get();
> } catch(Exception ex) {
> // ignore
> }
> // This never completes as the ResultSet tracked by driver at connection is
> // overridden when we submit the second query with same request id.
> // The ResultSet of the first query is orphaned and not updated, leaving the
> get() // to wait forever.
> query1_result.get();
> {code}
>
> I think the driver should reject the query when submitting the same request
> to prevent this from happening.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
Re: [VOTE] Accepting the gremlint donation
Vote +1 On Thu, Feb 18, 2021 at 7:42 AM Kelvin Lawrence wrote: > VOTE +1 > Kelvin > Kelvin R. Lawrence > > On Thursday, February 18, 2021, 08:17:41 AM CST, Stephen Mallette < > spmalle...@gmail.com> wrote: > > whoa! Dylan Millikin! nice to see you back on the list. > > On Thu, Feb 18, 2021 at 8:44 AM Dylan Millikin > wrote: > > > Been following this since I would eventually like to get gremlinbin back > on > > its feet. Vote +1 > > > > On Thu 18 Feb 2021 at 06:58, wrote: > > > > > VOTE +1 > > > > > > -Ursprüngliche Nachricht- > > > Von: Divij Vaidya > > > Gesendet: Donnerstag, 18. Februar 2021 05:52 > > > An: dev@tinkerpop.apache.org > > > Betreff: Re: [VOTE] Accepting the gremlint donation > > > > > > Vote +1 > > > > > > On Thu, Feb 18, 2021 at 2:23 AM Stephen Mallette > > > > wrote: > > > > > > > This vote is mostly a formality at this point as we had > > > > consensus[1][2] months ago on accepting the gremlint donation from > > > Øyvind Sæbø and Arqdoc. > > > > The Incubator IP Clearance form has been completed and can be found > > > > here and I will add a link to this thread to it once we are done: > > > > > > > > https://incubator.apache.org/ip-clearance/tinkerpop-gremlint.html > > > > > > > > This VOTE is open for the next 72 hours closing February 20, 2021 > > > > 9:00pm ET. > > > > > > > > My VOTE is +1 > > > > > > > > [1] > > > > > > > > > https://lists.apache.org/thread.html/r5bc915ec5281b3678a62e0be91cb26e7 > > > > 089d8a23252b7a5efcac5023%40%3Cdev.tinkerpop.apache.org%3E > > > > [2] > > > > > > > > > https://lists.apache.org/thread.html/raaefce2315ce7c32a288faa0657a3981 > > > > 9481dc0aff632bdabe0b9b71%40%3Cdev.tinkerpop.apache.org%3E > > > > > > > -- > > > Divij Vaidya > > > > > > > > >
Re: [DISCUSS] Request Retries
I think this would be a great way to allow customers to easily know if an error was transient and able to be retried or not. Dave On Wed, Feb 17, 2021 at 4:06 AM Stephen Mallette wrote: > I created this issue recently: > > https://issues.apache.org/jira/browse/TINKERPOP-2517 > > which discusses adding a new response status code that would let users know > when it is a good idea to consider a retry of a request. Graph providers > could use this code to provide a hint when an error is likely resolvable > with time. Usually, such errors are related to locking on transactions or > some similar sort of issue. Currently users need to parse error messages to > determine when best to retry their requests which isn't so nice. > > To make this new code easy to use for providers we could provide a specific > TemporaryException that could be thrown/extended or i suppose a heavier > approach would be to offer some kind of exception mapping that providers > could supply to take their custom exceptions and convert them to this form. > Not sure which we would do, but the main point would be to provide the code > itself in the protocol itself so that drivers can begin to pick it up. > > I think we could add "SERVER_ERROR_TEMPORARY 596" for this purpose. I'd > imagine it would be safe to even add it to 3.4.11. Thoughts? >
