[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715217#comment-17715217 ] ASF GitHub Bot commented on TINKERPOP-2852: --- lyndonbauto commented on PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#issuecomment-1518478482 @Cole-Greer Sweet, that's really cool mean. VOTE+1 > Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (TINKERPOP-2926) Gremlin-Java > An UnsupportedOperationException occurs on calling next() after a merge step with the option step modulator if the element does not exist
[
https://issues.apache.org/jira/browse/TINKERPOP-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Valentyn Kahamlyk updated TINKERPOP-2926:
-
Fix Version/s: 3.7.0
3.6.3
> Gremlin-Java > An UnsupportedOperationException occurs on calling next()
> after a merge step with the option step modulator if the element does not
> exist
>
>
> Key: TINKERPOP-2926
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2926
> Project: TinkerPop
> Issue Type: Bug
> Components: driver
>Affects Versions: 3.6.2
>Reporter: Andrew Kirk
>Assignee: Valentyn Kahamlyk
>Priority: Blocker
> Fix For: 3.7.0, 3.6.3
>
> Attachments: MergeTestApp.java
>
>
> Using Gremlin-Java, when the option step modulator is used in combination
> with a merge step, an `UnsupportedOperationException` is thrown upon calling
> `next()` if the specified element does not already exist.
> Using an example from the docs, the following construct works fine in the
> console if the element does not already exist:
> {code:groovy}
> gremlin> g.mergeV([(T.id):300]).
> option(Merge.onCreate,[(T.label):'Dog', name:'Toby', age:10]).
> option(Merge.onMatch,[age:11])
> {code}
> But, if we try to do the same thing in Java, we'll get an exception:
> {code:java}
> g.mergeV(Map.of(T.id, 300))
> .option(
> Merge.onCreate,
> Map.of(
> T.label, "Dog",
> "name", "Toby",
> "age", 10
> )
> )
> .option(
> Merge.onMatch,
> Map.of("age", 11)
> )
> .next();
> {code}
> Exception:
> {noformat}
> Exception in thread "main" java.lang.UnsupportedOperationException
> at
> java.base/java.util.ImmutableCollections.uoe(ImmutableCollections.java:142)
> at
> java.base/java.util.ImmutableCollections$AbstractImmutableMap.putAll(ImmutableCollections.java:1073)
> at
> org.apache.tinkerpop.gremlin.process.traversal.step.map.MergeVertexStep.onCreateMap(MergeVertexStep.java:205)
> at
> org.apache.tinkerpop.gremlin.process.traversal.step.map.MergeVertexStep.flatMap(MergeVertexStep.java:168)
> at
> org.apache.tinkerpop.gremlin.process.traversal.step.map.FlatMapStep.processNextStart(FlatMapStep.java:49)
> at
> org.apache.tinkerpop.gremlin.process.traversal.step.map.MergeStep.processNextStart(MergeStep.java:165)
> at
> org.apache.tinkerpop.gremlin.process.traversal.step.util.AbstractStep.next(AbstractStep.java:135)
> at
> org.apache.tinkerpop.gremlin.process.traversal.step.util.AbstractStep.next(AbstractStep.java:40)
> at
> org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversal.next(DefaultTraversal.java:249)
> at
> io.integralla.tinkerpop.poc.MergeWithOption.main(MergeWithOption.java:44)
> {noformat}
> If the element is first added (via an add or merge step), the merge with
> option works as expected.
> A full example is provided in the attached MergeTestApp.java
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (TINKERPOP-2890) Avoid exceptions on local scope based steps where possible
[
https://issues.apache.org/jira/browse/TINKERPOP-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Valentyn Kahamlyk updated TINKERPOP-2890:
-
Fix Version/s: 3.7.0
3.6.3
3.5.6
> Avoid exceptions on local scope based steps where possible
> --
>
> Key: TINKERPOP-2890
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2890
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.5.5
>Reporter: Stephen Mallette
>Priority: Critical
> Fix For: 3.7.0, 3.6.3, 3.5.6
>
>
> If you {{g.inject([1,2], 1])dedup(local)}} you get an casting error because
> "1" is not an {{Iterable}} and {{local}} only works with that type. Would be
> better if a {{dedup()}} of a non-iterable just returned the object itself.
> Consider other steps that use {{local}} and make similar improvements there
> for consistency.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (TINKERPOP-2926) Gremlin-Java > An UnsupportedOperationException occurs on calling next() after a merge step with the option step modulator if the element does not exist
[
https://issues.apache.org/jira/browse/TINKERPOP-2926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Valentyn Kahamlyk closed TINKERPOP-2926.
Resolution: Fixed
> Gremlin-Java > An UnsupportedOperationException occurs on calling next()
> after a merge step with the option step modulator if the element does not
> exist
>
>
> Key: TINKERPOP-2926
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2926
> Project: TinkerPop
> Issue Type: Bug
> Components: driver
>Affects Versions: 3.6.2
>Reporter: Andrew Kirk
>Assignee: Valentyn Kahamlyk
>Priority: Blocker
> Fix For: 3.7.0, 3.6.3
>
> Attachments: MergeTestApp.java
>
>
> Using Gremlin-Java, when the option step modulator is used in combination
> with a merge step, an `UnsupportedOperationException` is thrown upon calling
> `next()` if the specified element does not already exist.
> Using an example from the docs, the following construct works fine in the
> console if the element does not already exist:
> {code:groovy}
> gremlin> g.mergeV([(T.id):300]).
> option(Merge.onCreate,[(T.label):'Dog', name:'Toby', age:10]).
> option(Merge.onMatch,[age:11])
> {code}
> But, if we try to do the same thing in Java, we'll get an exception:
> {code:java}
> g.mergeV(Map.of(T.id, 300))
> .option(
> Merge.onCreate,
> Map.of(
> T.label, "Dog",
> "name", "Toby",
> "age", 10
> )
> )
> .option(
> Merge.onMatch,
> Map.of("age", 11)
> )
> .next();
> {code}
> Exception:
> {noformat}
> Exception in thread "main" java.lang.UnsupportedOperationException
> at
> java.base/java.util.ImmutableCollections.uoe(ImmutableCollections.java:142)
> at
> java.base/java.util.ImmutableCollections$AbstractImmutableMap.putAll(ImmutableCollections.java:1073)
> at
> org.apache.tinkerpop.gremlin.process.traversal.step.map.MergeVertexStep.onCreateMap(MergeVertexStep.java:205)
> at
> org.apache.tinkerpop.gremlin.process.traversal.step.map.MergeVertexStep.flatMap(MergeVertexStep.java:168)
> at
> org.apache.tinkerpop.gremlin.process.traversal.step.map.FlatMapStep.processNextStart(FlatMapStep.java:49)
> at
> org.apache.tinkerpop.gremlin.process.traversal.step.map.MergeStep.processNextStart(MergeStep.java:165)
> at
> org.apache.tinkerpop.gremlin.process.traversal.step.util.AbstractStep.next(AbstractStep.java:135)
> at
> org.apache.tinkerpop.gremlin.process.traversal.step.util.AbstractStep.next(AbstractStep.java:40)
> at
> org.apache.tinkerpop.gremlin.process.traversal.util.DefaultTraversal.next(DefaultTraversal.java:249)
> at
> io.integralla.tinkerpop.poc.MergeWithOption.main(MergeWithOption.java:44)
> {noformat}
> If the element is first added (via an add or merge step), the merge with
> option works as expected.
> A full example is provided in the attached MergeTestApp.java
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (TINKERPOP-2890) Avoid exceptions on local scope based steps where possible
[
https://issues.apache.org/jira/browse/TINKERPOP-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Valentyn Kahamlyk closed TINKERPOP-2890.
Resolution: Fixed
> Avoid exceptions on local scope based steps where possible
> --
>
> Key: TINKERPOP-2890
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2890
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.5.5
>Reporter: Stephen Mallette
>Priority: Critical
> Fix For: 3.7.0, 3.6.3, 3.5.6
>
>
> If you {{g.inject([1,2], 1])dedup(local)}} you get an casting error because
> "1" is not an {{Iterable}} and {{local}} only works with that type. Would be
> better if a {{dedup()}} of a non-iterable just returned the object itself.
> Consider other steps that use {{local}} and make similar improvements there
> for consistency.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715209#comment-17715209 ] ASF GitHub Bot commented on TINKERPOP-2852: --- Cole-Greer commented on PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#issuecomment-1518442805 @lyndonbauto > So does this now support building on x64 and aarch64? As of TinkerPop 3.5.5/3.6.3 both x64 and aarch64 were able to build and run TinkerPop out of the box. > Also does it support cross platform docker image building or just building for the given machines architecture? The new docker plugin introduced here uses docker buildx under the hood. In theory a user can run this from any platform with docker installed and build an image for any other platform they want. My expectation is that we could build images for all architectures supported by the [alpine base image](https://hub.docker.com/_/alpine/tags) simply by adding them to the `` list. The only reason the list is currently limited to x86 and arm is that is all I am able to test. Also in my testing the ARM console image was unstable on my ARM Mac so I opted not to include it in the deployment here. I'm currently unsure what's causing this instability as the console runs fine on ARM without docker. > Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715202#comment-17715202 ] ASF GitHub Bot commented on TINKERPOP-2852: --- lyndonbauto commented on PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#issuecomment-1518426644 Made a couple nits, feel free to commit or ignore them. So does this now support building on x64 and aarch64? Also does it support cross platform docker image building or just building for the given machines architecture? > Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[
https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715201#comment-17715201
]
ASF GitHub Bot commented on TINKERPOP-2852:
---
lyndonbauto commented on code in PR #2007:
URL: https://github.com/apache/tinkerpop/pull/2007#discussion_r1174226183
##
gremlin-server/pom.xml:
##
@@ -378,60 +412,28 @@ limitations under the License.
-com.spotify
-dockerfile-maven-plugin
+io.fabric8
+docker-maven-plugin
-docker-image-build
+docker:build
build
-
-${project.version}
-
-
target/apache-tinkerpop-${project.artifactId}-${project.version}-standalone
-
-
-
-
-docker-image-tag-minor-version
-
-tag
-
-
-
${parsedVersion.majorVersion}.${parsedVersion.minorVersion}
-
${only.when.is.prerelease.version}
-
+package
-docker-image-push
-deploy
+docker:push
push
-
-${project.version}
-${only.when.is.snapshot.used}
-
-
-
-docker-image-push-minor-version
deploy
-
-push
-
-
-
${parsedVersion.majorVersion}.${parsedVersion.minorVersion}
-
${only.when.is.prerelease.version}
-
-
-tinkerpop/gremlin-server
-
+
Review Comment:
```suggestion
```
> Update Maven plugin for docker-images building for M1 compatibility
> ---
>
> Key: TINKERPOP-2852
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2852
> Project: TinkerPop
> Issue Type: Improvement
> Components: build-release
>Affects Versions: 3.5.4
>Reporter: Yang Xia
>Priority: Critical
>
> The current Maven plug in we use for the `docker-image` building profile is
> no longer maintained
> ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).],
> and it is also not compatible with M1 Macs.
> We should consider swapping the plug in for an actively maintained one that
> is M1 compatible, for example
> [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715200#comment-17715200 ] ASF GitHub Bot commented on TINKERPOP-2852: --- lyndonbauto commented on code in PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#discussion_r1174226024 ## gremlin-server/pom.xml: ## @@ -32,6 +32,8 @@ limitations under the License. --> false Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [DISCUSS] Consider maintenance releases 3.5.6/3.6.3
Hi all, Given there have been no objections for the release dates, I'd like to go ahead and call the code-freeze today. We will be focusing on merging the existing PRs in the code-freeze week: Deploying multi-arch docker images: https://github.com/apache/tinkerpop/pull/2007 Incorrect result caused by has(key, predicate): https://github.com/apache/tinkerpop/pull/2017 Fixing a couple mergeV/E issues: https://github.com/apache/tinkerpop/pull/2036 Please let us know if there are other PRs you'd like to be merged. Note that we would not be considering large feature additions. Cheers, Yang On Fri, Apr 14, 2023 at 2:19 PM Yang Xia wrote: > Hi all, > > I just want to pitch the idea of considering the next maintenance release > for 3.5.6 and 3.6.3 soon. > > We have had a number of changes built up into the two branches since the > last release in January [1] [2], plus quite a few PRs for different JIRA > tickets currently in review, which look ready for merging next week. > > These changes include some major performance improvements with Groovy and > the path() traversers, along with upgrades for security vulnerability and > bug fixes in gremlin-core. There were updates and fixes in the GLVs that > led to two release candidates for python and .net. We are also looking to > have an ARM-based Gremlin Server image available for users. So I think we > should get a release planned sooner rather than later. > > In terms of dates, I'd like to propose we begin code-freeze next Friday, > Apr 21, and aim for the release announcement for Apr 28. > > Also to not leave out 3.7.0, while we recently had a large feature > implemented, Properties on Element, there are still quite a bit of features > left in the planned section [3], one being Dave's recent proposal on string > functions. At this point we probably should keep supporting 3.5.x, as most > if not all providers still have 3.5.x support. I'm thinking we could > reassess the dates for 3.7.0 as part of the release after this proposed one. > > Any thoughts on this? > > Cheers, > > Yang > > [1] https://github.com/apache/tinkerpop/blob/3.5-dev/CHANGELOG.asciidoc > [2] https://github.com/apache/tinkerpop/blob/3.6-dev/CHANGELOG.asciidoc > [3] > https://github.com/apache/tinkerpop/blob/master/docs/src/dev/future/index.asciidoc#37x---target-22q4 > > *--* > *Yang Xia* > >
[jira] [Closed] (TINKERPOP-2893) Incorrectly comparing a counted value with multiple predicates
[
https://issues.apache.org/jira/browse/TINKERPOP-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yang Xia closed TINKERPOP-2893.
---
Fix Version/s: 3.7.0
3.6.3
3.5.6
Resolution: Fixed
> Incorrectly comparing a counted value with multiple predicates
> --
>
> Key: TINKERPOP-2893
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2893
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.5.5
>Reporter: Lei Tang
>Assignee: Ken Hu
>Priority: Critical
> Fix For: 3.7.0, 3.6.3, 3.5.6
>
>
> We use a composition of two predicates inside(-1,1).and(lt(-1)) to filter
> numbers that are greater than -1 and less -1. Obviously, no values satisfy
> this condition. Therefore, we expect Tinkergraph returns an empty set.
> However, a vertex is returned.
> {code:java}
> gremlin> :> g.V().where(__.in('knows').count().is(inside(-1,1).and(lt(-1
> ==>v[0] {code}
> The graph of this example is as following.
> {code:java}
> Vertex bob = g.addV("person").property("name", "Bob").next(); // v[0]
> Vertex alice = g.addV("person").property("name", "Alice").next(); // v[1]
> Edge edge1 = g.addE("knows").from(bob).to(alice).next();{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (TINKERPOP-2893) Incorrectly comparing a counted value with multiple predicates
[
https://issues.apache.org/jira/browse/TINKERPOP-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yang Xia reassigned TINKERPOP-2893:
---
Assignee: Ken Hu
> Incorrectly comparing a counted value with multiple predicates
> --
>
> Key: TINKERPOP-2893
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2893
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.5.5
>Reporter: Lei Tang
>Assignee: Ken Hu
>Priority: Critical
>
> We use a composition of two predicates inside(-1,1).and(lt(-1)) to filter
> numbers that are greater than -1 and less -1. Obviously, no values satisfy
> this condition. Therefore, we expect Tinkergraph returns an empty set.
> However, a vertex is returned.
> {code:java}
> gremlin> :> g.V().where(__.in('knows').count().is(inside(-1,1).and(lt(-1
> ==>v[0] {code}
> The graph of this example is as following.
> {code:java}
> Vertex bob = g.addV("person").property("name", "Bob").next(); // v[0]
> Vertex alice = g.addV("person").property("name", "Alice").next(); // v[1]
> Edge edge1 = g.addE("knows").from(bob).to(alice).next();{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (TINKERPOP-2925) mergeE() in javascript producing an error
[
https://issues.apache.org/jira/browse/TINKERPOP-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yang Xia closed TINKERPOP-2925.
---
Fix Version/s: 3.7.0
3.6.3
Resolution: Fixed
> mergeE() in javascript producing an error
> -
>
> Key: TINKERPOP-2925
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2925
> Project: TinkerPop
> Issue Type: Bug
> Components: javascript
>Affects Versions: 3.6.2
>Reporter: Stephen Mallette
>Assignee: Yang Xia
>Priority: Blocker
> Fix For: 3.7.0, 3.6.3
>
>
> {code}
> g.mergeE([(T.id): 'teste-edge', (T.label): 'edge-label', (Direction.from):
> 'test-vertex', (Direction.to): 'test-vertex2'])
> {code}
> bytecode created seems to be off perhaps for {{Direction.from}} where it adds
> it as {{from_}} according to [~krlawrence]. would be nice to also improve the
> client-side error for this. it may have been a bit opaque.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (TINKERPOP-2925) mergeE() in javascript producing an error
[
https://issues.apache.org/jira/browse/TINKERPOP-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yang Xia reassigned TINKERPOP-2925:
---
Assignee: Yang Xia
> mergeE() in javascript producing an error
> -
>
> Key: TINKERPOP-2925
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2925
> Project: TinkerPop
> Issue Type: Bug
> Components: javascript
>Affects Versions: 3.6.2
>Reporter: Stephen Mallette
>Assignee: Yang Xia
>Priority: Blocker
>
> {code}
> g.mergeE([(T.id): 'teste-edge', (T.label): 'edge-label', (Direction.from):
> 'test-vertex', (Direction.to): 'test-vertex2'])
> {code}
> bytecode created seems to be off perhaps for {{Direction.from}} where it adds
> it as {{from_}} according to [~krlawrence]. would be nice to also improve the
> client-side error for this. it may have been a bit opaque.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2890) Avoid exceptions on local scope based steps where possible
[
https://issues.apache.org/jira/browse/TINKERPOP-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715198#comment-17715198
]
ASF GitHub Bot commented on TINKERPOP-2890:
---
vkagamlyk merged PR #2012:
URL: https://github.com/apache/tinkerpop/pull/2012
> Avoid exceptions on local scope based steps where possible
> --
>
> Key: TINKERPOP-2890
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2890
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.5.5
>Reporter: Stephen Mallette
>Priority: Critical
>
> If you {{g.inject([1,2], 1])dedup(local)}} you get an casting error because
> "1" is not an {{Iterable}} and {{local}} only works with that type. Would be
> better if a {{dedup()}} of a non-iterable just returned the object itself.
> Consider other steps that use {{local}} and make similar improvements there
> for consistency.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2925) mergeE() in javascript producing an error
[
https://issues.apache.org/jira/browse/TINKERPOP-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715197#comment-17715197
]
ASF GitHub Bot commented on TINKERPOP-2925:
---
xiazcy merged PR #2034:
URL: https://github.com/apache/tinkerpop/pull/2034
> mergeE() in javascript producing an error
> -
>
> Key: TINKERPOP-2925
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2925
> Project: TinkerPop
> Issue Type: Bug
> Components: javascript
>Affects Versions: 3.6.2
>Reporter: Stephen Mallette
>Priority: Blocker
>
> {code}
> g.mergeE([(T.id): 'teste-edge', (T.label): 'edge-label', (Direction.from):
> 'test-vertex', (Direction.to): 'test-vertex2'])
> {code}
> bytecode created seems to be off perhaps for {{Direction.from}} where it adds
> it as {{from_}} according to [~krlawrence]. would be nice to also improve the
> client-side error for this. it may have been a bit opaque.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2893) Incorrectly comparing a counted value with multiple predicates
[
https://issues.apache.org/jira/browse/TINKERPOP-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715195#comment-17715195
]
ASF GitHub Bot commented on TINKERPOP-2893:
---
kenhuuu merged PR #2033:
URL: https://github.com/apache/tinkerpop/pull/2033
> Incorrectly comparing a counted value with multiple predicates
> --
>
> Key: TINKERPOP-2893
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2893
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.5.5
>Reporter: Lei Tang
>Priority: Critical
>
> We use a composition of two predicates inside(-1,1).and(lt(-1)) to filter
> numbers that are greater than -1 and less -1. Obviously, no values satisfy
> this condition. Therefore, we expect Tinkergraph returns an empty set.
> However, a vertex is returned.
> {code:java}
> gremlin> :> g.V().where(__.in('knows').count().is(inside(-1,1).and(lt(-1
> ==>v[0] {code}
> The graph of this example is as following.
> {code:java}
> Vertex bob = g.addV("person").property("name", "Bob").next(); // v[0]
> Vertex alice = g.addV("person").property("name", "Alice").next(); // v[1]
> Edge edge1 = g.addE("knows").from(bob).to(alice).next();{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2890) Avoid exceptions on local scope based steps where possible
[
https://issues.apache.org/jira/browse/TINKERPOP-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715188#comment-17715188
]
ASF GitHub Bot commented on TINKERPOP-2890:
---
xiazcy commented on PR #2012:
URL: https://github.com/apache/tinkerpop/pull/2012#issuecomment-1518411671
VOTE +1
> Avoid exceptions on local scope based steps where possible
> --
>
> Key: TINKERPOP-2890
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2890
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.5.5
>Reporter: Stephen Mallette
>Priority: Critical
>
> If you {{g.inject([1,2], 1])dedup(local)}} you get an casting error because
> "1" is not an {{Iterable}} and {{local}} only works with that type. Would be
> better if a {{dedup()}} of a non-iterable just returned the object itself.
> Consider other steps that use {{local}} and make similar improvements there
> for consistency.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2925) mergeE() in javascript producing an error
[
https://issues.apache.org/jira/browse/TINKERPOP-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715185#comment-17715185
]
ASF GitHub Bot commented on TINKERPOP-2925:
---
xiazcy commented on PR #2034:
URL: https://github.com/apache/tinkerpop/pull/2034#issuecomment-1518394852
VOTE +1
> mergeE() in javascript producing an error
> -
>
> Key: TINKERPOP-2925
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2925
> Project: TinkerPop
> Issue Type: Bug
> Components: javascript
>Affects Versions: 3.6.2
>Reporter: Stephen Mallette
>Priority: Blocker
>
> {code}
> g.mergeE([(T.id): 'teste-edge', (T.label): 'edge-label', (Direction.from):
> 'test-vertex', (Direction.to): 'test-vertex2'])
> {code}
> bytecode created seems to be off perhaps for {{Direction.from}} where it adds
> it as {{from_}} according to [~krlawrence]. would be nice to also improve the
> client-side error for this. it may have been a bit opaque.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2860) Change release process to add binary verification for Python and .Net client
[ https://issues.apache.org/jira/browse/TINKERPOP-2860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715176#comment-17715176 ] Yang Xia commented on TINKERPOP-2860: - I think I'd agree with Stephen where the trust is placed on the release manager for the correct deployment of convenience binaries. [~divijvaidya], just checking if you had any thoughts or process suggestions regarding this topic, since we are looking into a new release? > Change release process to add binary verification for Python and .Net client > > > Key: TINKERPOP-2860 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2860 > Project: TinkerPop > Issue Type: Bug > Components: build-release >Affects Versions: 3.5.5 >Reporter: Divij Vaidya >Priority: Blocker > > The binaries that we release for python and .Net are not voted-on during the > release process. > Hence, there is no way for a user to validate that the binary in PyPi or > nuGet is actually generated from the code that was voted on by the PMC. > We need to modify our change process to add a step where we could validate > the integrity of the binary that will be added to PyPi or nuGet -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2373) Bump to Groovy 4.0
[ https://issues.apache.org/jira/browse/TINKERPOP-2373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715169#comment-17715169 ] Christopher Smith commented on TINKERPOP-2373: -- Is there an anticipated release timeline for 3.7.0? Gremlin Console 3.6.2 won't run on Java 17 because the shaded asm in Groovy 2.5.15 is too old. If 3.7.0 is still some time off, would it be possible to get a 3.6.3 with a version bump of Groovy to 2.5.22 to enable Java 17? > Bump to Groovy 4.0 > -- > > Key: TINKERPOP-2373 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2373 > Project: TinkerPop > Issue Type: Improvement > Components: groovy >Affects Versions: 3.5.0 >Reporter: Stephen Mallette >Assignee: Ken Hu >Priority: Major > Fix For: 3.7.0 > > > Groovy 3.0 has been out for a while now and has done several patch releases. > Time to upgrade on 3.5.0. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2890) Avoid exceptions on local scope based steps where possible
[
https://issues.apache.org/jira/browse/TINKERPOP-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715166#comment-17715166
]
ASF GitHub Bot commented on TINKERPOP-2890:
---
kenhuuu commented on PR #2012:
URL: https://github.com/apache/tinkerpop/pull/2012#issuecomment-1518319762
VOTE +1
> Avoid exceptions on local scope based steps where possible
> --
>
> Key: TINKERPOP-2890
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2890
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.5.5
>Reporter: Stephen Mallette
>Priority: Critical
>
> If you {{g.inject([1,2], 1])dedup(local)}} you get an casting error because
> "1" is not an {{Iterable}} and {{local}} only works with that type. Would be
> better if a {{dedup()}} of a non-iterable just returned the object itself.
> Consider other steps that use {{local}} and make similar improvements there
> for consistency.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2832) Nature of sessions and driver reconnect allow bytecode transactions to appear to remain open
[ https://issues.apache.org/jira/browse/TINKERPOP-2832?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715159#comment-17715159 ] Valentyn Kahamlyk commented on TINKERPOP-2832: -- Default session timeout is 8 hours, most Gremlin Server configurations also use this value. However, when this time is configured with a much lower value, then the following sequence of events is possible: 1. Client starts new session on server 2. Client sets some variables or make some changes in transaction 3. Client looses connection 4. Server removes session as expired 5. Client reconnects and try to continue to work with opened session 6. Server creates new session with same ID Resulting in an inconsistent state and possible data loss in the transaction. Proposed solution for 3.5/3.6: after closing the session, have the server keep its id for some more time and do not allow creating a session with same ID, throw an error when such an attempt is made. The longer term plan is to re-design the entire session logic as part of transaction implementation in TinkerGraph in 3.7 > Nature of sessions and driver reconnect allow bytecode transactions to appear > to remain open > > > Key: TINKERPOP-2832 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2832 > Project: TinkerPop > Issue Type: Bug > Components: driver, server >Affects Versions: 3.5.4 >Reporter: Stephen Mallette >Priority: Critical > > The driver is design to reconnect if it loses its connection to the server. > For sessions a close can happen if there is a timeout on the session itself. > On the server the session is invalidated, but on the client side, it tries to > reconnect using the same session id. Unfortunately this reconnect creates a > scenario for bytecode transactions where it can appear as though you're > working the same transaction when you are not. > Test to demonstrate shown > [here|https://github.com/apache/tinkerpop/commit/4528ec33ab56e3c0526ad8b38494674c64754e54] > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2925) mergeE() in javascript producing an error
[
https://issues.apache.org/jira/browse/TINKERPOP-2925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715144#comment-17715144
]
ASF GitHub Bot commented on TINKERPOP-2925:
---
kenhuuu commented on PR #2034:
URL: https://github.com/apache/tinkerpop/pull/2034#issuecomment-1518251457
VOTE +1
> mergeE() in javascript producing an error
> -
>
> Key: TINKERPOP-2925
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2925
> Project: TinkerPop
> Issue Type: Bug
> Components: javascript
>Affects Versions: 3.6.2
>Reporter: Stephen Mallette
>Priority: Blocker
>
> {code}
> g.mergeE([(T.id): 'teste-edge', (T.label): 'edge-label', (Direction.from):
> 'test-vertex', (Direction.to): 'test-vertex2'])
> {code}
> bytecode created seems to be off perhaps for {{Direction.from}} where it adds
> it as {{from_}} according to [~krlawrence]. would be nice to also improve the
> client-side error for this. it may have been a bit opaque.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2893) Incorrectly comparing a counted value with multiple predicates
[
https://issues.apache.org/jira/browse/TINKERPOP-2893?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715120#comment-17715120
]
ASF GitHub Bot commented on TINKERPOP-2893:
---
kenhuuu commented on PR #2033:
URL: https://github.com/apache/tinkerpop/pull/2033#issuecomment-1518180507
VOTE +1
> Incorrectly comparing a counted value with multiple predicates
> --
>
> Key: TINKERPOP-2893
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2893
> Project: TinkerPop
> Issue Type: Bug
> Components: process
>Affects Versions: 3.5.5
>Reporter: Lei Tang
>Priority: Critical
>
> We use a composition of two predicates inside(-1,1).and(lt(-1)) to filter
> numbers that are greater than -1 and less -1. Obviously, no values satisfy
> this condition. Therefore, we expect Tinkergraph returns an empty set.
> However, a vertex is returned.
> {code:java}
> gremlin> :> g.V().where(__.in('knows').count().is(inside(-1,1).and(lt(-1
> ==>v[0] {code}
> The graph of this example is as following.
> {code:java}
> Vertex bob = g.addV("person").property("name", "Bob").next(); // v[0]
> Vertex alice = g.addV("person").property("name", "Alice").next(); // v[1]
> Edge edge1 = g.addE("knows").from(bob).to(alice).next();{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (TINKERPOP-2931) Fix a few minor mergeV/E issues
Mike Personick created TINKERPOP-2931: - Summary: Fix a few minor mergeV/E issues Key: TINKERPOP-2931 URL: https://issues.apache.org/jira/browse/TINKERPOP-2931 Project: TinkerPop Issue Type: Improvement Reporter: Mike Personick Assignee: Mike Personick Checking for illegal hidden keys (~label, ~id). Refactor MergeVertexStep.searchVertices to allow Provider subclasses to override search criteria. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2890) Avoid exceptions on local scope based steps where possible
[
https://issues.apache.org/jira/browse/TINKERPOP-2890?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17715019#comment-17715019
]
ASF GitHub Bot commented on TINKERPOP-2890:
---
vkagamlyk commented on PR #2012:
URL: https://github.com/apache/tinkerpop/pull/2012#issuecomment-1517870321
VOTE+1
> Avoid exceptions on local scope based steps where possible
> --
>
> Key: TINKERPOP-2890
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2890
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.5.5
>Reporter: Stephen Mallette
>Priority: Critical
>
> If you {{g.inject([1,2], 1])dedup(local)}} you get an casting error because
> "1" is not an {{Iterable}} and {{local}} only works with that type. Would be
> better if a {{dedup()}} of a non-iterable just returned the object itself.
> Consider other steps that use {{local}} and make similar improvements there
> for consistency.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (TINKERPOP-2930) shouldContinueToEvalScriptsEvenWithTimedInterrupt is failing intermittently
Stephen Mallette created TINKERPOP-2930:
---
Summary: shouldContinueToEvalScriptsEvenWithTimedInterrupt is
failing intermittently
Key: TINKERPOP-2930
URL: https://issues.apache.org/jira/browse/TINKERPOP-2930
Project: TinkerPop
Issue Type: Bug
Components: groovy
Affects Versions: 3.7.0
Reporter: Stephen Mallette
This failure seems to only be happening on 3.7.x. Perhaps related to the groovy
upgrade?
{code}
javax.script.ScriptException: javax.script.ScriptException:
org.apache.tinkerpop.gremlin.groovy.jsr223.TimedInterruptTimeoutException:
Execution timed out after 1000 milliseconds. Start time: Fri Apr 21 09:32:39
EDT 2023
at
org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngine.eval(GremlinGroovyScriptEngine.java:383)
at
java.scripting/javax.script.AbstractScriptEngine.eval(AbstractScriptEngine.java:264)
at
org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngineTimedInterruptTest.shouldContinueToEvalScriptsEvenWithTimedInterrupt(GremlinGroovyScriptEngineTimedInterruptTest.java:74)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
at
com.intellij.junit4.JUnit4IdeaTestRunner.startRunnerWithArgs(JUnit4IdeaTestRunner.java:69)
at
com.intellij.rt.junit.IdeaTestRunner$Repeater.startRunnerWithArgs(IdeaTestRunner.java:33)
at
com.intellij.rt.junit.JUnitStarter.prepareStreamsAndStart(JUnitStarter.java:235)
at com.intellij.rt.junit.JUnitStarter.main(JUnitStarter.java:54)
Caused by: javax.script.ScriptException:
org.apache.tinkerpop.gremlin.groovy.jsr223.TimedInterruptTimeoutException:
Execution timed out after 1000 milliseconds. Start time: Fri Apr 21 09:32:39
EDT 2023
at
org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngine.eval(GremlinGroovyScriptEngine.java:702)
at
org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngine.eval(GremlinGroovyScriptEngine.java:381)
... 27 more
Caused by:
org.apache.tinkerpop.gremlin.groovy.jsr223.TimedInterruptTimeoutException:
Execution timed out after 1000 milliseconds. Start time: Fri Apr 21 09:32:39
EDT 2023
at
org.codehaus.groovy.vmplugin.v8.IndyInterface.fromCache(IndyInterface.java:321)
at Script7.run(Script7.groovy:2)
at
org.apache.tinkerpop.gremlin.groovy.jsr223.GremlinGroovyScriptEngine.eval(GremlinGroovyScriptEngine.java:679)
... 28 more
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2852) Update Maven plugin for docker-images building for M1 compatibility
[ https://issues.apache.org/jira/browse/TINKERPOP-2852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17714841#comment-17714841 ] ASF GitHub Bot commented on TINKERPOP-2852: --- FlorianHockmann commented on code in PR #2007: URL: https://github.com/apache/tinkerpop/pull/2007#discussion_r1173374302 ## pom.xml: ## @@ -345,11 +345,62 @@ limitations under the License. false + + Update Maven plugin for docker-images building for M1 compatibility > --- > > Key: TINKERPOP-2852 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2852 > Project: TinkerPop > Issue Type: Improvement > Components: build-release >Affects Versions: 3.5.4 >Reporter: Yang Xia >Priority: Critical > > The current Maven plug in we use for the `docker-image` building profile is > no longer maintained > ([https://github.com/spotify/dockerfile-maven)|https://github.com/spotify/dockerfile-maven).], > and it is also not compatible with M1 Macs. > We should consider swapping the plug in for an actively maintained one that > is M1 compatible, for example > [https://github.com/fabric8io/docker-maven-plugin/issues/1257.|https://github.com/fabric8io/docker-maven-plugin/issues/1257] -- This message was sent by Atlassian Jira (v8.20.10#820010)
