[jira] [Updated] (TINKERPOP-2945) TextP.regex() Serialization Failing in Java driver
[
https://issues.apache.org/jira/browse/TINKERPOP-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Valentyn Kahamlyk updated TINKERPOP-2945:
-
Fix Version/s: 3.6.4
> TextP.regex() Serialization Failing in Java driver
> --
>
> Key: TINKERPOP-2945
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2945
> Project: TinkerPop
> Issue Type: Bug
> Components: driver
>Affects Versions: 3.7.0, 3.6.3
>Reporter: Yang Xia
>Priority: Critical
> Fix For: 3.6.4
>
>
> The serialization for TextP.regex() is failing in Java for both GraphBinary
> and GraphSON.
> To reproduce, add
> {code:java}
> new Object[] {"TextP", TextP.regex("^meh"), null}, {code}
> into the argument list for GraphBinaryReaderWriterRoundTripTest.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (TINKERPOP-2945) TextP.regex() Serialization Failing in Java driver
[
https://issues.apache.org/jira/browse/TINKERPOP-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Valentyn Kahamlyk updated TINKERPOP-2945:
-
Fix Version/s: 3.7.0
> TextP.regex() Serialization Failing in Java driver
> --
>
> Key: TINKERPOP-2945
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2945
> Project: TinkerPop
> Issue Type: Bug
> Components: driver
>Affects Versions: 3.6.3
>Reporter: Yang Xia
>Priority: Critical
> Fix For: 3.7.0, 3.6.4
>
>
> The serialization for TextP.regex() is failing in Java for both GraphBinary
> and GraphSON.
> To reproduce, add
> {code:java}
> new Object[] {"TextP", TextP.regex("^meh"), null}, {code}
> into the argument list for GraphBinaryReaderWriterRoundTripTest.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (TINKERPOP-2945) TextP.regex() Serialization Failing in Java driver
[
https://issues.apache.org/jira/browse/TINKERPOP-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Valentyn Kahamlyk closed TINKERPOP-2945.
Resolution: Fixed
> TextP.regex() Serialization Failing in Java driver
> --
>
> Key: TINKERPOP-2945
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2945
> Project: TinkerPop
> Issue Type: Bug
> Components: driver
>Affects Versions: 3.6.3
>Reporter: Yang Xia
>Priority: Critical
> Fix For: 3.7.0, 3.6.4
>
>
> The serialization for TextP.regex() is failing in Java for both GraphBinary
> and GraphSON.
> To reproduce, add
> {code:java}
> new Object[] {"TextP", TextP.regex("^meh"), null}, {code}
> into the argument list for GraphBinaryReaderWriterRoundTripTest.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (TINKERPOP-2945) TextP.regex() Serialization Failing in Java driver
[
https://issues.apache.org/jira/browse/TINKERPOP-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Valentyn Kahamlyk updated TINKERPOP-2945:
-
Affects Version/s: (was: 3.7.0)
> TextP.regex() Serialization Failing in Java driver
> --
>
> Key: TINKERPOP-2945
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2945
> Project: TinkerPop
> Issue Type: Bug
> Components: driver
>Affects Versions: 3.6.3
>Reporter: Yang Xia
>Priority: Critical
> Fix For: 3.6.4
>
>
> The serialization for TextP.regex() is failing in Java for both GraphBinary
> and GraphSON.
> To reproduce, add
> {code:java}
> new Object[] {"TextP", TextP.regex("^meh"), null}, {code}
> into the argument list for GraphBinaryReaderWriterRoundTripTest.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [DISCUSS] Proposing 3.6.4 Patch Release
Hi Florian, Yup, it makes sense to include it. I think we can also do a .NET 3.5.7 RC release for the fix without adding burden to the patch release process. In any case, let's try merging everything by Friday noon PT, including the LICENSE/NOTICE updates. Then I will begin preparing for the 3.6.4 VOTE thread. Regards, Yang On Thu, May 11, 2023 at 7:57 AM Florian Hockmann wrote: > Hi, > > Would be great if we could include my PR for the memory leak fix. I just > had to modify the commit again as my fix apparently wasn't complete, but > now it should be in a good state. > But I agree that a 3.5.7 isn't necessary for this. Most .NET users > directly use the latest releases and don't stay on 3.5. We had for example > 8,600 downloads for 3.6.2, but only 1,400 for 3.5.5 and even 75,000 for > 3.6.1, but only 8,600 for 3.5.4 according to nuget.org. > > Regards, > Florian > > -Ursprüngliche Nachricht- > Von: Yang Xia > Gesendet: Mittwoch, 10. Mai 2023 22:28 > An: dev@tinkerpop.apache.org > Betreff: [DISCUSS] Proposing 3.6.4 Patch Release > > Hi all, > > In light of a recently discovered critical bug in TextP.regex() > serialization in 3.6.x ( > https://issues.apache.org/jira/browse/TINKERPOP-2945), > which unfortunately missed the 3.6.3 release, I'd like to propose a patch > release as 3.6.4 to bring this fix to the users as soon as possible. > > Given we just had a release and no new changes have been merged, I propose > we can skip the code freeze week and begin the preparation for the release > VOTE on 3.6.4 once the fix is merged ( > https://github.com/apache/tinkerpop/pull/2059). We will essentially be > performing a full release on the 3.6.4 branch only. > > The 3.5-dev and 3.6-dev branches will need to be frozen to any changes > which would fall outside of this 3.6.4 patch release. I do want to point > out a .NET memory leak fix in 3.5 ( > https://issues.apache.org/jira/browse/TINKERPOP-2944), with PR ( > https://github.com/apache/tinkerpop/pull/2058) by Florian may warrant > inclusion in this patch release. I would welcome any feedback regarding the > inclusion of this change in a 3.6.4 patch release, as well as if it would > also justify a 3.5.7 patch release. If there are no responses, I will > assume a lazy consensus supporting a 3.6.4 patch release only, with the > only significant change being TINKERPOP-2945. I would also look to include > a few trivial changes such as > https://github.com/apache/tinkerpop/pull/2052 > and fixes to the console and server NOTICE files. > > Feel free to comment on this thread if you have any questions or concerns. > > Regards, > > Yang > *--* > *Yang Xia* > >
[jira] [Commented] (TINKERPOP-2945) TextP.regex() Serialization Failing in Java driver
[
https://issues.apache.org/jira/browse/TINKERPOP-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721953#comment-17721953
]
ASF GitHub Bot commented on TINKERPOP-2945:
---
vkagamlyk merged PR #2059:
URL: https://github.com/apache/tinkerpop/pull/2059
> TextP.regex() Serialization Failing in Java driver
> --
>
> Key: TINKERPOP-2945
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2945
> Project: TinkerPop
> Issue Type: Bug
> Components: driver
>Affects Versions: 3.7.0, 3.6.3
>Reporter: Yang Xia
>Priority: Critical
>
> The serialization for TextP.regex() is failing in Java for both GraphBinary
> and GraphSON.
> To reproduce, add
> {code:java}
> new Object[] {"TextP", TextP.regex("^meh"), null}, {code}
> into the argument list for GraphBinaryReaderWriterRoundTripTest.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2944) Memory leak in Gremlin.Net driver if CancellationToken is used
[
https://issues.apache.org/jira/browse/TINKERPOP-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721954#comment-17721954
]
ASF GitHub Bot commented on TINKERPOP-2944:
---
kenhuuu commented on PR #2058:
URL: https://github.com/apache/tinkerpop/pull/2058#issuecomment-1544900944
VOTE +1
> Memory leak in Gremlin.Net driver if CancellationToken is used
> --
>
> Key: TINKERPOP-2944
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2944
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
>Affects Versions: 3.6.2, 3.5.5, 3.6.3, 3.5.6
>Reporter: Florian Hockmann
>Assignee: Florian Hockmann
>Priority: Major
>
> We have noticed in my team at G DATA that a .NET service has been using an
> increasing amount of memory since we began to propagate the
> {{CancellationToken}} into the Gremlin.Net traversal executions which was
> introduced in TINKERPOP-2794.
> We could track this down with memory profiling to [this place in the
> driver|https://github.com/apache/tinkerpop/blob/5c8af70c7fac3ee98df36d250b05320e67ff1b96/gremlin-dotnet/src/Gremlin.Net/Driver/Connection.cs#L94]
> where we register a callback to execute when cancellation is requested.
> These registered callbacks are only cleaned up when the whole {{Connection}}
> object gets disposed. Since the callback contains a reference to the full
> {{RequestMessage}} of the traversal, it can contain a lot of data. This is
> something that I've completely overlooked when I added support for
> cancellation.
> The driver should clean up those callbacks when they are not needed any more
> because the request has been processed completely (either successfully or
> with an error).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2945) TextP.regex() Serialization Failing in Java driver
[
https://issues.apache.org/jira/browse/TINKERPOP-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721951#comment-17721951
]
ASF GitHub Bot commented on TINKERPOP-2945:
---
xiazcy commented on PR #2059:
URL: https://github.com/apache/tinkerpop/pull/2059#issuecomment-1544900509
VOTE +1
> TextP.regex() Serialization Failing in Java driver
> --
>
> Key: TINKERPOP-2945
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2945
> Project: TinkerPop
> Issue Type: Bug
> Components: driver
>Affects Versions: 3.7.0, 3.6.3
>Reporter: Yang Xia
>Priority: Critical
>
> The serialization for TextP.regex() is failing in Java for both GraphBinary
> and GraphSON.
> To reproduce, add
> {code:java}
> new Object[] {"TextP", TextP.regex("^meh"), null}, {code}
> into the argument list for GraphBinaryReaderWriterRoundTripTest.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2945) TextP.regex() Serialization Failing in Java driver
[
https://issues.apache.org/jira/browse/TINKERPOP-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721952#comment-17721952
]
ASF GitHub Bot commented on TINKERPOP-2945:
---
vkagamlyk commented on PR #2059:
URL: https://github.com/apache/tinkerpop/pull/2059#issuecomment-1544900541
VOTE +1
> TextP.regex() Serialization Failing in Java driver
> --
>
> Key: TINKERPOP-2945
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2945
> Project: TinkerPop
> Issue Type: Bug
> Components: driver
>Affects Versions: 3.7.0, 3.6.3
>Reporter: Yang Xia
>Priority: Critical
>
> The serialization for TextP.regex() is failing in Java for both GraphBinary
> and GraphSON.
> To reproduce, add
> {code:java}
> new Object[] {"TextP", TextP.regex("^meh"), null}, {code}
> into the argument list for GraphBinaryReaderWriterRoundTripTest.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2945) TextP.regex() Serialization Failing in Java driver
[
https://issues.apache.org/jira/browse/TINKERPOP-2945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721922#comment-17721922
]
ASF GitHub Bot commented on TINKERPOP-2945:
---
kenhuuu commented on PR #2059:
URL: https://github.com/apache/tinkerpop/pull/2059#issuecomment-1544685727
VOTE +1
> TextP.regex() Serialization Failing in Java driver
> --
>
> Key: TINKERPOP-2945
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2945
> Project: TinkerPop
> Issue Type: Bug
> Components: driver
>Affects Versions: 3.7.0, 3.6.3
>Reporter: Yang Xia
>Priority: Critical
>
> The serialization for TextP.regex() is failing in Java for both GraphBinary
> and GraphSON.
> To reproduce, add
> {code:java}
> new Object[] {"TextP", TextP.regex("^meh"), null}, {code}
> into the argument list for GraphBinaryReaderWriterRoundTripTest.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2944) Memory leak in Gremlin.Net driver if CancellationToken is used
[
https://issues.apache.org/jira/browse/TINKERPOP-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721820#comment-17721820
]
ASF GitHub Bot commented on TINKERPOP-2944:
---
vkagamlyk commented on PR #2058:
URL: https://github.com/apache/tinkerpop/pull/2058#issuecomment-1544163982
LGTM
VOTE +1
> Memory leak in Gremlin.Net driver if CancellationToken is used
> --
>
> Key: TINKERPOP-2944
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2944
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
>Affects Versions: 3.6.2, 3.5.5, 3.6.3, 3.5.6
>Reporter: Florian Hockmann
>Assignee: Florian Hockmann
>Priority: Major
>
> We have noticed in my team at G DATA that a .NET service has been using an
> increasing amount of memory since we began to propagate the
> {{CancellationToken}} into the Gremlin.Net traversal executions which was
> introduced in TINKERPOP-2794.
> We could track this down with memory profiling to [this place in the
> driver|https://github.com/apache/tinkerpop/blob/5c8af70c7fac3ee98df36d250b05320e67ff1b96/gremlin-dotnet/src/Gremlin.Net/Driver/Connection.cs#L94]
> where we register a callback to execute when cancellation is requested.
> These registered callbacks are only cleaned up when the whole {{Connection}}
> object gets disposed. Since the callback contains a reference to the full
> {{RequestMessage}} of the traversal, it can contain a lot of data. This is
> something that I've completely overlooked when I added support for
> cancellation.
> The driver should clean up those callbacks when they are not needed any more
> because the request has been processed completely (either successfully or
> with an error).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2944) Memory leak in Gremlin.Net driver if CancellationToken is used
[
https://issues.apache.org/jira/browse/TINKERPOP-2944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17721818#comment-17721818
]
ASF GitHub Bot commented on TINKERPOP-2944:
---
FlorianHockmann commented on PR #2058:
URL: https://github.com/apache/tinkerpop/pull/2058#issuecomment-1544154709
I made the change you suggested, @vkagamlyk. But I also had to make another
change as my fix wasn't complete. It did solve the problem that the
`Connection` class had an ever increasing list of cancellation registrations,
but those registrations weren't disposed and were therefore still stored in the
underlying `CancellationTokenSource`.
We've found that by trying out the fix in the service where we initially
found the memory leak. The earlier fix here already improved the situation a
lot but a memory dump revealed that the `CancellationTokenSource` had a linked
list of all cancellation registrations.
The version that is now in this PR doesn't show any increasing memory usage
any more (at least right now after executing the application for ~30min which
was already enough earlier to see the problem, but I will update this comment
tomorrow to confirm this).
> Memory leak in Gremlin.Net driver if CancellationToken is used
> --
>
> Key: TINKERPOP-2944
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2944
> Project: TinkerPop
> Issue Type: Bug
> Components: dotnet
>Affects Versions: 3.6.2, 3.5.5, 3.6.3, 3.5.6
>Reporter: Florian Hockmann
>Assignee: Florian Hockmann
>Priority: Major
>
> We have noticed in my team at G DATA that a .NET service has been using an
> increasing amount of memory since we began to propagate the
> {{CancellationToken}} into the Gremlin.Net traversal executions which was
> introduced in TINKERPOP-2794.
> We could track this down with memory profiling to [this place in the
> driver|https://github.com/apache/tinkerpop/blob/5c8af70c7fac3ee98df36d250b05320e67ff1b96/gremlin-dotnet/src/Gremlin.Net/Driver/Connection.cs#L94]
> where we register a callback to execute when cancellation is requested.
> These registered callbacks are only cleaned up when the whole {{Connection}}
> object gets disposed. Since the callback contains a reference to the full
> {{RequestMessage}} of the traversal, it can contain a lot of data. This is
> something that I've completely overlooked when I added support for
> cancellation.
> The driver should clean up those callbacks when they are not needed any more
> because the request has been processed completely (either successfully or
> with an error).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
AW: [DISCUSS] Proposing 3.6.4 Patch Release
Hi, Would be great if we could include my PR for the memory leak fix. I just had to modify the commit again as my fix apparently wasn't complete, but now it should be in a good state. But I agree that a 3.5.7 isn't necessary for this. Most .NET users directly use the latest releases and don't stay on 3.5. We had for example 8,600 downloads for 3.6.2, but only 1,400 for 3.5.5 and even 75,000 for 3.6.1, but only 8,600 for 3.5.4 according to nuget.org. Regards, Florian -Ursprüngliche Nachricht- Von: Yang Xia Gesendet: Mittwoch, 10. Mai 2023 22:28 An: dev@tinkerpop.apache.org Betreff: [DISCUSS] Proposing 3.6.4 Patch Release Hi all, In light of a recently discovered critical bug in TextP.regex() serialization in 3.6.x (https://issues.apache.org/jira/browse/TINKERPOP-2945), which unfortunately missed the 3.6.3 release, I'd like to propose a patch release as 3.6.4 to bring this fix to the users as soon as possible. Given we just had a release and no new changes have been merged, I propose we can skip the code freeze week and begin the preparation for the release VOTE on 3.6.4 once the fix is merged ( https://github.com/apache/tinkerpop/pull/2059). We will essentially be performing a full release on the 3.6.4 branch only. The 3.5-dev and 3.6-dev branches will need to be frozen to any changes which would fall outside of this 3.6.4 patch release. I do want to point out a .NET memory leak fix in 3.5 ( https://issues.apache.org/jira/browse/TINKERPOP-2944), with PR ( https://github.com/apache/tinkerpop/pull/2058) by Florian may warrant inclusion in this patch release. I would welcome any feedback regarding the inclusion of this change in a 3.6.4 patch release, as well as if it would also justify a 3.5.7 patch release. If there are no responses, I will assume a lazy consensus supporting a 3.6.4 patch release only, with the only significant change being TINKERPOP-2945. I would also look to include a few trivial changes such as https://github.com/apache/tinkerpop/pull/2052 and fixes to the console and server NOTICE files. Feel free to comment on this thread if you have any questions or concerns. Regards, Yang *--* *Yang Xia*
