[jira] [Commented] (TINKERPOP-2990) Javascript GLV: Add getters and setters for Client and Connection classes
[
https://issues.apache.org/jira/browse/TINKERPOP-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787383#comment-17787383
]
Valentyn Kahamlyk commented on TINKERPOP-2990:
--
Adding setter is quite a risky move. Currently Client can only work with one
Connection, and Connection not designed to work with several Clients.
Connection constructor use same options as Client constructor, so technically,
a Client-created Connection will be exactly the same as Connection created in
other place.
Do you have an example of when setter is needed?
> Javascript GLV: Add getters and setters for Client and Connection classes
> -
>
> Key: TINKERPOP-2990
> URL: https://issues.apache.org/jira/browse/TINKERPOP-2990
> Project: TinkerPop
> Issue Type: Improvement
> Components: javascript
>Affects Versions: 3.7.0
>Reporter: Taylor Riggan
>Priority: Critical
>
> Java provides the ability to override a class constructor, which has allowed
> a Client or Connection class in Java to be instantiated using varying
> different parameters. Javascript classes only allow a single constructor.
> This limits a developer's ability to access or modify class properties for a
> Client or Connection object.
> Example:
> A DriverRemoteConnection object in gremlin-javascript can only be
> instantiated via:
> {code:java}
> let drc = new DriverRemoteConnection(some_url);{code}
> A developer would not be able to create a Client object first and create a
> new DriverRemoteConnection object based on the Client as they would be able
> to do using the Java GLV.
>
> Similarly, if a user needed to gain access to an underlying Client or
> Connection object from within a DriverRemoteConnection, they would be
> accessing these properties using the _client or _connection variable names.
> The underscore prefix typically denotes that these should be viewed as
> private class properties. As such, we should be treating these as private
> until a time comes as to when we can adopt actual private class properties
> and functions (a fairly new concept added to JS in ES2019).
> To address these issues, I suggest we add setter and getter functions to the
> respective classes that would allow a user to more properly interact with
> class properties that cannot be defined via overridden constructor.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (TINKERPOP-2830) Handle User-Agent from HTTP Requests to server
[ https://issues.apache.org/jira/browse/TINKERPOP-2830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cole Greer updated TINKERPOP-2830: -- Fix Version/s: 3.6.6 3.7.1 > Handle User-Agent from HTTP Requests to server > -- > > Key: TINKERPOP-2830 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2830 > Project: TinkerPop > Issue Type: Improvement > Components: server >Affects Versions: 3.5.4 >Reporter: Cole Greer >Assignee: Cole Greer >Priority: Critical > Fix For: 3.6.6, 3.7.1 > > > Changes are being introduced in > [2480|https://issues.apache.org/jira/browse/TINKERPOP-2480] which add a user > agent which is sent as a request header during web socket handshakes. > Originally 2480 was planned to also include the server accepting user agents > from http requests but this has now fallen outside of the scope. This ticket > is to complete the user agent feature by adding the ability for the server to > accept user agents in http requests in addition to web sockets. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (TINKERPOP-2830) Handle User-Agent from HTTP Requests to server
[ https://issues.apache.org/jira/browse/TINKERPOP-2830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cole Greer closed TINKERPOP-2830. - Resolution: Fixed > Handle User-Agent from HTTP Requests to server > -- > > Key: TINKERPOP-2830 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2830 > Project: TinkerPop > Issue Type: Improvement > Components: server >Affects Versions: 3.5.4 >Reporter: Cole Greer >Assignee: Cole Greer >Priority: Critical > Fix For: 3.6.6, 3.7.1 > > > Changes are being introduced in > [2480|https://issues.apache.org/jira/browse/TINKERPOP-2480] which add a user > agent which is sent as a request header during web socket handshakes. > Originally 2480 was planned to also include the server accepting user agents > from http requests but this has now fallen outside of the scope. This ticket > is to complete the user agent feature by adding the ability for the server to > accept user agents in http requests in addition to web sockets. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (TINKERPOP-2830) Handle User-Agent from HTTP Requests to server
[ https://issues.apache.org/jira/browse/TINKERPOP-2830?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Cole Greer reassigned TINKERPOP-2830: - Assignee: Cole Greer > Handle User-Agent from HTTP Requests to server > -- > > Key: TINKERPOP-2830 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2830 > Project: TinkerPop > Issue Type: Improvement > Components: server >Affects Versions: 3.5.4 >Reporter: Cole Greer >Assignee: Cole Greer >Priority: Critical > > Changes are being introduced in > [2480|https://issues.apache.org/jira/browse/TINKERPOP-2480] which add a user > agent which is sent as a request header during web socket handshakes. > Originally 2480 was planned to also include the server accepting user agents > from http requests but this has now fallen outside of the scope. This ticket > is to complete the user agent feature by adding the ability for the server to > accept user agents in http requests in addition to web sockets. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (TINKERPOP-2830) Handle User-Agent from HTTP Requests to server
[ https://issues.apache.org/jira/browse/TINKERPOP-2830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17787325#comment-17787325 ] ASF GitHub Bot commented on TINKERPOP-2830: --- Cole-Greer merged PR #2328: URL: https://github.com/apache/tinkerpop/pull/2328 > Handle User-Agent from HTTP Requests to server > -- > > Key: TINKERPOP-2830 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2830 > Project: TinkerPop > Issue Type: Improvement > Components: server >Affects Versions: 3.5.4 >Reporter: Cole Greer >Priority: Critical > > Changes are being introduced in > [2480|https://issues.apache.org/jira/browse/TINKERPOP-2480] which add a user > agent which is sent as a request header during web socket handshakes. > Originally 2480 was planned to also include the server accepting user agents > from http requests but this has now fallen outside of the scope. This ticket > is to complete the user agent feature by adding the ability for the server to > accept user agents in http requests in addition to web sockets. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (TINKERPOP-3017) Simplify TraversalSource creation from AnonymousTraversalSource
Stephen Mallette created TINKERPOP-3017:
---
Summary: Simplify TraversalSource creation from
AnonymousTraversalSource
Key: TINKERPOP-3017
URL: https://issues.apache.org/jira/browse/TINKERPOP-3017
Project: TinkerPop
Issue Type: Improvement
Components: process
Affects Versions: 3.6.5
Reporter: Stephen Mallette
Currently {{traversal()}} makes the user choose {{withRemote()}} or
{{withEmbedded()}}. We could simplify by just making it {{with()}} and
deprecating the old stuff. Also remove the long deprecated {{withGraph()}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
