[jira] [Created] (TINKERPOP-2077) VertexProgram.Builder should have a default create() method with no Graph
Philip Graff created TINKERPOP-2077: --- Summary: VertexProgram.Builder should have a default create() method with no Graph Key: TINKERPOP-2077 URL: https://issues.apache.org/jira/browse/TINKERPOP-2077 Project: TinkerPop Issue Type: Improvement Affects Versions: 3.2.10, 3.3.4 Reporter: Philip Graff Fix For: 3.2.10 The VertexProgram.Builder interface has a create(Graph) method, however, the Graph is not always needed. This is illustrated by The GraphComputerTest class with VertexProgramQ and VertexProgramR that both implement create() methods that pass in a null Graph. The Builder should just have this as a default method that will then be inherited by the AbstractVertexProgramBuilder and any subsequent builders that use the abstract class or interface. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1888) Extend max and min to all Comparable properties, not just Numbers
[ https://issues.apache.org/jira/browse/TINKERPOP-1888?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16371800#comment-16371800 ] Philip Graff commented on TINKERPOP-1888: - Sounds reasonable. It looks like TINKERPOP-1777 hasn't been resolved yet - is that planned to be part of 3.2.8/3.3.2? And then this would build on top of that for 3.4.0? Maybe it's best to roll it all into one update since you're already having to modify these functions? Thanks! > Extend max and min to all Comparable properties, not just Numbers > - > > Key: TINKERPOP-1888 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1888 > Project: TinkerPop > Issue Type: Improvement > Components: process >Affects Versions: 3.2.7 >Reporter: Philip Graff >Assignee: Daniel Kuppitz >Priority: Major > > Currently, min() and max() only operate on properties that extend Number. > However, these should be able to be applied to anything which implements > Comparable as they are well-defined for those, too. Other steps like mean() > and sum() should stay just for Numbers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (TINKERPOP-1888) Extend max and min to all Comparable properties, not just Numbers
Philip Graff created TINKERPOP-1888: --- Summary: Extend max and min to all Comparable properties, not just Numbers Key: TINKERPOP-1888 URL: https://issues.apache.org/jira/browse/TINKERPOP-1888 Project: TinkerPop Issue Type: Improvement Reporter: Philip Graff Currently, min() and max() only operate on properties that extend Number. However, these should be able to be applied to anything which implements Comparable as they are well-defined for those, too. Other steps like mean() and sum() should stay just for Numbers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1861) VertexProgram create with varargs for Graphs
[ https://issues.apache.org/jira/browse/TINKERPOP-1861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16310259#comment-16310259 ] Philip Graff commented on TINKERPOP-1861: - PR submitted: https://github.com/apache/tinkerpop/pull/768 > VertexProgram create with varargs for Graphs > > > Key: TINKERPOP-1861 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1861 > Project: TinkerPop > Issue Type: Improvement > Components: process >Affects Versions: 3.2.7 >Reporter: Philip Graff >Priority: Minor > > VertexProgram.Builder.create(Graph) can be modified to > VertexProgram.Builder.create(Graph...) so that passing in zero or many graphs > is naturally handled. The current state of passing in null when no graph is > needed is bad practice. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (TINKERPOP-1862) TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH
Philip Graff created TINKERPOP-1862: --- Summary: TinkerGraph VertexProgram message passing doesn't work properly when using Direction.BOTH Key: TINKERPOP-1862 URL: https://issues.apache.org/jira/browse/TINKERPOP-1862 Project: TinkerPop Issue Type: Bug Reporter: Philip Graff I think the messages are being sent properly in TinkerMessenger, but when I call messenger.receiveMessages(), the vertex is getting messages from the outVertex of their edges regardless of the edge direction. This is due to line 71 of TinkerMessenger (linked below) which calls Edge.vertices(direction).next(), thus getting the first result out of the Vertex iterator. For IN or OUT, this isn't a problem. But for BOTH, following line 124 of TinkerEdge (linked below), the outVertex is always returned first. TinkerMessenger needs to be modified to return the correct vertex (I think it's the one that != this.vertex). https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/process/computer/TinkerMessenger.java#L71 https://github.com/apache/tinkerpop/blob/master/tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerEdge.java#L124 -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (TINKERPOP-1861) VertexProgram create with varargs for Graphs
Philip Graff created TINKERPOP-1861: --- Summary: VertexProgram create with varargs for Graphs Key: TINKERPOP-1861 URL: https://issues.apache.org/jira/browse/TINKERPOP-1861 Project: TinkerPop Issue Type: Improvement Reporter: Philip Graff Priority: Minor VertexProgram.Builder.create(Graph) can be modified to VertexProgram.Builder.create(Graph...) so that passing in zero or many graphs is naturally handled. The current state of passing in null when no graph is needed is bad practice. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
