[GitHub] tinkerpop issue #470: TINKERPOP-887 Conversion of FastNoSuchElementException...
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/470 looks good and is a nice addition *I will definitely enjoy this* : VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #472: TINKERPOP-1508: Add choose(predicate,trueTraversal)
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/472 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #451: TINKERPOP-1458 Gremlin Server doesn't return confirmat...
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/451 Hmm do we know why's travis is choking? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #450: Javascript GLV
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/450
Nice PR @jorgebay
Can you elaborate on why you went for `list()` and `one()` rather than
keeping the original method names of `toList()` and `next()`? I understand that
they would still have to require callbacks but I guess the point I'm trying to
make is that it would probably be better to stick to the original naming to
stay consistent with gremlin documentation, and then document the variations in
a JS GLV specific documentation.
So :
```javascript
g.V().hasLabel('software').toList((err, vertices) => {
vertices.forEach(console.log);
});
g.V().has('name','marko').next((err, vertex) => {
console.log(vertex.label); // person
});
```
Thoughts?
Also, you mentioned not including the Driver because Javascript engines
does not provide a standard IO library. What would your suggestion be here? Was
that just an invitation for the community to figure out if we should use an
existing library or write a new driver?
Do you have any insight here in regards to something like
[gremlin-javascript](https://github.com/jbmusso/gremlin-javascript)? (minus
that it's not
ECMAScript5 native and doesn't currently support ByteCode).
Anyways, I think we would proceed to rewrite a minimal version for the GLV
anyways.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/439 I'm currently on some ressource intensive tasks so it's hard for me to bounce back and forth between projects but I would like to give this a run on ubuntu 14.04. I suspect that sysV might work out of the box with a simple change in commands. Will give this a spin asap. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/439 Just confirming that although ubuntu 14.04 has `systemd` it does not have `systemd-as-init` . So an upstart would be a good idea and should be relatively easy since this PR seems to be thorough. Question is, do we make a separate PR for this or not? Also maybe we should add some more documentation around this (instead of only having the upgrade docs)? Like in the gremlin-server section. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #439: TINKERPOP-980: added sysv and systemd init scripts
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/439 Should we add upstart to this PR? I'm not sure if the systemd covers older versions of ubuntu. Namely 14.04LTS ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #433: TINKERPOP-1249 Add keep-alive functionality to websock...
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/433 VOTE +1 I get the pinging as well. Looks good. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #424: TINKERPOP-1451 TinkerGraph persistence cannot handle a...
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/424 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #418: Fixed issue in NumberSerializer that could cause integ...
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/418 What's the test status on this GLV? Could it be possible to add tests for this case? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #425: Fixed behavior of has() methods
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/425 Docs were clear, change is straightforward and tested this manually: VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #412: TINKERPOP-1442 Improved session cleanup on client clos...
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/412 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #413: TINKERPOP-1442 Improved session cleanup on client clos...
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/413 VOTE +1 this is a nice fix to have. Unit tests passed for me too. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #399: TINKERPOP-1369 Renamed REST API to HTTP API
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/399 +1 from me :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #390: GraphSON 2.0 Deser tweaks and improvements
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/390 Hmmm. I haven't seen this crop up since it was fixed by upgrading Jackson to `2.7.2`. Though originally my issue was related to the serializing and not deserializing so there may be something else at play. What's weird is that in travis' environment this doesn't seem to be an issue. Have you tried with the docker image? Do you still get errors there? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #390: GraphSON 2.0 Deser tweaks and improvements
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/390 Is the difference in behavior on `Tree` between both of you because of some lingering older version of jackson (shaded) in your local maven repo? Thought this should have been fixed a while back and travis hasn't been chocking so far? Also, are we certain `Tree` is going to fit all needs? I don't have much visibility here, dunno how this plays into other implementations. Cheers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #387: TINKERPOP-1386 Bumped to Netty 4.0.40.final
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/387 Straightforward enough and tests pass so VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #386: TINKERPOP-1274: GraphSON 2.0 [revised]
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/386 Ok cool if we're all ok with the new features then I'm satisfied. Code looked good as well VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #386: TINKERPOP-1274: GraphSON 2.0 [revised]
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/386 I'm waiting to hear back from marko on the points he brought up to cast my vote :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #386: TINKERPOP-1274: GraphSON 2.0 [revised]
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/386 Still reviewing I would like to finish going through the code :) will try and do this later in the day. But looking good so far --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #386: TINKERPOP-1274: GraphSON 2.0 [revised]
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/386 I'm liking how this has turned out. I personally don't have much of an opinion in regards to assuming gremlin is the default namespace and getting rid of `g:` though it does have the merit of being self documenting. I don't know how much of a size difference this would represent. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #384: TINKERPOP-1037 Made life more colorful
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/384 awesome!! VOTE: +1 from me as well --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #383: TINKERPOP-1246 Added help message to console
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/383 I'm personally ok with the concept. It seems pretty mainstream and will definitely help some folk. It's the kind of thing that you don't really pick up from reading the documentation (at least I don't) I know it's there from keeping up with the mailing list but otherwise I wouldn't have a clue. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #382: TINKERPOP-989 Add a landing page for documentation.
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/382 +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #373: TINKERPOP-1151 Made a number of changes to logging dep...
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/373 Code looks straight forward. VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #365: Tp31: Minor word and link cleanup
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/365 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #362: Minor word and link cleanup
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/362 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #364: tweaks in gremlin language variants doc
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/364 Thanks for this @aholmberg . I'm guessing this will be CTRed but I'll give it my +1 just in case. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #351: TINKERPOP-1274: GraphSON 2.0.
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/351 ok I caught up and checked code. I think what @robertdale suggests on the typing end would be really nice (`int64`, `int32`, etc). But we can keep that for the thread stephen linked to. I VOTE +1 on this. @spmallette if you could just add a mention in the documentation that the basic types are based off of the JVM types that would be a nice bonus to have. Nice work @newkek, some nice effort went into this. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #351: TINKERPOP-1274: GraphSON 2.0.
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/351 Ok I thought The main point here was robustness in typing for non-java languages. Hence why I suggested even typing things like Int and using java classes. Honestly depending on how you compiled your PHP your basic JSON int will be converted to `Long`. And that's the case I was highlighting. It makes sense to ignore this if you're trying to reduce de payload but we'll still be lacking on the non-lossiness end. >As I see it for how I implemented the TypeDeserializer, it acts as a meta deserializer that will read the raw text JSON sequentially, so there's no chance there can be a mixup in the order You can't guaranty that the order would be maintained in some languages hence my previous comment. These languages will parse the JSON into `List` then check the list and Map along the lines of what I said in my previous post. It would be much more efficient to simply have JSON cast to `Map` and run a simple check on keys. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #351: TINKERPOP-1274: GraphSON 2.0.
Github user PommeVerte commented on the issue:
https://github.com/apache/tinkerpop/pull/351
Hey guys,
I've been super busy lately but I definitely plan on diving deep into this
PR over the weekend. One quick remark though.
1. Even the JSON supported types are not prone to lossiness in multi
language settings. They should also be typed.
2. In a multi language setting, having type names without their java
classes is not helpful.
I can illustrate both of these points with the following JSON : `{"id":1}`
The client assumes `id` is `int` but what exactly is an int? is it `16bit`,
`32bit`, or `64bit`? Languages will have their own definition here. Actually
some languages will even have different values of `int` depending on how they
were compiled.
Changing it to `{"id":[{"@class":"Integer"}, 1]}` is not helpful in this
case either. However the following is explicit and is something you can work
with: `{"id":[{"@class":"java.lang.Integer"}, 1]}`. It's immediately
identifiable and well documented. The client knows this is a 32bit Int and can
work accordingly. Without this you would have to go through documentation or
code to figure out what you were dealing with.
In conclusion:
1. Thinking about it some more it's possible that Integer is the only
special case that would need typing in the json supported types. I'll give it
some more though. We could possibly have a "verbose" option for those who
require typing of everything.
2. Type names should refer to the java class. This also seems to make sense
when dealing with custom objects.
PS: I would also like to point out that this format
`[{"@class":"java.lang.Integer"}, 1]` can be a pain in systems that do not
necessarily order lists. With these systems you need to check that your list
has two elements, that one is a map, and that the map contains a `@class` key.
Costly operation.
Perhaps `{"@class":"java.lang.Integer", "value": 1}` is a better option.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #337: TINKERPOP-1332: Improve .explain() Dialogue
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/337 duh I totally missed that line when looking through the changes. Late to the party >.< --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #337: TINKERPOP-1332: Improve .explain() Dialogue
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/337 Jline should have some support for obtaining terminal width though it might not be all that reliable : ```java jline.TerminalFactory.get().getWidth(); ``` I think the above might fail in some instances such as resizing the window after launching the app, or if the users are using a shell that doesn't support some column global envs. So falling back to 75 might be a good approach if the above doesn't return a width. This looks good. VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #333: if there is no edge label in the GraphML file, then us...
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/333 Simple enough, looks good VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1308 Allow Serializati...
Github user PommeVerte commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/321#issuecomment-221967886 Yeah that's a +1 from me :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] incubator-tinkerpop pull request: TINKERPOP-1308 Allow Serializati...
Github user PommeVerte commented on the pull request: https://github.com/apache/incubator-tinkerpop/pull/321#issuecomment-221967095 Had a look through the changes. Noticed you add a 'lite' `path` Serializer, does `tree` get serialized properly as well? I kind of expect it to since it leverages `vertex`/`edge` serialization but thought I would double check that with you. Appart from that one question it's looking tight. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
