[jira] [Commented] (TINKERPOP-1392) Remove support for java serialized Traversal
[
https://issues.apache.org/jira/browse/TINKERPOP-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15591276#comment-15591276
]
Ramzi Oueslati commented on TINKERPOP-1392:
---
Sorry Stephen. My mistake.
I upgraded to 3.2.2 and had a few problems and I though it was related.
> Remove support for java serialized Traversal
>
>
> Key: TINKERPOP-1392
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1392
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.2.1
>Reporter: stephen mallette
>Assignee: stephen mallette
> Labels: breaking
> Fix For: 3.2.2
>
>
> Given TINKERPOP-1278 and {{Bytecode}} serialization of a {{Traversal}} the
> old method of serializing {{Traversal}} with java serialization isn't that
> useful. There seems to be little point in deprecating that functionality
> because the only library that supports that protocol is gremlin-driver which
> will now use the new approach. Dropping it completely wouldn't break anyone's
> code though we still should consider it a "breaking" change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1392) Remove support for java serialized Traversal
[
https://issues.apache.org/jira/browse/TINKERPOP-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588699#comment-15588699
]
Ramzi Oueslati commented on TINKERPOP-1392:
---
We use a JMeter websocket plugin and send gremlin requests.
Here is a example of JSON sent through the websocket :
{ "requestId":"1d6d02bd-8e56-421d-9438-3bd6d0079ff1",
"op":"eval",
"processor":"",
"args":{"gremlin":"g.V(someNode)",
"bindings":{"someNode":"someValue"},
"language":"gremlin-groovy"}
}
> Remove support for java serialized Traversal
>
>
> Key: TINKERPOP-1392
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1392
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.2.1
>Reporter: stephen mallette
>Assignee: stephen mallette
> Labels: breaking
> Fix For: 3.2.2
>
>
> Given TINKERPOP-1278 and {{Bytecode}} serialization of a {{Traversal}} the
> old method of serializing {{Traversal}} with java serialization isn't that
> useful. There seems to be little point in deprecating that functionality
> because the only library that supports that protocol is gremlin-driver which
> will now use the new approach. Dropping it completely wouldn't break anyone's
> code though we still should consider it a "breaking" change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1392) Remove support for java serialized Traversal
[
https://issues.apache.org/jira/browse/TINKERPOP-1392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15588621#comment-15588621
]
Ramzi Oueslati commented on TINKERPOP-1392:
---
Hi
What if we use JMeter to run tests against Gremlin Server (JMeter does not use
gremlin driver) ?
> Remove support for java serialized Traversal
>
>
> Key: TINKERPOP-1392
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1392
> Project: TinkerPop
> Issue Type: Improvement
> Components: server
>Affects Versions: 3.2.1
>Reporter: stephen mallette
>Assignee: stephen mallette
> Labels: breaking
> Fix For: 3.2.2
>
>
> Given TINKERPOP-1278 and {{Bytecode}} serialization of a {{Traversal}} the
> old method of serializing {{Traversal}} with java serialization isn't that
> useful. There seems to be little point in deprecating that functionality
> because the only library that supports that protocol is gremlin-driver which
> will now use the new approach. Dropping it completely wouldn't break anyone's
> code though we still should consider it a "breaking" change.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (TINKERPOP-1351) Number of connections going beyond the pool max size
[
https://issues.apache.org/jira/browse/TINKERPOP-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358700#comment-15358700
]
Ramzi Oueslati commented on TINKERPOP-1351:
---
OK I will
> Number of connections going beyond the pool max size
>
>
> Key: TINKERPOP-1351
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1351
> Project: TinkerPop
> Issue Type: Bug
> Components: driver
>Affects Versions: 3.1.2-incubating
> Environment: RESTful web service using gremlin driver to send request
> to a Gremlin Server
>Reporter: Ramzi Oueslati
>Assignee: stephen mallette
> Fix For: 3.1.3, 3.2.1
>
>
> When the gremlin driver is used with an important number of concurrent
> requests, sockets are opened far beyond the max pool size.
> At some point, the connections are destroyed, the pool is empty and then the
> borrowConnection process goes through :
> {code:java}
> if (connections.isEmpty()) {
> logger.debug("Tried to borrow connection but the pool was empty
> for {} - scheduling pool creation and waiting for connection", host);
> for (int i = 0; i < minPoolSize; i++) {
> scheduledForCreation.incrementAndGet();
> newConnection();
> }
> return waitForConnection(timeout, unit);
> }
> {code}
> If many connections are borrowed at the same time then this code will
> schedule as many connections for creation.
> I added a check :
> {code:java}
> for (int i = 0; i < minPoolSize; i++) {
> if (scheduledForCreation.get() < minPoolSize) {
> scheduledForCreation.incrementAndGet();
> logger.debug("borrowConnection: [inc]
> scheduledForCreation=" + scheduledForCreation.get());
> newConnection();
> }
> }
> {code}
> It seems to solve the problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (TINKERPOP-1351) Number of connections going beyond the pool max size
[
https://issues.apache.org/jira/browse/TINKERPOP-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15358700#comment-15358700
]
Ramzi Oueslati edited comment on TINKERPOP-1351 at 7/1/16 9:29 AM:
---
OK I will
Thank you Stephen
was (Author: ramzi):
OK I will
> Number of connections going beyond the pool max size
>
>
> Key: TINKERPOP-1351
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1351
> Project: TinkerPop
> Issue Type: Bug
> Components: driver
>Affects Versions: 3.1.2-incubating
> Environment: RESTful web service using gremlin driver to send request
> to a Gremlin Server
>Reporter: Ramzi Oueslati
>Assignee: stephen mallette
> Fix For: 3.1.3, 3.2.1
>
>
> When the gremlin driver is used with an important number of concurrent
> requests, sockets are opened far beyond the max pool size.
> At some point, the connections are destroyed, the pool is empty and then the
> borrowConnection process goes through :
> {code:java}
> if (connections.isEmpty()) {
> logger.debug("Tried to borrow connection but the pool was empty
> for {} - scheduling pool creation and waiting for connection", host);
> for (int i = 0; i < minPoolSize; i++) {
> scheduledForCreation.incrementAndGet();
> newConnection();
> }
> return waitForConnection(timeout, unit);
> }
> {code}
> If many connections are borrowed at the same time then this code will
> schedule as many connections for creation.
> I added a check :
> {code:java}
> for (int i = 0; i < minPoolSize; i++) {
> if (scheduledForCreation.get() < minPoolSize) {
> scheduledForCreation.incrementAndGet();
> logger.debug("borrowConnection: [inc]
> scheduledForCreation=" + scheduledForCreation.get());
> newConnection();
> }
> }
> {code}
> It seems to solve the problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (TINKERPOP-1351) Nb of connections going beyond the pool max size
Ramzi Oueslati created TINKERPOP-1351:
-
Summary: Nb of connections going beyond the pool max size
Key: TINKERPOP-1351
URL: https://issues.apache.org/jira/browse/TINKERPOP-1351
Project: TinkerPop
Issue Type: Bug
Components: driver
Affects Versions: 3.2.0-incubating
Environment: RESTful web service using gremlin driver to send request
to a Gremlin Server
Reporter: Ramzi Oueslati
When the gremlin driver is used with an important number of concurrent
requests, sockets are opened far beyond the max pool size.
At some point, the connections are destroyed, the pool is empty and then the
borrowConnection process goes through :
{code:java}
if (connections.isEmpty()) {
logger.debug("Tried to borrow connection but the pool was empty for
{} - scheduling pool creation and waiting for connection", host);
for (int i = 0; i < minPoolSize; i++) {
scheduledForCreation.incrementAndGet();
newConnection();
}
return waitForConnection(timeout, unit);
}
{code}
If many connections are borrowed at the same time then this code will schedule
as many connections for creation.
I added a check :
{code:java}
for (int i = 0; i < minPoolSize; i++) {
if (scheduledForCreation.get() < minPoolSize) {
scheduledForCreation.incrementAndGet();
logger.debug("borrowConnection: [inc]
scheduledForCreation=" + scheduledForCreation.get());
newConnection();
}
}
{code}
It seems to solve the problem.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
