[GitHub] tinkerpop pull request #:

[analytically]

Github user analytically commented on the pull request:


https://github.com/apache/tinkerpop/commit/fbde4e2ae67b52ad56b4c33f8b3c7eb56a1a5fea#commitcomment-18861765
  
In gremlin-benchmark/pom.xml:
In gremlin-benchmark/pom.xml on line 73:
test?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #315: Remove dashes from labels and property keys

[analytically]

Github user analytically commented on the issue:

https://github.com/apache/tinkerpop/pull/315
  
The build error is unrelated to the changes in this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #:

[analytically]

Github user analytically commented on the pull request:


https://github.com/apache/tinkerpop/commit/1915fa531a5b3fb20b59d258313224864448ae0a#commitcomment-18135280
  
In 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Translator.java:
In 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/Translator.java
 on line 52:
Should it not be spelled bytecode? No capital c? 
https://en.wikipedia.org/wiki/Bytecode


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop pull request #332: if there is no edge label in the Grap...

[analytically]

Github user analytically commented on a diff in the pull request:

https://github.com/apache/incubator-tinkerpop/pull/332#discussion_r66219778
  
--- Diff: 
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphml/GraphMLReader.java
 ---
@@ -187,7 +187,9 @@ public void readGraph(final InputStream 
graphInputStream, final Graph graphToWri
 } else if (elementName.equals(GraphMLTokens.EDGE)) {
 final Object[] propsAsArray = 
edgeProps.entrySet().stream().flatMap(e -> Stream.of(e.getKey(), 
e.getValue())).toArray();
 final Object[] propsReady = 
edgeFeatures.willAllowId(edgeId) ? ElementHelper.upsert(propsAsArray, T.id, 
edgeId) : propsAsArray;
-edgeOutVertex.addEdge(edgeLabel, edgeInVertex, 
propsReady);
+
+   final String currentEdgeLabel = 
Optional.ofNullable(edgeLabel).orElse(Edge.DEFAULT_LABEL);
+edgeOutVertex.addEdge(currentEdgeLabel, 
edgeInVertex, propsReady);
--- End diff --

spacing a little off here


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-tinkerpop issue #328: TINKERPOP-1317: use graph class as root clas...

[analytically]

Github user analytically commented on the issue:

https://github.com/apache/incubator-tinkerpop/pull/328
  
Genius PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---