[GitHub] tinkerpop pull request #705: make TinkerGraph cloneable
GitHub user mpollmeier opened a pull request: https://github.com/apache/tinkerpop/pull/705 make TinkerGraph cloneable most people use tinkergraph for testing, and if there are traversals that manipulate the graph, it's useful to be able to clone it up front, especially for larger graphs. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mpollmeier/tinkerpop mp/tinkergraph-clone Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/705.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #705 commit b5c3c1171073d27ed1cda8b77a719b946aa4faaf Author: Michael Pollmeier Date: 2017-09-04T08:02:26Z make TinkerGraph cloneable --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #705: make TinkerGraph cloneable
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/705 That's very true. I just experimented with deep clones and it doesn't look straightforward * kryo can do it directly, but all referenced classes need a no-arg-constructor, and since there are some coming in from apache commons, it doesn't look like it's feasible. https://github.com/EsotericSoftware/kryo#copyingcloning * java's builtin ByteArrayOutputStream has a similar problem: all referenced classes need to be marked as `Serializable` * implementing `clone` for TinkerVertex, TinkerEdge, TinkerProperty etc. is hard because they all reference each other, i.e. you're in a chicken and egg situation. I guess we have two options: 1) accept that it's a shallow copy and add a comment, as you suggested 2) disregard this PR Thoughts? Any other ideas for making a deep copy? There's always the option to serialise it into graphml/graphson etc., but that's slow for large graphs. ---
[GitHub] tinkerpop issue #705: make TinkerGraph cloneable
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/705 Nice! And it does preserve the IDs as well. I'll update the PR. Thanks @spmallette ---
[GitHub] tinkerpop issue #705: make TinkerGraph cloneable
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/705 there we go @spmallette @robertdale ---
[GitHub] tinkerpop issue #705: make TinkerGraph cloneable
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/705 Ok gents, next iteration is ready for review: * addressed stephen's comments, rebased and changed target to tp32 * moved the impl to GraphHelper which lives next to ElementHelper in org.apache.tinkerpop.gremlin.structure.util. Note: I added a dependency with scope `test` to gremlin-core * updated CHANGELOG and upgrade docs ---
[GitHub] tinkerpop issue #705: make TinkerGraph cloneable
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/705 hmm, since I introduced a dependency from gremlin-core:test to tinkergraph-gremlin the build complains about a cyclic dependency. I thought that would have been fine, given that it's just a test dependency. Any suggestions how to best resolve that without scrapping the test? ---
[GitHub] tinkerpop pull request #715: change behaviour of repeat step to be depth fir...
GitHub user mpollmeier opened a pull request: https://github.com/apache/tinkerpop/pull/715 change behaviour of repeat step to be depth first search (DFS) OLTP traversals are normally DFS unless there is you use a barrier step. This wasn't the case for `repeat` though, and this PR fixes that. Related discussion: https://groups.google.com/forum/#!topic/gremlin-users/gLSLxH_K-wE You can merge this pull request into a Git repository by running: $ git pull https://github.com/mpollmeier/tinkerpop mp/make-repeat-step-dfs Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/715.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #715 commit c69ce5a67aea39d25dfbcbc7d545b54f0389109b Author: Michael Pollmeier Date: 2017-09-15T01:03:02Z change behaviour of repeat step to be depth first search (DFS) OLTP traversals are normally DFS unless there is you use a barrier step. This wasn't the case for `repeat` though, and this PR fixes that. Related discussion: https://groups.google.com/forum/#!topic/gremlin-users/gLSLxH_K-wE ---
[GitHub] tinkerpop issue #715: change behaviour of repeat step to be depth first sear...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/715 That's likely because of the RepeatUnrollStrategy, which kicks in when there's a foreseeable number of iterations. Needs to be changed as well I guess. -Original Message- From: Daniel Kuppitz To: apache/tinkerpop Cc: Michael Pollmeier , Author Sent: Sat, 16 Sep 2017 1:53 Subject: Re: [apache/tinkerpop] change behaviour of repeat step to be depth first search (DFS) (#715) Using the modern graph: ``` gremlin> g.V().emit().repeat(both()).times(3).limit(15).path() ==>[v[1]] ==>[v[1],v[3]] ==>[v[1],v[2]] ==>[v[1],v[4]] ==>[v[1],v[3],v[1]] ==>[v[1],v[3],v[1],v[3]] ==>[v[1],v[3],v[1],v[2]] ==>[v[1],v[3],v[1],v[4]] ==>[v[1],v[3],v[4]] ==>[v[1],v[3],v[4],v[5]] ==>[v[1],v[3],v[4],v[3]] ==>[v[1],v[3],v[4],v[1]] ==>[v[1],v[3],v[6]] ==>[v[1],v[3],v[6],v[3]] ==>[v[1],v[2],v[1]] ``` ^ This doesn't look like DFS to me. Row 3 and 4 should come much later. -- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/apache/tinkerpop/pull/715#issuecomment-329789246 ---
[GitHub] tinkerpop issue #715: change behaviour of repeat step to be depth first sear...
Github user mpollmeier commented on the issue:
https://github.com/apache/tinkerpop/pull/715
`emit` modifies the behaviour of the repeat traversal, and I am unsure why
that is. Let me explain what I know and hopefully you or someone else can fill
the blanks.
Let's take my toy graph `v5 <- v3 <- v1 <- v0 -> v2 -> v4 -> v6` since it's
easier to see where you are with a simple println of the vertex. Without emit,
this PR does what it's supposed to do: DFS. First the even numbers, then the
odds.
```
graph = TinkerGraph.open()
v0 = graph.addVertex("l0")
v1 = graph.addVertex("l1")
v2 = graph.addVertex("l1")
v3 = graph.addVertex("l2")
v4 = graph.addVertex("l2")
v5 = graph.addVertex("l3")
v6 = graph.addVertex("l3")
v0.addEdge("e", v2)
v2.addEdge("e", v4)
v4.addEdge("e", v6)
v0.addEdge("e", v1)
v1.addEdge("e", v3)
v3.addEdge("e", v5)
graph.traversal().V(v0).repeat(sideEffect{println("inside repeat at " +
it)}.out()).times(3)
inside repeat at v[0]
inside repeat at v[2]
inside repeat at v[4]
==>v[6]
inside repeat at v[1]
inside repeat at v[3]
==>v[5]
```
However if I add an `emit()` it becomes BFS again:
```
graph.traversal().V(v0).emit().repeat(sideEffect{println("inside repeat at
" + it)}.out()).times(3)
==>v[0]
inside repeat at v[0]
==>v[2]
inside repeat at v[2]
==>v[1]
inside repeat at v[1]
==>v[4]
inside repeat at v[4]
==>v[6]
==>v[3]
inside repeat at v[3]
==>v[5]
```
I tried to understand it in the debugger, and the core difference seems to
be the behaviour of `this.starts.hasNext()` in
`RepeatEndStep.standardAlgorithm`, which is an `ExpandableStepIterator`.
* without emit, `hasNext` finds that
`this.hostStep.getPreviousStep().hasNext()` is true, because it asks it's
`previousStep` (which is a `VertexStep(OUT)`), which in turns has some results
for `processNextStart`.
* with emit, the above chain returns false, which in turn leads to a
NoSuchElementException, which short-circuits and `while (true)` loop, which
results in losing DFS semantics.
I don't know where these different semantics derive from.
---
[GitHub] tinkerpop issue #705: make TinkerGraph cloneable
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/705 @spmallette addressed your comments. VOTE +1 ---
[GitHub] tinkerpop pull request #705: make TinkerGraph cloneable
Github user mpollmeier commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/705#discussion_r139550718 --- Diff: docs/src/upgrade/release-3.2.x-incubating.asciidoc --- @@ -88,6 +88,11 @@ to the list of locally computed clauses. See: link:https://issues.apache.org/jira/browse/TINKERPOP-1764[TINKERPOP-1764] +Clone a graph +^ --- End diff -- fixed ---
[GitHub] tinkerpop issue #705: make TinkerGraph cloneable
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/705 Thanks @spmallette. I already voted +1 above. Made those changes, merged (--no-ff) to tp32 and then merged tp32 to master (again --no-ff). ---
[GitHub] tinkerpop pull request #745: TINKERPOP-1830: fix race condition in TinkerInd...
GitHub user mpollmeier opened a pull request: https://github.com/apache/tinkerpop/pull/745 TINKERPOP-1830: fix race condition in TinkerIndex My colleage @fabsx00 discovered a race condition in tinkergraph's index creation. He fixed it by simply replacing `parallelStream` with `stream`. Quoting his analysis: > So, reading the code, you see that this.put is called in parallel, but that method seems to contain a race as get is called on the index, checked for null, and a subsequent write is performed. It still seems like using stream here fixes the problem we've been seeing, and the performance hit is not significant. Ticket: https://issues.apache.org/jira/browse/TINKERPOP-1830 After initial feedback I can backport this onto tp32. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mpollmeier/tinkerpop mp/1830-tinkergraph-index-race-condition Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/745.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #745 commit ca5aa798093b58833bf54d7a495a0928bca41555 Author: Fabian Yamaguchi Date: 2017-10-27T16:43:15Z patch for TinkerIndex ---
[GitHub] tinkerpop issue #745: TINKERPOP-1830: fix race condition in TinkerIndex
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/745 Agreed, that's a better solution @robertdale. Note that `putIfAbsent` is not generally thread safe, but since we use `ConcurrentHashMap` it should be. I'll amend the commit. ---
[GitHub] tinkerpop issue #745: TINKERPOP-1830: fix race condition in TinkerIndex
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/745 I made the same incorrect assumption. Fixed with your latest snippet and tested with our large testbase. No NPEs, no race conditions so far, looks good. VOTE +1 ---
[GitHub] tinkerpop issue #745: TINKERPOP-1830: fix race condition in TinkerIndex
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/745 Instead of marking them as final I simply dropped the assignment. Re tp32: yes, I also mentioned this in the description of the ticket. I've just squashed all commits and rebased onto tp32 ---
[GitHub] tinkerpop issue #745: TINKERPOP-1830: fix race condition in TinkerIndex
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/745 ok that's done. added a changelog entry, merged this branch into tp32 and merged tp32 into master. ---
[GitHub] tinkerpop issue #715: TINKERPOP-1822: change behaviour of repeat step to be ...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/715 @krlohnes thanks for jumping in! This is still an open issue for me, so I'll test your suggestion as soon as I find some time. Let me know how your testing goes, maybe we can get this one over the line. ---
[GitHub] tinkerpop pull request #838: TINKERPOP-1822: Add Depth First Search repeat s...
Github user mpollmeier commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r181282267
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/step/branch/RepeatStep.java
---
@@ -273,11 +314,37 @@ public RepeatEndStep(final Traversal.Admin traversal)
{
super(traversal);
}
+final LinkedList> stashedStarts = new
LinkedList<>();
+
+private Traverser.Admin nextStart(RepeatStep repeatStep) {
+if (repeatStep.searchAlgo.equals(SearchAlgo.BFS)) {
+return this.starts.next();
+} else {
+if (this.starts.hasNext()) {
+return this.starts.next();
+} else {
+return this.stashedStarts.pop();
+}
+}
+}
+
+@Override
+public boolean hasNext() {
+return super.hasNext() || this.stashedStarts.peek() != null;
--- End diff --
`this.stashedStarts.isEmpty()`
---
[GitHub] tinkerpop pull request #838: TINKERPOP-1822: Add Depth First Search repeat s...
Github user mpollmeier commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/838#discussion_r181282042
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java
---
@@ -496,6 +497,19 @@
return this.asAdmin().addStep(scope.equals(Scope.global) ? new
OrderGlobalStep<>(this.asAdmin()) : new OrderLocalStep<>(this.asAdmin()));
}
+/**
+ * Order the repeat step by depth first or breadth first
+ *
+ * @param algo either DFS or BFS
+ *
+ * @see http://tinkerpop.apache.org/docs/${project.version}/reference/#order-step";
target="_blank">Reference Documentation - Order Step
+ * @since 3.0.0-incubating
--- End diff --
`@since 3.3.3`
---
[GitHub] tinkerpop issue #715: TINKERPOP-1822: change behaviour of repeat step to be ...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/715 superseded by https://github.com/apache/tinkerpop/pull/838 ---
[GitHub] tinkerpop pull request #715: TINKERPOP-1822: change behaviour of repeat step...
Github user mpollmeier closed the pull request at: https://github.com/apache/tinkerpop/pull/715 ---
[GitHub] tinkerpop issue #838: TINKERPOP-1822: Add Depth First Search repeat step opt...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/838 If I run `mvn clean test` I also get heaps of compilation errors, but that's the same with master for me. E.g. ``` [ERROR] symbol: class JsonGenerator [ERROR] location: class org.apache.tinkerpop.gremlin.structure.io.graphson.TraversalSerializersV3d0.TraversalJacksonSerializer [ERROR] /home/mp/Projects/tinkerpop/tinkerpop3/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/TraversalSerializersV3d0.java:[74,99] cannot find symbol [ERROR] symbol: class SerializerProvider [ERROR] location: class org.apache.tinkerpop.gremlin.structure.io.graphson.TraversalSerializersV3d0.TraversalJacksonSerializer [ERROR] -> [Help 1] ``` Is that the same you're getting @krlohnes? If you just run `mvn clean install` as per http://tinkerpop.apache.org/docs/current/dev/developer/#building-testing it compiles fine (for me) and also runs tests which all pass, but then it stalls at `TinkerGraphProcessComputerTest`. [Travis](https://travis-ci.org/apache/tinkerpop/builds/366306070) reports four failed builds. Two of them time out, no idea what's going on there. The other two fail for a missing integration into .net and JS. Not really my cup of tea... Note: I also had to comment out `false` in `gremlin-core/pom.xml`. No idea what that is, but it runs into a NPE for me. @robertdale how do you normally run the tests, and how can we fix the .net/JS stuff? ---
[GitHub] tinkerpop pull request #589: provide examples where merge operator actually ...
GitHub user mpollmeier opened a pull request: https://github.com/apache/tinkerpop/pull/589 provide examples where merge operator actually has an impact see https://groups.google.com/d/msgid/gremlin-users/CD3873E8-F202-4717-92E4-700D6CA80603%40gmail.com I wasn't able to test the generated documentation locally because I don't have hadoop running. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mpollmeier/tinkerpop sack-doc-update Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/589.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #589 commit 8ab124d0eb355f60fb0e933e8b7ebb46e1c53253 Author: Michael Pollmeier Date: 2017-03-28T21:39:41Z provide examples where merge operator actually has an impact see https://groups.google.com/d/msgid/gremlin-users/CD3873E8-F202-4717-92E4-700D6CA80603%40gmail.com --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #589: provide examples where merge operator actually has an ...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/589 Interesting, yes I just did that and it did generate more docs, but not the reference documentation. I can't find it at least - where is it supposed to end up? The end of the console output suggests that after a successful build it tries to do something with openbsd and hadoop and it fails. Is that what triggers the doc generation? ``` [INFO] Reactor Summary: [INFO] [INFO] Apache TinkerPop .. SUCCESS [3:40.690s] [INFO] Apache TinkerPop :: Gremlin Shaded SUCCESS [28.007s] [INFO] Apache TinkerPop :: Gremlin Core .. SUCCESS [22.767s] [INFO] Apache TinkerPop :: Gremlin Test .. SUCCESS [16.600s] [INFO] Apache TinkerPop :: TinkerGraph Gremlin ... SUCCESS [2.069s] [INFO] Apache TinkerPop :: Gremlin Groovy SUCCESS [38.851s] [INFO] Apache TinkerPop :: Gremlin Driver SUCCESS [41.450s] [INFO] Apache TinkerPop :: Neo4j Gremlin . SUCCESS [9.500s] [INFO] Apache TinkerPop :: Gremlin Server SUCCESS [19.902s] [INFO] Apache TinkerPop :: Gremlin Python SUCCESS [8:42.556s] [INFO] Apache TinkerPop :: Hadoop Gremlin SUCCESS [2:18.967s] [INFO] Apache TinkerPop :: Spark Gremlin . SUCCESS [2:35.916s] [INFO] Apache TinkerPop :: Giraph Gremlin SUCCESS [1:21.021s] [INFO] Apache TinkerPop :: Gremlin Console ... SUCCESS [28.799s] [INFO] Apache TinkerPop :: Gremlin Archetype . SUCCESS [0.115s] [INFO] Apache TinkerPop :: Archetype - TinkerGraph ... SUCCESS [18.551s] [INFO] Apache TinkerPop :: Archetype - Server SUCCESS [0.162s] [INFO] Apache TinkerPop :: Gremlin Tools . SUCCESS [0.190s] [INFO] Apache TinkerPop :: Gremlin Benchmark . SUCCESS [34.424s] [INFO] Apache TinkerPop :: Gremlin Coverage .. SUCCESS [0.394s] [INFO] Apache TinkerPop :: Gremlin IO Test ... SUCCESS [0.923s] [INFO] [INFO] BUILD SUCCESS [INFO] [INFO] Total time: 23:03.212s [INFO] Finished at: Tue Mar 28 23:16:31 UTC 2017 [INFO] Final Memory: 180M/1098M [INFO] * Starting OpenBSD Secure Shell server sshd [ OK ] Error: A JNI error has occurred, please check your installation and try again Exception in thread "main" java.lang.NoClassDefFoundError: org/apache/hadoop/security/authorize/RefreshAuthorizationPolicyProtocol at java.lang.ClassLoader.defineClass1(Native Method) at java.lang.ClassLoader.defineClass(ClassLoader.java:763) at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142) at java.net.URLClassLoader.defineClass(URLClassLoader.java:467) at java.net.URLClassLoader.access$100(URLClassLoader.java:73) at java.net.URLClassLoader$1.run(URLClassLoader.java:368) at java.net.URLClassLoader$1.run(URLClassLoader.java:362) at java.security.AccessController.doPrivileged(Native Method) at java.net.URLClassLoader.findClass(URLClassLoader.java:361) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) at java.lang.Class.getDeclaredMethods0(Native Method) at java.lang.Class.privateGetDeclaredMethods(Class.java:2701) at java.lang.Class.privateGetMethodRecursive(Class.java:3048) at java.lang.Class.getMethod0(Class.java:3018) at java.lang.Class.getMethod(Class.java:1784) at sun.launcher.LauncherHelper.validateMainClass(LauncherHelper.java:544) at sun.launcher.LauncherHelper.checkAndLoadMain(LauncherHelper.java:526) Caused by: java.lang.ClassNotFoundException: org.apache.hadoop.security.authorize.RefreshAuthorizationPolicyProtocol at java.net.URLClassLoader.findClass(URLClassLoader.java:381) at java.lang.ClassLoader.loadClass(ClassLoader.java:424) at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331) at java.lang.ClassLoader.loadClass(ClassLoader.java:357) ... 19 more Error: Could not find or load main class org.apache.hadoop.hdfs.tools.GetConf Starting namenodes on [] localhost: Warning: Permanently added 'localhost' (ECDSA) to the list of k
[GitHub] tinkerpop issue #589: provide examples where merge operator actually has an ...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/589 ``` docker --version Docker version 17.03.0-ce, build 60ccb2265b ``` --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #589: provide examples where merge operator actually has an ...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/589 @robertdale I haven't run the tinkerpop docker before, so it did a fresh download of all the docker images @dkuppitz the docker daemon runs as root, if I read the output here correctly: ``` ps -ef|grep docker root 580 1 0 12:16 ?00:00:00 /usr/bin/dockerd -H fd:// root 642 580 0 12:16 ?00:00:00 docker-containerd -l unix:///var/run/docker/libcontainerd/docker-containerd.sock --metrics-interval=0 --start-timeout 2m --state-dir /var/run/docker/libcontainerd/containerd --shim docker-containerd-shim --runtime docker-runc ``` Anyway, these issues shouldn't stop the PR from getting merged. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #589: provide examples where merge operator actually has an ...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/589 @spmallette I'm also surprised, but not a docker expert. I'm happy to try out other stuff to get to the bottom of that problem, just let me know if you have some idea. @robertdale Re the examples without sack: I don't mind, they just didn't look very interesting to me. I just added them back in, same goes for withBulk --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #589: provide examples where merge operator actually has an ...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/589 @spmallette I simply assumed master should be the target, just changed it to tp32 (after rebasing the commit onto that branch and force pushing to my repo). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #589: provide examples where merge operator actually has an ...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/589 @robertdale thanks for checking. Must have happened during rebase. Here they are again. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #589: provide examples where merge operator actually has an ...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/589 @spmallette I don't have write access to this repository, can you either grant them to me or merge for me? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #589: provide examples where merge operator actually has an ...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/589 I've just contacted you on hipchat, that might be a better place for figuring out those access rights. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #589: provide examples where merge operator actually has an ...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/589 this was merged to tp32 and master and should have been closed automatically here, for some reason the sync-script didn't capture that. closing manually. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #589: provide examples where merge operator actually ...
Github user mpollmeier closed the pull request at: https://github.com/apache/tinkerpop/pull/589 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #604: TINKERPOP-1670 Maintain Traversal type information in ...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/604 VOTE +1 related: https://github.com/mpollmeier/gremlin-scala/issues/203 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #605: TINKERPOP-1671 Propagate exception to Future instead o...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/605 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #606: Corrected copy-paste error in until step for predicate...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/606 I spoke to @ml86 (we are colleagues) and we think that this error doesn't actually change the functionality. It only leads to computational overhead. But that makes it hard to write a test for. Since it's a very obvious copy/pasta error, I'd say let's just merge it as is. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #606: Corrected copy-paste error in until step for predicate...
Github user mpollmeier commented on the issue:
https://github.com/apache/tinkerpop/pull/606
In theory, yes. But it seems to behave fine as it is. Here's a scenario for
the gremlin-groovy shell:
```
g = TinkerGraph.open()
v0 = g.addVertex("x", 1)
v1 = g.addVertex("x", 2)
v2 = g.addVertex("x", 2)
v0.addEdge("edge", v1)
v1.addEdge("edge", v2)
g.traversal().V(v0.id).repeat(out()).until(has("x", 2)).path()
```
If `until` would incorrectly behave like `emit`, I would assume that we'd
see all three nodes in the path. Instead we only see v0 and v1, which is the
correct behavious for repeat/until. Is our scenario missing something?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] tinkerpop issue #615: TINKERPOP-1678: until(Predicate) is actually calling e...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/615 VOTE +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #606: Corrected copy-paste error in until step for predicate...
Github user mpollmeier commented on the issue: https://github.com/apache/tinkerpop/pull/606 Thanks Marko! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
