[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1075: Docker gremlin-server test script
I didn't want to say that we should do that now, but it would be the only option I see. Otherwise we would have to check out older commits to get test data for older versions which doesn't sound like a sane alternative to me. [ Full content available at: https://github.com/apache/tinkerpop/pull/1075 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1075: Docker gremlin-server test script
> What if you wanted to test 3.2.x server with a 3.4.x client? How do we access > the test data from 3.2.x to copy it over? You mean if the test data is version specific and therefore won't work with a 3.2.z server if we are on `master`? I guess for that to work we would have to actually publish test images to Docker Hub that already contain the test data. But that should also be easier to do if we already use `tinkerpop/gremlin-server` here as the base image instead of building a completely new Gremlin Server image. > Finally, what would this look like? ./docker/gremlin-server.sh --version > 3.2.9? Then without --version it uses the working copy? That sounds like a good idea to me, yes. It would make it possible to test different versions one after another by calling this script repeatedly with different versions. But being able to test older versions was really only a possibility I saw here. I don't think that we should tackle that with this PR. If we can simplify testing for the image built from the current branch, then that's already a great improvement in my opinion. [ Full content available at: https://github.com/apache/tinkerpop/pull/1075 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1075: Docker gremlin-server test script
Sounds good to me 👍 [ Full content available at: https://github.com/apache/tinkerpop/pull/1075 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1075: Docker gremlin-server test script
I think it would make sense to use a different env var here instead of `TINKERPOP_DOCKER_OPTS`. My `TINKERPOP_DOCKER_OPTS` looks like this: ```bash $ echo $TINKERPOP_DOCKER_OPTS --tmpfs /usr/src/tinkermem:exec,mode=0755,rw,noatime,size=2000m -p 8080:80 ``` The port mapping is necessary on Windows to be able to access the generated docs on Windows as Docker for Windows unfortunately doesn't support connecting to a Docker container via its IP. This also means that I have to overwrite this env var now to: ```bash TINKERPOP_DOCKER_OPTS="-p 45940:45940" ``` to get the integration tests working with this image. If we would use a different env var here, then I (and possibly other contributors with Windows machines) could use this script and also still our usual `docker/build.sh` script :) [ Full content available at: https://github.com/apache/tinkerpop/pull/1075 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
[GitHub] [tinkerpop] FlorianHockmann commented on pull request #1075: Docker gremlin-server test script
I haven't really looked into this image, but couldn't we use the gremlin-server image that we also publish to Docker Hub instead as a base image? This would have the nice advantage that we would use the image for testing that we are also publishing and we could also change the version to use an older image for the tests to test backwards compatibility. [ Full content available at: https://github.com/apache/tinkerpop/pull/1075 ] This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org
