[GitHub] [tinkerpop] spmallette commented on issue #964: TINKERPOP-2071: gremlin-python: g:Set graphson deserializer should return a python set

2018-10-22 Thread GitHub
Thanks for submitting thisTravis seems unhappy on the gremlin-python 
version of the buildcould you please have a look at that? Also, this looks 
like it needs a rebase now that we have the tp33 branch re-opened for 
development. That should get CHANGELOG setup for new entries. Please don't 
include the JIRA issue there - just a bullet point with your representation of 
what changed will suffice. 

[ Full content available at: https://github.com/apache/tinkerpop/pull/964 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[GitHub] [tinkerpop] spmallette commented on issue #964: TINKERPOP-2071: gremlin-python: g:Set graphson deserializer should return a python set

2018-10-23 Thread GitHub
I think there needs to be a documentation update too - i just noticed this:

http://tinkerpop.apache.org/docs/3.3.4/reference/#_limitations

[ Full content available at: https://github.com/apache/tinkerpop/pull/964 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[GitHub] [tinkerpop] spmallette commented on issue #964: TINKERPOP-2071: gremlin-python: g:Set graphson deserializer should return a python set

2018-10-26 Thread GitHub
I re-ran the travis build and the error is gone. probably a fluke of travis or 
something. I guess this is good now.  do you happen to know if there is a test 
for the alternative scenario somewhere (i.e. where a set becomes a list)?

[ Full content available at: https://github.com/apache/tinkerpop/pull/964 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org


[GitHub] [tinkerpop] spmallette commented on issue #964: TINKERPOP-2071: gremlin-python: g:Set graphson deserializer should return a python set

2018-10-29 Thread GitHub
I think this one is ok at this point - note the creation of 
https://issues.apache.org/jira/browse/TINKERPOP-2082 for other GLVs 

VOTE +1

[ Full content available at: https://github.com/apache/tinkerpop/pull/964 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org