[GitHub] tinkerpop issue #390: GraphSON 2.0 Deser tweaks and improvements
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/390 I think I understand the Tree issue better (not the solution, just the context of the PR). Merged the second commit as well. Made note of the limitation to deal with later. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #390: GraphSON 2.0 Deser tweaks and improvements
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/390 i merged the first of these two commits via cherry pick. let's sit on the other one for a bit. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #390: GraphSON 2.0 Deser tweaks and improvements
Github user newkek commented on the issue: https://github.com/apache/tinkerpop/pull/390 Seems like it is only on my machine... I think Stephen tried on the docker image ? Yes what I have seen so far is it happens at the moment we call `deserializationContext.findContextualValueDeserializer(typeFromId)` in `GraphSONTypeDeserializer` where the `typeFromId` is the type that has been constructed at init time with `TypeFactory.defaultInstance().constructType(Tree.class)`. I also see that for some reason I don't get, it happens to me only when the [Enums types](https://github.com/apache/tinkerpop/blob/TINKERPOP-1278/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/graphson/GraphSONModule.java#L131-L140) from the Traversal serialzers have been constructed as well. If I comment those lines, I've got no problem when doing constructType(Tree.class) like all the rest.. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #390: GraphSON 2.0 Deser tweaks and improvements
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/390 Hmmm. I haven't seen this crop up since it was fixed by upgrading Jackson to `2.7.2`. Though originally my issue was related to the serializing and not deserializing so there may be something else at play. What's weird is that in travis' environment this doesn't seem to be an issue. Have you tried with the docker image? Do you still get errors there? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #390: GraphSON 2.0 Deser tweaks and improvements
Github user newkek commented on the issue: https://github.com/apache/tinkerpop/pull/390 @PommeVerte I've seen indeed some issues on the Jackson GH issue tracker that were looking like what I see with `Tree` but all were resolver in Jackson 2.7.6, and even when removing my local "gremlin-shaded" jar and updating the Jackson databind to 2.7.6 I still see the issue on my computer... Have you had that kind of problem already? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #390: GraphSON 2.0 Deser tweaks and improvements
Github user PommeVerte commented on the issue: https://github.com/apache/tinkerpop/pull/390 Is the difference in behavior on `Tree` between both of you because of some lingering older version of jackson (shaded) in your local maven repo? Thought this should have been fixed a while back and travis hasn't been chocking so far? Also, are we certain `Tree` is going to fit all needs? I don't have much visibility here, dunno how this plays into other implementations. Cheers. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
