[GitHub] tinkerpop issue #571: TINKERPOP-1504 Added the property key to events for ne...
Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/571 Ran the docker build with tests, code reviewed the new test cases, they are quite thorough. Thanks @spmallette and @dkuppitz VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #571: TINKERPOP-1504 Added the property key to events for ne...
Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/571 Just amazed with TinkerPop, as usual. I saw last night @dkuppitz said he didn't have tests, then I check this morning, and boom! Tests and votes in place. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #571: TINKERPOP-1504 Added the property key to events for ne...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/571 i wasn't in a massive rush :smile: - just wanted to let you know i was going to hold off of merging until you've had a chance to review. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #571: TINKERPOP-1504 Added the property key to events for ne...
Github user pluradj commented on the issue: https://github.com/apache/tinkerpop/pull/571 Yeah, I started looking at it... you guys are so fast! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #571: TINKERPOP-1504 Added the property key to events for ne...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/571 @pluradj looks like i have enough votes here to merge, but since you created the original issue, could you give this a quick look to see if it satisfies your concerns. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #571: TINKERPOP-1504 Added the property key to events for ne...
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/571 VOTE +1. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop issue #571: TINKERPOP-1504 Added the property key to events for ne...
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/571 VOTE: +1 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---