[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/721 ^ [solved](https://github.com/apache/tinkerpop/commit/a86097d0823397f0485566e8fd5def7a82fb32f3). The `execute()` command was just missing a `waitFor()`, which sometimes led to a missing or incomplete / corrupt zip file. ---
[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/721 I know, this PR was closed long ago, but I just ran into this issue when building the docs using Docker: ``` * source: /usr/src/tinkerpop/docs/src/recipes/olap-spark-yarn.asciidoc target: /usr/src/tinkerpop/target/postprocess-asciidoc/recipes/olap-spark-yarn.asciidoc progress: [] 10% Last 10 lines of /usr/src/tinkerpop/target/postprocess-asciidoc/recipes/olap-spark-yarn.asciidoc: at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.apache.hadoop.io.retry.RetryInvocationHandler.invokeMethod(RetryInvocationHandler.java:191) at org.apache.hadoop.io.retry.RetryInvocationHandler.invoke(RetryInvocationHandler.java:102) at com.sun.proxy.$Proxy26.getApplicationReport(Unknown Source) at org.apache.hadoop.yarn.client.api.impl.YarnClientImpl.getApplicationReport(YarnClientImpl.java:430) at org.apache.spark.deploy.yarn.Client.getApplicationReport(Client.scala:265) at org.apache.spark.deploy.yarn.Client.monitorApplication(Client.scala:937) at org.apache.spark.scheduler.cluster.YarnClientSchedulerBackend$MonitorThread.run(YarnClientSchedulerBackend.scala:144) ERROR org.apache.spark.scheduler.cluster.YarnClientSchedulerBackend - Yarn application has already exited with state FAILED! ``` The docs build fine w/o Docker, so I guess it's something easy, like a missing dependency. Any idea @vtslab? ---
[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/721 I am fine with the PR now. Build server needs a check, though. ---
[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/721 Please do not merge yet, I just noticed two wrong links. I will correct this later in the week together with the tp33/master branch. Marc ---
[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/721 Thanks @pluradj for going the extra mile. ---
[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/721 There are two aspects to CHANGELOG - (1) developer notes on what was done and (2) JIRA tickets. You are really just responsible for (1) - it is typically a more descriptive explanation of everything that was added/modified. It is also usually more readable to a user, who may be perusing it (as opposed to the sometimes terse JIRA ticket titles). The JIRA tickets get added on release by the release manager, so you don't really need to reference JIRA tickets at all in the CHANGELOG yourself. So to fix up your PR you just need to remove the `Improvements` header and the JIRA ticket below it. As for your PR to master and 3.3.x, you don't have to adjust CHANGELOGjust leave your entries on 3.2.x - we assume that any fixes to 3.2.x fold are inclusive to 3.3.x and make reference to that in the CHANGELOG so that we don't duplicate the entries. Let me know if what I have written here isn't clear for some reason. ---
[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/721 Hi @spmallette, No problem, but it is unclear to me whether JIRA will also add items to the list then, apart from adding the section headings. Where will my two change items appear, for which item(s) should I add the JIRA issue number? And for the TP3.3 line (the other PR), should the two new items be in the 3.2 section, the 3.3 section, in both or in none? Cheers,Marc ---
[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/721 Added a minor note about CHANGELOG, but pending that little fix: VOTE +1 ---
[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/721 Your welcome. Thanks all for the initial suggestions on the dev list and the review comments above. ---
[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/721 Would be nice to see this PR rebased on the current `tp32/` as it won't build in Docker in its current state. ---
[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/721 VOTE +1 ---
[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...
Github user vtslab commented on the issue: https://github.com/apache/tinkerpop/pull/721 Could I assume a pseudo-hadoop cluster present during the integration test phase? I thought only the asciidoc processing had that. Anyway, breaking the spark-yarn option will be noticed through the docs processing, but hopefully not until hadoop-3 or spark-3. I´ll correct the TinkerPop naming, off course, and will also add a pointer to the gremlin-plugin-dependencies section of the spark-gremlin manifest file. ---
[GitHub] tinkerpop issue #721: TINKERPOP-1786 Recipe and missing manifest items for S...
Github user okram commented on the issue: https://github.com/apache/tinkerpop/pull/721 This is good stuff. Is it possible to write a test case for the work? Also, can you fix your documentation so its `TinkerPop` not `Tinkerpop` (camel case). ---
