[GitHub] tinkerpop issue #829: TINKERPOP-1888 Extend max and min to all Comparable pr...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/829 VOTE +1 ---
[GitHub] tinkerpop issue #829: TINKERPOP-1888 Extend max and min to all Comparable pr...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/829 VOTE +1 ---
[GitHub] tinkerpop issue #829: TINKERPOP-1888 Extend max and min to all Comparable pr...
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/829 I added some notes in the upgrade docs, rebases the branch and force-pushed it. ---
[GitHub] tinkerpop issue #829: TINKERPOP-1888 Extend max and min to all Comparable pr...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/829 yeah - i tend to think of upgrade docs as extending to more than just breaking changes. it should also include any new features that people might like to know about and that we want to call attention to ---
[GitHub] tinkerpop issue #829: TINKERPOP-1888 Extend max and min to all Comparable pr...
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/829 I thought about the upgrade docs, but felt like it's not necessary as existing working scenarios didn't change, we just allow more now. But, well, I can add something. ---
[GitHub] tinkerpop issue #829: TINKERPOP-1888 Extend max and min to all Comparable pr...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/829 Perhaps this needs upgrade docs for 3.4.0 as well? I think it would be good to call attention to this change in behavior. ---
[GitHub] tinkerpop issue #829: TINKERPOP-1888 Extend max and min to all Comparable pr...
Github user PBGraff commented on the issue: https://github.com/apache/tinkerpop/pull/829 Thank you! ---
