[GitHub] tinkerpop issue #862: TINKERPOP-1961 Removed duplication of images in binari...
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/862 VOTE: +1 ---
[GitHub] tinkerpop issue #862: TINKERPOP-1961 Removed duplication of images in binari...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/862 I walked through the actual release process and this time I do see the correct packaging. VOTE +1 ---
[GitHub] tinkerpop issue #862: TINKERPOP-1961 Removed duplication of images in binari...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/862 I dunno man - here's a fast way to test which I just went through: 1. `bin/process-docs.sh --dryRun` - check `target/docs/htmlsingle` - should just have `images/` directory there. 1. `mvn package -pl gremlin-server -DskipTests` 1. look at `gremlin-server/target/apache-tinkerpop-gremlin-server-x.y.z-standalone` as that is used to build the zip - should just have `docs/images/` 1. the zip is in there too to check and looks ok to me ---
[GitHub] tinkerpop issue #862: TINKERPOP-1961 Removed duplication of images in binari...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/862 I did: 1. `bin/process-docs.sh` 2. `mvn install` 3. `find . -name '*.zip'` 4. `unzip -t ./gremlin-server/target/apache-tinkerpop-gremlin-server-3.2.9-distribution.zip | grep images` I don't see any images 3. `mvn deploy` I can see the maven-assembly-plugin rebuild the zip file. Still don't see any images in any zips ---
[GitHub] tinkerpop issue #862: TINKERPOP-1961 Removed duplication of images in binari...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/862 Confirmed that once you do `bin/process-docs.sh` it generates just the `/images` directory to the right place without `/static/images`. To get that into the zip distributions you need to go an extra step and do `mvn install` (during release this occurs during `mvn deploy`). The zip distributions are much smaller now. ---
[GitHub] tinkerpop issue #862: TINKERPOP-1961 Removed duplication of images in binari...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/862 hmm - let me try testing in a more round-trip way. i thought i had it figured out with my more surgical testing. ---
[GitHub] tinkerpop issue #862: TINKERPOP-1961 Removed duplication of images in binari...
Github user robertdale commented on the issue: https://github.com/apache/tinkerpop/pull/862 After running `bin/process-docs.sh` the resulting console/server zip files no longer contain `docs/` let alone `images`. Is there a different step that needs to be run? ---
