[GitHub] tinkerpop issue #928: TINKERPOP-2015 Expose WebSocket configuration in Greml...
Github user jantzeca commented on the issue: https://github.com/apache/tinkerpop/pull/928 @spmallette Okay, thank you! ---
[GitHub] tinkerpop issue #928: TINKERPOP-2015 Expose WebSocket configuration in Greml...
Github user spmallette commented on the issue: https://github.com/apache/tinkerpop/pull/928 @jantzeca this merged a day or so ago. it has not been released yet to nuget. we have releases scheduled for 3.2.10 and 3.3.4 in the next couple of weeks. it will be available then. ---
[GitHub] tinkerpop issue #928: TINKERPOP-2015 Expose WebSocket configuration in Greml...
Github user jantzeca commented on the issue: https://github.com/apache/tinkerpop/pull/928 My latest Gremlin.net NuGet package is showing as 3.3.3. Is the package for these new changes not ready yet? ---
[GitHub] tinkerpop issue #928: TINKERPOP-2015 Expose WebSocket configuration in Greml...
Github user FlorianHockmann commented on the issue:
https://github.com/apache/tinkerpop/pull/928
@deejvince: Did you see [the integration
test](https://github.com/apache/tinkerpop/blob/master/gremlin-dotnet/test/Gremlin.Net.IntegrationTest/Driver/GremlinClientTests.cs#L233)
added with this PR?
The relevant part is basically this:
```cs
var webSocketConfiguration =
new Action(options =>
{
options.UseDefaultCredentials = false;
options.KeepAliveInterval =
TimeSpan.FromMilliseconds(11);
});
var gremlinClient = new GremlinClient(gremlinServer,
webSocketConfiguration: webSocketConfiguration);
```
The `Action` you provide will be called for every `ClientWebSocket` created
by the driver of Gremlin.Net.
I haven't tested that specifically, but it should also be possible to set a
request header like this:
```cs
var webSocketConfiguration =
new Action(options =>
{
options.SetRequestHeader("Authorization", "Bearer " +
token);
});
```
Please report back if that doesn't work.
---
[GitHub] tinkerpop issue #928: TINKERPOP-2015 Expose WebSocket configuration in Greml...
Github user deejvince commented on the issue: https://github.com/apache/tinkerpop/pull/928 @FlorianHockmann Could you please post a working example on how to use the delegate with the driver connection with GremlinClient? ---
[GitHub] tinkerpop issue #928: TINKERPOP-2015 Expose WebSocket configuration in Greml...
Github user Pede23 commented on the issue: https://github.com/apache/tinkerpop/pull/928 I need this merged so I add authentication headers to my gremlin requests! I'm sure this will be extremely useful to anyone else trying to encrypt their connection with Amazon Neptune. VOTE +1 ---
[GitHub] tinkerpop issue #928: TINKERPOP-2015 Expose WebSocket configuration in Greml...
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/928 Hm, alright. I don't have an environment to test it myself, but apparently I'm missing something; I thought it would be a simple property delegation. VOTE +1 ---
[GitHub] tinkerpop issue #928: TINKERPOP-2015 Expose WebSocket configuration in Greml...
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/928 I also wanted to implement it like that as first, but unfortunately the [`ClientWebSocket.Options` property](https://docs.microsoft.com/dotnet/api/system.net.websockets.clientwebsocket.options) only has a `get`, but no `set`. So, we have no way to provide our own `ClientWebSocketOptions` object. I also don't see how we could forward changes to the `ClientWebSocketOptions` of every already created connection. ---
[GitHub] tinkerpop issue #928: TINKERPOP-2015 Expose WebSocket configuration in Greml...
Github user dkuppitz commented on the issue: https://github.com/apache/tinkerpop/pull/928 IMO it would be better to expose the options as a property unless there's a good reason to not allow any changes in options after the client has been initialized. But since the underlying `ClientWebSocket` allows a change in options at any point in time, `GremlinClient` should preferably do the same. ---
[GitHub] tinkerpop issue #928: TINKERPOP-2015 Expose WebSocket configuration in Greml...
Github user FlorianHockmann commented on the issue: https://github.com/apache/tinkerpop/pull/928 Yes, that should be possible. With this PR, you can provide a delegate to configure the ClientWebSocketOptions which should also include custom headers. ---
