[GitHub] tinkerpop pull request #336: TINKERPOP-1320 fix GremlinGroovyScriptEngineFil...
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/336 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #336: TINKERPOP-1320 fix GremlinGroovyScriptEngineFil...
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/336#discussion_r67174102 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoWriter.java --- @@ -131,7 +131,7 @@ public void writeVertexProperty(final OutputStream outputStream, final VertexPro public void writeProperty(final OutputStream outputStream, final Property p) throws IOException { final Output output = new Output(outputStream); writeHeader(output); -kryo.writeObject(output, DetachedFactory.detach(p, true)); --- End diff -- cool - something doesn't make sense in that {{GryoWriter}} - very weird looking. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
[GitHub] tinkerpop pull request #336: TINKERPOP-1320 fix GremlinGroovyScriptEngineFil...
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/336#discussion_r67157460 --- Diff: gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoWriter.java --- @@ -131,7 +131,7 @@ public void writeVertexProperty(final OutputStream outputStream, final VertexPro public void writeProperty(final OutputStream outputStream, final Property p) throws IOException { final Output output = new Output(outputStream); writeHeader(output); -kryo.writeObject(output, DetachedFactory.detach(p, true)); --- End diff -- that's weird as a standalone issue - @pluradj what did this change have to do with TINKERPOP-1320 ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---