[GitHub] tinkerpop pull request #363: TINKERPOP-1379 remove excess bulk in tail buffe...
Github user pluradj closed the pull request at: https://github.com/apache/tinkerpop/pull/363 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
Re: [GitHub] tinkerpop pull request #363: TINKERPOP-1379 remove excess bulk in tail buffe...
Thanks for the feedback, Marko. I'll try to come up with another reproduce scenario. Thanks! On Fri, Jul 22, 2016 at 8:09 AM, Marko A. Rodriguez wrote: > More info -- on vacation from ipad s -- dont make anew graph as you > have. Use modern or Grateful. this way olap will test too. order on age or > something like that to get the bulking. name you method like all other test > methods. in short yoy are doing too much and making your test too > complicated. you just need to get a bulk where the total sum of the tail is > greater than what is being tailed. > > Sent from my iPad > > > On Jul 21, 2016, at 5:36 PM, Marko A. Rodriguez > wrote: > > > > The teat method structure and naming convention is bad. Stephen can help > set it straight. > > > >> On Jul 20, 2016, at 12:40 PM, pluradj wrote: > >> > >> GitHub user pluradj opened a pull request: > >> > >> https://github.com/apache/tinkerpop/pull/363 > >> > >> TINKERPOP-1379 remove excess bulk in tail buffer > >> > >> https://issues.apache.org/jira/browse/TINKERPOP-1379 > >> > >> You can merge this pull request into a Git repository by running: > >> > >> $ git pull https://github.com/apache/tinkerpop TINKERPOP-1379 > >> > >> Alternatively you can review and apply these changes as the patch at: > >> > >> https://github.com/apache/tinkerpop/pull/363.patch > >> > >> To close this pull request, make a commit to your master/trunk branch > >> with (at least) the following in the commit message: > >> > >> This closes #363 > >> > >> > >> commit d43db2bb2f3f4988503f0cdedbd1877cd542c502 > >> Author: Jason Plurad > >> Date: 2016-07-20T16:31:53Z > >> > >> remove excess bulk in tail buffer > >> > >> > >> > >> > >> --- > >> If your project is set up for it, you can reply to this email and have > your > >> reply appear on GitHub as well. If your project does not have this > feature > >> enabled and wishes so, or if the feature is enabled but not working, > please > >> contact infrastructure at infrastruct...@apache.org or file a JIRA > ticket > >> with INFRA. > >> --- >
Re: [GitHub] tinkerpop pull request #363: TINKERPOP-1379 remove excess bulk in tail buffe...
More info -- on vacation from ipad s -- dont make anew graph as you have. Use modern or Grateful. this way olap will test too. order on age or something like that to get the bulking. name you method like all other test methods. in short yoy are doing too much and making your test too complicated. you just need to get a bulk where the total sum of the tail is greater than what is being tailed. Sent from my iPad > On Jul 21, 2016, at 5:36 PM, Marko A. Rodriguez wrote: > > The teat method structure and naming convention is bad. Stephen can help set > it straight. > >> On Jul 20, 2016, at 12:40 PM, pluradj wrote: >> >> GitHub user pluradj opened a pull request: >> >> https://github.com/apache/tinkerpop/pull/363 >> >> TINKERPOP-1379 remove excess bulk in tail buffer >> >> https://issues.apache.org/jira/browse/TINKERPOP-1379 >> >> You can merge this pull request into a Git repository by running: >> >> $ git pull https://github.com/apache/tinkerpop TINKERPOP-1379 >> >> Alternatively you can review and apply these changes as the patch at: >> >> https://github.com/apache/tinkerpop/pull/363.patch >> >> To close this pull request, make a commit to your master/trunk branch >> with (at least) the following in the commit message: >> >> This closes #363 >> >> >> commit d43db2bb2f3f4988503f0cdedbd1877cd542c502 >> Author: Jason Plurad >> Date: 2016-07-20T16:31:53Z >> >> remove excess bulk in tail buffer >> >> >> >> >> --- >> If your project is set up for it, you can reply to this email and have your >> reply appear on GitHub as well. If your project does not have this feature >> enabled and wishes so, or if the feature is enabled but not working, please >> contact infrastructure at infrastruct...@apache.org or file a JIRA ticket >> with INFRA. >> ---
Re: [GitHub] tinkerpop pull request #363: TINKERPOP-1379 remove excess bulk in tail buffe...
The teat method structure and naming convention is bad. Stephen can help set it straight. > On Jul 20, 2016, at 12:40 PM, pluradj wrote: > > GitHub user pluradj opened a pull request: > >https://github.com/apache/tinkerpop/pull/363 > >TINKERPOP-1379 remove excess bulk in tail buffer > >https://issues.apache.org/jira/browse/TINKERPOP-1379 > > You can merge this pull request into a Git repository by running: > >$ git pull https://github.com/apache/tinkerpop TINKERPOP-1379 > > Alternatively you can review and apply these changes as the patch at: > >https://github.com/apache/tinkerpop/pull/363.patch > > To close this pull request, make a commit to your master/trunk branch > with (at least) the following in the commit message: > >This closes #363 > > > commit d43db2bb2f3f4988503f0cdedbd1877cd542c502 > Author: Jason Plurad > Date: 2016-07-20T16:31:53Z > >remove excess bulk in tail buffer > > > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > ---
[GitHub] tinkerpop pull request #363: TINKERPOP-1379 remove excess bulk in tail buffe...
GitHub user pluradj opened a pull request: https://github.com/apache/tinkerpop/pull/363 TINKERPOP-1379 remove excess bulk in tail buffer https://issues.apache.org/jira/browse/TINKERPOP-1379 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1379 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/363.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #363 commit d43db2bb2f3f4988503f0cdedbd1877cd542c502 Author: Jason Plurad Date: 2016-07-20T16:31:53Z remove excess bulk in tail buffer --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---
