[GitHub] tinkerpop pull request #744: TINKERPOP-1802: hasId() fails for empty collect...

2017-11-07 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/744


---


[GitHub] tinkerpop pull request #744: TINKERPOP-1802: hasId() fails for empty collect...

2017-11-06 Thread okram
GitHub user okram opened a pull request:

https://github.com/apache/tinkerpop/pull/744

TINKERPOP-1802: hasId() fails for empty collections

https://issues.apache.org/jira/browse/TINKERPOP-1802

If `hasId([])` is specified, then an `ArrayOutOfBoundsException` occurs. 
This has been fixed by simply filtering out (`filter(true)` in essence) all 
vertices once a `hasId([])` is reached. cc/ @rjbriody 

VOTE +1.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1802

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/744.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #744


commit 74ca03dea1a7db7b2af39f46020cf8a75a2ea5c4
Author: Marko A. Rodriguez 
Date:   2017-11-06T21:36:22Z

fixed a hasId([]) ArrayOutOfBoundsException bug that occurs in the rare 
situation where a user provides an empty collection of ids. Test cases 
developed by @dkuppitz.




---