[GitHub] tinkerpop pull request #801: TINKERPOP-1862 TinkerMessenger proper handling ...
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/801 ---
[GitHub] tinkerpop pull request #801: TINKERPOP-1862 TinkerMessenger proper handling ...
Github user spmallette commented on a diff in the pull request: https://github.com/apache/tinkerpop/pull/801#discussion_r171238657 --- Diff: tinkergraph-gremlin/src/main/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerFactory.java --- @@ -149,6 +149,13 @@ public static void generateKitchenSink(final TinkerGraph graph) { g.addV("loops").property(T.id, 1000).property("name", "loop").as("me"). addE("self").to("me"). iterate(); +final String LABEL = "message_passing_test"; +final String EDGE_LABEL = "msg_pass_test_edge"; +final String PROPERTY_IN = "propertyin"; +Vertex a = graph.addVertex(T.id, 2000, T.label, LABEL, PROPERTY_IN, "a"); --- End diff -- all of these sample graphs need a "name" property of some sort. that's why the build is currently failing for me. please "final" the two `Vertex` variables. ---
[GitHub] tinkerpop pull request #801: TINKERPOP-1862 TinkerMessenger proper handling ...
GitHub user PBGraff opened a pull request: https://github.com/apache/tinkerpop/pull/801 TINKERPOP-1862 TinkerMessenger proper handling of Direction.BOTH New PR based off of #777 re-based on new head of tp32 branch. Need to update toy graph merged in #794 with scenario for this test and then update relevant tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/PBGraff/tinkerpop TINKERPOP-1862 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/801.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #801 commit f02ea338a8d039c50896f7c65ca57a695975fc43 Author: Graff, Philip B Date: 2018-01-04T18:27:44Z TinkerMessenger proper handling of Direction.BOTH commit 80c0b8465fe9bb6ddbe4522a36304c7ba054e909 Author: Graff, Philip B Date: 2018-01-14T02:32:29Z Adding simple graph computer test of proper message passing in all 3 directions commit 750677cf55d7445c3746870d86c6592f6cd3664d Author: Graff, Philip B Date: 2018-01-14T04:49:27Z Test cleanup - hopefully can run now commit 153238b2a8a3fc5e051251662ef6ab80f72c659f Author: Graff, Philip B Date: 2018-01-14T06:01:17Z Additional check. Tests still fail - but I think this is a problem with the implementations, not the test. commit 5467a33f2e17ad22b736effebede124556f049ed Author: Graff, Philip B Date: 2018-01-14T18:44:33Z Test bug fix and refactoring repeated code ---