[GitHub] tinkerpop pull request #855: TINKERPOP-1950 Cached global strategy lookups d...
Github user asfgit closed the pull request at: https://github.com/apache/tinkerpop/pull/855 ---
[GitHub] tinkerpop pull request #855: TINKERPOP-1950 Cached global strategy lookups d...
Github user spmallette commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/855#discussion_r184028279
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/TraversalStrategies.java
---
@@ -63,6 +63,8 @@
*/
public interface TraversalStrategies extends Serializable, Cloneable {
+static Set LOADED = new HashSet<>();
--- End diff --
ha - i was so excited that this changed worked i didn't bother to think too
hard about what i was doing. good suggestions in both cases - i've made those
changes now. thanks
---
[GitHub] tinkerpop pull request #855: TINKERPOP-1950 Cached global strategy lookups d...
Github user jorgebay commented on a diff in the pull request:
https://github.com/apache/tinkerpop/pull/855#discussion_r183959745
--- Diff:
gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/TraversalStrategies.java
---
@@ -63,6 +63,8 @@
*/
public interface TraversalStrategies extends Serializable, Cloneable {
+static Set LOADED = new HashSet<>();
--- End diff --
Shouldn't we use a collection that supports concurrent modification?
Different threads might be adding items to the collection.
Also, we could move the declaration to `GlobalCache`?.
---
[GitHub] tinkerpop pull request #855: TINKERPOP-1950 Cached global strategy lookups d...
GitHub user spmallette opened a pull request: https://github.com/apache/tinkerpop/pull/855 TINKERPOP-1950 Cached global strategy lookups during traversal construction https://issues.apache.org/jira/browse/TINKERPOP-1950 This change leads to a 1.5x to 2x speed improvement in traversal construction. It is especially effective when processing traversals that have many child traversals within them as this method is called for not only the parent traversal but all the children as well. All tests pass with `docker/build.sh -t -i` VOTE +1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/tinkerpop TINKERPOP-1950 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/tinkerpop/pull/855.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #855 commit d7d0aafc08cf8600b03d4d9d79ce52056d694a4f Author: Stephen Mallette Date: 2018-04-20T20:18:13Z TINKERPOP-1950 Cached global strategy lookups during traversal construction This change leads to a 1.5x to 2x speed improvement in traversal construction. It is especially effective when processing traversals that have many child traversals within them as this method is called for not only the parent traversal but all the children as well. ---
