[GitHub] tinkerpop pull request #928: TINKERPOP-2015 Expose WebSocket configuration i...

2018-10-03 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/928


---


[GitHub] tinkerpop pull request #928: TINKERPOP-2015 Expose WebSocket configuration i...

2018-09-09 Thread FlorianHockmann
GitHub user FlorianHockmann opened a pull request:

https://github.com/apache/tinkerpop/pull/928

TINKERPOP-2015 Expose WebSocket configuration in Gremlin.Net driver

https://issues.apache.org/jira/browse/TINKERPOP-2015

Users can now provide a delegate to the Gremlin.Net driver that will be 
used to configure WebSocket connections. Using a delegate for this has the 
advantage that it's extensible as the options available via 
[`ClientWebSocketOptions`](https://docs.microsoft.com/dotnet/api/system.net.websockets.clientwebsocketoptions)
 change between different .NET implementations, e.g., as mentioned in the 
ticket, a `RemoteCertificateValidationCallback` was added with .NET Core 2.1.

When #903 is merged first, then we need to add this new option also to the 
docs when merging this into `master` as #903 adds descriptions for the config 
options to the docs.

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-2015

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/928.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #928


commit 828b0503e4d0f0a9b21f89158bbef31de20ffa3a
Author: Florian Hockmann 
Date:   2018-09-09T12:49:03Z

Expose WebSocket configuration TINKERPOP-2015

Users can now provide a delegate to the Gremlin.Net driver that will be
used to configure WebSocket connections.




---