[jira] [Comment Edited] (TINKERPOP-1906) Make ResponseException explorable
[ https://issues.apache.org/jira/browse/TINKERPOP-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636683#comment-16636683 ] stephen mallette edited comment on TINKERPOP-1906 at 10/3/18 9:36 AM: -- This was added on TINKERPOP-1913 https://github.com/apache/tinkerpop/blob/b788201bfcc0bd4f2a5eb24a66d32be58d06583d/gremlin-dotnet/src/Gremlin.Net/Driver/Exceptions/ResponseException.cs#L57 was (Author: spmallette): This was added on TINKERPOP-1906 https://github.com/apache/tinkerpop/blob/b788201bfcc0bd4f2a5eb24a66d32be58d06583d/gremlin-dotnet/src/Gremlin.Net/Driver/Exceptions/ResponseException.cs#L57 > Make ResponseException explorable > - > > Key: TINKERPOP-1906 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1906 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Affects Versions: 3.2.7 >Reporter: Roman Kreisel >Assignee: stephen mallette >Priority: Major > Fix For: 3.4.0 > > Attachments: message.txt, stacktrace.txt > > > The ResponseException from Gremlin.NET doesn't give you any possibility to > react on the GremlinService's Response. The only content is the exception's > Message, which is just free text. > It would be great, to add some fields to expose at least the HTTP ErrorCode > or anything else that's responded by the service. > > Especially, if you're using Gremlin.NET with Azure's Cosmos DB, there's a > "Request Rate to Large" response, in case you have high load on your > database. In such a case, you want to be able to detect this "error" and just > retry after a few milliseconds (i'm not sure, but i think even a proposal for > this retry-timeout is given in the response) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (TINKERPOP-1906) Make ResponseException explorable
[ https://issues.apache.org/jira/browse/TINKERPOP-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16381019#comment-16381019 ] Ashwini Singh edited comment on TINKERPOP-1906 at 2/28/18 8:47 PM: --- In case of 429, Gremlin Response from Azure Cosmos DB contains ResponseStatusCode.ServerError(500) and exception details as the message, which includes details of 429 exceptions. At the Gremlin.Net driver side, you see the ResponseException because of the error code ResponseStatusCode.ServerError (500). Also, Cosmos DB adds more details in the ResponseStatus.Attributes. You can check that through tools like Fiddler. I agree with Florian, the change mentioned below is to expose these details and client can handle the rate limiting. [https://lists.apache.org/thread.html/fd2208a2db827bc1eb479ad8c2f181bd2fa532553c97b3fe6994a7b6@%3Cdev.tinkerpop.apache.org%3E] was (Author: ashwini singh): In case of 429, Gremlin Response from Azure Cosmos DB contains ResponseStatusCode.ServerError(500) and exception details as the message, which includes details of 429 exceptions. At the Gremlin.Net driver side, you see the ResponseException because of the error code ResponseStatusCode.ServerError (500). Also, Cosmos DB adds more details in the ResponseStatus.Attributes. You can check that through tools like Fiddler. I agree with Florian, the change mentioned [here|mailto:%20https://lists.apache.org/thread.html/fd2208a2db827bc1eb479ad8c2f181bd2fa532553c97b3fe6994a7b6@%3Cdev.tinkerpop.apache.org%3E] is to expose these details and client can handle the rate limiting. > Make ResponseException explorable > - > > Key: TINKERPOP-1906 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1906 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Affects Versions: 3.2.7 >Reporter: Roman Kreisel >Priority: Major > Attachments: message.txt, stacktrace.txt > > > The ResponseException from Gremlin.NET doesn't give you any possibility to > react on the GremlinService's Response. The only content is the exception's > Message, which is just free text. > It would be great, to add some fields to expose at least the HTTP ErrorCode > or anything else that's responded by the service. > > Especially, if you're using Gremlin.NET with Azure's Cosmos DB, there's a > "Request Rate to Large" response, in case you have high load on your > database. In such a case, you want to be able to detect this "error" and just > retry after a few milliseconds (i'm not sure, but i think even a proposal for > this retry-timeout is given in the response) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (TINKERPOP-1906) Make ResponseException explorable
[ https://issues.apache.org/jira/browse/TINKERPOP-1906?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16380930#comment-16380930 ] Roman Kreisel edited comment on TINKERPOP-1906 at 2/28/18 7:40 PM: --- Hi Florian, please find the exception's [^message.txt] and [^stacktrace.txt] attached to this comment. I just checked the sourcecode of [https://github.com/apache/tinkerpop/blob/master/gremlin-dotnet/src/Gremlin.Net/Driver/Messages/ResponseStatusCode.cs] and have to admit I don't quite understand why this exception has been thrown, but my debugger clearly tells me, it's a Gremlin.Net.Driver.Exceptions.ResponseException. And even in the exception's Text, you can read "BackendStatusCode : 429" I'm using the 3.3.2-rc1 of Gremlin.NET from NuGet was (Author: romankreisel): Hi Florian, please find the exception's [^message.txt] and [^stacktrace.txt] attached to this comment. I just checked the sourcecode of [https://github.com/apache/tinkerpop/blob/master/gremlin-dotnet/src/Gremlin.Net/Driver/Messages/ResponseStatusCode.cs] and have to admit, i don't quite understand why this exception has been thrown, but my debugger clearly tells me, it's a Gremlin.Net.Driver.Exceptions.ResponseException. And even in the exception's Text, you can read "BackendStatusCode : 429" I'm using the 3.3.2-rc1 of Gremlin.NET from NuGet > Make ResponseException explorable > - > > Key: TINKERPOP-1906 > URL: https://issues.apache.org/jira/browse/TINKERPOP-1906 > Project: TinkerPop > Issue Type: Improvement > Components: dotnet >Affects Versions: 3.2.7 >Reporter: Roman Kreisel >Priority: Major > Attachments: message.txt, stacktrace.txt > > > The ResponseException from Gremlin.NET doesn't give you any possibility to > react on the GremlinService's Response. The only content is the exception's > Message, which is just free text. > It would be great, to add some fields to expose at least the HTTP ErrorCode > or anything else that's responded by the service. > > Especially, if you're using Gremlin.NET with Azure's Cosmos DB, there's a > "Request Rate to Large" response, in case you have high load on your > database. In such a case, you want to be able to detect this "error" and just > retry after a few milliseconds (i'm not sure, but i think even a proposal for > this retry-timeout is given in the response) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
