[jira] [Commented] (TINKERPOP-1631) Fix visibility issues with the BindingsGremlinPlugin
[
https://issues.apache.org/jira/browse/TINKERPOP-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15880406#comment-15880406
]
ASF GitHub Bot commented on TINKERPOP-1631:
---
Github user asfgit closed the pull request at:
https://github.com/apache/tinkerpop/pull/558
> Fix visibility issues with the BindingsGremlinPlugin
>
>
> Key: TINKERPOP-1631
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1631
> Project: TinkerPop
> Issue Type: Improvement
> Components: plugin
>Affects Versions: 3.2.3
>Reporter: stephen mallette
>Assignee: stephen mallette
> Fix For: 3.2.5
>
>
> The whole aspect of applying bindings via plugin with the revised plugin
> system is a little sketchy/inconsistent.
> * Bindings should always be assigned to global scope because engine scope is
> always overriden with local bindings.
> * Bindings assigned by {{HadoopGremlinPlugin}} don't seem to want to appear
> in Gremlin Server.
> * There needs to be some form of mock {{GremlinScriptEngine}} that can be
> used to test plugins without having to depend on an actual implementation
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1631) Fix visibility issues with the BindingsGremlinPlugin
[
https://issues.apache.org/jira/browse/TINKERPOP-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879321#comment-15879321
]
ASF GitHub Bot commented on TINKERPOP-1631:
---
Github user dkuppitz commented on the issue:
https://github.com/apache/tinkerpop/pull/558
VOTE: +1
> Fix visibility issues with the BindingsGremlinPlugin
>
>
> Key: TINKERPOP-1631
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1631
> Project: TinkerPop
> Issue Type: Improvement
> Components: plugin
>Affects Versions: 3.2.3
>Reporter: stephen mallette
>Assignee: stephen mallette
> Fix For: 3.2.5
>
>
> The whole aspect of applying bindings via plugin with the revised plugin
> system is a little sketchy/inconsistent.
> * Bindings should always be assigned to global scope because engine scope is
> always overriden with local bindings.
> * Bindings assigned by {{HadoopGremlinPlugin}} don't seem to want to appear
> in Gremlin Server.
> * There needs to be some form of mock {{GremlinScriptEngine}} that can be
> used to test plugins without having to depend on an actual implementation
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1631) Fix visibility issues with the BindingsGremlinPlugin
[
https://issues.apache.org/jira/browse/TINKERPOP-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15879045#comment-15879045
]
ASF GitHub Bot commented on TINKERPOP-1631:
---
Github user davebshow commented on the issue:
https://github.com/apache/tinkerpop/pull/558
`mvn clean install` passes.
VOTE +1
> Fix visibility issues with the BindingsGremlinPlugin
>
>
> Key: TINKERPOP-1631
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1631
> Project: TinkerPop
> Issue Type: Improvement
> Components: plugin
>Affects Versions: 3.2.3
>Reporter: stephen mallette
>Assignee: stephen mallette
> Fix For: 3.2.5
>
>
> The whole aspect of applying bindings via plugin with the revised plugin
> system is a little sketchy/inconsistent.
> * Bindings should always be assigned to global scope because engine scope is
> always overriden with local bindings.
> * Bindings assigned by {{HadoopGremlinPlugin}} don't seem to want to appear
> in Gremlin Server.
> * There needs to be some form of mock {{GremlinScriptEngine}} that can be
> used to test plugins without having to depend on an actual implementation
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1631) Fix visibility issues with the BindingsGremlinPlugin
[
https://issues.apache.org/jira/browse/TINKERPOP-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15870143#comment-15870143
]
ASF GitHub Bot commented on TINKERPOP-1631:
---
Github user okram commented on the issue:
https://github.com/apache/tinkerpop/pull/558
VOTE +1.
> Fix visibility issues with the BindingsGremlinPlugin
>
>
> Key: TINKERPOP-1631
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1631
> Project: TinkerPop
> Issue Type: Improvement
> Components: plugin
>Affects Versions: 3.2.3
>Reporter: stephen mallette
>Assignee: stephen mallette
> Fix For: 3.2.5
>
>
> The whole aspect of applying bindings via plugin with the revised plugin
> system is a little sketchy/inconsistent.
> * Bindings should always be assigned to global scope because engine scope is
> always overriden with local bindings.
> * Bindings assigned by {{HadoopGremlinPlugin}} don't seem to want to appear
> in Gremlin Server.
> * There needs to be some form of mock {{GremlinScriptEngine}} that can be
> used to test plugins without having to depend on an actual implementation
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (TINKERPOP-1631) Fix visibility issues with the BindingsGremlinPlugin
[
https://issues.apache.org/jira/browse/TINKERPOP-1631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15867018#comment-15867018
]
ASF GitHub Bot commented on TINKERPOP-1631:
---
GitHub user spmallette opened a pull request:
https://github.com/apache/tinkerpop/pull/558
TINKERPOP-1631 Improvements to BindingsGremlinPlugin
https://issues.apache.org/jira/browse/TINKERPOP-1631
This PR is a bit in the weeds. You can read the JIRA issue if you want a
few more details, but basically most of this is driven by the work being done
in master to get rid of gremlin-groovy-test.
Builds fine with docker.
VOTE +1
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/tinkerpop TINKERPOP-1631
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/tinkerpop/pull/558.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #558
commit 66ab01bad354d5933ce169c8fb7e679ad8050fa6
Author: Stephen Mallette
Date: 2017-02-13T13:50:45Z
TINKERPOP-1631 Got rid of old deprecated syntax for creating TraversalSource
commit 4818565467e6b847007dbb4032484a3efb6d091e
Author: Stephen Mallette
Date: 2017-02-13T13:51:51Z
TINKERPOP-1631 Improved consistency of binding application to
GremlinScriptEngine
Added a base factory class. Added start of a test framework for
GremlinScriptEngineFactory. Pushed all bindings to global - engine is overriden
at time of eval() by "parameters".
commit c6bbbd61516eee428a9c5a7bce2fd474a2359e87
Author: Stephen Mallette
Date: 2017-02-13T14:14:48Z
TINKERPOP-1631 Show message when global scope bindings conflict
commit d694dfa3c651d97797bd3a694bf15dfeab06e1f5
Author: Stephen Mallette
Date: 2017-02-14T12:28:48Z
TINKERPOP-1634 Deprecated CustomizerProvider infrastructure
commit 28a0ad3e43a969ed529a5a1777bc47ffde9ab0f9
Author: Stephen Mallette
Date: 2017-02-14T12:31:49Z
TINKERPOP-1631 Updated changelog
commit b57de665ab6ade256b2755ba9d94c40fadb37f1c
Author: Stephen Mallette
Date: 2017-02-14T20:44:52Z
TINKERPOP-1631 Limit bindings test to gremlin-groovy.
This test uses a script that is groovy based. Would need to generalize the
test to be better suited for all GremlinScriptEngine implementations.
> Fix visibility issues with the BindingsGremlinPlugin
>
>
> Key: TINKERPOP-1631
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1631
> Project: TinkerPop
> Issue Type: Improvement
> Components: plugin
>Affects Versions: 3.2.3
>Reporter: stephen mallette
>Assignee: stephen mallette
> Fix For: 3.2.5
>
>
> The whole aspect of applying bindings via plugin with the revised plugin
> system is a little sketchy/inconsistent.
> * Bindings should always be assigned to global scope because engine scope is
> always overriden with local bindings.
> * Bindings assigned by {{HadoopGremlinPlugin}} don't seem to want to appear
> in Gremlin Server.
> * There needs to be some form of mock {{GremlinScriptEngine}} that can be
> used to test plugins without having to depend on an actual implementation
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
