[jira] [Commented] (TINKERPOP-1798) MutationListener.vertexPropertyChanged oldValue should be a VertexProperty

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16220297#comment-16220297
 ] 

ASF GitHub Bot commented on TINKERPOP-1798:
---

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/737


> MutationListener.vertexPropertyChanged oldValue should be a VertexProperty
> --
>
> Key: TINKERPOP-1798
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1798
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.6
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>Priority: Minor
>  Labels: deprecation
> Fix For: 3.2.7, 3.3.1
>
>
> Currently the signature looks like this:
> {noformat}
> public void vertexPropertyChanged(final Vertex element, final Property 
> oldValue, final Object setValue, final Object... vertexPropertyKeyValues);
> {noformat}
> But should probably be:
> {noformat}
> public void vertexPropertyChanged(final Vertex element, final VertexProperty 
> oldValue, final Object setValue, final Object... vertexPropertyKeyValues);
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1798) MutationListener.vertexPropertyChanged oldValue should be a VertexProperty

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219795#comment-16219795
 ] 

ASF GitHub Bot commented on TINKERPOP-1798:
---

Github user robertdale commented on the issue:

https://github.com/apache/tinkerpop/pull/737
  
VOTE +1


> MutationListener.vertexPropertyChanged oldValue should be a VertexProperty
> --
>
> Key: TINKERPOP-1798
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1798
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.6
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>Priority: Minor
>  Labels: deprecation
>
> Currently the signature looks like this:
> {noformat}
> public void vertexPropertyChanged(final Vertex element, final Property 
> oldValue, final Object setValue, final Object... vertexPropertyKeyValues);
> {noformat}
> But should probably be:
> {noformat}
> public void vertexPropertyChanged(final Vertex element, final VertexProperty 
> oldValue, final Object setValue, final Object... vertexPropertyKeyValues);
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1798) MutationListener.vertexPropertyChanged oldValue should be a VertexProperty

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16219554#comment-16219554
 ] 

ASF GitHub Bot commented on TINKERPOP-1798:
---

Github user dkuppitz commented on the issue:

https://github.com/apache/tinkerpop/pull/737
  
VOTE: +1


> MutationListener.vertexPropertyChanged oldValue should be a VertexProperty
> --
>
> Key: TINKERPOP-1798
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1798
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.6
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>Priority: Minor
>  Labels: deprecation
>
> Currently the signature looks like this:
> {noformat}
> public void vertexPropertyChanged(final Vertex element, final Property 
> oldValue, final Object setValue, final Object... vertexPropertyKeyValues);
> {noformat}
> But should probably be:
> {noformat}
> public void vertexPropertyChanged(final Vertex element, final VertexProperty 
> oldValue, final Object setValue, final Object... vertexPropertyKeyValues);
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

[jira] [Commented] (TINKERPOP-1798) MutationListener.vertexPropertyChanged oldValue should be a VertexProperty

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16213543#comment-16213543
 ] 

ASF GitHub Bot commented on TINKERPOP-1798:
---

GitHub user spmallette opened a pull request:

https://github.com/apache/tinkerpop/pull/737

TINKERPOP-1798 Fix signature of MutationListener.vertexPropertyChanged()

https://issues.apache.org/jira/browse/TINKERPOP-1798

This method was referencing a Property when it should have been referencing 
a VertexProperty. Implemented by way of deprecation of the old method so that 
this ends up being a non-breaking change.

All tests pass with `docker/build.sh -t -n -i`

VOTE +1

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/apache/tinkerpop TINKERPOP-1798

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/tinkerpop/pull/737.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #737


commit 0a06a86121ab5d3ac6d85531d75f70eba469cb01
Author: Stephen Mallette 
Date:   2017-10-20T16:20:52Z

TINKERPOP-1798 Fix signature of MutationListener.vertexPropertyChanged()

This method was referencing a Property when it should have been referencing 
a VertexProperty. Implemented by way of deprecation of the old method so that 
this ends up being a non-breaking change.




> MutationListener.vertexPropertyChanged oldValue should be a VertexProperty
> --
>
> Key: TINKERPOP-1798
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1798
> Project: TinkerPop
>  Issue Type: Bug
>  Components: process
>Affects Versions: 3.2.6
>Reporter: Bryn Cooke
>Assignee: stephen mallette
>Priority: Minor
>  Labels: deprecation
>
> Currently the signature looks like this:
> {noformat}
> public void vertexPropertyChanged(final Vertex element, final Property 
> oldValue, final Object setValue, final Object... vertexPropertyKeyValues);
> {noformat}
> But should probably be:
> {noformat}
> public void vertexPropertyChanged(final Vertex element, final VertexProperty 
> oldValue, final Object setValue, final Object... vertexPropertyKeyValues);
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)