[jira] [Commented] (TINKERPOP-1871) Exception handling is slow in element ReferenceElement creation

2018-01-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335747#comment-16335747
 ] 

ASF GitHub Bot commented on TINKERPOP-1871:
---

Github user jorgebay commented on the issue:

https://github.com/apache/tinkerpop/pull/780
  
lgtm! VOTE: +1


> Exception handling is slow in element  ReferenceElement creation
> 
>
> Key: TINKERPOP-1871
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1871
> Project: TinkerPop
>  Issue Type: Improvement
>Affects Versions: 3.3.1
>Reporter: Artem Aliev
>Priority: Major
>
> Following exception happen for each vertex in OLAP and takes ~10% of 
> execution time.
> [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/reference/ReferenceElement.java#L48]
> The exception is always thrown for ComputerGraph.ComputerAdjacentVertex class.
> So the check could be added to improve performance. This is 3.3.x issue only, 
> 3.2 has no this problem.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (TINKERPOP-1871) Exception handling is slow in element ReferenceElement creation

2018-01-23 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/TINKERPOP-1871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16335763#comment-16335763
 ] 

ASF GitHub Bot commented on TINKERPOP-1871:
---

Github user asfgit closed the pull request at:

https://github.com/apache/tinkerpop/pull/780


> Exception handling is slow in element  ReferenceElement creation
> 
>
> Key: TINKERPOP-1871
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1871
> Project: TinkerPop
>  Issue Type: Improvement
>Affects Versions: 3.3.1
>Reporter: Artem Aliev
>Priority: Major
>
> Following exception happen for each vertex in OLAP and takes ~10% of 
> execution time.
> [https://github.com/apache/tinkerpop/blob/master/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/util/reference/ReferenceElement.java#L48]
> The exception is always thrown for ComputerGraph.ComputerAdjacentVertex class.
> So the check could be added to improve performance. This is 3.3.x issue only, 
> 3.2 has no this problem.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)