[jira] [Commented] (TINKERPOP-1882) Apply range and limit steps as early as possible
[
https://issues.apache.org/jira/browse/TINKERPOP-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16759868#comment-16759868
]
ASF GitHub Bot commented on TINKERPOP-1882:
---
dkuppitz commented on pull request #1040: TINKERPOP-1882 Apply range and limit
steps as early as possible
URL: https://github.com/apache/tinkerpop/pull/1040
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Apply range and limit steps as early as possible
>
>
> Key: TINKERPOP-1882
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1882
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.2.7, 3.3.1
>Reporter: Florian Hockmann
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> For a traversal like
> {{g.V(a).out().valueMap().limit(123)}}
> we can simply move the {{limit()}} to the left so we get:
> {{g.V(a).out().limit(123).valueMap()}}
> This avoids unnecessary database lookups.
> We should create a strategy that moves the {{limit}} and the {{range}} step
> like this to _the left_ for all {{map}} steps.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1882) Apply range and limit steps as early as possible
[
https://issues.apache.org/jira/browse/TINKERPOP-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16743224#comment-16743224
]
ASF GitHub Bot commented on TINKERPOP-1882:
---
dkuppitz commented on pull request #1040: TINKERPOP-1882 Apply range and limit
steps as early as possible
URL: https://github.com/apache/tinkerpop/pull/1040
https://issues.apache.org/jira/browse/TINKERPOP-1882
`docker/build.sh -t -i -n` passed.
VOTE +1
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Apply range and limit steps as early as possible
>
>
> Key: TINKERPOP-1882
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1882
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.2.7, 3.3.1
>Reporter: Florian Hockmann
>Assignee: Daniel Kuppitz
>Priority: Minor
>
> For a traversal like
> {{g.V(a).out().valueMap().limit(123)}}
> we can simply move the {{limit()}} to the left so we get:
> {{g.V(a).out().limit(123).valueMap()}}
> This avoids unnecessary database lookups.
> We should create a strategy that moves the {{limit}} and the {{range}} step
> like this to _the left_ for all {{map}} steps.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1882) Apply range and limit steps as early as possible
[
https://issues.apache.org/jira/browse/TINKERPOP-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357176#comment-16357176
]
stephen mallette commented on TINKERPOP-1882:
-
Strategies are really tricky. They need a lot of thought. Perhaps rather than
{{g.V(a).out().limit(123).barrier(2500).valueMap()}} we could alter the barrier
size to be like: {{g.V(a).out().barrier(123).limit(123).valueMap()}} - seems
less invasive in my mind.
> Apply range and limit steps as early as possible
>
>
> Key: TINKERPOP-1882
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1882
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.2.7, 3.3.1
>Reporter: Florian Hockmann
>Priority: Minor
>
> For a traversal like
> {{g.V(a).out().valueMap().limit(123)}}
> we can simply move the {{limit()}} to the left so we get:
> {{g.V(a).out().limit(123).valueMap()}}
> This avoids unnecessary database lookups.
> We should create a strategy that moves the {{limit}} and the {{range}} step
> like this to _the left_ for all {{map}} steps.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1882) Apply range and limit steps as early as possible
[
https://issues.apache.org/jira/browse/TINKERPOP-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16357159#comment-16357159
]
Florian Hockmann commented on TINKERPOP-1882:
-
To be honest, I didn't think about the {{LazyBarrierStrategy}} but that makes
queries like {{g.V(a).out().valueMap().limit(123)}} of course a much smaller
problem.
{quote}Without the {{barrier(2500)}} the traversal wouldn't add any extra
processing that wasn't necessary, correct?
{quote}
Yes, that was exactly my intention with this ticket.
However, shouldn't the end result be
{{g.V(a).out().limit(123).barrier(2500).valueMap()}}? So, I guess this new
strategy should ideally be applied prior to the {{LazyBarrierStrategy}}.
> Apply range and limit steps as early as possible
>
>
> Key: TINKERPOP-1882
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1882
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.2.7, 3.3.1
>Reporter: Florian Hockmann
>Priority: Minor
>
> For a traversal like
> {{g.V(a).out().valueMap().limit(123)}}
> we can simply move the {{limit()}} to the left so we get:
> {{g.V(a).out().limit(123).valueMap()}}
> This avoids unnecessary database lookups.
> We should create a strategy that moves the {{limit}} and the {{range}} step
> like this to _the left_ for all {{map}} steps.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (TINKERPOP-1882) Apply range and limit steps as early as possible
[
https://issues.apache.org/jira/browse/TINKERPOP-1882?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16350187#comment-16350187
]
stephen mallette commented on TINKERPOP-1882:
-
I've often thought about a strategy like that. I guess
{{g.V(a).out().valueMap().limit(123)}} will include a {{barrier(2500)}} after
{{out()}} only to have it {{limit(123)}} later. Without the {{barrier(2500)}}
the traversal wouldn't add any extra processing that wasn't necessary, correct?
> Apply range and limit steps as early as possible
>
>
> Key: TINKERPOP-1882
> URL: https://issues.apache.org/jira/browse/TINKERPOP-1882
> Project: TinkerPop
> Issue Type: Improvement
> Components: process
>Affects Versions: 3.2.7, 3.3.1
>Reporter: Florian Hockmann
>Priority: Minor
>
> For a traversal like
> {{g.V(a).out().valueMap().limit(123)}}
> we can simply move the {{limit()}} to the left so we get:
> {{g.V(a).out().limit(123).valueMap()}}
> This avoids unnecessary database lookups.
> We should create a strategy that moves the {{limit}} and the {{range}} step
> like this to _the left_ for all {{map}} steps.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
