[jira] [Commented] (TINKERPOP-2262) Improve Netty protocol handling
[ https://issues.apache.org/jira/browse/TINKERPOP-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17006951#comment-17006951 ] ASF GitHub Bot commented on TINKERPOP-2262: --- spmallette commented on pull request #1232: TINKERPOP-2262 Prevented channel close by server on protocol error URL: https://github.com/apache/tinkerpop/pull/1232 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve Netty protocol handling > --- > > Key: TINKERPOP-2262 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2262 > Project: TinkerPop > Issue Type: Improvement > Components: driver, server >Affects Versions: 3.3.7, 3.4.2 >Reporter: Divij Vaidya >Priority: Major > > 4.1.37 adds [https://github.com/netty/netty/pull/9116] which is critical to > the stability of the Java Client. > After the upgrade a follow-up task would : > 1. change the Java Client to set the newly introduced flag > "closeOnProtocolViolation" to false. This would prevent causing all the other > requests using the same channel to fail when a single request causes a > protocol violation. > 2. introduce the protocol exception error handling code on the client to > handle protocol violation exceptions. Currently, the code force replaces the > channel, thus closing all the other requests being served on the channel.[ > https://netty.io/news/2019/06/28/4-1-37-Final.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TINKERPOP-2262) Improve Netty protocol handling
[ https://issues.apache.org/jira/browse/TINKERPOP-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16997355#comment-16997355 ] ASF GitHub Bot commented on TINKERPOP-2262: --- spmallette commented on pull request #1232: TINKERPOP-2262 Prevented channel close by server on protocol error URL: https://github.com/apache/tinkerpop/pull/1232 https://issues.apache.org/jira/browse/TINKERPOP-2262 Allows the channel on the driver to be reused rather than replaced. Interestingly no additional error handling seemed to be needed as all tests passed. Builds with `mvn clean install && mvn verify -pl gremlin-server -DskipIntegrationTests=false` VOTE +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Improve Netty protocol handling > --- > > Key: TINKERPOP-2262 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2262 > Project: TinkerPop > Issue Type: Improvement > Components: driver, server >Affects Versions: 3.3.7, 3.4.2 >Reporter: Divij Vaidya >Priority: Major > > 4.1.37 adds [https://github.com/netty/netty/pull/9116] which is critical to > the stability of the Java Client. > After the upgrade a follow-up task would : > 1. change the Java Client to set the newly introduced flag > "closeOnProtocolViolation" to false. This would prevent causing all the other > requests using the same channel to fail when a single request causes a > protocol violation. > 2. introduce the protocol exception error handling code on the client to > handle protocol violation exceptions. Currently, the code force replaces the > channel, thus closing all the other requests being served on the channel.[ > https://netty.io/news/2019/06/28/4-1-37-Final.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TINKERPOP-2262) Improve Netty protocol handling
[ https://issues.apache.org/jira/browse/TINKERPOP-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957826#comment-16957826 ] Stephen Mallette commented on TINKERPOP-2262: - probably doesn't apply. can't see us moving to 4.1.x there at this point. wonder how many more releases we'll even see on 3.3.x. would really like to turn attention to 3.5.0 at this point and don't want to juggle three branches. > Improve Netty protocol handling > --- > > Key: TINKERPOP-2262 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2262 > Project: TinkerPop > Issue Type: Improvement > Components: driver, server >Affects Versions: 3.3.7, 3.4.2 >Reporter: Divij Vaidya >Priority: Major > > 4.1.37 adds [https://github.com/netty/netty/pull/9116] which is critical to > the stability of the Java Client. > After the upgrade a follow-up task would : > 1. change the Java Client to set the newly introduced flag > "closeOnProtocolViolation" to false. This would prevent causing all the other > requests using the same channel to fail when a single request causes a > protocol violation. > 2. introduce the protocol exception error handling code on the client to > handle protocol violation exceptions. Currently, the code force replaces the > channel, thus closing all the other requests being served on the channel.[ > https://netty.io/news/2019/06/28/4-1-37-Final.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TINKERPOP-2262) Improve Netty protocol handling
[ https://issues.apache.org/jira/browse/TINKERPOP-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957471#comment-16957471 ] Robert Dale commented on TINKERPOP-2262: TP 3.3 uses Netty 4.0.x. Does the affects version still apply? I don't think we would update 3.3 to use Netty 4.1.x otherwise we would have done that. > Improve Netty protocol handling > --- > > Key: TINKERPOP-2262 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2262 > Project: TinkerPop > Issue Type: Improvement > Components: driver, server >Affects Versions: 3.3.7, 3.4.2 >Reporter: Divij Vaidya >Priority: Major > > 4.1.37 adds [https://github.com/netty/netty/pull/9116] which is critical to > the stability of the Java Client. > After the upgrade a follow-up task would : > 1. change the Java Client to set the newly introduced flag > "closeOnProtocolViolation" to false. This would prevent causing all the other > requests using the same channel to fail when a single request causes a > protocol violation. > 2. introduce the protocol exception error handling code on the client to > handle protocol violation exceptions. Currently, the code force replaces the > channel, thus closing all the other requests being served on the channel.[ > https://netty.io/news/2019/06/28/4-1-37-Final.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (TINKERPOP-2262) Improve Netty protocol handling
[ https://issues.apache.org/jira/browse/TINKERPOP-2262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16957469#comment-16957469 ] Robert Dale commented on TINKERPOP-2262: Updated to Netty 4.1.42 outside of this ticket. > Improve Netty protocol handling > --- > > Key: TINKERPOP-2262 > URL: https://issues.apache.org/jira/browse/TINKERPOP-2262 > Project: TinkerPop > Issue Type: Improvement > Components: driver, server >Affects Versions: 3.3.7, 3.4.2 >Reporter: Divij Vaidya >Priority: Major > > 4.1.37 adds [https://github.com/netty/netty/pull/9116] which is critical to > the stability of the Java Client. > After the upgrade a follow-up task would : > 1. change the Java Client to set the newly introduced flag > "closeOnProtocolViolation" to false. This would prevent causing all the other > requests using the same channel to fail when a single request causes a > protocol violation. > 2. introduce the protocol exception error handling code on the client to > handle protocol violation exceptions. Currently, the code force replaces the > channel, thus closing all the other requests being served on the channel.[ > https://netty.io/news/2019/06/28/4-1-37-Final.html] -- This message was sent by Atlassian Jira (v8.3.4#803005)
