Re: SSL-based SessionTracking/Management

2006-05-03 Thread Jean-frederic Clere

Oliver Schoenwald wrote:


Dear developers,

I have developed an SSL-based SessionManagement for our university's
e-learning system because I was unsuccessful to find any ability of 
Tomcat 5

to create and manage an SSLSession as in the JSSE-Specification.
Several weeks of googling after such a feature and asking questions in 
the

tomcat-user-mailingliste resulted in practically nothing.

Because we wanted a session management without having to force our 
students

to activate cookies and without having to do url-rewriting, I did my own
development which resulted (after several refactorings) in our own 
SessionManagement.
However, this SessionManagement is only a subpackage of our 
webapplication,
which has also its own authentication mechanism due to other 
requirements that
were set by our users. So far, it is a quite proprietary solution that 
might be changed

to be integrated as an alternative SessionManagement component.


Do you use client certificates?



I wonder if there is someone or some people who are interested in 
SSL-based
SessionManagement? Or maybe there is some well hidden development 
underway
with the same objective? Maybe we could exchange some experience and 
ideas and
even find a way to add SSL-based SessionManagement to coming Tomcat 
versions?


If I should have been just blind to such a feature in Tomcat and there 
is already a
working solution I apologize for this - in that case - unnecessary 
question in advance.
In that case I would be happy if someone could point me to the right 
documentation

or source code to at least find what I searched for before.

Thank you,

Oliver Schönwald
University of Hagen
Germany


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r399545 - /tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java

2006-05-03 Thread billbarker
Author: billbarker
Date: Wed May  3 21:49:09 2006
New Revision: 399545

URL: http://svn.apache.org/viewcvs?rev=399545&view=rev
Log:
Enable Annotation processing for Tags even when pooling is disabled.

Of course, this will be horrible slow at least until Jasper looks for 
metadata-complete.

Also style fixes on the tagPoolHandler Vector.


Modified:
tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java
URL: 
http://svn.apache.org/viewcvs/tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java?rev=399545&r1=399544&r2=399545&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java Wed May 
 3 21:49:09 2006
@@ -93,7 +93,7 @@
 
 private PageInfo pageInfo;
 
-private Vector tagHandlerPoolNames;
+private Vector tagHandlerPoolNames;
 
 private GenBuffer charArrayBuffer;
 
@@ -385,7 +385,7 @@
 out.pushIndent();
 if (isPoolingEnabled) {
 for (int i = 0; i < tagHandlerPoolNames.size(); i++) {
-out.printin((String) tagHandlerPoolNames.elementAt(i));
+out.printin(tagHandlerPoolNames.elementAt(i));
 out
 .print(" = 
org.apache.jasper.runtime.TagHandlerPool.getTagHandlerPool(");
 if (ctxt.isTagFile()) {
@@ -422,8 +422,20 @@
 
 if (isPoolingEnabled) {
 for (int i = 0; i < tagHandlerPoolNames.size(); i++) {
-out.printin((String) tagHandlerPoolNames.elementAt(i));
-out.println(".release();");
+out.printin("Tag handler = ");
+out.printin(tagHandlerPoolNames.elementAt(i));
+out.println(";");
+out.println("handler.release();");
+out.println("try {");
+out.pushIndent();
+
out.println("org.apache.jasper.runtime.AnnotationProcessor.preDestroy(handler);");
+out.popIndent();
+out.println("} catch (Exception e) {");
+out.pushIndent();
+out.println("log(\"Error processing preDestroy on tag instance 
of \" ");
+out.println(" + handler.getClass().getName());");
+out.popIndent();
+out.println("}");
 }
 }
 
@@ -2143,6 +2155,9 @@
 out.print("new ");
 out.print(tagHandlerClassName);
 out.println("();");
+
out.printin("org.apache.jasper.runtime.AnnotationProcessor.postConstruct(");
+out.print(tagHandlerVar);
+out.println(");");
 }
 
 // includes setting the context
@@ -2288,6 +2303,19 @@
 } else {
 out.printin(tagHandlerVar);
 out.println(".release();");
+out.println("try {");
+out.pushIndent();
+
out.printin("org.apache.jasper.runtime.AnnotationProcessor.preDestroy(");
+out.print(tagHandlerVar);
+out.println(");");
+out.popIndent();
+out.println("} catch (Exception e) {");
+out.pushIndent();
+out.println("log(\"Error processing preDestroy on tag 
instance of \" +");
+out.printin(tagHandlerVar);
+out.println(".getClass().getName());");
+out.popIndent();
+out.println("}");
 }
 }
 if (isTagFile || isFragment) {
@@ -2330,6 +2358,17 @@
 } else {
 out.printin(tagHandlerVar);
 out.println(".release();");
+out.println("try {");
+out.pushIndent();
+
out.printin("org.apache.jasper.runtime.AnnotationProcessor.preDestroy(");
+out.print(tagHandlerVar);
+out.println(");");
+out.println("} catch (Exception e) {");
+out.println("log(\"Error processing preDestroy on tag instance 
of \" +");
+out.printin(tagHandlerVar);
+out.println(".getClass().getName());");
+out.popIndent();
+out.println("}");
 }
 
 if (n.implementsTryCatchFinally()) {



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



problem in installing tomcat.

2006-05-03 Thread shivani . anand

Hi,
I am new to JSP and Tomcat.
this is a very basic question that I want to ask.
i have installed the latest version of apache tomcat server using 
apache-tomcat-5.5.12.exe
(it ran the setup for me).

Now i want to deploy my application.
I am able to make simple JSP pages which use inbuilt packages.
But i have a package that i want to use.

I read about some manual changes that are to be done in the Classpath and 
all.

could anyone please guide me.

I have read the document and also made changes but no luck.

none of my jsp,s are running(those that use my own classes).
i think there is some change required in the settings.
can anyone guide me through them.

It would be very kind.

Regards,

Shivani Anand

Notice: The information contained in this e-mail message and/or attachments to 
it may contain confidential or privileged information.   If you are not the 
intended recipient, any dissemination, use, review, distribution, printing or 
copying of the information contained in this e-mail message and/or attachments 
to it are strictly prohibited.   If you have received this communication in 
error, please notify us by reply e-mail or telephone and immediately and 
permanently delete the message and any attachments.  Thank you

DO NOT REPLY [Bug 39470] - Session timeout/stack trace issue in 4.1.30

2006-05-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39470





--- Additional Comments From [EMAIL PROTECTED]  2006-05-04 00:38 ---
Bug 19238 is likely masking the problem.

Given you are having problems it might be worth updating to 4.1.31 even if it
isn't officially supported to see if any more information is reported when the
error occurs.

Based on the limited information, this looks like an application problem to me.
Without the root cause info, there is very little that can be done. I'll leave
this open for now but without additional root cause information or a way to
reproduce this will eventually get closed as invalid. 

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2006-05-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453





--- Additional Comments From [EMAIL PROTECTED]  2006-05-03 21:00 ---
(In reply to comment #50)
> > The problem isn't isolated to an "edge" case, it affects the standard way 
> > apps
> > are deployed.  Thus the numerous other people who have encountered it. 
> 
> I certainly agree. I encountered this issue multiple times. I took quite some
> time and flustration to discover this bug. 
> The workaround I currently use is deploying exploded .war contents and setting
> scp not to preserve timestamps, effectively forcing all copied JSP files to be
> recompiled.
> I think the bug is obviously serious and is definately not isolated to an 
> "edge"
> case. 
> I'm glad someone is trying to fix it.

I've fixed it, getting the fix incorporated into the codebase appears to be the
impossible part.  Feel free to use the code from my patch and give feedback if
you find any problems.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 33453] - Jasper should recompile JSP files whose datestamps change in either direction (not just newer)

2006-05-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=33453





--- Additional Comments From [EMAIL PROTECTED]  2006-05-03 20:54 ---
> The problem isn't isolated to an "edge" case, it affects the standard way apps
> are deployed.  Thus the numerous other people who have encountered it. 

I certainly agree. I encountered this issue multiple times. I took quite some
time and flustration to discover this bug. 
The workaround I currently use is deploying exploded .war contents and setting
scp not to preserve timestamps, effectively forcing all copied JSP files to be
recompiled.
I think the bug is obviously serious and is definately not isolated to an "edge"
case. 
I'm glad someone is trying to fix it.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r399216 - in /tomcat/tc6.0.x/trunk/java/org/apache/jasper: compiler/Generator.java runtime/AnnotationProcessor.java runtime/TagHandlerPool.java

2006-05-03 Thread Remy Maucherat

Bill Barker wrote:

Section 7.1.11 specifically says Annotation processing happens before the
setters, not after.  


I didn't notice that. Thanks.

Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r399406 - /tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java

2006-05-03 Thread remm
Author: remm
Date: Wed May  3 13:26:35 2006
New Revision: 399406

URL: http://svn.apache.org/viewcvs?rev=399406&view=rev
Log:
- Injection should occur before the setters (BTW, since simple tags are not 
pooled, performance
  will be bad; most likely some sort of caching is needed).

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java
URL: 
http://svn.apache.org/viewcvs/tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java?rev=399406&r1=399405&r2=399406&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java Wed May 
 3 13:26:35 2006
@@ -2369,13 +2369,13 @@
 out.print(tagHandlerClassName);
 out.println("();");
 
-generateSetters(n, tagHandlerVar, handlerInfo, true);
-
 // Resource injection
 
out.printin("org.apache.jasper.runtime.AnnotationProcessor.postConstruct(");
 out.print(tagHandlerVar);
 out.println(");");
 
+generateSetters(n, tagHandlerVar, handlerInfo, true);
+
 // Set the body
 if (findJspBody(n) == null) {
 /*



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



RE: svn commit: r399216 - in /tomcat/tc6.0.x/trunk/java/org/apache/jasper: compiler/Generator.java runtime/AnnotationProcessor.java runtime/TagHandlerPool.java

2006-05-03 Thread Bill Barker
 

> -Original Message-
> From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] 
> Sent: Wednesday, May 03, 2006 2:11 AM
> To: tomcat-dev@jakarta.apache.org
> Subject: svn commit: r399216 - in 
> /tomcat/tc6.0.x/trunk/java/org/apache/jasper: 
> compiler/Generator.java runtime/AnnotationProcessor.java 
> runtime/TagHandlerPool.java
> 
> Author: remm
> Date: Wed May  3 02:11:13 2006
> New Revision: 399216
> 
> URL: http://svn.apache.org/viewcvs?rev=399216&view=rev
> Log:
> - Add resource injection for tags (listeners are being 
> handled in the servlet container).
> 

>  /**
> @@ -2370,6 +2371,11 @@
>  
>  generateSetters(n, tagHandlerVar, handlerInfo, true);
>  
> +// Resource injection
> +
> out.printin("org.apache.jasper.runtime.AnnotationProcessor.pos
> tConstruct(");
> +out.print(tagHandlerVar);
> +out.println(");");
> +
>  // Set the body

Section 7.1.11 specifically says Annotation processing happens before the
setters, not after.  




This message is intended only for the use of the person(s) listed above as the 
intended recipient(s), and may contain information that is PRIVILEGED and 
CONFIDENTIAL.  If you are not an intended recipient, you may not read, copy, or 
distribute this message or any attachment. If you received this communication 
in error, please notify us immediately by e-mail and then delete all copies of 
this message and any attachments.

In addition you should be aware that ordinary (unencrypted) e-mail sent through 
the Internet is not secure. Do not send confidential or sensitive information, 
such as social security numbers, account numbers, personal identification 
numbers and passwords, to us via ordinary (unencrypted) e-mail.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39476] New: - Invalid build.xml file

2006-05-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39476

   Summary: Invalid build.xml file
   Product: Tomcat 5
   Version: 5.5.16
  Platform: All
OS/Version: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Unknown
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


The build.xml file which ships with both TomCat 5.5.16 and 5.5.17 (source
package) is missing the following:



from the first line of the file. I installed the package fine on Fedora Core 4
(Stock install), but apparently the XML handling on Fedora Core 5 is much
stricter and leads to a NullPointerException as a result. This file needs to be
updated to include this line.

I used the same Java SDK on both.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r399383 - /tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java

2006-05-03 Thread fhanik
Author: fhanik
Date: Wed May  3 11:55:20 2006
New Revision: 399383

URL: http://svn.apache.org/viewcvs?rev=399383&view=rev
Log:
Don't pass start levels down that are not valid for the bottom components.
This way, interceptors can add own their own start/stop levels, and the bottom 
layer would be 
unaffected. 

Modified:

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java

Modified: 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java?rev=399383&r1=399382&r2=399383&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java
 Wed May  3 11:55:20 2006
@@ -120,7 +120,11 @@
 protected synchronized void internalStart(int svc) throws ChannelException 
{
 try {
 boolean valid = false;
-if (startLevel == Channel.DEFAULT) return;
+//make sure we don't pass down any flags that are unrelated to the 
bottom layer
+svc = svc & Channel.DEFAULT;
+
+if (startLevel == Channel.DEFAULT) return; //we have already 
started up all components
+if (svc == 0 ) return;//nothing to start
 
 //must start the receiver first so that we can coordinate the port 
it
 //listens to with the local membership settings
@@ -144,7 +148,8 @@
 if ( Channel.MBR_TX_SEQ==(svc & Channel.MBR_TX_SEQ) ) {
 membershipService.start(MembershipService.MBR_TX);
 valid = true;
-}
+}
+
 if ( !valid) {
 throw new IllegalArgumentException("Invalid start level, valid 
levels are:SND_RX_SEQ,SND_TX_SEQ,MBR_TX_SEQ,MBR_RX_SEQ");
 }
@@ -169,8 +174,13 @@
  */
 protected synchronized void internalStop(int svc) throws ChannelException {
 try {
+//make sure we don't pass down any flags that are unrelated to the 
bottom layer
+svc = svc & Channel.DEFAULT;
+
+if (startLevel == 0) return; //we have already stopped up all 
components
+if (svc == 0 ) return;//nothing to stop
+
 boolean valid = false;
-if ( startLevel == 0 ) return;
 if ( Channel.SND_RX_SEQ==(svc & Channel.SND_RX_SEQ) ) {
 clusterReceiver.stop();
 clusterReceiver.setMessageListener(null);



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39089] - java.lang.InternalError: name is too long to represent

2006-05-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39089


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-05-03 18:53 ---
(In reply to comment #5) 
> The Sun JVM issue is really a spec documentation conflict. The overall JVM 
> specs
> quite clearly says there is a 4K limit for attributes, the JSR spec says
> something different. I would think the JVM spec is much more important here. 
> 
> For large JSPs, Jasper is adding > 4K work of SourceDebugExtension information
> to the compiled classes - this violates the JVM spec and causes the bug.
Erik,

Where did you get that information about the 4K limit. An attribute length can
be on 4 unsigned byte.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r399382 - in /tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes: Channel.java MembershipService.java group/ChannelCoordinator.java membership/McastService.java

2006-05-03 Thread fhanik
Author: fhanik
Date: Wed May  3 11:48:01 2006
New Revision: 399382

URL: http://svn.apache.org/viewcvs?rev=399382&view=rev
Log:
Start levels are now respected correctly, this will make unit testing easier 
since we can shutdown and start different components to simulate errors

Modified:

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/Channel.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/MembershipService.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastService.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/membership/McastServiceImpl.java

Modified: 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/Channel.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/Channel.java?rev=399382&r1=399381&r2=399382&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/Channel.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/Channel.java
 Wed May  3 11:48:01 2006
@@ -30,9 +30,9 @@
  * Start and stop sequences can be controlled by these constants
  */
 public static final int DEFAULT = 15;
-public static final int MBR_RX_SEQ = 1;
+public static final int SND_RX_SEQ = 1;
 public static final int SND_TX_SEQ = 2;
-public static final int SND_RX_SEQ = 4;
+public static final int MBR_RX_SEQ = 4;
 public static final int MBR_TX_SEQ = 8;
 
 /**

Modified: 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/MembershipService.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/MembershipService.java?rev=399382&r1=399381&r2=399382&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/MembershipService.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/MembershipService.java
 Wed May  3 11:48:01 2006
@@ -27,8 +27,8 @@
 
 public interface MembershipService {
 
-public static final int MBR_RX = 1;
-public static final int MBR_TX = 2;
+public static final int MBR_RX = Channel.MBR_RX_SEQ;
+public static final int MBR_TX = Channel.MBR_TX_SEQ;
 
 /**
  * Sets the properties for the membership service. This must be called 
before
@@ -52,17 +52,24 @@
 /**
  * Starts the membership service. If a membership listeners is added
  * the listener will start to receive membership events.
- * @param level - level 1 starts listening for members, level 2 
+ * @param level - level MBR_RX starts listening for members, level MBR_TX 
  * starts broad casting the server
  * @throws java.lang.Exception if the service fails to start.
+ * @throws java.lang.IllegalArgumentException if the level is incorrect.
  */
 public void start(int level) throws java.lang.Exception;
 
 
 /**
- * Stops the membership service
+ * Starts the membership service. If a membership listeners is added
+ * the listener will start to receive membership events.
+ * @param level - level MBR_RX stops listening for members, level MBR_TX 
+ * stops broad casting the server
+ * @throws java.lang.Exception if the service fails to stop
+ * @throws java.lang.IllegalArgumentException if the level is incorrect.
  */
-public void stop();
+
+public void stop(int level);
 
 /**
  * Returns that cluster has members.

Modified: 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java?rev=399382&r1=399381&r2=399382&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/ChannelCoordinator.java
 Wed May  3 11:48:01 2006
@@ -41,10 +41,13 @@
 private ChannelReceiver clusterReceiver = new NioReceiver();
 private ChannelSender clusterSender = new ReplicationTransmitter();
 private MembershipService membershipService = new McastService();
-private boolean started = false;
 
+//override optionflag
 protected int optionFlag = 
Channel.SEND_OPTIONS_BYTE_MESSAGE|Cha

DO NOT REPLY [Bug 39473] - Session timeout much shorter than setting in web.xml in cluster envirement

2006-05-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39473


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2006-05-03 17:16 ---
Arrg!

You are right and have also see that for long time, but I don't find them. Many 
Thanks to report and find 
that
Peter

Fixed at 5.5.18.
I hope for next release we refactor the nasty code duplication between core and 
cluster modules :-(

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r399358 - in /tomcat/container/tc5.5.x: modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaSession.java modules/ha/src/share/org/apache/catalina/ha/session/DeltaSession.jav

2006-05-03 Thread pero
Author: pero
Date: Wed May  3 10:16:15 2006
New Revision: 399358

URL: http://svn.apache.org/viewcvs?rev=399358&view=rev
Log:
Session timeout much shorter than setting at web.xml at cluster environment

Modified:

tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaSession.java

tomcat/container/tc5.5.x/modules/ha/src/share/org/apache/catalina/ha/session/DeltaSession.java
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaSession.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaSession.java?rev=399358&r1=399357&r2=399358&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaSession.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/cluster/src/share/org/apache/catalina/cluster/session/DeltaSession.java
 Wed May  3 10:16:15 2006
@@ -600,7 +600,7 @@
 
 if (maxInactiveInterval >= 0) {
 long timeNow = System.currentTimeMillis();
-int timeIdle = (int) ((timeNow - lastAccessedTime) / 1000L);
+int timeIdle = (int) ((timeNow - thisAccessedTime) / 1000L);
 if (isPrimarySession()) {
 if(timeIdle >= maxInactiveInterval) {
 expire(true);

Modified: 
tomcat/container/tc5.5.x/modules/ha/src/share/org/apache/catalina/ha/session/DeltaSession.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/ha/src/share/org/apache/catalina/ha/session/DeltaSession.java?rev=399358&r1=399357&r2=399358&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/ha/src/share/org/apache/catalina/ha/session/DeltaSession.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/ha/src/share/org/apache/catalina/ha/session/DeltaSession.java
 Wed May  3 10:16:15 2006
@@ -636,7 +636,7 @@
 }
 if (maxInactiveInterval >= 0) {
 long timeNow = System.currentTimeMillis();
-int timeIdle = (int) ( (timeNow - lastAccessedTime) / 1000L);
+int timeIdle = (int) ( (timeNow - thisAccessedTime) / 1000L);
 if (isPrimarySession()) {
 if (timeIdle >= maxInactiveInterval) {
 expire(true);

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?rev=399358&r1=399357&r2=399358&view=diff
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Wed May  3 10:16:15 2006
@@ -42,6 +42,14 @@
   
 

+  
+
+  
+39473: Session timeout much shorter than setting
+ at web.xml at cluster environment, suggested by Jin Jiang. (pero)
+  
+
+ 
 
 
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r399350 - in /tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes: group/interceptors/TcpFailureDetector.java membership/Membership.java

2006-05-03 Thread fhanik
Author: fhanik
Date: Wed May  3 09:54:15 2006
New Revision: 399350

URL: http://svn.apache.org/viewcvs?rev=399350&view=rev
Log:
fixed some small code issues

Modified:

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java

tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/membership/Membership.java

Modified: 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java?rev=399350&r1=399349&r2=399350&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/group/interceptors/TcpFailureDetector.java
 Wed May  3 09:54:15 2006
@@ -189,6 +189,7 @@
 data.setTimestamp(System.currentTimeMillis());
 int options = getOptionFlag() | 
Channel.SEND_OPTIONS_BYTE_MESSAGE;
 if ( performReadTest ) options = (options | 
Channel.SEND_OPTIONS_USE_ACK);
+else options = (options & (~Channel.SEND_OPTIONS_USE_ACK));
 data.setOptions(options);
 byte[] message = XByteBuffer.createDataPackage(data);
 socket.getOutputStream().write(message);

Modified: 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/membership/Membership.java
URL: 
http://svn.apache.org/viewcvs/tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/membership/Membership.java?rev=399350&r1=399349&r2=399350&view=diff
==
--- 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/membership/Membership.java
 (original)
+++ 
tomcat/container/tc5.5.x/modules/groupcom/src/share/org/apache/catalina/tribes/membership/Membership.java
 Wed May  3 09:54:15 2006
@@ -92,9 +92,7 @@
 //return true if the membership has changed
 MbrEntry entry = (MbrEntry)map.get(member);
 if ( entry == null ) {
-entry = new MbrEntry(member);
-map.put(member,entry);
-addMember(member);
+entry = addMember(member);
 result = true;
} else {
 //update the member alive time
@@ -113,15 +111,16 @@
  * Add a member to this component and sort array with memberComparator
  * @param member The member to add
  */
-public void addMember(MemberImpl member) {
+public synchronized MbrEntry addMember(MemberImpl member) {
   synchronized (members) {
-  MemberImpl results[] =
-new MemberImpl[members.length + 1];
-  for (int i = 0; i < members.length; i++)
-  results[i] = members[i];
+  MbrEntry entry = new MbrEntry(member);
+  map.put(member,entry);
+  MemberImpl results[] = new MemberImpl[members.length + 1];
+  for (int i = 0; i < members.length; i++) results[i] = members[i];
   results[members.length] = member;
   members = results;
   Arrays.sort(members, memberComparator);
+  return entry;
   }
 }
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39473] New: - Session timeout much shorter than setting in web.xml in cluster envirement

2006-05-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39473

   Summary: Session timeout much shorter than setting in web.xml in
cluster envirement
   Product: Tomcat 5
   Version: 5.5.7
  Platform: Sun
OS/Version: Solaris
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina:Cluster
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


We have a tow nodes Tomcat cluster server on production.
The session timeout is set to 20 minutes.
The costomers complained their session timeout much shorter than 20 minutes,
sometimes within 5 minutes.
I did a test:
T1 -> access the page
T2 -> access the page
T3 -> access the page
The session would timeout if T3 - T1 > 20 minutes.

I compare the source for Non-cluster session and Cluster session,
found they are calculate the idle time in different way.

In DeltaSession.java:
int timeIdle = (int) ((timeNow - lastAccessedTime) / 1000L);

In StandardSession.java:
int timeIdle = (int) ((timeNow - thisAccessedTime) / 1000L);

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39470] - Session timeout/stack trace issue in 4.1.30

2006-05-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39470


[EMAIL PROTECTED] changed:

   What|Removed |Added

Summary|Session timeout/stack trace |Session timeout/stack trace
   |issue in 4.0.30 |issue in 4.1.30




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39470] - Session timeout/stack trace issue in 4.0.30

2006-05-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39470


[EMAIL PROTECTED] changed:

   What|Removed |Added

Version|4.0.3 Final |4.1.30




--- Additional Comments From [EMAIL PROTECTED]  2006-05-03 12:54 ---
updated version in drop down.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: help regarding tomcat.

2006-05-03 Thread Yoav Shapira

Shivani,
Please use the tomcat users mailing list at users@tomcat.apache.org
for discussing this issue.

Yoav

On 5/3/06, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote:

i have just starting working in JSP.
i have installed the latest version of apache tomcat server using
apache-tomcat-5.5.12.exe
(it ran the setup for me).

Now i want to deploy my application.
I am able to make simple JSP pages which use inbuilt packages.
But i have a package that i want to use.

I read about some manual changes that are to be done in the Classpath and
all.

could anyone please guide me.

none of my jsp,s are running.
i think there is some change required in the settings.
can anyone guide me through them.

It would be very kind.

Regards,

Shivani Anand
=-=-=
Notice: The information contained in this e-mail
message and/or attachments to it may contain
confidential or privileged information. If you are
not the intended recipient, any dissemination, use,
review, distribution, printing or copying of the
information contained in this e-mail message
and/or attachments to it are strictly prohibited. If
you have received this communication in error,
please notify us by reply e-mail or telephone and
immediately and permanently delete the message
and any attachments. Thank you







--
Yoav Shapira
Nimalex LLC
1 Mifflin Place, Suite 310
Cambridge, MA, USA
[EMAIL PROTECTED] / www.yoavshapira.com

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39470] - Session timeout/stack trace issue in 4.0.30

2006-05-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39470





--- Additional Comments From [EMAIL PROTECTED]  2006-05-03 12:25 ---
Many apols. All refs to 4.0.30 are meant to be 4.1.30.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



help regarding tomcat.

2006-05-03 Thread shivani . anand
i have just starting working in JSP.
i have installed the latest version of apache tomcat server using 
apache-tomcat-5.5.12.exe
(it ran the setup for me).

Now i want to deploy my application.
I am able to make simple JSP pages which use inbuilt packages.
But i have a package that i want to use.

I read about some manual changes that are to be done in the Classpath and 
all.

could anyone please guide me.

none of my jsp,s are running.
i think there is some change required in the settings.
can anyone guide me through them.

It would be very kind.

Regards,

Shivani Anand
=-=-=
Notice: The information contained in this e-mail
message and/or attachments to it may contain 
confidential or privileged information. If you are 
not the intended recipient, any dissemination, use, 
review, distribution, printing or copying of the 
information contained in this e-mail message 
and/or attachments to it are strictly prohibited. If 
you have received this communication in error, 
please notify us by reply e-mail or telephone and 
immediately and permanently delete the message 
and any attachments. Thank you




DO NOT REPLY [Bug 37356] - Tomcat does not invalidate sessions after session-timeout period has passed.

2006-05-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=37356


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|WORKSFORME  |




--- Additional Comments From [EMAIL PROTECTED]  2006-05-03 11:30 ---
I am re-opening this bug as I do not believe that marking it as 'works for me -
 fixed' is satisfactory to any of the people who are suffering this bug.

If it was just one person suffering from the bug then this might be an 
acceptable reply but given that there are multiple people who have reported 
it - and some people who have managed to debug Tomcat and suggest what the 
problem might be - to just close it without proper investigation is 
unacceptable.

I am aware that I have not provided a reproducable test case but like many 
other contributors I only see this issue in a live well loaded environment - 
in my case in a clients production environment - I simply cannot send you my 
clients entire application to test with and cannot reprodcue it here on our 
development machines - but this does not mean that there is not a problem.

I look forward to some more in depth investigation and proposals for solving 
this problem. Thanks, Eddie



-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 39470] New: - Session timeout/stack trace issue in 4.0.30

2006-05-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39470

   Summary: Session timeout/stack trace issue in 4.0.30
   Product: Tomcat 4
   Version: 4.0.3 Final
  Platform: Other
OS/Version: Windows 2000
Status: NEW
  Severity: major
  Priority: P2
 Component: Jasper
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


Our application has a session timeout of one hour. When this is reached and a 
link is hit an http 500 error is reported with a NullPointerException root 
cause. However the root cause is not showing an associated stack trace with 
the component throwing the NPE. I therefore cannot troubleshoot whether this 
is a development related problem or a tomcat internal session issue. The 
application in question is supplied by a 3rd party and they currently only 
support up to Tomcat 4.0.30 (an upgrade to the latest version is therefore not 
possible). The browser and logs show the same stack trace which I have added 
below:-

type Exception report

message

description The server encountered an internal error () that prevented it from 
fulfilling this request.

exception

org.apache.jasper.JasperException
at org.apache.jasper.servlet.JspServletWrapper.service
(JspServletWrapper.java:254)
at org.apache.jasper.servlet.JspServlet.serviceJspFile
(JspServlet.java:295)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:241)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:853)
at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter
(ApplicationFilterChain.java:247)
at org.apache.catalina.core.ApplicationFilterChain.doFilter
(ApplicationFilterChain.java:193)
at org.apache.catalina.core.StandardWrapperValve.invoke
(StandardWrapperValve.java:256)
at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNe
xt(StandardPipeline.java:643)
at org.apache.catalina.core.StandardPipeline.invoke
(StandardPipeline.java:480)
at org.apache.catalina.core.ContainerBase.invoke
(ContainerBase.java:995)
at org.apache.catalina.core.StandardContextValve.invoke
(StandardContextValve.java:191)
at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNe
xt(StandardPipeline.java:643)
at org.apache.catalina.core.StandardPipeline.invoke
(StandardPipeline.java:480)
at org.apache.catalina.core.ContainerBase.invoke
(ContainerBase.java:995)
at org.apache.catalina.core.StandardContext.invoke
(StandardContext.java:2422)
at org.apache.catalina.core.StandardHostValve.invoke
(StandardHostValve.java:180)
at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNe
xt(StandardPipeline.java:643)
at org.apache.catalina.valves.ErrorDispatcherValve.invoke
(ErrorDispatcherValve.java:171)
at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNe
xt(StandardPipeline.java:641)
at org.apache.catalina.valves.ErrorReportValve.invoke
(ErrorReportValve.java:163)
at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNe
xt(StandardPipeline.java:641)
at org.apache.catalina.valves.AccessLogValve.invoke
(AccessLogValve.java:577)
at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNe
xt(StandardPipeline.java:641)
at org.apache.catalina.core.StandardPipeline.invoke
(StandardPipeline.java:480)
at org.apache.catalina.core.ContainerBase.invoke
(ContainerBase.java:995)
at org.apache.catalina.core.StandardEngineValve.invoke
(StandardEngineValve.java:174)
at 
org.apache.catalina.core.StandardPipeline$StandardPipelineValveContext.invokeNe
xt(StandardPipeline.java:643)
at org.apache.catalina.core.StandardPipeline.invoke
(StandardPipeline.java:480)
at org.apache.catalina.core.ContainerBase.invoke
(ContainerBase.java:995)
at org.apache.coyote.tomcat4.CoyoteAdapter.service
(CoyoteAdapter.java:199)
at org.apache.coyote.http11.Http11Processor.process
(Http11Processor.java:828)
at 
org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.processConnecti
on(Http11Protocol.java:700)
at org.apache.tomcat.util.net.TcpWorkerThread.runIt
(PoolTcpEndpoint.java:584)
at org.apache.tomcat.util.threads.ThreadPool$ControlRunnable.run
(ThreadPool.java:683)
at java.lang.Thread.run(Thread.java:534)


root cause

java.lang.NullPointerException

Why is there no further detail with the page that threw the NPE? Are there any 
session related issues in 4.0.30 that could

svn commit: r399216 - in /tomcat/tc6.0.x/trunk/java/org/apache/jasper: compiler/Generator.java runtime/AnnotationProcessor.java runtime/TagHandlerPool.java

2006-05-03 Thread remm
Author: remm
Date: Wed May  3 02:11:13 2006
New Revision: 399216

URL: http://svn.apache.org/viewcvs?rev=399216&view=rev
Log:
- Add resource injection for tags (listeners are being handled in the servlet 
container).

Modified:
tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java
tomcat/tc6.0.x/trunk/java/org/apache/jasper/runtime/AnnotationProcessor.java
tomcat/tc6.0.x/trunk/java/org/apache/jasper/runtime/TagHandlerPool.java

Modified: tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java
URL: 
http://svn.apache.org/viewcvs/tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java?rev=399216&r1=399215&r2=399216&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/jasper/compiler/Generator.java Wed May 
 3 02:11:13 2006
@@ -504,7 +504,8 @@
 }
 out.printin("private javax.el.ExpressionFactory ");
 out.print(VAR_EXPRESSIONFACTORY);
-out.println(";\n");
+out.println(";");
+out.println();
 }
 
 /**
@@ -2370,6 +2371,11 @@
 
 generateSetters(n, tagHandlerVar, handlerInfo, true);
 
+// Resource injection
+
out.printin("org.apache.jasper.runtime.AnnotationProcessor.postConstruct(");
+out.print(tagHandlerVar);
+out.println(");");
+
 // Set the body
 if (findJspBody(n) == null) {
 /*
@@ -2410,6 +2416,11 @@
 // Declare and synchronize AT_END scripting variables
 declareScriptingVars(n, VariableInfo.AT_END);
 syncScriptingVars(n, VariableInfo.AT_END);
+
+// Resource injection
+
out.printin("org.apache.jasper.runtime.AnnotationProcessor.preDestroy(");
+out.print(tagHandlerVar);
+out.println(");");
 
 n.setEndJavaLine(out.getJavaLine());
 }

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/jasper/runtime/AnnotationProcessor.java
URL: 
http://svn.apache.org/viewcvs/tomcat/tc6.0.x/trunk/java/org/apache/jasper/runtime/AnnotationProcessor.java?rev=399216&r1=399215&r2=399216&view=diff
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/jasper/runtime/AnnotationProcessor.java 
(original)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/jasper/runtime/AnnotationProcessor.java 
Wed May  3 02:11:13 2006
@@ -24,6 +24,8 @@
 import javax.annotation.EJB;
 import javax.annotation.PostConstruct;
 import javax.annotation.Resource;
+import javax.naming.Context;
+import javax.naming.InitialContext;
 import javax.naming.NamingException;
 import javax.persistence.PersistenceContext;
 import javax.persistence.PersistenceUnit;
@@ -38,15 +40,71 @@
  * @version $Revision: 303236 $, $Date: 2006-03-09 16:46:52 -0600 (Thu, 09 Mar 
2006) $
  */
 public class AnnotationProcessor {
-
 
+
 /**
- * Call postConstruct method on the specified instance.
+ * Call postConstruct method on the specified instance. Note: In Jasper, 
this
+ * calls naming resources injection as well.
  */
 public static void postConstruct(Object instance)
-throws IllegalAccessException, InvocationTargetException {
+throws IllegalAccessException, InvocationTargetException, 
NamingException {
 
+// Initialize fields annotations
+Field[] fields = instance.getClass().getFields();
+for (int i = 0; i < fields.length; i++) {
+if (fields[i].isAnnotationPresent(Resource.class)) {
+Resource annotation = (Resource) 
fields[i].getAnnotation(Resource.class);
+lookupFieldResource(instance, fields[i], annotation.name());
+}
+if (fields[i].isAnnotationPresent(EJB.class)) {
+EJB annotation = (EJB) fields[i].getAnnotation(EJB.class);
+lookupFieldResource(instance, fields[i], annotation.name());
+}
+if (fields[i].isAnnotationPresent(WebServiceRef.class)) {
+WebServiceRef annotation = 
+(WebServiceRef) 
fields[i].getAnnotation(WebServiceRef.class);
+lookupFieldResource(instance, fields[i], annotation.name());
+}
+if (fields[i].isAnnotationPresent(PersistenceContext.class)) {
+PersistenceContext annotation = 
+(PersistenceContext) 
fields[i].getAnnotation(PersistenceContext.class);
+lookupFieldResource(instance, fields[i], annotation.name());
+}
+if (fields[i].isAnnotationPresent(PersistenceUnit.class)) {
+PersistenceUnit annotation = 
+(PersistenceUnit) 
fields[i].getAnnotation(PersistenceUnit.class);
+lookupFieldResource(instance, fields[i], annotation.name());
+

svn commit: r399196 - in /tomcat/tc6.0.x/trunk/java/org/apache/catalina/core: RestrictedServlets.properties StandardWrapper.java

2006-05-03 Thread remm
Author: remm
Date: Wed May  3 01:07:02 2006
New Revision: 399196

URL: http://svn.apache.org/viewcvs?rev=399196&view=rev
Log:
- As suggested by Mladen, add a more robust mechanism for restricted servlets.

Added:

tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/RestrictedServlets.properties
   (with props)
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java

Added: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/RestrictedServlets.properties
URL: 
http://svn.apache.org/viewcvs/tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/RestrictedServlets.properties?rev=399196&view=auto
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/RestrictedServlets.properties
 (added)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/RestrictedServlets.properties
 Wed May  3 01:07:02 2006
@@ -0,0 +1,3 @@
+org.apache.catalina.ssi.SSIServlet=restricted
+org.apache.catalina.servlets.CGIServlet=restricted
+org.apache.catalina.servlets.InvokerServlet=restricted

Propchange: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/RestrictedServlets.properties
--
svn:eol-style = native

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java
URL: 
http://svn.apache.org/viewcvs/tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java?rev=399196&r1=399195&r2=399196&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java 
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardWrapper.java Wed 
May  3 01:07:02 2006
@@ -18,11 +18,14 @@
 package org.apache.catalina.core;
 
 import java.lang.reflect.Method;
+import java.io.IOException;
+import java.io.InputStream;
 import java.io.PrintStream;
 import java.util.ArrayList;
 import java.util.Enumeration;
 import java.util.HashMap;
 import java.util.HashSet;
+import java.util.Properties;
 import java.util.Stack;
 import java.security.AccessController;
 import java.security.PrivilegedActionException;
@@ -73,10 +76,10 @@
 extends ContainerBase
 implements ServletConfig, Wrapper, NotificationEmitter {
 
-private static org.apache.commons.logging.Log log=
+protected static org.apache.commons.logging.Log log=
 org.apache.commons.logging.LogFactory.getLog( StandardWrapper.class );
 
-private static final String[] DEFAULT_SERVLET_METHODS = new String[] {
+protected static final String[] DEFAULT_SERVLET_METHODS = new String[] {
 "GET", "HEAD", "POST" };
 
 // --- Constructors
@@ -92,6 +95,22 @@
 pipeline.setBasic(swValve);
 broadcaster = new NotificationBroadcasterSupport();
 
+if (restrictedServlets == null) {
+restrictedServlets = new Properties();
+try {
+InputStream is = 
+this.getClass().getClassLoader().getResourceAsStream
+
("org/apache/catalina/core/RestrictedServlets.properties");
+if (is != null) {
+restrictedServlets.load(is);
+} else {
+
log.error(sm.getString("standardWrapper.restrictedServletsResources"));
+}
+} catch (IOException e) {
+
log.error(sm.getString("standardWrapper.restrictedServletsResources"), e);
+}
+}
+
 }
 
 
@@ -104,70 +123,70 @@
  * If this value equals Long.MAX_VALUE, the unavailability of this
  * servlet is considered permanent.
  */
-private long available = 0L;
+protected long available = 0L;
 
 /**
  * The broadcaster that sends j2ee notifications. 
  */
-private NotificationBroadcasterSupport broadcaster = null;
+protected NotificationBroadcasterSupport broadcaster = null;
 
 /**
  * The count of allocations that are currently active (even if they
  * are for the same instance, as will be true on a non-STM servlet).
  */
-private int countAllocated = 0;
+protected int countAllocated = 0;
 
 
 /**
  * The facade associated with this wrapper.
  */
-private StandardWrapperFacade facade =
+protected StandardWrapperFacade facade =
 new StandardWrapperFacade(this);
 
 
 /**
  * The descriptive information string for this implementation.
  */
-private static final String info =
+protected static final String info =
 "org.apache.catalina.core.StandardWrapper/1.0";
 
 
 /**
  * The (single) initialized instance of this servlet.
  */
-private Servlet instance = null;
+protected Servlet instance = null;
 
 
 /**
  * The support object for our instance li

DO NOT REPLY [Bug 30871] - Error when stop service in tomcat 5.0

2006-05-03 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=30871





--- Additional Comments From [EMAIL PROTECTED]  2006-05-03 07:36 ---
I guess it's the same issue as in Bug #29521.
It looks like this issue was corrected in 5.0.29

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]