svn commit: r473661 - /tomcat/tc6.0.x/trunk/java/javax/ejb/EJB.java

2006-11-10 Thread remm 
Author: remm
Date: Fri Nov 10 23:41:42 2006
New Revision: 473661

URL: http://svn.apache.org/viewvc?view=rev&rev=473661
Log:
- Fix API.

Modified:
tomcat/tc6.0.x/trunk/java/javax/ejb/EJB.java

Modified: tomcat/tc6.0.x/trunk/java/javax/ejb/EJB.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/javax/ejb/EJB.java?view=diff&rev=473661&r1=473660&r2=473661
==
--- tomcat/tc6.0.x/trunk/java/javax/ejb/EJB.java (original)
+++ tomcat/tc6.0.x/trunk/java/javax/ejb/EJB.java Fri Nov 10 23:41:42 2006
@@ -23,13 +23,12 @@
 import java.lang.annotation.RetentionPolicy;
 import java.lang.annotation.Target;
 
[EMAIL PROTECTED]({ElementType.METHOD, ElementType.TYPE, ElementType.FIELD, 
ElementType.PARAMETER})
[EMAIL PROTECTED]({ElementType.METHOD, ElementType.TYPE, ElementType.FIELD})
 @Retention(RetentionPolicy.RUNTIME)
 
 public @interface EJB {
String name() default "";
-   Class businessInterface() default java.lang.Object.class;
+   Class beanInterface() default java.lang.Object.class;
String beanName() default "";
String mappedName() default "";
-   String description() default "";
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40874] - Example in section log4j cause double entries in log files

2006-11-10 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40874


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2006-11-10 17:43 ---
Many thanks for the fix. It has been applied to SVN and will be included in
5.5.21 onwards.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r473619 - in /tomcat/container/tc5.5.x/webapps/docs: changelog.xml logging.xml

2006-11-10 Thread markt 
Author: markt
Date: Fri Nov 10 17:43:44 2006
New Revision: 473619

URL: http://svn.apache.org/viewvc?view=rev&rev=473619
Log:
Fix bug 40874. Correct log4j example. Patch by Franck Borel.

Modified:
tomcat/container/tc5.5.x/webapps/docs/changelog.xml
tomcat/container/tc5.5.x/webapps/docs/logging.xml

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?view=diff&rev=473619&r1=473618&r2=473619
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Fri Nov 10 17:43:44 2006
@@ -151,6 +151,10 @@
 40633: Remove references to the DefaultContext from the
 documentation. (markt)
   
+  
+40874: Correct log4j configuration in documentation webapp.
+Patch provided by Franck Borel. (markt)
+  
 

   

Modified: tomcat/container/tc5.5.x/webapps/docs/logging.xml
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/logging.xml?view=diff&rev=473619&r1=473618&r2=473619
==
--- tomcat/container/tc5.5.x/webapps/docs/logging.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/logging.xml Fri Nov 10 17:43:44 2006
@@ -63,14 +63,13 @@
 Create a file called log4j.properties with the following content 
 and save it into common/classes.
   
-log4j.rootLogger=debug, R 
+log4j.rootLogger=DEBUG, R 
 log4j.appender.R=org.apache.log4j.RollingFileAppender 
 log4j.appender.R.File=${catalina.home}/logs/tomcat.log 
 log4j.appender.R.MaxFileSize=10MB 
 log4j.appender.R.MaxBackupIndex=10 
 log4j.appender.R.layout=org.apache.log4j.PatternLayout 
-log4j.appender.R.layout.ConversionPattern=%p %t %c - %m%n 
-log4j.logger.org.apache.catalina=DEBUG, R
+log4j.appender.R.layout.ConversionPattern=%p %t %c - %m%n
   

 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40895] - Tomcat breaks XSLT on JRE5 or above

2006-11-10 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40895


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2006-11-10 17:35 ---
As per
http://forum.java.sun.com/thread.jspa?tstart=30&forumID=34&threadID=542044&trange=15
another solution is to set a system property.

System.setProperty("javax.xml.transform.TransformerFactory",
"com.sun.org.apache.xalan.internal.xsltc.trax.TransformerFactoryImpl");

This is not an issue for 5.5.x

5.0.x is no longer actively being worked on. I am therefore resolving this as
WONTFIX since that best reflects the status of this issue.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40668] - MailSessionFactory is missing in Tomcat 5.5.20

2006-11-10 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40668





--- Additional Comments From [EMAIL PROTECTED]  2006-11-10 14:25 ---
(In reply to comment #13)
> This is really pathetic ...

There are a least six people (other than you) who have taken the time to post
comments regarding this bug. Obviously, the missing libraries from the 5.5.20
distribution is causing concern to them - otherwise they would not have posted. 
The hope is that by providing feedback in a forum such as this that concerns
will be taken seriously ... at the end of the day, a more robust software
product will be developed - that we can all benefit from.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40668] - MailSessionFactory is missing in Tomcat 5.5.20

2006-11-10 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40668





--- Additional Comments From [EMAIL PROTECTED]  2006-11-10 14:09 ---
This is really pathetic ...

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40901] - listings page does not escape XML characters

2006-11-10 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40901


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2006-11-10 13:17 ---
many thanks for the patch. A variation has been applied to SVN and will be
included in 5.5.21 onwards.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 39444] - autocreate a Context Descriptor for webApps without META-INF/context.xml

2006-11-10 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=39444





--- Additional Comments From [EMAIL PROTECTED]  2006-11-10 13:17 ---
To add to this bug if you supply a webapps/[application]/META-INF/context.xml 
with the following content:

 or


eg. 

The context.xml does get copied to engine/host/[APPNAME].xml.  But the [PATH] 
appended before the name of the context does not work. So:
http://localhost:8080/foo/barplication  - does not work but
http://localhost:8080/barplication -  does work just as though there were no 
context descriptor at all.

The only way I have been able to get the path attribute to work is if I add 
the context tag to my server.xml , which according to the documentation 
is not recommended and not really what I want to do.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r473488 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java webapps/docs/changelog.xml

2006-11-10 Thread markt 
Author: markt
Date: Fri Nov 10 13:16:56 2006
New Revision: 473488

URL: http://svn.apache.org/viewvc?view=rev&rev=473488
Log:
Fix bug 40901. Encode directory listing output. Based on a patch by Chris 
Halstead.

Modified:

tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java?view=diff&rev=473488&r1=473487&r2=473488
==
--- 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java
 (original)
+++ 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/servlets/DefaultServlet.java
 Fri Nov 10 13:16:56 2006
@@ -55,6 +55,7 @@
 import javax.xml.transform.stream.StreamSource;
 
 import org.apache.catalina.Globals;
+import org.apache.catalina.util.RequestUtil;
 import org.apache.catalina.util.ServerInfo;
 import org.apache.catalina.util.StringManager;
 import org.apache.catalina.util.URLEncoder;
@@ -1207,7 +1208,7 @@
   .append("'");
 
 sb.append(">");
-sb.append(trimmed);
+sb.append(RequestUtil.filter(trimmed));
 if (childCacheEntry.context != null)
 sb.append("/");
 sb.append("");
@@ -1376,7 +1377,7 @@
 if (childCacheEntry.context != null)
 sb.append("/");
 sb.append("\">");
-sb.append(trimmed);
+sb.append(RequestUtil.filter(trimmed));
 if (childCacheEntry.context != null)
 sb.append("/");
 sb.append("\r\n");

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?view=diff&rev=473488&r1=473487&r2=473488
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Fri Nov 10 13:16:56 2006
@@ -112,8 +112,11 @@
 (markt)
   
   
+40901: Encode directory listing output. Based on a patch
+provided by Chris Halstead. (markt)
+  
+  
 40929: Correct JavaDoc for StandardCalssLoader. (markt)
-(markt)
   
 




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40929] - Misleading comments in StandardClassLoader

2006-11-10 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40929


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2006-11-10 13:07 ---
This has been fixed in SVN and will be in 5.5.21 onwards.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r473474 - /tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/loader/WebappLoader.java

2006-11-10 Thread markt 
Author: markt
Date: Fri Nov 10 13:06:59 2006
New Revision: 473474

URL: http://svn.apache.org/viewvc?view=rev&rev=473474
Log:
Clean up code. No functional change.

Modified:

tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/loader/WebappLoader.java

Modified: 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/loader/WebappLoader.java
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/loader/WebappLoader.java?view=diff&rev=473474&r1=473473&r2=473474
==
--- 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/loader/WebappLoader.java
 (original)
+++ 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/loader/WebappLoader.java
 Fri Nov 10 13:06:59 2006
@@ -49,7 +49,6 @@
 
 import org.apache.catalina.Container;
 import org.apache.catalina.Context;
-import org.apache.catalina.Engine;
 import org.apache.catalina.Globals;
 import org.apache.catalina.Lifecycle;
 import org.apache.catalina.LifecycleException;
@@ -594,7 +593,6 @@
 // Register ourself. The container must be a webapp
 try {
 StandardContext ctx=(StandardContext)container;
-Engine eng=(Engine)ctx.getParent().getParent();
 String path = ctx.getPath();
 if (path.equals("")) {
 path = "/";
@@ -690,7 +688,6 @@
 ((ClassLoader) classLoader, this.container.getResources());
 
 StandardContext ctx=(StandardContext)container;
-Engine eng=(Engine)ctx.getParent().getParent();
 String path = ctx.getPath();
 if (path.equals("")) {
 path = "/";
@@ -739,7 +736,6 @@
 
 try {
 StandardContext ctx=(StandardContext)container;
-Engine eng=(Engine)ctx.getParent().getParent();
 String path = ctx.getPath();
 if (path.equals("")) {
 path = "/";
@@ -772,7 +768,6 @@
 // Validate the source of this event
 if (!(event.getSource() instanceof Context))
 return;
-Context context = (Context) event.getSource();
 
 // Process a relevant property change
 if (event.getPropertyName().equals("reloadable")) {
@@ -1229,15 +1224,11 @@
 org.apache.commons.logging.LogFactory.getLog( WebappLoader.class );
 
 private ObjectName oname;
-private MBeanServer mserver;
-private String domain;
 private ObjectName controller;
 
 public ObjectName preRegister(MBeanServer server,
   ObjectName name) throws Exception {
 oname=name;
-mserver=server;
-domain=name.getDomain();
 
 return name;
 }



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r473473 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/loader/StandardClassLoader.java webapps/docs/changelog.xml

2006-11-10 Thread markt 
Author: markt
Date: Fri Nov 10 13:06:39 2006
New Revision: 473473

URL: http://svn.apache.org/viewvc?view=rev&rev=473473
Log:
Fix bug 40929. Update JavaDoc

Modified:

tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/loader/StandardClassLoader.java
tomcat/container/tc5.5.x/webapps/docs/changelog.xml

Modified: 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/loader/StandardClassLoader.java
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/loader/StandardClassLoader.java?view=diff&rev=473473&r1=473472&r2=473473
==
--- 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/loader/StandardClassLoader.java
 (original)
+++ 
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/loader/StandardClassLoader.java
 Fri Nov 10 13:06:39 2006
@@ -22,23 +22,8 @@
 import java.net.URLClassLoader;
 
 /**
- * Subclass implementation of java.net.URLClassLoader that knows how
- * to load classes from disk directories, as well as local and remote JAR
- * files.  It also implements the Reloader interface, to provide
- * automatic reloading support to the associated loader.
- * 
- * In all cases, URLs must conform to the contract specified by
- * URLClassLoader - any URL that ends with a "/" character is
- * assumed to represent a directory; all other URLs are assumed to be the
- * address of a JAR file.
- * 
- * IMPLEMENTATION NOTE - Local repositories are searched in
- * the order they are added via the initial constructor and/or any subsequent
- * calls to addRepository().
- * 
- * IMPLEMENTATION NOTE - At present, there are no dependencies
- * from this class to any other Catalina class, so that it could be used
- * independently.
+ * Subclass implementation of java.net.URLClassLoader. There are no
+ * functional differences between this class and 
java.net.URLClassLoader.
  *
  * @author Craig R. McClanahan
  * @author Remy Maucherat

Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?view=diff&rev=473473&r1=473472&r2=473473
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Fri Nov 10 13:06:39 2006
@@ -111,6 +111,10 @@
 multi-level context paths and to further discourage use of server.xml
 (markt)
   
+  
+40929: Correct JavaDoc for StandardCalssLoader. (markt)
+(markt)
+  
 

   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40668] - MailSessionFactory is missing in Tomcat 5.5.20

2006-11-10 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40668





--- Additional Comments From [EMAIL PROTECTED]  2006-11-10 10:23 ---
(In reply to comment #11)
> It's probably because JavaMail wasn't on the classpath when 5.5.20 was built.

Good point! I cannot recommend 5.5.20 to for use on any of our development or
production servers when a critical component that we rely on is missing.

Does anyone know when the next release of Tomcat 5.5.x is scheduled? 


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: building TC 5.5.9 failed

2006-11-10 Thread Yoav Shapira 

Check out the history of the build.properties.default file at
http://svn.apache.org/viewvc/tomcat/build/tc5.5.x/build.properties.default?view=log

Specifically look at the old value here:
http://svn.apache.org/viewvc/tomcat/build/tc5.5.x/build.properties.default?r1=354430&r2=380673&diff_format=h

Or even older ones if you wish.

Yoav

On 11/10/06, Jean-frederic Clere <[EMAIL PROTECTED]> wrote:

Hi,

I am not able to build 5.5.9, build failed with:
+++
build-jasper:
 [echo] == Building: jasper

build-only:
[javac] Compiling 87 source files to /home/jfclere/jakarta-
tomcat-5.5.9-src/jakarta-tomcat-5/build/classes
[javac] /home/jfclere/jakarta-tomcat-5.5.9-src/jakarta-tomcat-
jasper/jasper2/src/share/org/apache/jasper/compiler/JDTCompiler.java:194: 
cannot find symbol
[javac] symbol  : constructor NameEnvironmentAnswer
(org.eclipse.jdt.internal.compiler.env.ICompilationUnit)
[javac] location: class
org.eclipse.jdt.internal.compiler.env.NameEnvironmentAnswer
[javac] new NameEnvironmentAnswer
(compilationUnit);
[javac] ^
[javac] /home/jfclere/jakarta-tomcat-5.5.9-src/jakarta-tomcat-
jasper/jasper2/src/share/org/apache/jasper/compiler/JDTCompiler.java:215: 
cannot find symbol
[javac] symbol  : constructor NameEnvironmentAnswer
(org.eclipse.jdt.internal.compiler.classfmt.ClassFileReader)
[javac] location: class
org.eclipse.jdt.internal.compiler.env.NameEnvironmentAnswer
[javac] new NameEnvironmentAnswer
(classFileReader);
[javac] ^
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] 2 errors
+++

Where could I find the right version of eclipse-JDT-3.0.1.zip?

Cheers

Jean-Frederic


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

building TC 5.5.9 failed

2006-11-10 Thread Jean-frederic Clere 
Hi,

I am not able to build 5.5.9, build failed with:
+++
build-jasper:
 [echo] == Building: jasper

build-only:
[javac] Compiling 87 source files to /home/jfclere/jakarta-
tomcat-5.5.9-src/jakarta-tomcat-5/build/classes
[javac] /home/jfclere/jakarta-tomcat-5.5.9-src/jakarta-tomcat-
jasper/jasper2/src/share/org/apache/jasper/compiler/JDTCompiler.java:194: 
cannot find symbol
[javac] symbol  : constructor NameEnvironmentAnswer
(org.eclipse.jdt.internal.compiler.env.ICompilationUnit)
[javac] location: class
org.eclipse.jdt.internal.compiler.env.NameEnvironmentAnswer
[javac] new NameEnvironmentAnswer
(compilationUnit);
[javac] ^
[javac] /home/jfclere/jakarta-tomcat-5.5.9-src/jakarta-tomcat-
jasper/jasper2/src/share/org/apache/jasper/compiler/JDTCompiler.java:215: 
cannot find symbol
[javac] symbol  : constructor NameEnvironmentAnswer
(org.eclipse.jdt.internal.compiler.classfmt.ClassFileReader)
[javac] location: class
org.eclipse.jdt.internal.compiler.env.NameEnvironmentAnswer
[javac] new NameEnvironmentAnswer
(classFileReader);
[javac] ^
[javac] Note: Some input files use or override a deprecated API.
[javac] Note: Recompile with -Xlint:deprecation for details.
[javac] 2 errors
+++

Where could I find the right version of eclipse-JDT-3.0.1.zip?

Cheers

Jean-Frederic


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40070] - APR causes JVM to crashon SEGV

2006-11-10 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40070


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2006-11-10 07:47 ---
Fixed in the SVN. The fix will be available with tomcat-native-1.1.7

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40070] - APR causes JVM to crashon SEGV

2006-11-10 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40070


[EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




--- Additional Comments From [EMAIL PROTECTED]  2006-11-10 07:46 ---
*** Bug 40868 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40868] - tcnative-1 EXCEPTION_ACCES_VIOLATION JVM crash when using IE7

2006-11-10 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40868


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||DUPLICATE




--- Additional Comments From [EMAIL PROTECTED]  2006-11-10 07:46 ---


*** This bug has been marked as a duplicate of 40070 ***

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r473374 - /tomcat/connectors/trunk/jni/native/src/network.c

2006-11-10 Thread mturk 
Author: mturk
Date: Fri Nov 10 07:45:52 2006
New Revision: 473374

URL: http://svn.apache.org/viewvc?view=rev&rev=473374
Log:
Fix #40070 and #40868 by checking if the provided
socket was already destroyed and set to zero instead
crashing.

Modified:
tomcat/connectors/trunk/jni/native/src/network.c

Modified: tomcat/connectors/trunk/jni/native/src/network.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/native/src/network.c?view=diff&rev=473374&r1=473373&r2=473374
==
--- tomcat/connectors/trunk/jni/native/src/network.c (original)
+++ tomcat/connectors/trunk/jni/native/src/network.c Fri Nov 10 07:45:52 2006
@@ -424,7 +424,10 @@
 apr_status_t ss;
 
 UNREFERENCED(o);
-TCN_ASSERT(sock != 0);
+if (!sock) {
+tcn_ThrowAPRException(e, APR_ENOTSOCK);
+return -(jint)APR_ENOTSOCK;
+}
 TCN_ASSERT(s->opaque != NULL);
 #ifdef TCN_DO_STATISTICS
 sp_max_send = TCN_MAX(sp_max_send, nbytes);
@@ -459,7 +462,10 @@
 {
 tcn_socket_t *s = J2P(sock, tcn_socket_t *);
 UNREFERENCED(o);
-TCN_ASSERT(sock != 0);
+if (!sock) {
+tcn_ThrowAPRException(e, APR_ENOTSOCK);
+return;
+}
 TCN_ASSERT(s->opaque != NULL);
 if (buf)
 s->jsbbuff = (char *)(*e)->GetDirectBufferAddress(e, buf);
@@ -472,7 +478,10 @@
 {
 tcn_socket_t *s = J2P(sock, tcn_socket_t *);
 UNREFERENCED(o);
-TCN_ASSERT(sock != 0);
+if (!sock) {
+tcn_ThrowAPRException(e, APR_ENOTSOCK);
+return;
+}
 TCN_ASSERT(s->opaque != NULL);
 if (buf)
 s->jrbbuff = (char *)(*e)->GetDirectBufferAddress(e, buf);
@@ -490,7 +499,10 @@
 apr_status_t ss = APR_SUCCESS;
 
 UNREFERENCED(o);
-TCN_ASSERT(sock != 0);
+if (!sock) {
+tcn_ThrowAPRException(e, APR_ENOTSOCK);
+return -(jint)APR_ENOTSOCK;
+}
 TCN_ASSERT(s->opaque != NULL);
 TCN_ASSERT(buf != NULL);
 #ifdef TCN_DO_STATISTICS
@@ -526,8 +538,11 @@
 apr_size_t sent = 0;
 apr_status_t ss = APR_SUCCESS;
 
-UNREFERENCED_STDARGS;
-TCN_ASSERT(sock != 0);
+UNREFERENCED(o);
+if (!sock) {
+tcn_ThrowAPRException(e, APR_ENOTSOCK);
+return -(jint)APR_ENOTSOCK;
+}
 TCN_ASSERT(s->opaque != NULL);
 TCN_ASSERT(s->jsbbuff != NULL);
 #ifdef TCN_DO_STATISTICS
@@ -746,7 +761,10 @@
 char *bytes;
 
 UNREFERENCED(o);
-TCN_ASSERT(sock != 0);
+if (!sock) {
+tcn_ThrowAPRException(e, APR_ENOTSOCK);
+return -(jint)APR_ENOTSOCK;
+}
 TCN_ASSERT(s->opaque != NULL);
 TCN_ASSERT(buf != NULL);
 
@@ -789,7 +807,11 @@
 apr_status_t ss;
 apr_size_t nbytes = (apr_size_t)len;
 
-UNREFERENCED_STDARGS;
+UNREFERENCED(o);
+if (!sock) {
+tcn_ThrowAPRException(e, APR_ENOTSOCK);
+return -(jint)APR_ENOTSOCK;
+}
 TCN_ASSERT(sock != 0);
 TCN_ASSERT(s->opaque != NULL);
 TCN_ASSERT(s->jrbbuff != NULL);
@@ -834,7 +856,10 @@
 char *bytes;
 
 UNREFERENCED(o);
-TCN_ASSERT(sock != 0);
+if (!sock) {
+tcn_ThrowAPRException(e, APR_ENOTSOCK);
+return -(jint)APR_ENOTSOCK;
+}
 TCN_ASSERT(buf != NULL);
 TCN_ASSERT(s->opaque != NULL);
 
@@ -882,7 +907,11 @@
 apr_size_t nbytes = (apr_size_t)len;
 
 UNREFERENCED_STDARGS;
-TCN_ASSERT(sock != 0);
+UNREFERENCED(o);
+if (!sock) {
+tcn_ThrowAPRException(e, APR_ENOTSOCK);
+return -(jint)APR_ENOTSOCK;
+}
 TCN_ASSERT(s->jrbbuff != NULL);
 TCN_ASSERT(s->opaque != NULL);
 
@@ -930,7 +959,10 @@
 apr_status_t ss;
 
 UNREFERENCED(o);
-TCN_ASSERT(sock != 0);
+if (!sock) {
+tcn_ThrowAPRException(e, APR_ENOTSOCK);
+return -(jint)APR_ENOTSOCK;
+}
 TCN_ASSERT(s->sock != NULL);
 TCN_ASSERT(buf != NULL);
 ss = apr_socket_recvfrom(f, s->sock, (apr_int32_t)flags, (char*)(bytes + 
offset), &nbytes);
@@ -950,10 +982,11 @@
 {
 tcn_socket_t *s = J2P(sock, tcn_socket_t *);
 
-UNREFERENCED_STDARGS;
-TCN_ASSERT(sock != 0);
-if (!s->sock)
-return APR_EINVAL;
+UNREFERENCED(o);
+if (!s->sock) {
+tcn_ThrowAPRException(e, APR_ENOTSOCK);
+return APR_ENOTSOCK;
+}
 else
 return (jint)(*s->net->opt_set)(s->opaque, (apr_int32_t)opt, 
(apr_int32_t)on);
 }
@@ -965,9 +998,8 @@
 apr_int32_t on = 0;
 
 UNREFERENCED(o);
-TCN_ASSERT(sock != 0);
 if (s->sock)
-tcn_ThrowAPRException(e, APR_EINVAL);
+tcn_ThrowAPRException(e, APR_ENOTSOCK);
 else {
 TCN_THROW_IF_ERR((*s->net->opt_get)(s->opaque, (apr_int32_t)opt,
 &on), on);
@@ -981,9 +1013,12 @@
 {
 tcn_socket_t *s = J2P(sock, tcn_socket_t *);
 
-UNREFERENCED_STDARGS;
-TCN_ASSERT(sock != 0);
+UNREFERENCED(o);
 TCN_ASSERT(s->opaque != NULL);
+if (!sock) {
+tcn_ThrowAPRException(e, APR_ENOTSOCK);
+return APR

Re: svn commit: r473346 - /tomcat/tc6.0.x/trunk/build.properties.default

2006-11-10 Thread Mladen Turk 

Remy Maucherat wrote:

[EMAIL PROTECTED] wrote:

Author: mturk
Date: Fri Nov 10 06:23:52 2006
New Revision: 473346

URL: http://svn.apache.org/viewvc?view=rev&rev=473346
Log:
Add version control flags like in 5.5


No, it's to be added when building only, according to what the user is 
building.




OK. Although it requires the manual intervention each time instead
on the single place. The $HOME/build.properties can only contain
a base.path, while everything else is done via build.properties.default
from the svn including the version, without the need to checkout/edit

Anyhow, it's not that important.

Regards,
Mladen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r473358 - /tomcat/tc6.0.x/trunk/build.xml

2006-11-10 Thread mturk 
Author: mturk
Date: Fri Nov 10 06:45:01 2006
New Revision: 473358

URL: http://svn.apache.org/viewvc?view=rev&rev=473358
Log:
Add version info to the build.

Modified:
tomcat/tc6.0.x/trunk/build.xml

Modified: tomcat/tc6.0.x/trunk/build.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/build.xml?view=diff&rev=473358&r1=473357&r2=473358
==
--- tomcat/tc6.0.x/trunk/build.xml (original)
+++ tomcat/tc6.0.x/trunk/build.xml Fri Nov 10 06:45:01 2006
@@ -94,8 +94,14 @@
   
   
 
+
+  
+  
+
 
 
+
+
 
   
 



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r473353 - /tomcat/tc6.0.x/trunk/build.properties.default

2006-11-10 Thread remm 
Author: remm
Date: Fri Nov 10 06:36:49 2006
New Revision: 473353

URL: http://svn.apache.org/viewvc?view=rev&rev=473353
Log:
- Fix version number.

Modified:
tomcat/tc6.0.x/trunk/build.properties.default

Modified: tomcat/tc6.0.x/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/build.properties.default?view=diff&rev=473353&r1=473352&r2=473353
==
--- tomcat/tc6.0.x/trunk/build.properties.default (original)
+++ tomcat/tc6.0.x/trunk/build.properties.default Fri Nov 10 06:36:49 2006
@@ -12,10 +12,9 @@
 # - Vesion Control Flags -
 version.major=6
 version.minor=0
-version.build=2
+version.build=0
 version.patch=0
-#Set the pretty version name
-version=6.0.2
+version=6.0-snapshot
 
 # - Default Base Path for Dependent Packages -
 # Please note this path must be absolute, not relative,



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r473346 - /tomcat/tc6.0.x/trunk/build.properties.default

2006-11-10 Thread Remy Maucherat 

[EMAIL PROTECTED] wrote:

Author: mturk
Date: Fri Nov 10 06:23:52 2006
New Revision: 473346

URL: http://svn.apache.org/viewvc?view=rev&rev=473346
Log:
Add version control flags like in 5.5


No, it's to be added when building only, according to what the user is 
building.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r473349 - in /tomcat/tc6.0.x/trunk/native/connector: include/tcn.h src/network.c src/sslnetwork.c

2006-11-10 Thread mturk 
Author: mturk
Date: Fri Nov 10 06:26:11 2006
New Revision: 473349

URL: http://svn.apache.org/viewvc?view=rev&rev=473349
Log:
Backport from tomcat-connectors.
Fix coredump when the client socket is inside read/write
operation (not closed), and the Tomcat is shutdown.
The pool was destroyed twice in that case.

Modified:
tomcat/tc6.0.x/trunk/native/connector/include/tcn.h
tomcat/tc6.0.x/trunk/native/connector/src/network.c
tomcat/tc6.0.x/trunk/native/connector/src/sslnetwork.c

Modified: tomcat/tc6.0.x/trunk/native/connector/include/tcn.h
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/native/connector/include/tcn.h?view=diff&rev=473349&r1=473348&r2=473349
==
--- tomcat/tc6.0.x/trunk/native/connector/include/tcn.h (original)
+++ tomcat/tc6.0.x/trunk/native/connector/include/tcn.h Fri Nov 10 06:26:11 2006
@@ -145,6 +145,7 @@
 
 typedef struct {
 apr_pool_t   *pool;
+apr_pool_t   *child;
 apr_socket_t *sock;
 void *opaque;
 char *jsbbuff;

Modified: tomcat/tc6.0.x/trunk/native/connector/src/network.c
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/native/connector/src/network.c?view=diff&rev=473349&r1=473348&r2=473349
==
--- tomcat/tc6.0.x/trunk/native/connector/src/network.c (original)
+++ tomcat/tc6.0.x/trunk/native/connector/src/network.c Fri Nov 10 06:26:11 2006
@@ -83,8 +83,9 @@
 if (s->net && s->net->cleanup)
 (*s->net->cleanup)(s->opaque);
 if (s->sock) {
-apr_socket_close(s->sock);
+apr_socket_t *as = s->sock;
 s->sock = NULL;
+apr_socket_close(as);
 }
 #ifdef TCN_DO_STATISTICS
 apr_atomic_inc32(&sp_cleared);
@@ -181,6 +182,15 @@
 GET_S_FAMILY(f, family);
 GET_S_TYPE(t, type);
 
+a = (tcn_socket_t *)apr_pcalloc(p, sizeof(tcn_socket_t));
+TCN_CHECK_ALLOCATED(a);
+a->pool = p;
+if (family >= 0)
+a->net = &apr_socket_layer;
+apr_pool_cleanup_register(p, (const void *)a,
+  sp_socket_cleanup,
+  apr_pool_cleanup_null);
+
 if (family >= 0) {
 TCN_THROW_IF_ERR(apr_socket_create(&s,
  f, t, protocol, p), a);
@@ -188,19 +198,15 @@
 #ifdef TCN_DO_STATISTICS
 sp_created++;
 #endif
-a = (tcn_socket_t *)apr_pcalloc(p, sizeof(tcn_socket_t));
-TCN_CHECK_ALLOCATED(a);
 a->sock = s;
-a->pool = p;
 if (family >= 0)
 a->net = &apr_socket_layer;
 a->opaque   = s;
-apr_pool_cleanup_register(p, (const void *)a,
-  sp_socket_cleanup,
-  apr_pool_cleanup_null);
+apr_pool_create(&a->child, a->pool);
 
-cleanup:
 return P2J(a);
+cleanup:
+return 0;
 
 }
 
@@ -209,6 +215,18 @@
 tcn_socket_t *s = J2P(sock, tcn_socket_t *);
 UNREFERENCED_STDARGS;
 TCN_ASSERT(sock != 0);
+
+apr_pool_cleanup_kill(s->pool, s, sp_socket_cleanup);
+if (s->net && s->net->cleanup) {
+(*s->net->cleanup)(s->opaque);
+s->net = NULL;
+}
+if (s->sock) {
+apr_socket_t *as = s->sock;
+s->sock = NULL;
+apr_socket_close(as);
+}
+
 apr_pool_destroy(s->pool);
 }
 
@@ -264,6 +282,10 @@
 UNREFERENCED_STDARGS;
 TCN_ASSERT(sock != 0);
 
+apr_pool_cleanup_kill(s->pool, s, sp_socket_cleanup);
+if (s->child) {
+apr_pool_clear(s->child);
+}
 #ifdef TCN_DO_STATISTICS
 apr_atomic_inc32(&sp_closed);
 #endif
@@ -272,8 +294,9 @@
 s->net = NULL;
 }
 if (s->sock) {
-rv = (jint)apr_socket_close(s->sock);
+apr_socket_t *as = s->sock;
 s->sock = NULL;
+rv = (jint)apr_socket_close(as);
 }
 return rv;
 }
@@ -316,6 +339,13 @@
 
 if (s->net->type == TCN_SOCKET_APR) {
 TCN_ASSERT(s->sock != NULL);
+a = (tcn_socket_t *)apr_pcalloc(p, sizeof(tcn_socket_t));
+TCN_CHECK_ALLOCATED(a);
+a->pool   = p;
+apr_pool_cleanup_register(p, (const void *)a,
+  sp_socket_cleanup,
+  apr_pool_cleanup_null);
+
 TCN_THROW_IF_ERR(apr_socket_accept(&n, s->sock, p), n);
 }
 else {
@@ -326,15 +356,9 @@
 #ifdef TCN_DO_STATISTICS
 apr_atomic_inc32(&sp_accepted);
 #endif
-a = (tcn_socket_t *)apr_pcalloc(p, sizeof(tcn_socket_t));
-TCN_CHECK_ALLOCATED(a);
-a->sock   = n;
-a->pool   = p;
 a->net= &apr_socket_layer;
+a->sock   = n;
 a->opaque = n;
-apr_pool_cleanup_register(p, (const void *)a,
-  sp_socket_cleanup,
-  apr_pool_cleanup_null);
 }
 
 cleanup:
@@ -354,6 +378,13 @@
 TCN_THROW_IF_ERR(apr_pool_create(&p, s->pool), p);
 if (s->net->type == TCN_SOCKET_APR) {
 TCN_ASS

svn commit: r473346 - /tomcat/tc6.0.x/trunk/build.properties.default

2006-11-10 Thread mturk 
Author: mturk
Date: Fri Nov 10 06:23:52 2006
New Revision: 473346

URL: http://svn.apache.org/viewvc?view=rev&rev=473346
Log:
Add version control flags like in 5.5

Modified:
tomcat/tc6.0.x/trunk/build.properties.default

Modified: tomcat/tc6.0.x/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/build.properties.default?view=diff&rev=473346&r1=473345&r2=473346
==
--- tomcat/tc6.0.x/trunk/build.properties.default (original)
+++ tomcat/tc6.0.x/trunk/build.properties.default Fri Nov 10 06:23:52 2006
@@ -9,6 +9,14 @@
 # $Id$
 # -
 
+# - Vesion Control Flags -
+version.major=6
+version.minor=0
+version.build=2
+version.patch=0
+#Set the pretty version name
+version=6.0.2
+
 # - Default Base Path for Dependent Packages -
 # Please note this path must be absolute, not relative,
 # as it is referenced with different working directory



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r473341 - in /tomcat/connectors/trunk/jni/native: include/tcn.h src/network.c

2006-11-10 Thread mturk 
Author: mturk
Date: Fri Nov 10 05:55:47 2006
New Revision: 473341

URL: http://svn.apache.org/viewvc?view=rev&rev=473341
Log:
Fix coredump when the client socket is inside read/write
operation (not closed), and the Tomcat is shutdown.
The pool was destroyed twice in that case.

Modified:
tomcat/connectors/trunk/jni/native/include/tcn.h
tomcat/connectors/trunk/jni/native/src/network.c

Modified: tomcat/connectors/trunk/jni/native/include/tcn.h
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/native/include/tcn.h?view=diff&rev=473341&r1=473340&r2=473341
==
--- tomcat/connectors/trunk/jni/native/include/tcn.h (original)
+++ tomcat/connectors/trunk/jni/native/include/tcn.h Fri Nov 10 05:55:47 2006
@@ -145,6 +145,7 @@
 
 typedef struct {
 apr_pool_t   *pool;
+apr_pool_t   *child;
 apr_socket_t *sock;
 void *opaque;
 char *jsbbuff;

Modified: tomcat/connectors/trunk/jni/native/src/network.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/native/src/network.c?view=diff&rev=473341&r1=473340&r2=473341
==
--- tomcat/connectors/trunk/jni/native/src/network.c (original)
+++ tomcat/connectors/trunk/jni/native/src/network.c Fri Nov 10 05:55:47 2006
@@ -202,8 +202,11 @@
 if (family >= 0)
 a->net = &apr_socket_layer;
 a->opaque   = s;
-cleanup:
+apr_pool_create(&a->child, a->pool);
+
 return P2J(a);
+cleanup:
+return 0;
 
 }
 
@@ -213,6 +216,7 @@
 UNREFERENCED_STDARGS;
 TCN_ASSERT(sock != 0);
 
+apr_pool_cleanup_kill(s->pool, s, sp_socket_cleanup);
 if (s->net && s->net->cleanup) {
 (*s->net->cleanup)(s->opaque);
 s->net = NULL;
@@ -278,6 +282,10 @@
 UNREFERENCED_STDARGS;
 TCN_ASSERT(sock != 0);
 
+apr_pool_cleanup_kill(s->pool, s, sp_socket_cleanup);
+if (s->child) {
+apr_pool_clear(s->child);
+}
 #ifdef TCN_DO_STATISTICS
 apr_atomic_inc32(&sp_closed);
 #endif
@@ -373,7 +381,7 @@
 a = (tcn_socket_t *)apr_pcalloc(p, sizeof(tcn_socket_t));
 TCN_CHECK_ALLOCATED(a);
 a->pool   = p;
-apr_pool_cleanup_register(p, (const void *)a,
+apr_pool_cleanup_register(s->child, (const void *)a,
   sp_socket_cleanup,
   apr_pool_cleanup_null);
 
@@ -1219,7 +1227,7 @@
 void *rv = NULL;
 
 UNREFERENCED(o);
-TCN_ASSERT(sock != 0);
+TCN_ASSERT(socket != 0);
 
 if (apr_socket_data_get(&rv, J2S(key), s->sock) != APR_SUCCESS) {
 rv = NULL;



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 40668] - MailSessionFactory is missing in Tomcat 5.5.20

2006-11-10 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40668





--- Additional Comments From [EMAIL PROTECTED]  2006-11-10 04:28 ---
This looks similar to bug 29255.

It's probably because JavaMail wasn't on the classpath when 5.5.20 was built.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

[EMAIL PROTECTED]: Project tomcat-tc6-dbcp (in module tomcat-tc6) failed

2006-11-10 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project tomcat-tc6-dbcp has an issue affecting its community integration.
This issue affects 2 projects,
 and has been outstanding for 5 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc6 :  Java Servlet 2.5 & Server Pages JSP 2.1 implementation (for 
...
- tomcat-tc6-dbcp :  Java Servlet 2.5 & Server Pages JSP 2.1 implementation 
(for ...


Full details are available at:
http://vmgump.apache.org/gump/public/tomcat-tc6/tomcat-tc6-dbcp/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole output [tomcat-jdbc-10112006.jar] identifier set to project name
 -INFO- Made directory [/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps]
 -INFO- Failed with reason build failed
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-tc6/tomcat-tc6-dbcp/gump_work/build_tomcat-tc6_tomcat-tc6-dbcp.html
Work Name: build_tomcat-tc6_tomcat-tc6-dbcp (Type: Build)
Work ended in a state of : Failed
Elapsed: 6 secs
Command Line: java -Djava.awt.headless=true org.apache.tools.ant.Main 
-Dgump.merge=/x1/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only 
-Dcommons-collections.home=/usr/local/gump/public/workspace/jakarta-commons/collections
 -Dcommons-dbcp.home=/usr/local/gump/public/workspace/jakarta-commons/dbcp 
-Dtomcat-dbcp.jar=/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/tomcat-jdbc-10112006.jar
 -Dtomcat-dbcp.home=/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps 
-Dcommons-pool.home=/usr/local/gump/public/workspace/jakarta-commons/pool 
build-tomcat-dbcp 
[Working Directory: /usr/local/gump/public/workspace/tomcat-tc6]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar
-
Buildfile: build.xml

build-tomcat-dbcp:
 [copy] Copying 104 files to 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps
[mkdir] Created dir: 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/src/java/org/apache/tomcat/dbcp
 [move] Moving 92 files to 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/src/java/org/apache/tomcat/dbcp
[mkdir] Created dir: 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/classes
[javac] Compiling 92 source files to 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/classes
[javac] 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/src/java/org/apache/tomcat/dbcp/pool/PoolUtils.java:20:
 cannot find symbol
[javac] symbol  : class StackKeyedObjectPool
[javac] location: package org.apache.tomcat.dbcp.pool.impl
[javac] import org.apache.tomcat.dbcp.pool.impl.StackKeyedObjectPool;
[javac] ^
[javac] 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/src/java/org/apache/tomcat/dbcp/pool/PoolUtils.java:22:
 cannot find symbol
[javac] symbol  : class SoftReferenceObjectPool
[javac] location: package org.apache.tomcat.dbcp.pool.impl
[javac] import org.apache.tomcat.dbcp.pool.impl.SoftReferenceObjectPool;
[javac] ^
[javac] 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/src/java/org/apache/tomcat/dbcp/pool/PoolUtils.java:23:
 cannot find symbol
[javac] symbol  : class StackObjectPool
[javac] location: package org.apache.tomcat.dbcp.pool.impl
[javac] import org.apache.tomcat.dbcp.pool.impl.StackObjectPool;
[javac] ^
[javac] 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/src/java/org/apache/tomcat/dbcp/pool/PoolUtils.java:350:
 cannot find symbol
[javac] symbol  : class SoftReferenceObjectPool
[javac] location: class org.apache.tomcat.dbcp.pool.PoolUtils
[javac] assert !(pool instanceof SoftReferenceObjectPool)
[javac]  ^
[javac] 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/src/java/org/apache/tomcat/dbcp/pool/PoolUtils.java:352:
 c

[EMAIL PROTECTED]: Project tomcat-tc6-dbcp (in module tomcat-tc6) failed

2006-11-10 Thread Bill Barker 
To whom it may engage...

This is an automated request, but not an unsolicited one. For 
more information please visit http://gump.apache.org/nagged.html, 
and/or contact the folk at [EMAIL PROTECTED]

Project tomcat-tc6-dbcp has an issue affecting its community integration.
This issue affects 2 projects,
 and has been outstanding for 5 runs.
The current state of this project is 'Failed', with reason 'Build Failed'.
For reference only, the following projects are affected by this:
- tomcat-tc6 :  Java Servlet 2.5 & Server Pages JSP 2.1 implementation (for 
...
- tomcat-tc6-dbcp :  Java Servlet 2.5 & Server Pages JSP 2.1 implementation 
(for ...


Full details are available at:
http://vmgump.apache.org/gump/public/tomcat-tc6/tomcat-tc6-dbcp/index.html

That said, some information snippets are provided here.

The following annotations (debug/informational/warning/error messages) were 
provided:
 -DEBUG- Sole output [tomcat-jdbc-10112006.jar] identifier set to project name
 -INFO- Made directory [/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps]
 -INFO- Failed with reason build failed
 -INFO- Failed to extract fallback artifacts from Gump Repository



The following work was performed:
http://vmgump.apache.org/gump/public/tomcat-tc6/tomcat-tc6-dbcp/gump_work/build_tomcat-tc6_tomcat-tc6-dbcp.html
Work Name: build_tomcat-tc6_tomcat-tc6-dbcp (Type: Build)
Work ended in a state of : Failed
Elapsed: 6 secs
Command Line: java -Djava.awt.headless=true org.apache.tools.ant.Main 
-Dgump.merge=/x1/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only 
-Dcommons-collections.home=/usr/local/gump/public/workspace/jakarta-commons/collections
 -Dcommons-dbcp.home=/usr/local/gump/public/workspace/jakarta-commons/dbcp 
-Dtomcat-dbcp.jar=/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/tomcat-jdbc-10112006.jar
 -Dtomcat-dbcp.home=/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps 
-Dcommons-pool.home=/usr/local/gump/public/workspace/jakarta-commons/pool 
build-tomcat-dbcp 
[Working Directory: /usr/local/gump/public/workspace/tomcat-tc6]
CLASSPATH: 
/opt/jdk1.5/lib/tools.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-swing.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-trax.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-junit.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/usr/local/gump/public/workspace/ant/dist/lib/ant.jar:/usr/local/gump/packages/junit3.8.1/junit.jar:/usr/local/gump/public/workspace/xml-commons/java/build/resolver.jar
-
Buildfile: build.xml

build-tomcat-dbcp:
 [copy] Copying 104 files to 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps
[mkdir] Created dir: 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/src/java/org/apache/tomcat/dbcp
 [move] Moving 92 files to 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/src/java/org/apache/tomcat/dbcp
[mkdir] Created dir: 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/classes
[javac] Compiling 92 source files to 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/classes
[javac] 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/src/java/org/apache/tomcat/dbcp/pool/PoolUtils.java:20:
 cannot find symbol
[javac] symbol  : class StackKeyedObjectPool
[javac] location: package org.apache.tomcat.dbcp.pool.impl
[javac] import org.apache.tomcat.dbcp.pool.impl.StackKeyedObjectPool;
[javac] ^
[javac] 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/src/java/org/apache/tomcat/dbcp/pool/PoolUtils.java:22:
 cannot find symbol
[javac] symbol  : class SoftReferenceObjectPool
[javac] location: package org.apache.tomcat.dbcp.pool.impl
[javac] import org.apache.tomcat.dbcp.pool.impl.SoftReferenceObjectPool;
[javac] ^
[javac] 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/src/java/org/apache/tomcat/dbcp/pool/PoolUtils.java:23:
 cannot find symbol
[javac] symbol  : class StackObjectPool
[javac] location: package org.apache.tomcat.dbcp.pool.impl
[javac] import org.apache.tomcat.dbcp.pool.impl.StackObjectPool;
[javac] ^
[javac] 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/src/java/org/apache/tomcat/dbcp/pool/PoolUtils.java:350:
 cannot find symbol
[javac] symbol  : class SoftReferenceObjectPool
[javac] location: class org.apache.tomcat.dbcp.pool.PoolUtils
[javac] assert !(pool instanceof SoftReferenceObjectPool)
[javac]  ^
[javac] 
/usr/local/gump/public/workspace/tomcat-tc6/tomcat-deps/src/java/org/apache/tomcat/dbcp/pool/PoolUtils.java:352:
 c

DO NOT REPLY [Bug 40925] - APR connector JVM crash

2006-11-10 Thread bugzilla 
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=40925





--- Additional Comments From [EMAIL PROTECTED]  2006-11-10 01:56 ---
Can you check the current SVN trunk?

$> svn export
http://svn.apache.org/repos/asf/tomcat/connectors/trunk/jni/native/ 
tomcat-native
$> cd tomcat-native
$> ./buildconf --with-apr=...
$> ./configure --with-apr=...
$> make && make install

Regards.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r473293 - in /tomcat/connectors/trunk/jni/native/src: network.c sslnetwork.c

2006-11-10 Thread mturk 
Author: mturk
Date: Fri Nov 10 01:53:30 2006
New Revision: 473293

URL: http://svn.apache.org/viewvc?view=rev&rev=473293
Log:
Make sure we register out cleanups before APR cleanups
gets registered.

Modified:
tomcat/connectors/trunk/jni/native/src/network.c
tomcat/connectors/trunk/jni/native/src/sslnetwork.c

Modified: tomcat/connectors/trunk/jni/native/src/network.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/native/src/network.c?view=diff&rev=473293&r1=473292&r2=473293
==
--- tomcat/connectors/trunk/jni/native/src/network.c (original)
+++ tomcat/connectors/trunk/jni/native/src/network.c Fri Nov 10 01:53:30 2006
@@ -83,8 +83,9 @@
 if (s->net && s->net->cleanup)
 (*s->net->cleanup)(s->opaque);
 if (s->sock) {
-apr_socket_close(s->sock);
+apr_socket_t *as = s->sock;
 s->sock = NULL;
+apr_socket_close(as);
 }
 #ifdef TCN_DO_STATISTICS
 apr_atomic_inc32(&sp_cleared);
@@ -181,6 +182,15 @@
 GET_S_FAMILY(f, family);
 GET_S_TYPE(t, type);
 
+a = (tcn_socket_t *)apr_pcalloc(p, sizeof(tcn_socket_t));
+TCN_CHECK_ALLOCATED(a);
+a->pool = p;
+if (family >= 0)
+a->net = &apr_socket_layer;
+apr_pool_cleanup_register(p, (const void *)a,
+  sp_socket_cleanup,
+  apr_pool_cleanup_null);
+
 if (family >= 0) {
 TCN_THROW_IF_ERR(apr_socket_create(&s,
  f, t, protocol, p), a);
@@ -188,17 +198,10 @@
 #ifdef TCN_DO_STATISTICS
 sp_created++;
 #endif
-a = (tcn_socket_t *)apr_pcalloc(p, sizeof(tcn_socket_t));
-TCN_CHECK_ALLOCATED(a);
 a->sock = s;
-a->pool = p;
 if (family >= 0)
 a->net = &apr_socket_layer;
 a->opaque   = s;
-apr_pool_cleanup_register(p, (const void *)a,
-  sp_socket_cleanup,
-  apr_pool_cleanup_null);
-
 cleanup:
 return P2J(a);
 
@@ -209,6 +212,17 @@
 tcn_socket_t *s = J2P(sock, tcn_socket_t *);
 UNREFERENCED_STDARGS;
 TCN_ASSERT(sock != 0);
+
+if (s->net && s->net->cleanup) {
+(*s->net->cleanup)(s->opaque);
+s->net = NULL;
+}
+if (s->sock) {
+apr_socket_t *as = s->sock;
+s->sock = NULL;
+apr_socket_close(as);
+}
+
 apr_pool_destroy(s->pool);
 }
 
@@ -272,8 +286,9 @@
 s->net = NULL;
 }
 if (s->sock) {
-rv = (jint)apr_socket_close(s->sock);
+apr_socket_t *as = s->sock;
 s->sock = NULL;
+rv = (jint)apr_socket_close(as);
 }
 return rv;
 }
@@ -316,6 +331,13 @@
 
 if (s->net->type == TCN_SOCKET_APR) {
 TCN_ASSERT(s->sock != NULL);
+a = (tcn_socket_t *)apr_pcalloc(p, sizeof(tcn_socket_t));
+TCN_CHECK_ALLOCATED(a);
+a->pool   = p;
+apr_pool_cleanup_register(p, (const void *)a,
+  sp_socket_cleanup,
+  apr_pool_cleanup_null);
+
 TCN_THROW_IF_ERR(apr_socket_accept(&n, s->sock, p), n);
 }
 else {
@@ -326,15 +348,9 @@
 #ifdef TCN_DO_STATISTICS
 apr_atomic_inc32(&sp_accepted);
 #endif
-a = (tcn_socket_t *)apr_pcalloc(p, sizeof(tcn_socket_t));
-TCN_CHECK_ALLOCATED(a);
-a->sock   = n;
-a->pool   = p;
 a->net= &apr_socket_layer;
+a->sock   = n;
 a->opaque = n;
-apr_pool_cleanup_register(p, (const void *)a,
-  sp_socket_cleanup,
-  apr_pool_cleanup_null);
 }
 
 cleanup:
@@ -354,6 +370,13 @@
 TCN_THROW_IF_ERR(apr_pool_create(&p, s->pool), p);
 if (s->net->type == TCN_SOCKET_APR) {
 TCN_ASSERT(s->sock != NULL);
+a = (tcn_socket_t *)apr_pcalloc(p, sizeof(tcn_socket_t));
+TCN_CHECK_ALLOCATED(a);
+a->pool   = p;
+apr_pool_cleanup_register(p, (const void *)a,
+  sp_socket_cleanup,
+  apr_pool_cleanup_null);
+
 TCN_THROW_IF_ERR(apr_socket_accept(&n, s->sock, p), n);
 }
 else {
@@ -364,15 +387,9 @@
 #ifdef TCN_DO_STATISTICS
 apr_atomic_inc32(&sp_accepted);
 #endif
-a = (tcn_socket_t *)apr_pcalloc(p, sizeof(tcn_socket_t));
-TCN_CHECK_ALLOCATED(a);
-a->sock   = n;
-a->pool   = p;
 a->net= &apr_socket_layer;
+a->sock   = n;
 a->opaque = n;
-apr_pool_cleanup_register(p, (const void *)a,
-  sp_socket_cleanup,
-  apr_pool_cleanup_null);
 }
 return P2J(a);
 cleanup:

Modified: tomcat/connectors/trunk/jni/native/src/sslnetwork.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jni/native/src/sslnetwork.c?view=diff&rev=473293&r1=473292&r2=473293