DO NOT REPLY [Bug 42076] New: - typo in ForwardSSLCertChain JkOptions

2007-04-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=42076.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42076

   Summary: typo in  ForwardSSLCertChain JkOptions
   Product: Tomcat 5
   Version: Unknown
  Platform: All
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Native:JK
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


Recently, ForwardSSLCertChain option was added to mod_jk for apache.

Although document and sources' comment indicate ForwardSSLCertChain, but code is
written as ForwardCertChain.

Here is a patch for fixing typo

Index: apache-1.3/mod_jk.c
===
--- apache-1.3/mod_jk.c (revision 527056)
+++ apache-1.3/mod_jk.c (working copy)
@@ -1738,7 +1738,7 @@
 else if (!strcasecmp(w, DisableReuse)) {
 opt = JK_OPT_DISABLEREUSE;
 }
-else if (!strcasecmp(w, ForwardCertChain)) {
+else if (!strcasecmp(w, ForwardSSLCertChain)) {
 opt = JK_OPT_FWDCERTCHAIN;
 }
 else
Index: apache-2.0/mod_jk.c
===
--- apache-2.0/mod_jk.c (revision 527056)
+++ apache-2.0/mod_jk.c (working copy)
@@ -1771,7 +1771,7 @@
 else if (!strcasecmp(w, DisableReuse)) {
 opt = JK_OPT_DISABLEREUSE;
 }
-else if (!strcasecmp(w, ForwardCertChain)) {
+else if (!strcasecmp(w, ForwardSSLCertChain)) {
 opt = JK_OPT_FWDCERTCHAIN;
 }
 else

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r527077 - in /tomcat/connectors/trunk/jk/native: apache-1.3/mod_jk.c apache-2.0/mod_jk.c

2007-04-10 Thread rjung
Author: rjung
Date: Tue Apr 10 03:03:05 2007
New Revision: 527077

URL: http://svn.apache.org/viewvc?view=revrev=527077
Log:
Fix new option ForwardCertChain - ForwardSSLCertChain
like it was documented.

Modified:
tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c
tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c

Modified: tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c?view=diffrev=527077r1=527076r2=527077
==
--- tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c (original)
+++ tomcat/connectors/trunk/jk/native/apache-1.3/mod_jk.c Tue Apr 10 03:03:05 
2007
@@ -1738,7 +1738,7 @@
 else if (!strcasecmp(w, DisableReuse)) {
 opt = JK_OPT_DISABLEREUSE;
 }
-else if (!strcasecmp(w, ForwardCertChain)) {
+else if (!strcasecmp(w, ForwardSSLCertChain)) {
 opt = JK_OPT_FWDCERTCHAIN;
 }
 else

Modified: tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c?view=diffrev=527077r1=527076r2=527077
==
--- tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c (original)
+++ tomcat/connectors/trunk/jk/native/apache-2.0/mod_jk.c Tue Apr 10 03:03:05 
2007
@@ -1771,7 +1771,7 @@
 else if (!strcasecmp(w, DisableReuse)) {
 opt = JK_OPT_DISABLEREUSE;
 }
-else if (!strcasecmp(w, ForwardCertChain)) {
+else if (!strcasecmp(w, ForwardSSLCertChain)) {
 opt = JK_OPT_FWDCERTCHAIN;
 }
 else



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 42077] New: - the iterator from javax.el.CompositeELResolver#getFeatureDescriptor() must not return null values

2007-04-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=42077.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42077

   Summary: the iterator from
javax.el.CompositeELResolver#getFeatureDescriptor() must
not return null values
   Product: Tomcat 6
   Version: 6.0.11
  Platform: All
OS/Version: All
Status: NEW
  Severity: major
  Priority: P2
 Component: Catalina
AssignedTo: tomcat-dev@jakarta.apache.org
ReportedBy: [EMAIL PROTECTED]


According to the spec the iterator which is returned by
javax.el.CompositeELResolver#getFeatureDescriptor() must skip any null
FeatureDescriptor of a containing el resolver.

Currently any feature descriptor value is returned whether it is null or not.

I have a working testcase (including a fix) in myfaces 1.2 
TestCase:
http://svn.apache.org/viewvc/myfaces/core/branches/jsf12/impl/src/test/java/org/apache/myfaces/el/CompositeELResolverTest.java?revision=527076pathrev=527076
Fix:
http://svn.apache.org/viewvc/myfaces/core/branches/jsf12/impl/src/main/java/org/apache/myfaces/el/CompositeELResolver.java?revision=527076pathrev=527076

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r527079 - /tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml

2007-04-10 Thread rjung
Author: rjung
Date: Tue Apr 10 03:05:16 2007
New Revision: 527079

URL: http://svn.apache.org/viewvc?view=revrev=527079
Log:
Add changelog item for fixing ForwardCertChain - ForwardSSLCertChain.
(BZ 42076)

Modified:
tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml

Modified: tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml?view=diffrev=527079r1=527078r2=527079
==
--- tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml Tue Apr 10 
03:05:16 2007
@@ -27,6 +27,10 @@
   subsection name=Native
 changelog
   fix
+bug42076/bug: Fix name of new option from ForwardCertChain to
+ForwardSSLCertChain as documented. (rjung)
+  /fix
+  fix
   Docs: Fix a couple of typos, change format of a few tables,
   fix links to news pages. (rjung)
   /fix



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 42076] - typo in ForwardSSLCertChain JkOptions

2007-04-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=42076.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42076


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2007-04-10 03:06 ---
This fix will be part of 1.2.22, which is the first release with this new 
feature.
The release will be done soon.
Thanks for reporting this in time.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 42038] - JK uriworkermap ROOT mapping causes non-virtual exclusions to be ignored

2007-04-10 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=42038.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42038


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||WONTFIX




--- Additional Comments From [EMAIL PROTECTED]  2007-04-10 07:08 ---
Hi,

 /*=v7CDALiveWorker
This is wrong.
In case you have multiple virtual hosts you shuld never do that.
Always use the /VHOST/URI form:
/lsa-cmsdev1.lsa.adsroot.itcs.umich.edu/*=v7CDALiveWorker
or at least ...
/*/*=v7CDALiveWorker

 #Exclude static files (take turns commenting out the following for testing)
 !/lsa-cmsdev1.lsa.adsroot.itcs.umich.edu/UMICH/*=v7CDALiveWorker
 !/UMICH/*=v7CDALiveWorker

Again, use the:
!/*/UMICH/*=v7CDALiveWorker

There is simply no way to know what the virtual host is from the
uriworkermap.properties unless we change the configuration, and
mark the VHOST part somehow. That would make configs backward incompatible,
so it'll have to wait some post 1.2 version


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Jk_isapi_plugin.c bug #42038 in JK 1.2.20, 21, 22

2007-04-10 Thread Coffman, Steven
Hi,
I have a question for 42038. I only recently figured out exactly what
was causing it, so I'm sorry for the bugzilla spam as I zeroed in on it.

(FYI, On IIS, virtual host name can be optionally prefixed, so /*
positive mount always succeeds even if there are non-virtual exclusion
mounts) 

Even if I reverse the order in jk_isapi_plugin.c so that it checks
Default redirection map_uri_to_worker before attempting a Virtual Host
Redirection map_uri_to_worker, it then still needs additional
information to be communicated (that it both matched and no matched for
Default so it should skip Virtual). That either means an additional
parameter (with side effects) passed to map_uri_to_worker, or a global
variable. Either way, it means changing code other code that uses the
map_uri_to_worker. I would prefer to add another parameter.

Is this legit? Can I submit a patch? Or is there an alternate approach
that is preferred?

PS. I just now found Rainer's message:
[snip]
8) BZ http://issues.apache.org/bugzilla/show_bug.cgi?id=42038
=

This is special to IIS. I think it's not a show stopper (it's also not
new), but interesting. Because IIS has the option of prefixing the URL
with the vhost name, exclusion mounts do not work, once you add /* the
the list of positive mounts.

[snip]

Again, sorry for the bugzilla spam.
-Steve

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r527143 - in /tomcat/connectors/trunk/jk: native/common/jk_util.c xdocs/miscellaneous/changelog.xml

2007-04-10 Thread mturk
Author: mturk
Date: Tue Apr 10 07:29:48 2007
New Revision: 527143

URL: http://svn.apache.org/viewvc?view=revrev=527143
Log:
Make fail_on_status multiline

Modified:
tomcat/connectors/trunk/jk/native/common/jk_util.c
tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml

Modified: tomcat/connectors/trunk/jk/native/common/jk_util.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_util.c?view=diffrev=527143r1=527142r2=527143
==
--- tomcat/connectors/trunk/jk/native/common/jk_util.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_util.c Tue Apr 10 07:29:48 2007
@@ -142,6 +142,7 @@
 USER_OF_WORKER,
 GOOD_RATING_OF_WORKER,
 BAD_RATING_OF_WORKER,
+STATUS_FAIL_OF_WORKER,
 list,
 NULL
 };
@@ -188,7 +189,6 @@
 XML_NAMESPACE_OF_WORKER,
 XML_DOCTYPE_OF_WORKER,
 PROP_PREFIX_OF_WORKER,
-STATUS_FAIL_OF_WORKER,
 USER_CASE_OF_WORKER,
 NULL
 };

Modified: tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml?view=diffrev=527143r1=527142r2=527143
==
--- tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml (original)
+++ tomcat/connectors/trunk/jk/xdocs/miscellaneous/changelog.xml Tue Apr 10 
07:29:48 2007
@@ -27,6 +27,16 @@
   subsection name=Native
 changelog
   fix
+  Refactor line endings logging to make it correct for all
+  platforms and webservers. (mturk)
+  /fix
+  update
+  Added command line windows make files. (mturk)
+  /update
+  update
+  Allow fail_on_status directive to be multi line. (mturk)
+  /update
+  fix
 bug42076/bug: Fix name of new option from ForwardCertChain to
 ForwardSSLCertChain as documented. (rjung)
   /fix
@@ -479,7 +489,7 @@
   LB: Cleanup of Mladens forced recovery. (rjung)
   /fix
   fix
-  LB: Do not change lb_value for recovering workers to max, if 
+  LB: Do not change lb_value for recovering workers to max, if
   we are using BUSYNESS method. (rjung)
   /fix
   fix



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Jk_isapi_plugin.c bug #42038 in JK 1.2.20, 21, 22

2007-04-10 Thread Mladen Turk

Coffman, Steven wrote:

Hi,
I have a question for 42038. I only recently figured out exactly what
was causing it, so I'm sorry for the bugzilla spam as I zeroed in on it.



I already explain that in the bz case.
Please do not steal threads!

Regards,
Mladen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: Tagging 1.2.22

2007-04-10 Thread Guenter Knauf
Hi Rainer,
 - Fix whitespace in Netware make file
non-important, was more a test that commit works again; please drop from the 
list.

Guenter.



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r527334 - /tomcat/tc6.0.x/tags/TOMCAT_6_0_11/

2007-04-10 Thread remm
Author: remm
Date: Tue Apr 10 15:56:49 2007
New Revision: 527334

URL: http://svn.apache.org/viewvc?view=revrev=527334
Log:
- 6.0.11. Candidate binaries will be available tomorrow.

Added:
tomcat/tc6.0.x/tags/TOMCAT_6_0_11/
  - copied from r527333, tomcat/tc6.0.x/trunk/


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]