DO NOT REPLY [Bug 42782] New: - problem while defining a context in server.xml file

2007-06-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42782

   Summary: problem while defining a context in server.xml file
   Product: Tomcat 6
   Version: 6.0.3
  Platform: Other
OS/Version: Linux
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


I defined to specified host (espadrille) and when I enter the follwing url :
http://espadrille:8082/fred/

i cannot access to the pintpoint directory (/home/peadev/workspace/web)

how can i specify context to access to a specified directory directly 
i  think there is a bug here

please could you reply to my request

thnak you 





  




  


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: JK3 roadmap?

2007-06-29 Thread Jim Jagielski


On Jun 27, 2007, at 10:55 AM, Mladen Turk wrote:


jean-frederic clere wrote:
I have noted that nothing has happened in tomcat/connectors/trunk/ 
jk3.
Nearly 2 months without real road map nor clear specifications,  
what is wrong?




I don't think anything is wrong. We are waiting for the list of
requirements, and any suggestion from yours or anybody else side
is more then welcome.



I would likely recommend is looking at the protocol 1st
and what aspects need to be adjusted or improved. And
then from that standpoint, add and improve the extra
features.


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: JK3 roadmap?

2007-06-29 Thread Henri Gomez

When I see the buzz to make mod_jk works on i5/OS, any initiative to
make jk fully APR, is greatly welcome !

2007/6/29, jean-frederic clere <[EMAIL PROTECTED]>:

Jim Jagielski wrote:
>
> On Jun 27, 2007, at 11:27 AM, jean-frederic clere wrote:
>
>> Rainer Jung wrote:
>>> Whenever I had a couple of hours I was doing small tests with scripting.
>>>
>>> I think the most valuable first step would be the transformation to APR.
>>> Unfortunately this is something I could hekp with, but I wouldn't want
>>> to lead, because my experience with APR programing is only medium.
>>>
>> APR-izing is something I am willing to do even to lead... (I am APR
>> committer since 1999!)
>
>
> Ummm... APR wasn't even created until Dec of 2000

I am getting old ;-)

Cheers

Jean-Frederic

>
> -
> To unsubscribe, e-mail: [EMAIL PROTECTED]
> For additional commands, e-mail: [EMAIL PROTECTED]
>
>


-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]




-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: JK3 roadmap?

2007-06-29 Thread jean-frederic clere

Jim Jagielski wrote:


On Jun 27, 2007, at 11:27 AM, jean-frederic clere wrote:


Rainer Jung wrote:

Whenever I had a couple of hours I was doing small tests with scripting.

I think the most valuable first step would be the transformation to APR.
Unfortunately this is something I could hekp with, but I wouldn't want
to lead, because my experience with APR programing is only medium.

APR-izing is something I am willing to do even to lead... (I am APR 
committer since 1999!)



Ummm... APR wasn't even created until Dec of 2000


I am getting old ;-)

Cheers

Jean-Frederic



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: JK3 roadmap?

2007-06-29 Thread Jim Jagielski


On Jun 27, 2007, at 11:27 AM, jean-frederic clere wrote:


Rainer Jung wrote:
Whenever I had a couple of hours I was doing small tests with  
scripting.


I think the most valuable first step would be the transformation  
to APR.
Unfortunately this is something I could hekp with, but I wouldn't  
want

to lead, because my experience with APR programing is only medium.

APR-izing is something I am willing to do even to lead... (I am APR  
committer since 1999!)



Ummm... APR wasn't even created until Dec of 2000

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: 6.0.14 release?

2007-06-29 Thread Sebastiaan van Erk

Remy Maucherat wrote:

Sebastiaan van Erk wrote:

Filip Hanik - Dev Lists wrote:

first week of July maybe?

thoughts...

What will happen to the Comet developments that you guys were working 
in?

Will they go in 6.0.14? Will it be backwards compatible?


Personally, I will be working on Comet developments elsewhere (with an 
API which should remain compatible), and may propose them eventually.


Regardless of what happens, I don't think there will be any backport 
in 6.0.x.



Ok, thanks for the info.

Regards,
Sebastiaan


Rémy



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: 6.0.14 release?

2007-06-29 Thread Remy Maucherat

Sebastiaan van Erk wrote:

Filip Hanik - Dev Lists wrote:

first week of July maybe?

thoughts...


What will happen to the Comet developments that you guys were working in?
Will they go in 6.0.14? Will it be backwards compatible?


Personally, I will be working on Comet developments elsewhere (with an 
API which should remain compatible), and may propose them eventually.


Regardless of what happens, I don't think there will be any backport in 
6.0.x.


Rémy

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: 6.0.14 release?

2007-06-29 Thread Sebastiaan van Erk

Filip Hanik - Dev Lists wrote:

first week of July maybe?

thoughts...


What will happen to the Comet developments that you guys were working in?
Will they go in 6.0.14? Will it be backwards compatible?

Regards,
Sebastiaan


Filip

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r551897 - /tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

2007-06-29 Thread remm
Author: remm
Date: Fri Jun 29 06:58:09 2007
New Revision: 551897

URL: http://svn.apache.org/viewvc?view=rev&rev=551897
Log:
- Changelog update.

Modified:
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?view=diff&rev=551897&r1=551896&r2=551897
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Fri Jun 29 06:58:09 2007
@@ -59,6 +59,19 @@
 42547: Fix NPE when a ResourceLink in context.xml tries to
 override an env-entry in web.xml. (markt)
   
+  
+Avoid some casting in ErrorReportValve (remm)
+  
+  
+Fix persistence API annotation, submitted by Bill Burke (remm)
+  
+  
+In Comet mode, if bytes are not read, send an error event (otherwise, 
+fields referring to the connection could remain) (remm)
+  
+  
+Fix Comet when running Tomcat with the security manager (remm)
+  
 
   
   
@@ -75,6 +88,13 @@
   
 42643 Prevent creation of duplicate JSP function mapper
 variables. (markt)
+  
+
+  
+  
+
+  
+Add back missing socketBuffer attribute in the java.io HTTP connector 
(remm)
   
 
   



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r551893 - /tomcat/connectors/trunk/jk/native/common/jk_shm.c

2007-06-29 Thread hgomez
Author: hgomez
Date: Fri Jun 29 06:55:47 2007
New Revision: 551893

URL: http://svn.apache.org/viewvc?view=rev&rev=551893
Log:
Add ascii->ebcdic conversion around open, unlink. Provided by Ron Egyed

Modified:
tomcat/connectors/trunk/jk/native/common/jk_shm.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_shm.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_shm.c?view=diff&rev=551893&r1=551892&r2=551893
==
--- tomcat/connectors/trunk/jk/native/common/jk_shm.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_shm.c Fri Jun 29 06:55:47 2007
@@ -241,6 +241,10 @@
 {
 int rc;
 char flkname[256];
+#ifdef AS400_UTF8
+char *wptr;
+#endif
+
 JK_TRACE_ENTER(l);
 
 if (attached && jk_shmem.lockname) {
@@ -248,7 +252,7 @@
 jk_shmem.fd_lock = open(jk_shmem.lockname, O_RDWR, 0666);
 #else
 errno = EINVAL;
-#endif
+#endif
 if (jk_shmem.fd_lock == -1) {
 rc = errno;
 JK_TRACE_EXIT(l);
@@ -278,8 +282,15 @@
 #else
 strcpy(flkname, fname);
 strcat(flkname, ".lock");
+#ifdef AS400_UTF8
+wptr = (char *)malloc(strlen(flkname) + 1);
+jk_ascii2ebcdic((char *)flkname, wptr);
+jk_shmem.fd_lock = open(wptr, O_RDWR|O_CREAT|O_TRUNC, 0666);
+free(wptr);
+#else
 jk_shmem.fd_lock = open(flkname, O_RDWR|O_CREAT|O_TRUNC, 0666);
 #endif
+#endif
 if (jk_shmem.fd_lock == -1) {
 rc = errno;
 JK_TRACE_EXIT(l);
@@ -319,6 +330,9 @@
 int rc;
 int fd;
 void *base;
+#ifdef AS400_UTF8
+char *wptr;
+#endif
 
 JK_TRACE_ENTER(l);
 if (jk_shmem.hdr) {
@@ -353,7 +367,14 @@
 if (!attached) {
 size_t size;
 jk_shmem.attached = 0;
+#ifdef AS400_UTF8
+wptr = (char *)malloc(strlen(jk_shmem.filename) + 1);
+jk_ascii2ebcdic((char *)jk_shmem.filename, wptr);
+fd = open(wptr, O_RDWR|O_CREAT|O_TRUNC, 0666);
+free(wptr);
+#else
 fd = open(jk_shmem.filename, O_RDWR|O_CREAT|O_TRUNC, 0666);
+#endif
 if (fd == -1) {
 jk_shmem.size = 0;
 JK_TRACE_EXIT(l);
@@ -365,7 +386,14 @@
 if (ftruncate(fd, jk_shmem.size)) {
 rc = errno;
 close(fd);
+#ifdef  AS400_UTF8
+wptr = (char *)malloc(strlen(jk_shmem.filename) + 1);
+jk_ascii2ebcdic((char *)jk_shmem.filename, wptr);
+unlink(wptr);
+free(wptr);
+#else
 unlink(jk_shmem.filename);
+#endif
 jk_shmem.size = 0;
 JK_TRACE_EXIT(l);
 return rc;
@@ -377,7 +405,14 @@
 if (lseek(fd, 0, SEEK_SET) != 0) {
 rc = errno;
 close(fd);
+#ifdef  AS400_UTF8
+wptr = (char *)malloc(strlen(jk_shmem.filename) + 1);
+jk_ascii2ebcdic((char *)jk_shmem.filename, wptr);
+unlink(wptr);
+free(wptr);
+#else
 unlink(jk_shmem.filename);
+#endif
 jk_shmem.size = 0;
 JK_TRACE_EXIT(l);
 return rc;
@@ -390,7 +425,14 @@
 if (base == (caddr_t)MAP_FAILED || base == (caddr_t)0) {
 rc = errno;
 close(fd);
+#ifdef  AS400_UTF8
+wptr = (char *)malloc(strlen(jk_shmem.filename) + 1);
+jk_ascii2ebcdic((char *)jk_shmem.filename, wptr);
+unlink(wptr);
+free(wptr);
+#else
 unlink(jk_shmem.filename);
+#endif
 jk_shmem.size = 0;
 JK_TRACE_EXIT(l);
 return rc;
@@ -439,7 +481,14 @@
 if (!attached) {
 munmap((void *)jk_shmem.hdr, jk_shmem.size);
 close(jk_shmem.fd);
+#ifdef  AS400_UTF8
+wptr = (char *)malloc(strlen(jk_shmem.filename) + 1);
+jk_ascii2ebcdic((char *)jk_shmem.filename, wptr);
+unlink(wptr);
+free(wptr);
+#else
 unlink(jk_shmem.filename);
+#endif
 }
 jk_shmem.hdr = NULL;
 jk_shmem.fd  = -1;
@@ -463,6 +512,10 @@
 void jk_shm_close()
 {
 int rc;
+#ifdef AS400_UTF8
+char *wptr;
+#endif
+
 if (jk_shmem.hdr) {
 --jk_shmem.hdr->h.data.childs;
 
@@ -493,12 +546,26 @@
 if (jk_shmem.fd_lock >= 0)
 close(jk_shmem.fd_lock);
 if (jk_shmem.lockname) {
+#ifdef  AS400_UTF8
+wptr = (char *)malloc(strlen(jk_shmem.lockname) + 1);
+jk_ascii2ebcdic((char *)jk_shmem.lockname, wptr);
+unlink(wptr);
+free(wptr);
+#else
 unlink(jk_shmem.lockname);
+#endif
 free(jk_shmem.lockname);
 jk_shmem.lockname = NULL;
 }
 if (jk_shmem.filename) {
+#ifdef  AS400_UTF8
+wptr = (char *)malloc(strlen(jk_shmem.filename) + 1);
+jk_ascii2ebcdic((char *)jk_shmem.filename, wptr);
+unlink(wptr);
+ 

6.0.14 release?

2007-06-29 Thread Filip Hanik - Dev Lists

first week of July maybe?

thoughts...


Filip

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 42754] - Infinite loop after comet event breaks

2007-06-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42754


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2007-06-29 06:40 ---
See also bug 42753.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 42753] - Race condition when using available() or reading in CometProcessor.event()

2007-06-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42753


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 42753] - Race condition when using available() or reading in CometProcessor.event()

2007-06-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42753





--- Additional Comments From [EMAIL PROTECTED]  2007-06-29 06:27 ---
(In reply to comment #15)
> Excellent, we will fix this!

Thanks a lot. :-) Sorry for my initially incorrect analysis of the problem. I
should stick to reporting observed behavior instead of theorizing.


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 42753] - Race condition when using available() or reading in CometProcessor.event()

2007-06-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42753





--- Additional Comments From [EMAIL PROTECTED]  2007-06-29 06:25 ---
(In reply to comment #16)
> The "issue" in this bug report is that the user claims that the value of
> "available()" randomly changes. This minor glitch is unrelated.

The issue was that Tomcat reported that I had not read all available bytes even
though I did. The reason turns out to be because Tomcat was not calling the
event method of my comet processor, which entails that indeed bytes were not
being read.

My original issue is thereby resolved and the summary of this bug turns out to
be wrong. It just looked to me like there was a race condition, since I had a
breakpoint in event() and it was not being called anymore, so I thought
(erroneously) that it was complaining at the end of the BEGIN event.

So, as far as I'm concerned this issue can be closed. I don't care if you mark
it INVALID if that's what you want because the summary turns out to be
incorrect; that's fine by me.

I'm happy that the issue is resolved and the bug is fixed. :-)


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 42753] - Race condition when using available() or reading in CometProcessor.event()

2007-06-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42753


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |




--- Additional Comments From [EMAIL PROTECTED]  2007-06-29 06:10 ---
The "issue" in this bug report is that the user claims that the value of
"available()" randomly changes. This minor glitch is unrelated.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r551881 - /tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java

2007-06-29 Thread fhanik
Author: fhanik
Date: Fri Jun 29 06:07:27 2007
New Revision: 551881

URL: http://svn.apache.org/viewvc?view=rev&rev=551881
Log:
Bugzilla 42753
Same fix as 6.0 branch

Modified:
tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java

Modified: 
tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java?view=diff&rev=551881&r1=551880&r2=551881
==
--- tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java 
(original)
+++ tomcat/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java 
Fri Jun 29 06:07:27 2007
@@ -123,9 +123,13 @@
 ApplicationFilterChain filterChain = null;
 if (request instanceof Request) {
 Request req = (Request) request;
+comet = req.isComet();
 if (Globals.IS_SECURITY_ENABLED) {
 // Security: Do not recycle
 filterChain = new ApplicationFilterChain();
+if (comet) {
+req.setFilterChain(filterChain);
+}
 } else {
 filterChain = (ApplicationFilterChain) req.getFilterChain();
 if (filterChain == null) {
@@ -133,7 +137,6 @@
 req.setFilterChain(filterChain);
 }
 }
-comet = req.isComet();
 } else {
 // Request dispatcher in use
 filterChain = new ApplicationFilterChain();



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 42753] - Race condition when using available() or reading in CometProcessor.event()

2007-06-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42753


[EMAIL PROTECTED] changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Additional Comments From [EMAIL PROTECTED]  2007-06-29 06:05 ---
Excellent, we will fix this!

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



svn commit: r551870 - /tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java

2007-06-29 Thread remm
Author: remm
Date: Fri Jun 29 05:35:04 2007
New Revision: 551870

URL: http://svn.apache.org/viewvc?view=rev&rev=551870
Log:
- Fix a lost reference problem when using Comet with a security manager.

Modified:

tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java

Modified: 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
URL: 
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java?view=diff&rev=551870&r1=551869&r2=551870
==
--- 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
 (original)
+++ 
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/ApplicationFilterFactory.java
 Fri Jun 29 05:35:04 2007
@@ -123,9 +123,13 @@
 ApplicationFilterChain filterChain = null;
 if (request instanceof Request) {
 Request req = (Request) request;
+comet = req.isComet();
 if (Globals.IS_SECURITY_ENABLED) {
 // Security: Do not recycle
 filterChain = new ApplicationFilterChain();
+if (comet) {
+req.setFilterChain(filterChain);
+}
 } else {
 filterChain = (ApplicationFilterChain) req.getFilterChain();
 if (filterChain == null) {
@@ -133,7 +137,6 @@
 req.setFilterChain(filterChain);
 }
 }
-comet = req.isComet();
 } else {
 // Request dispatcher in use
 filterChain = new ApplicationFilterChain();



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



DO NOT REPLY [Bug 42753] - Race condition when using available() or reading in CometProcessor.event()

2007-06-29 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=42753





--- Additional Comments From [EMAIL PROTECTED]  2007-06-29 03:13 ---
I have found the cause of the problem.

The code place where it goes wrong is ApplicationFilterFactory line 126:

Request req = (Request) request;
if (Globals.IS_SECURITY_ENABLED) {
// Security: Do not recycle
filterChain = new ApplicationFilterChain();
} else {
filterChain = (ApplicationFilterChain) req.getFilterChain();
if (filterChain == null) {
filterChain = new ApplicationFilterChain();
req.setFilterChain(filterChain);
}
}
comet = req.isComet();

When a security manager is installed the filter chain is not set on the request.

On subsequent Comet events, since the filter chain is null, the event is not
handled properly and the poller goes into a busy loop.





-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Configuring the MBeanServer with which Tomcat MBeans get registered

2007-06-29 Thread Vamsavardhana Reddy

Hi,

I notice that if there is more than one registered MBeanServer in the JVM,
there is no way to configure the MBeanServer with which Tomcat registers its
MBeans.  IIUC, org.apache.tomcat.util.modeler.Registry.getMBeanServer() is
the method that hooks up the MBeanServer with which tomcat registers its
MBeans.  It is using the first one in the results from
MBeanServerFactory.findMBeanServer(null) which returns all the registered
MBeanServers.  If there are no MBeanServers, then it creates one. Is there a
way to configure the MBeanServer? In any case, I have created a bug report
http://issues.apache.org/bugzilla/show_bug.cgi?id=42759 and attached a patch
too.

Thanks and regards,
Vamsi


Re: svn commit: r551809 - /tomcat/connectors/trunk/jk/native/common/jk_msg_buff.c

2007-06-29 Thread Mladen Turk

jean-frederic clere wrote:

 /* We checked for space !!  */
-strncpy((char *)msg->buf + msg->len, param, len + 1);   /* 
including \0 */

+memcpy(msg->buf + msg->len, param, len + 1); /* including \0 */


Why do you remove the (char *)?



Cause memcpy uses void* so no need for casting.
This is backport from mod_proxy_ajp BTW.

Cheers,
Mladen.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]



Re: svn commit: r551809 - /tomcat/connectors/trunk/jk/native/common/jk_msg_buff.c

2007-06-29 Thread jean-frederic clere

[EMAIL PROTECTED] wrote:

Author: mturk
Date: Thu Jun 28 23:32:27 2007
New Revision: 551809

URL: http://svn.apache.org/viewvc?view=rev&rev=551809
Log:
Fix potential overflow. The actual encoded string length is strlen + 3 (Two 
bytes for len and one '\0')

Modified:
tomcat/connectors/trunk/jk/native/common/jk_msg_buff.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_msg_buff.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_msg_buff.c?view=diff&rev=551809&r1=551808&r2=551809
==
--- tomcat/connectors/trunk/jk/native/common/jk_msg_buff.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_msg_buff.c Thu Jun 28 23:32:27 
2007
@@ -173,7 +173,7 @@
 }
 
 len = (unsigned short)strlen(param);

-if (msg->len + len + 2 > msg->maxlen) {
+if (msg->len + len + 3 > msg->maxlen) {
 return -1;
 }
 
@@ -181,7 +181,7 @@

 jk_b_append_int(msg, len);
 
 /* We checked for space !!  */

-strncpy((char *)msg->buf + msg->len, param, len + 1);   /* including 
\0 */
+memcpy(msg->buf + msg->len, param, len + 1); /* including \0 */


Why do you remove the (char *)?

Cheers

Jean-Frederic


 #if (defined(AS400) && !defined(AS400_UTF8)) || defined(_OSD_POSIX)
 /* convert from EBCDIC if needed */
 jk_xlate_to_ascii((char *)msg->buf + msg->len, len + 1);



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]