date:20071215

Re: svn commit: r604267 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

2007-12-15 Thread Mladen Turk


[EMAIL PROTECTED] wrote:

Author: rjung
 int ajp_connect_to_endpoint(ajp_endpoint_t * ae, jk_logger_t *l)
 {
@@ -841,7 +861,7 @@
 
 if (!IS_VALID_SOCKET(ae-sd)) {

 ae-last_errno = errno;
-jk_log(l, JK_LOG_INFO,
+jk_log(l, JK_LOG_ERROR,
Failed opening socket to (%s) (errno=%d),
jk_dump_hinfo(ae-worker-worker_inet_addr, buf), 
ae-last_errno);


IMO this will create duplicate errors lines in the log for the
same cause. The parent function calling this one will log the error
if this one fails. Now we'll have multiple of them.

I've changed the ERROR-INFO some time back just because of that.
Is it really needed to have that changed to ERROR?
It'll only confuse users thought.

Regards,
Mladen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: trunk development

2007-12-15 Thread Peter Rossbach


Hi Filip,

good news :-) I am happy to test this features :-)

Regards
Peter


Am 14.12.2007 um 20:53 schrieb Filip Hanik - Dev Lists:


In the near future, I plan to add the following to trunk

1. annotation dependency injection patch
2. cluster JMX configurations
3. any NIO improvements that haven't been ported

I've also completed a non blocking comet write implementation in  
sandbox, and will write some demo/sample apps to demonstrate before  
I suggest moving forward with it.


Filip

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]





-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r604438 - in /tomcat/connectors/trunk/jk/native/common: jk_ajp_common.c jk_lb_worker.c

2007-12-15 Thread rjung

Author: rjung
Date: Sat Dec 15 07:14:04 2007
New Revision: 604438

URL: http://svn.apache.org/viewvc?rev=604438view=rev
Log:
Lower log level of some messages to get closer
to log behaviour of previous release.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c?rev=604438r1=604437r2=604438view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c Sat Dec 15 
07:14:04 2007
@@ -828,7 +828,7 @@
 }
 
 if ((cmd = jk_b_get_byte(msg)) != AJP13_CPONG_REPLY) {
-jk_log(l, JK_LOG_ERROR,
+jk_log(l, JK_LOG_WAITING,
awaited reply cpong, received %d instead,
cmd);
 /* We can't trust this connection any more. */
@@ -866,7 +866,7 @@
 
 if (!IS_VALID_SOCKET(ae-sd)) {
 ae-last_errno = errno;
-jk_log(l, JK_LOG_ERROR,
+jk_log(l, JK_LOG_INFO,
Failed opening socket to (%s) (errno=%d),
jk_dump_hinfo(ae-worker-worker_inet_addr, buf), 
ae-last_errno);
 JK_TRACE_EXIT(l);
@@ -1275,7 +1275,7 @@
 int err = JK_FALSE;
 if (jk_is_socket_connected(ae-sd, l) == JK_FALSE) {
 ae-last_errno = errno;
-jk_log(l, JK_LOG_INFO,
+jk_log(l, JK_LOG_DEBUG,
(%s) failed sending request, 
socket %d is not connected any more (errno=%d),
ae-worker-name, ae-sd, ae-last_errno);
@@ -2368,7 +2368,7 @@
   JK_RETRIES);
 if (pThis-retries  1) {
 jk_log(l, JK_LOG_INFO,
-   number of retries must be grater then 1. Setting to 
default=%d,
+   number of retries must be greater then 1. Setting to 
default=%d,
JK_RETRIES);
 pThis-retries = JK_RETRIES;
 }

Modified: tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c?rev=604438r1=604437r2=604438view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_lb_worker.c Sat Dec 15 07:14:04 
2007
@@ -1165,7 +1165,7 @@
 rc = JK_FALSE;
 }
 if (rec-s-state == JK_LB_STATE_ERROR)
-jk_log(l, JK_LOG_ERROR,
+jk_log(l, JK_LOG_INFO,
service failed, worker %s is in error state,
rec-s-name);
 if (p-worker-lblock == JK_LB_LOCK_PESSIMISTIC)



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r604439 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

2007-12-15 Thread rjung

Author: rjung
Date: Sat Dec 15 07:16:09 2007
New Revision: 604439

URL: http://svn.apache.org/viewvc?rev=604439view=rev
Log:
Never commit without compilation.
Sometimes your fingers think different from your brain.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c?rev=604439r1=604438r2=604439view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c Sat Dec 15 
07:16:09 2007
@@ -828,7 +828,7 @@
 }
 
 if ((cmd = jk_b_get_byte(msg)) != AJP13_CPONG_REPLY) {
-jk_log(l, JK_LOG_WAITING,
+jk_log(l, JK_LOG_WARNING,
awaited reply cpong, received %d instead,
cmd);
 /* We can't trust this connection any more. */



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r604267 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

2007-12-15 Thread Rainer Jung

Done (switching back).

Mladen Turk schrieb:
 [EMAIL PROTECTED] wrote:
 Author: rjung
  int ajp_connect_to_endpoint(ajp_endpoint_t * ae, jk_logger_t *l)
  {
 @@ -841,7 +861,7 @@
  
  if (!IS_VALID_SOCKET(ae-sd)) {
  ae-last_errno = errno;
 -jk_log(l, JK_LOG_INFO,
 +jk_log(l, JK_LOG_ERROR,
 Failed opening socket to (%s) (errno=%d),
 jk_dump_hinfo(ae-worker-worker_inet_addr, buf),
 ae-last_errno);
 
 IMO this will create duplicate errors lines in the log for the
 same cause. The parent function calling this one will log the error
 if this one fails. Now we'll have multiple of them.
 
 I've changed the ERROR-INFO some time back just because of that.
 Is it really needed to have that changed to ERROR?
 It'll only confuse users thought.
 
 Regards,
 Mladen

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

svn commit: r604450 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

2007-12-15 Thread rjung

Author: rjung
Date: Sat Dec 15 08:32:47 2007
New Revision: 604450

URL: http://svn.apache.org/viewvc?rev=604450view=rev
Log:
Don't retry in case of client errors.

Modified:
tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

Modified: tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c
URL: 
http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c?rev=604450r1=604449r2=604450view=diff
==
--- tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c (original)
+++ tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c Sat Dec 15 
08:32:47 2007
@@ -2103,6 +2103,7 @@
 rc = JK_CLIENT_ERROR;
 log_error = JK_FALSE;
 e-recoverable = JK_FALSE;
+op-recoverable = JK_FALSE;
   /* This doesn't make sense, because we already set reuse */
   /* to JK_FALSE at the beginning of service() and only set it 
to true again after */
   /* the whole response has beend received (callback 
JK_AJP13_END_RESPONSE). */
@@ -2118,6 +2119,7 @@
 rc = JK_CLIENT_ERROR;
 log_error = JK_FALSE;
 e-recoverable = JK_FALSE;
+op-recoverable = JK_FALSE;
   /* This doesn't make sense, because we already set reuse */
   /* to JK_FALSE at the beginning of service() and only set it 
to true again after */
   /* the whole response has beend received (callback 
JK_AJP13_END_RESPONSE). */



-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 44084] New: - JAASRealm useContextClassLoader has problems

2007-12-15 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=44084.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44084

   Summary: JAASRealm useContextClassLoader has problems
   Product: Tomcat 6
   Version: unspecified
  Platform: Other
OS/Version: other
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
AssignedTo: [EMAIL PROTECTED]
ReportedBy: [EMAIL PROTECTED]


The useContextClassLoader config option doesn't work right. 

- it is ignored when setting userClassNames and roleClassNames 
- it's respected when the LoginContext is created, but that is insufficient,
because all the needed classes are not necessarily loaded until
loginContext.login() is called

Patch to follow. With it I'm able to keep everything related to the JAASRealm in
my webapp.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 44084] - JAASRealm useContextClassLoader has problems

2007-12-15 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=44084.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44084





--- Additional Comments From [EMAIL PROTECTED]  2007-12-15 14:28 ---
Created an attachment (id=21278)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=21278action=view)
patch to fix useContextClassLoader for JAASRealm


-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 44084] - JAASRealm useContextClassLoader has problems

2007-12-15 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=44084.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=44084


[EMAIL PROTECTED] changed:

   What|Removed |Added

  Attachment #21278|0   |1
is obsolete||




--- Additional Comments From [EMAIL PROTECTED]  2007-12-15 14:34 ---
Created an attachment (id=21279)
 -- (http://issues.apache.org/bugzilla/attachment.cgi?id=21279action=view)
better patch

Made a mistake about the second thing. Actually the only problem with the
LoginContext stuff is that the logic was backwards. This patch is better.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

DO NOT REPLY [Bug 43392] - Tomcat6 JAASRealm ignores useContextClassLoader in parseClassNames

2007-12-15 Thread bugzilla

DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG·
RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT
http://issues.apache.org/bugzilla/show_bug.cgi?id=43392.
ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND·
INSERTED IN THE BUG DATABASE.

http://issues.apache.org/bugzilla/show_bug.cgi?id=43392





--- Additional Comments From [EMAIL PROTECTED]  2007-12-15 14:55 ---
Just noticed this bug report. I put up a patch at bug 44084, would be cool if
you could try it.

The logic also seemed to be backwards to me. I assume useContextClassLoader
means to use Thread.currentThread().getContextClassLoader(), which is the
webapp's class loader, and useContextClassLoader=false means the servlet class
loader, which is retrieved by getClass().getClassLoader() from the JAASRealm.

-- 
Configure bugmail: http://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug, or are watching the assignee.

-
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Re: svn commit: r604267 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

Re: trunk development

svn commit: r604438 - in /tomcat/connectors/trunk/jk/native/common: jk_ajp_common.c jk_lb_worker.c

svn commit: r604439 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

Re: svn commit: r604267 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

svn commit: r604450 - /tomcat/connectors/trunk/jk/native/common/jk_ajp_common.c

DO NOT REPLY [Bug 44084] New: - JAASRealm useContextClassLoader has problems

DO NOT REPLY [Bug 44084] - JAASRealm useContextClassLoader has problems

DO NOT REPLY [Bug 44084] - JAASRealm useContextClassLoader has problems

DO NOT REPLY [Bug 43392] - Tomcat6 JAASRealm ignores useContextClassLoader in parseClassNames

10 matches

Site Navigation

Mail list logo

Footer information