svn commit: r762967 - /tomcat/connectors/trunk/jk/xdocs/webserver_howto/nes.xml
Author: markt Date: Tue Apr 7 21:11:25 2009 New Revision: 762967 URL: http://svn.apache.org/viewvc?rev=762967&view=rev Log: Fix typo Modified: tomcat/connectors/trunk/jk/xdocs/webserver_howto/nes.xml Modified: tomcat/connectors/trunk/jk/xdocs/webserver_howto/nes.xml URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/webserver_howto/nes.xml?rev=762967&r1=762966&r2=762967&view=diff == --- tomcat/connectors/trunk/jk/xdocs/webserver_howto/nes.xml (original) +++ tomcat/connectors/trunk/jk/xdocs/webserver_howto/nes.xml Tue Apr 7 21:11:25 2009 @@ -257,7 +257,7 @@ That's all, now you should start tomcat and ask for http://server:port/servlets-examples/ -The file obj.conf seems to be sensible to leading white space in lines, especially in +The file obj.conf seems to be sensitive to leading white space in lines, especially in the Object element. Make sure you have no leading white space (no indentation) on any line of this file. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r762948 - in /tomcat/site/trunk: docs/security-jk.html xdocs/security-jk.xml
Author: markt Date: Tue Apr 7 20:39:58 2009 New Revision: 762948 URL: http://svn.apache.org/viewvc?rev=762948&view=rev Log: Update site with details of CVE-2008-5519 Modified: tomcat/site/trunk/docs/security-jk.html tomcat/site/trunk/xdocs/security-jk.xml Modified: tomcat/site/trunk/docs/security-jk.html URL: http://svn.apache.org/viewvc/tomcat/site/trunk/docs/security-jk.html?rev=762948&r1=762947&r2=762948&view=diff == --- tomcat/site/trunk/docs/security-jk.html (original) +++ tomcat/site/trunk/docs/security-jk.html Tue Apr 7 20:39:58 2009 @@ -218,6 +218,49 @@ + +Fixed in Apache Tomcat JK Connector 1.2.27 + + + + + + + + + +important: Information disclosure + http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2008-5519";> + CVE-2008-5519 + + +Situations where faulty clients set Content-Length without providing + data, or where a user submits repeated requests very quickly, may permit + one user to view the response associated with a different user's request. + + +This was fixed in + http://svn.apache.org/viewvc?rev=702540&view=rev";> + revision 702540. + +Affects: JK 1.2.0-1.2.26 + Source shipped with Tomcat 4.0.0-4.0.6, 4.1.0-4.1.36, 5.0.0-5.0.30, + 5.5.0-5.5.27 + + + + + + + + + + + + + + + Fixed in Apache Tomcat JK Connector 1.2.23 @@ -263,7 +306,7 @@ Affects: JK 1.2.0-1.2.22 (httpd mod_jk module only) - Source shipped with Tomcat 4.0.1-4.0.6, 4.1.0-4.1.36, 5.0.0-5.0.30, + Source shipped with Tomcat 4.0.0-4.0.6, 4.1.0-4.1.36, 5.0.0-5.0.30, 5.5.0-5.5.23 @@ -291,14 +334,14 @@ -critical: Arbitary code execution and denial of service +critical: Arbitrary code execution and denial of service http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2007-0774";> CVE-2007-0774 An unsafe memory copy in the URI handler for the native JK connector - could result in a stackoverflow condition which could be leveraged to - execute arbitary code or crash the web server. + could result in a stack overflow condition which could be leveraged to + execute arbitrary code or crash the web server. Affects: JK 1.2.19-1.2.20 Source shipped with: Tomcat 4.1.34, 5.5.20 @@ -339,7 +382,7 @@ reveal sensitive memory information to a client. Affects: JK 1.2.0-1.2.15 - Source shipped with: Tomcat 4.0.1-4.0.6, 4.1.0-4.1.32, 5.0.0-5.0.30, + Source shipped with: Tomcat 4.0.0-4.0.6, 4.1.0-4.1.32, 5.0.0-5.0.30, 5.5.0-5.5.16 Modified: tomcat/site/trunk/xdocs/security-jk.xml URL: http://svn.apache.org/viewvc/tomcat/site/trunk/xdocs/security-jk.xml?rev=762948&r1=762947&r2=762948&view=diff == --- tomcat/site/trunk/xdocs/security-jk.xml (original) +++ tomcat/site/trunk/xdocs/security-jk.xml Tue Apr 7 20:39:58 2009 @@ -24,6 +24,26 @@ + +important: Information disclosure + http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2008-5519";> + CVE-2008-5519 + +Situations where faulty clients set Content-Length without providing + data, or where a user submits repeated requests very quickly, may permit + one user to view the response associated with a different user's request. + + +This was fixed in + http://svn.apache.org/viewvc?rev=702540&view=rev";> + revision 702540. + +Affects: JK 1.2.0-1.2.26 + Source shipped with Tomcat 4.0.0-4.0.6, 4.1.0-4.1.36, 5.0.0-5.0.30, + 5.5.0-5.5.27 + + + important: Information disclosure http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2007-1860";> @@ -58,19 +78,19 @@ Affects: JK 1.2.0-1.2.22 (httpd mod_jk module only) - Source shipped with Tomcat 4.0.1-4.0.6, 4.1.0-4.1.36, 5.0.0-5.0.30, + Source shipped with Tomcat 4.0.0-4.0.6, 4.1.0-4.1.36, 5.0.0-5.0.30, 5.5.0-5.5.23 -critical: Arbitary code execution and denial of service +critical: Arbitrary code execution and denial of service http://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2007-0774";> CVE-2007-0774 An unsafe memory copy in the URI handler for the native JK connector - could result in a stackoverflow condition which could be leveraged to - execute arbitary code or crash the web server. + could result in a stack overflow condition which could be leveraged to + execute arbitrary code or crash the web server. Affects: JK 1.2.19-1.2.20 Source shipped with: Tomcat 4.1.34, 5.5.20 @@ -88,7 +108,7 @@ reveal sensitive memory information to a client. Affects: JK 1.2.0-1.2.15 - Source shipped with: Tomcat 4.0.1-4.0.6, 4.1.0-4.1.32, 5.0.0-5.0.30, + Source shipped with: Tomcat 4.0.0-4.0.6, 4.1.0-4.1.32, 5.0.0-5.0.30, 5.5.0-5.5.1
svn commit: r762940 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Tue Apr 7 20:24:08 2009 New Revision: 762940 URL: http://svn.apache.org/viewvc?rev=762940&view=rev Log: Add a couple of proposals Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=762940&r1=762939&r2=762940&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Apr 7 20:24:08 2009 @@ -144,7 +144,18 @@ +1: markt -1: - * Update native to 1.1.16 +* Update native to 1.1.16 http://svn.apache.org/viewvc?view=rev&revision=762868 +1: markt -1: + +* Fix .exe and .pdf corruption in -src.tar.gz bundle + http://svn.apache.org/viewvc?view=rev&revision=762936 + +1: markt + -1: + +* Enable running of Tomcat directly from build directory on linux + http://svn.apache.org/viewvc?view=rev&revision=762937 + http://svn.apache.org/viewvc?view=rev&revision=762929 + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r762929 - /tomcat/trunk/build.xml
Author: markt Date: Tue Apr 7 20:04:31 2009 New Revision: 762929 URL: http://svn.apache.org/viewvc?rev=762929&view=rev Log: Fix annoying loss of executable bit when building on Mac Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=762929&r1=762928&r2=762929&view=diff == --- tomcat/trunk/build.xml (original) +++ tomcat/trunk/build.xml Tue Apr 7 20:04:31 2009 @@ -104,7 +104,7 @@ - + @@ -476,6 +476,8 @@ + + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r762923 - in /tomcat/tc6.0.x/trunk: STATUS.txt build.xml webapps/docs/changelog.xml
Author: markt Date: Tue Apr 7 19:47:04 2009 New Revision: 762923 URL: http://svn.apache.org/viewvc?rev=762923&view=rev Log: Apply Remy's patch for https://issues.apache.org/bugzilla/show_bug.cgi?id=46910 Fix filtering of properties files. Modified: tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/build.xml tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=762923&r1=762922&r2=762923&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Apr 7 19:47:04 2009 @@ -139,20 +139,6 @@ +1: markt, rjung -1: -* Fix encoding when filtering French properties files, by using in build.xml: - http://svn.apache.org/viewvc?view=rev&revision=759720 -@@ -128,7 +128,7 @@ - - - -- -+ - - - - +1: remm, rjung, markt - -1: - * Fix some failures when testing WebDAV with litmus test suite http://svn.apache.org/viewvc?view=rev&revision=761601 +1: markt Modified: tomcat/tc6.0.x/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/build.xml?rev=762923&r1=762922&r2=762923&view=diff == --- tomcat/tc6.0.x/trunk/build.xml (original) +++ tomcat/tc6.0.x/trunk/build.xml Tue Apr 7 19:47:04 2009 @@ -128,7 +128,7 @@ - + Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=762923&r1=762922&r2=762923&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Tue Apr 7 19:47:04 2009 @@ -85,6 +85,9 @@ 46351: Refactor the build script. Patch provided by Marc Guillemot. (markt) + +46910: Properties files corrupted by build process. (remm) + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r762936 - /tomcat/trunk/dist.xml
Author: markt Date: Tue Apr 7 20:19:18 2009 New Revision: 762936 URL: http://svn.apache.org/viewvc?rev=762936&view=rev Log: Fix typo that meant .exe and .pdf files were corrupted in .tar.gz source bundle Modified: tomcat/trunk/dist.xml Modified: tomcat/trunk/dist.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/dist.xml?rev=762936&r1=762935&r2=762936&view=diff == --- tomcat/trunk/dist.xml (original) +++ tomcat/trunk/dist.xml Tue Apr 7 20:19:18 2009 @@ -576,7 +576,7 @@ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r762937 - /tomcat/trunk/build.xml
Author: markt Date: Tue Apr 7 20:20:32 2009 New Revision: 762937 URL: http://svn.apache.org/viewvc?rev=762937&view=rev Log: Add missing dir that stops me running Tomcat directly from the build dir Modified: tomcat/trunk/build.xml Modified: tomcat/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/build.xml?rev=762937&r1=762936&r2=762937&view=diff == --- tomcat/trunk/build.xml (original) +++ tomcat/trunk/build.xml Tue Apr 7 20:20:32 2009 @@ -114,6 +114,7 @@ + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r762920 - /tomcat/connectors/trunk/jk/xdocs/webserver_howto/nes.xml
Author: rjung Date: Tue Apr 7 19:33:13 2009 New Revision: 762920 URL: http://svn.apache.org/viewvc?rev=762920&view=rev Log: Improve Netscape docs page: - Fix typo - Remove whitespace in example config (breaks configuration) - Add warning about whitespace Modified: tomcat/connectors/trunk/jk/xdocs/webserver_howto/nes.xml Modified: tomcat/connectors/trunk/jk/xdocs/webserver_howto/nes.xml URL: http://svn.apache.org/viewvc/tomcat/connectors/trunk/jk/xdocs/webserver_howto/nes.xml?rev=762920&r1=762919&r2=762920&view=diff == --- tomcat/connectors/trunk/jk/xdocs/webserver_howto/nes.xml (original) +++ tomcat/connectors/trunk/jk/xdocs/webserver_howto/nes.xml Tue Apr 7 19:33:13 2009 @@ -225,8 +225,8 @@ Create a new configuration object by adding the following lines to the end of the obj.conf file @@ -256,6 +256,11 @@ That's all, now you should start tomcat and ask for http://server:port/servlets-examples/ + +The file obj.conf seems to be sensible to leading white space in lines, especially in +the Object element. Make sure you have no leading white space (no indentation) +on any line of this file. + @@ -342,7 +347,7 @@ -This requires a change to NemaTrans portion of obj.conf. +This requires a change to NameTrans portion of obj.conf. @@ -413,10 +418,10 @@ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r762921 - in /tomcat: tc6.0.x/trunk/webapps/docs/changelog.xml tc6.0.x/trunk/webapps/docs/windows-service-howto.xml trunk/webapps/docs/windows-service-howto.xml
Author: markt Date: Tue Apr 7 19:36:18 2009 New Revision: 762921 URL: http://svn.apache.org/viewvc?rev=762921&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46599 Document known DAEMON issue Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml tomcat/trunk/webapps/docs/windows-service-howto.xml Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=762921&r1=762920&r2=762921&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Tue Apr 7 19:36:18 2009 @@ -72,6 +72,9 @@ +46599: Document known DAEMON issue. (markt) + + 46807: Correct docs for configuration of tag pooling. (markt) Modified: tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml?rev=762921&r1=762920&r2=762921&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/windows-service-howto.xml Tue Apr 7 19:36:18 2009 @@ -109,6 +109,10 @@ --Classpath=xx.jar as command line parameter. +Note: PR_DEPENDSON, PR_ENVIRONMENT, PR_JVMOPTIONS, +PR_JVMMS, PR_JVMMX, PR_JVMSS, PR_STARTPARAMS, PR_STOPPARAMS and +PR_STOPTIMEOUT will not work until this bug is fixed: +http://issues.apache.org/jira/browse/DAEMON-49";>DAEMON-49 Modified: tomcat/trunk/webapps/docs/windows-service-howto.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/windows-service-howto.xml?rev=762921&r1=762920&r2=762921&view=diff == --- tomcat/trunk/webapps/docs/windows-service-howto.xml (original) +++ tomcat/trunk/webapps/docs/windows-service-howto.xml Tue Apr 7 19:36:18 2009 @@ -109,6 +109,10 @@ --Classpath=xx.jar as command line parameter. +Note: PR_DEPENDSON, PR_ENVIRONMENT, PR_JVMOPTIONS, +PR_JVMMS, PR_JVMMX, PR_JVMSS, PR_STARTPARAMS, PR_STOPPARAMS and +PR_STOPTIMEOUT will not work until this bug is fixed: +http://issues.apache.org/jira/browse/DAEMON-49";>DAEMON-49 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r762915 - /tomcat/tc6.0.x/trunk/NOTICE
Author: markt Date: Tue Apr 7 19:21:29 2009 New Revision: 762915 URL: http://svn.apache.org/viewvc?rev=762915&view=rev Log: Fix year in NOTICE Modified: tomcat/tc6.0.x/trunk/NOTICE Modified: tomcat/tc6.0.x/trunk/NOTICE URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/NOTICE?rev=762915&r1=762914&r2=762915&view=diff == --- tomcat/tc6.0.x/trunk/NOTICE (original) +++ tomcat/tc6.0.x/trunk/NOTICE Tue Apr 7 19:21:29 2009 @@ -1,5 +1,5 @@ Apache Tomcat -Copyright 1999-2007 The Apache Software Foundation +Copyright 1999-2009 The Apache Software Foundation This product includes software developed by The Apache Software Foundation (http://www.apache.org/). - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r762912 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Tue Apr 7 19:16:30 2009 New Revision: 762912 URL: http://svn.apache.org/viewvc?rev=762912&view=rev Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=762912&r1=762911&r2=762912&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Apr 7 19:16:30 2009 @@ -150,7 +150,7 @@ - +1: remm, rjung + +1: remm, rjung, markt -1: * Fix some failures when testing WebDAV with litmus test suite - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r762911 - in /tomcat/tc6.0.x/trunk: ./ java/org/apache/catalina/core/ java/org/apache/catalina/tribes/util/ test/org/apache/catalina/tribes/demos/ test/org/apache/catalina/tribes/test/chan
Author: markt
Date: Tue Apr 7 19:15:16 2009
New Revision: 762911
URL: http://svn.apache.org/viewvc?rev=762911&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46866
Better init of Random objects
Modified:
tomcat/tc6.0.x/trunk/ (props changed)
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardServer.java
tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/util/UUIDGenerator.java
tomcat/tc6.0.x/trunk/test/org/apache/catalina/tribes/demos/LoadTest.java
tomcat/tc6.0.x/trunk/test/org/apache/catalina/tribes/demos/MapDemo.java
tomcat/tc6.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestDataIntegrity.java
tomcat/tc6.0.x/trunk/test/org/apache/catalina/tribes/test/channel/TestRemoteProcessException.java
tomcat/tc6.0.x/trunk/test/org/apache/catalina/tribes/test/io/TestSenderConnections.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc6.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Apr 7 19:15:16 2009
@@ -1 +1 @@
-/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,673796,673820,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,718360,719119,719124,719602,719626,719628,720046,720069,721040,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,747834,747863,748344,750258,750291,750921,751286-751287,751295,757774
+/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,673796,673820,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,718360,719119,719124,719602,719626,719628,720046,720069,721040,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,747834,747863,748344,750258,750291,750921,751286-751287,751295,757774,758596
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=762911&r1=762910&r2=762911&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Apr 7 19:15:16 2009
@@ -110,14 +110,6 @@
+1: markt, rjung
-1:
-* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46866
- http://svn.apache.org/viewvc?rev=758596&view=rev
- Better init of Random objects
- +1: markt, rjung, billbarker
- billbarker: This is more like a +0.5, since Random isn't that secure in
the first place.
- But the patch seems harmless, so I'll support
itch-scraching.
- -1:
-
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46822
http://svn.apache.org/viewvc?rev=758616&view=rev
Remove unnecessary object creation in StandardContext
Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardServer.java
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardServer.java?rev=762911&r1=762910&r2=762911&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardServer.java
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/core/StandardServer.java Tue
Apr 7 19:15:16 2009
@@ -403,7 +403,7 @@
int expected = 1024; // Cut off to avoid DoS attack
while (expected < shutdown.length()) {
if (random == null)
-random = new Random(System.currentTimeMillis());
+random = new Random();
expected += (random.nextInt() % 1024);
}
while (expected > 0) {
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/util/UUIDGenerator.java
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/util/UUIDGenerator.java?rev=762911&r1=762910&r2=762911&view=diff
==
---
tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/util/UUIDGenerator.java
(original)
+++
tomcat/tc6.0.x/trunk/java/org/apache/catalina/tribes/util/UUIDGenerator.java
Tue Apr 7 19:15:16 2009
@@ -31,7 +31,7 @@
public static final int BITS_PER_BYTE = 8;
protected static SecureRandom secran
svn commit: r762909 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt java/org/apache/catalina/servlets/DefaultServlet.java webapps/docs/changelog.xml
Author: markt
Date: Tue Apr 7 19:12:35 2009
New Revision: 762909
URL: http://svn.apache.org/viewvc?rev=762909&view=rev
Log:
Fix typo in OPTIONS response from default servlet
Modified:
tomcat/tc6.0.x/trunk/ (props changed)
tomcat/tc6.0.x/trunk/STATUS.txt
tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
Propchange: tomcat/tc6.0.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Tue Apr 7 19:12:35 2009
@@ -1 +1 @@
-/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,673796,673820,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,718360,719119,719124,719602,719626,719628,720046,720069,721040,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,747834,747863,748344,750258,750291,750921,751286-751287,751295
+/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,673796,673820,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,718360,719119,719124,719602,719626,719628,720046,720069,721040,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,747834,747863,748344,750258,750291,750921,751286-751287,751295,757774
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=762909&r1=762908&r2=762909&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Apr 7 19:12:35 2009
@@ -97,11 +97,6 @@
but could agree to some of it if it was split into parts
-1: remm: no for TC 6.0
-* Fix typo in OPTIONS response
- http://svn.apache.org/viewvc?rev=757774&view=rev
- +1: markt, rjung, billbarker
- -1:
-
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46908
http://svn.apache.org/viewvc?rev=758365&view=rev
Try and support java encoding names when using an xml parser provided via the
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java?rev=762909&r1=762908&r2=762909&view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/servlets/DefaultServlet.java
Tue Apr 7 19:12:35 2009
@@ -383,7 +383,7 @@
// There is a doPut
allow.append(", PUT");
// There is a doDelete
-allow.append(", POST");
+allow.append(", DELETE");
// Trace - assume disabled unless we can prove otherwise
if (req instanceof RequestFacade &&
((RequestFacade) req).getAllowTrace()) {
Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=762909&r1=762908&r2=762909&view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Tue Apr 7 19:12:35 2009
@@ -39,6 +39,9 @@
46816: Align session manager mbean descriptor with
implementation. (markt)
+
+Fix a typo in the OPTIONS response from the default servlet. (markt)
+
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r762906 - in /tomcat/tc6.0.x/trunk: ./ STATUS.txt build.xml res/maven/mvn-pub.xml webapps/docs/changelog.xml
Author: markt Date: Tue Apr 7 19:08:39 2009 New Revision: 762906 URL: http://svn.apache.org/viewvc?rev=762906&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46351 Build script re-factoring. Patch provided by Marc Guillemot Modified: tomcat/tc6.0.x/trunk/ (props changed) tomcat/tc6.0.x/trunk/STATUS.txt tomcat/tc6.0.x/trunk/build.xml tomcat/tc6.0.x/trunk/res/maven/mvn-pub.xml tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Propchange: tomcat/tc6.0.x/trunk/ -- --- svn:mergeinfo (original) +++ svn:mergeinfo Tue Apr 7 19:08:39 2009 @@ -1 +1 @@ -/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,673796,673820,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,718360,719119,719124,719602,719626,719628,720046,720069,721040,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,747834,747863,748344,750258,750291,750921,751286-751287,751295 +/tomcat/trunk:601180,606992,612607,630314,640888,652744,653247,673796,673820,683982,684001,684081,684234,684269-684270,685177,687503,687645,689402,690781,691392,691805,692748,693378,694992,695053,695311,696780,696782,698012,698227,698236,698613,699427,699634,701355,709294,709811,709816,710063,710066,710125,710205,711126,711600,712461,712467,718360,719119,719124,719602,719626,719628,720046,720069,721040,723404,723738,726052,727303,728032,728768,728947,729057,729567,729569,729571,729681,729809,729815,729934,730250,730590,731651,732859,732863,734734,740675,740684,742677,742697,742714,744160,744238,746321,746384,747834,747863,748344,750258,750291,750921,751286-751287,751295 Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=762906&r1=762905&r2=762906&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Apr 7 19:08:39 2009 @@ -56,15 +56,6 @@ http://svn.apache.org/viewvc?rev=757335&view=rev (to remove the Catalina dep) +1: markt, billbarker -* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46351 - Build script re-factoring - Patch provided by Marc Guillemot - http://svn.apache.org/viewvc?rev=729681&view=rev - +1: markt, jim, pero - 0: fhanik - not sure its needed in 6.0 branch if all is working with the old script - 0: funkman - ditto - -1: - * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=46815 http://svn.apache.org/viewvc?rev=751289&view=rev http://svn.apache.org/viewvc?rev=753039&view=rev Modified: tomcat/tc6.0.x/trunk/build.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/build.xml?rev=762906&r1=762905&r2=762906&view=diff == --- tomcat/tc6.0.x/trunk/build.xml (original) +++ tomcat/tc6.0.x/trunk/build.xml Tue Apr 7 19:08:39 2009 @@ -142,24 +142,114 @@ + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + + - - - - - - - - - - - - + - - - + @@ -196,7 +284,7 @@ - + @@ -204,30 +292,13 @@ - - - - - - - - + - - - - - - - - - - - + @@ -235,99 +306,28 @@ - - - - - - - - + - - - - - - - - - - - - - - - - - - + - - - - - - - - + + - - - - - - - - + - - -
svn commit: r762904 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Tue Apr 7 19:02:52 2009 New Revision: 762904 URL: http://svn.apache.org/viewvc?rev=762904&view=rev Log: Propose native update Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=762904&r1=762903&r2=762904&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Tue Apr 7 19:02:52 2009 @@ -179,3 +179,8 @@ http://svn.apache.org/viewvc?view=rev&revision=761601 +1: markt -1: + + * Update native to 1.1.16 + http://svn.apache.org/viewvc?view=rev&revision=762868 + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r762868 - /tomcat/trunk/build.properties.default
Author: markt
Date: Tue Apr 7 17:44:04 2009
New Revision: 762868
URL: http://svn.apache.org/viewvc?rev=762868&view=rev
Log:
Update native
Modified:
tomcat/trunk/build.properties.default
Modified: tomcat/trunk/build.properties.default
URL:
http://svn.apache.org/viewvc/tomcat/trunk/build.properties.default?rev=762868&r1=762867&r2=762868&view=diff
==
--- tomcat/trunk/build.properties.default (original)
+++ tomcat/trunk/build.properties.default Tue Apr 7 17:44:04 2009
@@ -62,7 +62,7 @@
jdt.loc=http://www.eclipse.org/downloads/download.php?file=/eclipse/downloads/drops/R-3.3.1-200709211145/eclipse-JDT-3.3.1.zip
# - Tomcat native library -
-tomcat-native.version=1.1.15
+tomcat-native.version=1.1.16
tomcat-native.home=${base.path}/tomcat-native-${tomcat-native.version}
tomcat-native.tar.gz=${tomcat-native.home}/tomcat-native.tar.gz
tomcat-native.loc=${base-tomcat.loc}/tomcat-connectors/native/tomcat-native-${tomcat-native.version}-src.tar.gz
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46990] New: Synchronize target cannot be changed midway
https://issues.apache.org/bugzilla/show_bug.cgi?id=46990 Summary: Synchronize target cannot be changed midway Product: Tomcat 6 Version: unspecified Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org Created an attachment (id=23455) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23455) Fix broken synchronization Various classes synchronize on a variable which is then changed. This will not have the desired effect, as all accesses must use the same lock in order for the synchronisation to work correctly. The patch adds new final lock objects (which cannot be changed midway). It also adds some additional synchronization to various get() methods to ensure that reader threads get the correct updates. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46988] New: JMXAccessorTask String constants should be final
https://issues.apache.org/bugzilla/show_bug.cgi?id=46988 Summary: JMXAccessorTask String constants should be final Product: Tomcat 6 Version: unspecified Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org Created an attachment (id=23452) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=23452) Patch to make fields final JMXAccessorTask String constants should be final -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46986] New: org.apache.jasper.Constants public arrays are mutable
https://issues.apache.org/bugzilla/show_bug.cgi?id=46986 Summary: org.apache.jasper.Constants public arrays are mutable Product: Tomcat 6 Version: unspecified Platform: PC OS/Version: Windows XP Status: NEW Severity: normal Priority: P2 Component: Jasper AssignedTo: dev@tomcat.apache.org ReportedBy: s...@apache.org There are various public String arrays in org.apache.jasper.Constants. Although the array variables are final, any code can change any of the array constants. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46985] New: Impossible condition in coyote.http11.Http11Processor.process(Socket socket)
https://issues.apache.org/bugzilla/show_bug.cgi?id=46985
Summary: Impossible condition in
coyote.http11.Http11Processor.process(Socket socket)
Product: Tomcat 6
Version: unspecified
Platform: PC
OS/Version: Windows XP
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: s...@apache.org
coyote.http11.Http11Processor.process(Socket socket)
...
int soTimeout = socket.getSoTimeout();
int oldSoTimeout = soTimeout;
int threadRatio = (endpoint.getCurrentThreadsBusy() * 100)
/ endpoint.getMaxThreads();
if (threadRatio > 75) {
keepAliveLeft = 1;
}
if (soTimeout != oldSoTimeout) {
The above condition will never be true. It looks like the code is trying to
reset the timeout if it has not changed, but it will never do so.
Both the method and the class have a variable called "socket" which may be part
of the problem - is the method trying to set the instance socket to have the
same timeout as the parameter socket, or vice versa?
The socket parameter should be renamed.
Note that the Javadoc appears to be completely wrong as well.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[SECURITY] CVE-2008-5519: Apache Tomcat mod_jk information disclosure vulnerability
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Vulnerability announcement: CVE-2008-5519: Apache Tomcat mod_jk information disclosure vulnerability Severity: important Vendor: The Apache Software Foundation Versions Affected: mod_jk 1.2.0 to 1.2.26 Description: Situations where faulty clients set Content-Length without providing data, or where a user submits repeated requests very quickly may permit one user to view the response associated with a different user's request. Mitigation: Upgrade to mod_jk 1.2.27 or later Example: See description Credit: This issue was discovered by the Red Hat Security Response Team References: http://tomcat.apache.org/security.html http://tomcat.apache.org/security-jk.html The Apache Tomcat Security Team -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.7 (MingW32) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFJ27rAb7IeiTPGAkMRAlsDAJ9qqKPiFnh+rxaxzMZmKIFA5Q5r5QCg2N84 OzL54gpA6e272kokWjK4wZU= =GKVO -END PGP SIGNATURE- - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release build 6.0.19
sebb wrote: > On 07/04/2009, Remy Maucherat wrote: >> The candidates binaries are available here: >> http://people.apache.org/~remm/tomcat-6/v6.0.19/ > > Hashes and sigs look OK, though I only checked the main archives. > > There's a packaging problem with the source archives. > > I would expect the .zip and .tar.gz to have the same contents, apart > possibly from line endings. However there are other differences which > appear to be caused by character set problems. E.g. in > > LocalStrings_de.properties - zip > htmlManagerServlet.appsAvailable=Verfügbar > > whereas in > > LocalStrings_de.properties - tar.gz > htmlManagerServlet.appsAvailable=Verf�gbar Bug 46910 - now fixed. > Furthermore, some of the binary files are different, for example > requestProcess.pdf and serverStartup.pdf. The tar.gz versions of the > PDFs don't seem to be usable. Typo in dist.xml. Fix proposed: http://svn.apache.org/viewvc?view=rev&revision=762936 > The NOTICE files say: > Copyright 1999-2007 The Apache Software Foundation Fixed. > Findbugs also says that there are lots of problems with the code. > Some of them look quite serious, e.g. synchronising on an object > reference that the code then replaces with another object. I can > upload the analysis if required. Create a bugzilla entry for the ones that really need fixing. If you can include patches that would be great. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46910] properties files in tomcat-i18n-fr.jar misencoded
https://issues.apache.org/bugzilla/show_bug.cgi?id=46910 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Mark Thomas 2009-04-07 12:47:17 PST --- Root cause found and fixed in 6.0.x and trunk. It will be used from 6.0.20 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46599] Tomcat doc. should acknowledge longstanding Daemon bug
https://issues.apache.org/bugzilla/show_bug.cgi?id=46599 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Mark Thomas 2009-04-07 12:36:44 PST --- Not sure when I'm going to get the time to look at this so I have added a note to the docs. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46866] Seed from current time is useless
https://issues.apache.org/bugzilla/show_bug.cgi?id=46866 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Mark Thomas 2009-04-07 12:26:00 PST --- This has been applied to 6.0.x and will be included in 6.0.20 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46350] Maven repository should contain source bundles
https://issues.apache.org/bugzilla/show_bug.cgi?id=46350 Bug 46350 depends on bug 46351, which changed state. Bug 46351 Summary: Refactor a bit the build scripts https://issues.apache.org/bugzilla/show_bug.cgi?id=46351 What|Old Value |New Value Status|NEW |RESOLVED Resolution||FIXED -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46351] Refactor a bit the build scripts
https://issues.apache.org/bugzilla/show_bug.cgi?id=46351 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #2 from Mark Thomas 2009-04-07 12:25:14 PST --- This has been applied to 6.0.x and will be included in 6.0.20 onwards -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46924] Session is lost when application is reloaded through touching the war file
https://issues.apache.org/bugzilla/show_bug.cgi?id=46924 --- Comment #5 from Pid 2009-04-07 10:58:31 PST --- (In reply to comment #3) > I would like to add, althrough that may be a different problem, that in some > cases (probably for larger [20mb] war files), when you start replace a war > with > another, Tomcat starts the new deploy before the war file is entire writen. > That causes errors as corrupted war file. If your filing system takes longer than the war deployer monitor interval to copy 20Mb you have a very slow harddrive and should consider upgrading. If on the other hand you are FTPing a war file straight into your webapps dir, then you should probably rethink your strategy - as that's not the most sensible approach - e.g. rename before upload, upload to safe temp dir, etc. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46924] Session is lost when application is reloaded through touching the war file
https://issues.apache.org/bugzilla/show_bug.cgi?id=46924 --- Comment #4 from Kirk True 2009-04-07 10:15:20 PST --- Yeah, I've noticed this problem too. I wonder if there should be some kind of idle wait that waits for N milliseconds without a file change before trying to unzip. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46924] Session is lost when application is reloaded through touching the war file
https://issues.apache.org/bugzilla/show_bug.cgi?id=46924 --- Comment #3 from adrian...@gmail.com 2009-04-07 09:52:14 PST --- I would like to add, althrough that may be a different problem, that in some cases (probably for larger [20mb] war files), when you start replace a war with another, Tomcat starts the new deploy before the war file is entire writen. That causes errors as corrupted war file. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46924] Session is lost when application is reloaded through touching the war file
https://issues.apache.org/bugzilla/show_bug.cgi?id=46924 --- Comment #2 from Kirk True 2009-04-07 09:12:02 PST --- Whoops - regarding comment 1: s/6.1.18/6.0.18/g -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46924] Session is lost when application is reloaded through touching the war file
https://issues.apache.org/bugzilla/show_bug.cgi?id=46924 --- Comment #1 from Kirk True 2009-04-07 09:06:21 PST --- In addition to the OP seeing this on Windows on 6.1.18, I am able to reproduce this on Linux against the trunk. OP - thanks for the example (Maven) project and the clear steps. There are three cases discussed; this is what happens presently: * Touching $TOMCAT_HOME/webapps/example.war - sessions deleted * Deleting $TOMCAT_HOME/webapps/example - sessions deleted * Deleting $TOMCAT_HOME/webapps/example/* - sessions preserved So what is the expected behaviour with regard to the above cases? -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46984] New: Server incorrectly reports a 501 error on bad method name. Should report 400 error.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46984
Summary: Server incorrectly reports a 501 error on bad method
name. Should report 400 error.
Product: Tomcat 5
Version: 5.5.27
Platform: All
OS/Version: All
Status: NEW
Severity: minor
Priority: P3
Component: Connector:HTTP
AssignedTo: dev@tomcat.apache.org
ReportedBy: jsm...@infotrustgroup.com
I managed to send a corrupt data stream to Tomcat. The result was that the
method name turned out to be '0\n\n0\n\n0\n\nPOST'. This was actually the
method name that was returned to the servlet's .service(request, response)
method by Tomcat. The error message returned back to the client was:
java.io.IOException: Server returned HTTP response code: 501 for URL:
http://localhost/method-bug/bug
at
sun.net.www.protocol.http.HttpURLConnection.getInputStream(HttpURLConnection.java:1305)
at
sun.net.www.protocol.http.HttpURLConnection.getHeaderFields(HttpURLConnection.java:2187)
The 501 error indicates that the method is not implemented or not supported.
While this is somewhat true, there is a more applicable error message. The 501
error is confusing, in that it indicates a valid method name was received. In
this case, the method name was formed with invalid characters (numbers and
carriage returns).
The correct behavior is that Tomcat should detect the bad/invalid/malformed
method name and throw a 400 error, bad request.
The offending code is in org.apache.coyote.http11.InternalInputBuffer.
The parseRequestLine code is naive. It starts by skipping blank lines, then
puts EVERYTHING up until the next 'space' character into the method name,
including carriage returns, special characters, numbers, etc.
Correct behavior is that it should detect an invalid method name (according to
the spec) at this point, and throw error 400 (I think 400 is correct).
public void parseRequestLine() throws IOException {
int start = 0;
//
// Skipping blank lines
//
byte chr = 0;
do {
// Read new bytes if needed
if (pos >= lastValid) {
if (!fill())
throw new EOFException(sm.getString("iib.eof.error"));
}
chr = buf[pos++];
} while ((chr == Constants.CR) || (chr == Constants.LF));
pos--;
// Mark the current buffer position
start = pos;
//
// Reading the method name
// Method name is always US-ASCII
//
boolean space = false;
while (!space) {
// Read new bytes if needed
if (pos >= lastValid) {
if (!fill())
throw new EOFException(sm.getString("iib.eof.error"));
}
ascbuf[pos] = (char) buf[pos];
// Spec says single SP but it also says be tolerant of HT
if (buf[pos] == Constants.SP || buf[pos] == Constants.HT) {
space = true;
request.method().setChars(ascbuf, start, pos - start);
}
pos++;
}
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 46982] New: AccessLogValve reports correct time but incorrect offset following Spring DST transition.
https://issues.apache.org/bugzilla/show_bug.cgi?id=46982
Summary: AccessLogValve reports correct time but incorrect
offset following Spring DST transition.
Product: Tomcat 5
Version: 5.5.27
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: phil.pick...@springsource.com
This is a problem with AccessLogValve for tc5.5 as well as tc6.0 on all
platforms.
With the system clock on my linux machine (Ubuntu in my case) to just before
the US time change on March 8, I started Tomcat 5.5 and see the following
messages in my Tomcat access log after accessing Tomcat JSP example pages at
the time of DST transition:
-: - [08/Mar/2009:01:56:20 -0700] GET /jsp-examples/jsp2/simpletag/book.jsp
HTTP/1.1 200 1738 1 - {http-8080-Processor24}
-: - [08/Mar/2009:03:01:22 -0700] GET /jsp-examples/jsp2/tagfiles/hello.jsp
HTTP/1.1 200 2213 68 - {http-8080-Processor25}
Note the offset of "-0700" both before and after DST transition. Following a
Tomcat restart the offset is correct:
-: - [08/Mar/2009:03:19:42 -0600] GET /jsp-examples/jsp2/jspx/basic.jspx
HTTP/1.1 200 1919 780 - {http-8080-Processor25}
-: - [08/Mar/2009:03:19:59 -0600] GET /jsp-examples/jsp2/jspx/svgexample.html
HTTP/1.1 200 2239 4 - {http-8080-Processor25}
-: - [08/Mar/2009:03:19:59 -0600] GET /jsp-examples/jsp2/jspx/textRotate.jpg
HTTP/1.1 200 26729 3 - {http-8080-Processor25}
BTW, I ran the tzupdater before my tests:
linwin01-512> java -jar tzupdater.jar -V
tzupdater version 1.3.12-b01
JRE time zone data version: tzdata2009a
Embedded time zone data version: tzdata2009a
The problem is in the org.apache.catalina.valves.AccessLogValve which contains
the following in its start method:
// Initialize the timeZone, Date formatters, and currentDate
timezone = TimeZone.getDefault();
timeZoneNoDST = calculateTimeZoneOffset(timezone.getRawOffset());
Calendar calendar = Calendar.getInstance(timezone);
int offset = calendar.get(Calendar.DST_OFFSET);
timeZoneDST = calculateTimeZoneOffset(timezone.getRawOffset()+offset);
Based on what I’ve seen, “int offset = calendar.get(Calendar.DST_OFFSET);”
returns 0 when the current time is not in Daylight savings time and (for my
timezone) 360 (60 * 60 * 1000) when the current time is in Daylight
Savings. It looks like the code assumes this is always the offset for Daylight
Savings for the current timezone. I have no idea if there are some
locations/timezones where Daylight Savings Time does not have a 1 hour offset.
Because of this, if in a non-DST time period, timeZoneDST and timeZoneNoDST are
set to the same value. If in a DST time period, I believe they are set
correctly so that the transition in Autumn works correctly. I think the only
problem is when moving ahead in Springtime (unless the software has been
running for 6 months or so which caused the offset to be set correctly).
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[tcnative, MINA multicast, SLP]: jSLP dependencies
Hi guys Sorry for the cross-post two 3 lists, but this whole jSLP issue depends on work from all three areas... As mentioned in the ApacheDS devlist, jSLP will be ready for release really soon. However, jSLP relies on: --- MINA multicasting I implemented AprDatagram classes in order to be able to multicast using MINA. These classes are currently being revised. I used the classes myself and they seem to work, both when used by the standalone jSLP directory agent as well as when used as OSGi bundles (equinox). These classes however require: --- tomcat native There were a bunch of typo bugs in the release version of tomcat native (have been fixed by now) when I started working on jSLP/MINA, so I was forced to use my own fixed version of libtcnative and tomcat native (aka tomcat-apr aka tomcat-jni) here. I inserted a fixed version into my local maven repo to be able to build MINA and jSLP. I also needed tomcat jni to run as a bundle, so I whipped up a quick pom.xml to build me a tomcat-jni OSGi bundle including the (fixed) libtcnative libraries for windows (doesn't work, multicast fails without any errors), linux 32 bit and linux 64 bit (both worked, used them myself). So my questions are the following: - Is there a timeframe on the official release of the tomcat native code to the maven central repo? - Will there be an OSGi bundle version including the native code? - Is there a timeframe on the official relase of the AprDatagram code, even if in some kind of beta version? - If the answer to any of the above is "yes", can I also get some info on version etc. in order to adjust my POM.xml files for jSLP 2.0? cheers, lorenz - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release build 6.0.19
[X] Stable Filip Remy Maucherat wrote: The candidates binaries are available here: http://people.apache.org/~remm/tomcat-6/v6.0.19/ According to the release process, the 6.0.19 tag is: [ ] Broken [ ] Alpha [ ] Beta [ ] Stable Note: The i18n issue for the French language could be addressed by providing a replacement JAR from a bugzilla, since I suppose the affected user base is not that large. Rémy - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release build 6.0.19
Remy Maucherat wrote: > The candidates binaries are available here: > http://people.apache.org/~remm/tomcat-6/v6.0.19/ > > According to the release process, the 6.0.19 tag is: > [ ] Broken > [ ] Alpha > [ ] Beta > [X] Stable > > Note: The i18n issue for the French language could be addressed by > providing a replacement JAR from a bugzilla, since I suppose the > affected user base is not that large. TCK passes. My local tests look OK. I suspect the other languages are affected as well. They could also just use the i18n jar from 6.0.18 as well if it is major issue for them. Mark Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [VOTE] Release build 6.0.19
On 07/04/2009, Remy Maucherat wrote: > The candidates binaries are available here: > http://people.apache.org/~remm/tomcat-6/v6.0.19/ Hashes and sigs look OK, though I only checked the main archives. There's a packaging problem with the source archives. I would expect the .zip and .tar.gz to have the same contents, apart possibly from line endings. However there are other differences which appear to be caused by character set problems. E.g. in LocalStrings_de.properties - zip htmlManagerServlet.appsAvailable=Verfügbar whereas in LocalStrings_de.properties - tar.gz htmlManagerServlet.appsAvailable=Verf�gbar [In case this does not make it unscathed through the mail system, the first one shows up as u-umlaut and the second as a small square.] The underlying bytes are: u-umlaut = FC blob = EF BF BD This problem affects many properties files, also changelog.xml and KEYS. Furthermore, some of the binary files are different, for example requestProcess.pdf and serverStartup.pdf. The tar.gz versions of the PDFs don't seem to be usable. The tomcat exes are also different. Perhaps no-one will use .tar.gz on Windows, but that's not impossible. Clearly the process for creating the source tar.gz archives is not working properly. The binary zip archive contains two extra (empty) directories, work and log, but otherwise the contents match, so they seem OK. The NOTICE files say: Copyright 1999-2007 The Apache Software Foundation Unless the software has not been significantly updated since 2007, that needs to be changed. Findbugs also says that there are lots of problems with the code. Some of them look quite serious, e.g. synchronising on an object reference that the code then replaces with another object. I can upload the analysis if required. > According to the release process, the 6.0.19 tag is: > [X] Broken > [ ] Alpha > [ ] Beta > [ ] Stable > > Note: The i18n issue for the French language could be addressed by > providing a replacement JAR from a bugzilla, since I suppose the > affected user base is not that large. > > Rémy > > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
GSOC - "Convert current Tomcat valves to Servlet Filters"
Hi, I've updated my proposal by adding the comment. I would be grateful if you could read it. thanks in advance, Marcin Wilkos
Re: [Proposal] Remove older of the two BIO AJP connectors
> I am saying the exact same thing - we shouldn't add another protocol, it was > > a mistake to even have AJP proto in the first place, and we shouldn't > attempt > to extend it. > > However we do need some form of communication between tomcat and jk - > what AJP provides won't allow much. And what I was suggesting is to not > do another protocol - but find an existing one and use/adapt it. Another solution could be : - just use HTTP between HTTPd/IIS and Tomcat to forward request. - add some special HTTP requests on Tomcat to get informations about load or live topology. ie: When a new Tomcat enter a 'named' cluster group, others should get the informations and should be able to deliver to HTTPd/IIS with just simple HTTP requests so no need to add the multicast support in HTTP/IIS. There is allready cluster middleware in TC (tribes) to do this. Same thing when a Tomcat shutdown or exit a 'named' cluster group. A good idea will be to provide a simple/default Tomcat load servlet but let people override or provide their own. In many uses, it's not the number of threads or Tomcat CPUs load which should be counter but for example remote SQL load. Just an idea - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: New sandbox project -- Apache Commons (Portable) Runtime
+1 Good ideas 2009/4/6 Rainer Jung : > On 06.04.2009 21:32, Niall Pemberton wrote: >> Sounds good. Who currently works on the Tomcat code and are they happy >> for it to come here as well. > > Very basic commit statistics on repos/asf/tomcat/connectors/trunk/jni, > not including data about how big each of the commits was: > > Count id > 391 mturk > 77 jfclere > 15 markt > 11 rjung > 6 pero > 5 remm > 4 jim > 2 wrowe > 1 costin > > I'm personally fine with moving the Java API for APR to commons and > think it's a nice environment to grow the feature set. I'm cross-posting > to d...@tomcat for the the other committers. > >> Also has there been any interest from >> other project committers (you mention mina)? >> >> Niall >> >> On Sat, Apr 4, 2009 at 8:21 AM, Mladen Turk wrote: >>> Hi all >>> >>> This is not official project manifest, just few things >>> so I can gather info weather the project has any chance >>> to settle in the commons at the first place. >>> >>> The project is completely different from other >>> commons projects, because it contains platform native >>> code beside java api. >>> >>> The idea is to evolve the Tomcat Native to a >>> standalone component. It is used by Apache Tomcat >>> and Apache Mina projects, so we have two TLP >>> projects already using it. >>> And my plan is to use this component inside >>> daemons project for common platform tasks. >>> >>> The java part will also have a special native >>> library dynamic runtime, allowing the native >>> module(s) to exist in the same jar and gets >>> extracted at runtime depending on the JVM platform >>> with all internal native dependencies resolved, >>> thus liberating the user from .dll hell. >>> >>> So, thumbs up or down to pursue this, or do I >>> need to find a different settlement :) >>> >>> >>> Regards >>> -- >>> ^(TM) > > - > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org > > - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
