Bug report for Tomcat 5 [2009/07/05]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |27122|Opn|Enh|2004-02-20|IE plugins cannot access components through Tomcat| |28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn | |29160|Ver|Enh|2004-05-23|precompile problem: _jspx_meth_* (javax.servlet.js| |29494|Inf|Enh|2004-06-10|No way to set PATH when running as a service on Wi| |30241|Ver|Enh|2004-07-21|Enhance build script to use branch argument when c| |33262|Inf|Enh|2005-01-27|Service Manager autostart should check for adminis| |33453|Opn|Enh|2005-02-08|Jasper should recompile JSP files whose datestamps| |33671|Opn|Enh|2005-02-21|Manual Windows service installation with custom na| |34801|New|Enh|2005-05-08|PATCH: CGIServlet does not terminate child after a| |34805|Ass|Enh|2005-05-08|warn about invalid security constraint url pattern| |34868|Ass|Enh|2005-05-11|allow to register a trust store for a session that| |35054|Inf|Enh|2005-05-25|warn if appBase is not existing as a File or direc| |36133|Inf|Enh|2005-08-10|Support JSS SSL implementation| |36362|New|Enh|2005-08-25|missing check for Java reserved keywords in tag fi| |36569|Inf|Enh|2005-09-09|Redirects produce illegal URL's | |36837|Inf|Enh|2005-09-28|Looking for ProxyHandler implementation of Http re| |36922|Inf|Enh|2005-10-04|setup.sh file mis-advertised and missing | |37018|Ass|Enh|2005-10-11|Document how to use tomcat-SSL with a pkcs11 token| |37084|Ass|Nor|2005-10-14|JspC from ant fails on JSPs that use custom taglib| |37334|Inf|Enh|2005-11-02|Realm digest property not aligned with the adminis| |37449|Opn|Enh|2005-11-10|Two UserDatabaseRealm break manager user | |37485|Inf|Enh|2005-11-14|I'd like to run init SQL after JDBC Connection cre| |37847|Ass|Enh|2005-12-09|Allow User To Optionally Specify Catalina Output F| |37869|Opn|Nor|2005-12-12|Cannot obtain client certificate with SSL / client| |37984|New|Nor|2005-12-21|JNDIRealm.java not able to handle MD5 password| |38216|Inf|Enh|2006-01-10|Extend Jmxproxy to allow call of MBean Operations | |38217|Ver|Enh|2006-01-10|mention that private key password and keystore pas| |38268|Inf|Enh|2006-01-13|User friendly: Need submit button on adding/deleti| |38360|Inf|Enh|2006-01-24|Domain for session cookies| |38483|New|Nor|2006-02-01|access log valve uses simpledateformat in tread-un| |38546|Inf|Enh|2006-02-07|Google bot sends invalid If-Modifed-Since Header, | |38577|Inf|Enh|2006-02-08|Enhance logging of security failures | |38743|New|Min|2006-02-21|when using APR, JKS options are silently ignored | |38797|Opn|Nor|2006-02-27|5.5.12 and 5.5.15 emit different code on | |41007|Opn|Enh|2006-11-20|Can't define customized 503 error page| |41059|Ass|Maj|2006-11-28|WebAppClassLoader clearReferences code break runni| |41179|New|Enh|2006-12-15|400 Bad Request response during auto re-deployment| |41227|Opn|Enh|2006-12-21|When the jasper compiler fails to compile a JSP, i| |41337|Opn|Enh|2007-01-10|Display an error page if no cert is available on C| |41496|New|Enh|2007-01-30|set a security provider for jsse in a connector co| |41498|New|Enh|2007-01-30|allRolesMode Realm configuration option not docume| |41539|Inf|Enh|2007-02-05|NullPointerException during Embedded tomcat restar| |41564|Inf|Maj|2007-02-07|service.bat does not install tomcat as a service p| |41661|Opn|Nor|2007-02-20|JspConfig.init() is not synchronized | |41673|New|Enh|2007-02-21|Jasper output the message of compiling error using| |41697|Ver|Enh|2007-02-25|make visible in debug output if charset from brows| |41709|Inf|Enh|2007-02-26|When calling the API that relates to the buffer af| |41718|New|Enh|2007-02-27|Status 302 response to GET request has no body whe| |41824|New|Nor|2007-03-12|Unable to use nested type in TLD | |41849|Opn|Nor|2007-03-15|Blank page after login on static html page (form a| |42390|New|Maj|2007-05-11|JSP compilation error with nested tagfile tags wit| |42416|New|Enh|
Bug report for Tomcat 4 [2009/07/05]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 3839|Opn|Enh|2001-09-26|Problem bookmarking login page| | 4227|Opn|Enh|2001-10-17|Invalid CGI path | | 5329|New|Enh|2001-12-08|NT Service exits startup before Tomcat is finished| | 5795|New|Enh|2002-01-10|Catalina Shutdown relies on localhost causing prob| | 5829|New|Enh|2002-01-13|StandardManager needs to cope with sessions throwi| | 5985|New|Enh|2002-01-23|Tomcat should perform a more restrictive validatio| | 6600|Opn|Enh|2002-02-20|enodeURL adds 'jsession' when 'isRequestedSessionI| | 6614|New|Enh|2002-02-21|Have Bootstrap and StandardClassLoader use the sam| | 6671|New|Enh|2002-02-25|Simple custom tag example uses old declaration sty| | 7043|New|Enh|2002-03-12|database user and password for JDBC Based Store | | 7374|New|Enh|2002-03-22|Apache Tomcat/4.0.1 message on standard output| | 7676|New|Enh|2002-04-02|Allow name property to use match experssions in without className in server.xml produces N| |11129|New|Enh|2002-07-24|New valve for putting the sessionIDs in the reques| |11248|New|Enh|2002-07-29|DefaultServlet doesn't send expires header| |11754|Opn|Enh|2002-08-15|Synchronous shutdown script - shutdown.sh should w| |12069|New|Enh|2002-08-27|Creation of more HttpSession objects for one previ| |12428|Opn|Enh|2002-09-09|request.getUserPrincipal(): Misinterpretation of s| |12658|New|Enh|2002-09-15|a proxy host and port at the element level | |12766|New|Enh|2002-09-18|Tomcat should use tld files in /WEB-INF/ over vers| |13309|Opn|Enh|2002-10-04|Catalina calls System.exit() | |13634|New|Enh|2002-10-15|Allowing system properties to be substituted in co| |13689|Opn|Enh|2002-10-16|Classloader paths for 'Common' classes and librari| |13731|New|Enh|2002-10-17|Final request, response, session and other variabl| |13941|New|Enh|2002-10-24|reload is VERY slow | |13965|New|Enh|2002-10-25|Catalina.sh correction request for Tru64 Unix | |14097|New|Enh|2002-10-30|hardcoded registry value for vm lets tomcat servic| |14416|New|Enh|2002-11-10|blank tag name in TLD cause NullPointerException | |14635|New|Enh|2002-11-18|Should be possible not to have -MM-DD in log f| |14766|New|Enh|2002-11-22|Redirect Vavle| |14993|New|Enh|2002-12-02|Possible obselete synchronized declaration| |15115|New|Enh|2002-12-05|correct docs... XML parser *cannot* be overridden | |15417|Opn|Enh|2002-12-16|Add port for forced compilation of JSP pages | |15688|New|Enh|2002-12-27|full-qualified names instead of imports | |15941|New|Enh|2003-01-10|Expose rootCause exceptions at deeper levels | |16294|New|Enh|2003-01-21|Configurable URL Decoding.| |16357|New|Enh|2003-01-23|"connection timeout reached" | |16531|New|Enh|2003-01-29|Updating already deployed ".war" files in a single| |16579|New|Enh|2003-01-30|documentation page layout/style breaks wrapping to| |16596|New|Enh|2003-01-30|option for disabling log rotation | |17070|New|Enh|2003-02-14|The Catalina Ant tasks do not allow for 'reusable'| |17146|New|Enh|2003-02-18|Simplify build.xml using
Bug report for Tomcat 6 [2009/07/05]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |39661|Opn|Enh|2006-05-25|Please document JULI FileHandler configuration pro| |41093|Ver|Enh|2006-11-30|publish 6.0.2 beta jars in a maven repository | |41128|Inf|Enh|2006-12-07|Reference to java Thread name from RequestProcesso| |41530|Ver|Nor|2007-02-02|stopping a connector produces intermittent SocketE| |41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat| |41791|New|Enh|2007-03-07|Tomcat behaves inconsistently concerning flush-pac| |41797|Ver|Maj|2007-03-09|CNFE/NPE thrown from function mapper when external| |41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific| |41944|New|Enh|2007-03-25|Start running the RAT tool to see where we're miss| |41992|New|Enh|2007-03-30|Need ability to set OS process title | |42463|New|Enh|2007-05-20|"crossContext" and classloader issues - pls amend | |42996|Opn|Nor|2007-07-29|POST with nio connector results in missing variabl| |43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant| |43003|New|Enh|2007-07-30|Separate dependent component download and build ta| |43154|New|Enh|2007-08-17|forward port from 5.5.x to 6.x about AccessLogValv| |43400|New|Enh|2007-09-14|enum support for tag libs | |43497|New|Enh|2007-09-26|Add ability to escape rendered output of JSP expre| |43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml | |43642|New|Enh|2007-10-17|Add prestartminSpareThreads attribute for Executor| |43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor| |43742|New|Enh|2007-10-30|.tag compiles performed one at a time -- extremel| |43790|Ass|Enh|2007-11-03|concurrent access issue on TagHandlerPool | |43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output | |44047|New|Enh|2007-12-10|Provide a way for Tomcat to serve up error pages w| |44106|New|Enh|2007-12-19|autodeploy configures directories which do not con| |44199|New|Enh|2008-01-10|expose current backlog queue size | |44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f| |44264|New|Enh|2008-01-18|Clustering - Support for disabling multicasting an| |44265|New|Enh|2008-01-18|Improve JspWriterImpl performance with "inline" su| |44284|New|Enh|2008-01-23|Support java.lang.Iterable in c:forEach tag | |44294|New|Enh|2008-01-25|Support for EL functions with varargs | |44299|New|Enh|2008-01-26|Provider manager app with a log out button| |44312|New|Enh|2008-01-28|Warn when overwritting docBase of the default Host| |44409|New|Enh|2008-02-13|Tomcat does not support Windows-My Provider | |44598|New|Enh|2008-03-13|JAASRealm is suppressing Exceptions | |44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI "java.nam| |44787|New|Enh|2008-04-09|provide more error context on "java.lang.IllegalSt| |44818|New|Enh|2008-04-13|tomcat hangs with GET when content-length is defin| |45014|New|Enh|2008-05-15|Request and Response classes should have wrappers | |45255|New|Enh|2008-06-23|support disable jsessionid from url against sessio| |45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets| |45283|Opn|Enh|2008-06-25|Allow multiple authenticators to be added to pipel| |45403|New|Nor|2008-07-15|Tomcat does not reload application| |45428|New|Enh|2008-07-18|warn if the tomcat stop doesn't complete | |45654|New|Enh|2008-08-19|use static methods and attributes in a direct way!| |45731|New|Enh|2008-09-02|Enhancement request : pluggable httpsession cache | |45794|New|Enh|2008-09-12|Patch causes JNDIRealm to bind with user entered c| |45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks| |45871|New|Enh|2008-09-23|Support for salted and digested patches in DataSou| |45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or | |45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE| |45931|
DO NOT REPLY [Bug 39637] AJP13 connector does not handle chain of SSL client certificate
https://issues.apache.org/bugzilla/show_bug.cgi?id=39637 Patrik Schnellmann changed: What|Removed |Added Status|RESOLVED|REOPENED Resolution|DUPLICATE | --- Comment #8 from Patrik Schnellmann 2009-07-05 22:33:03 PST --- This bug (39637) and https://issues.apache.org/bugzilla/show_bug.cgi?id=37869 are not the same issue. This one has been filed for the JK connector while #37869 has been filed for the HTTP connector. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [g...@vmgump]: Project tomcat-catalina (in module jakarta-tomcat-4.0) failed
On 2009-07-06, Konstantin Kolinko wrote: > According to Gump metadata > (http://svn.apache.org/repos/asf/gump/metadata/project/jakarta-servletapi-4.xml), > the sources for the servletapi build were taken from > tomcat/servletapi/branches/other/servlet2.3-jsp1.2-tc4.x/ASF > That address is wrong. - It should point to > tomcat/archive/tc4.1.x/trunk/servletapi Thanks for the analysis. This should be fixed with the next Gump build (after the currently active one). Stefan - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [g...@vmgump]: Project tomcat-catalina (in module jakarta-tomcat-4.0) failed
2009/7/6 Konstantin Kolinko : > 2009/7/5 Stefan Bodewig : >> To whom it may engage... >> >> This is an automated request, but not an unsolicited one. For >> more information please visit http://gump.apache.org/nagged.html, >> and/or contact the folk at gene...@gump.apache.org. >> >> Project tomcat-catalina has an issue affecting its community integration. >> This issue affects 3 projects, >> and has been outstanding for 3 runs. >> The current state of this project is 'Failed', with reason 'Build Failed'. >> For reference only, the following projects are affected by this: >> - jakarta-tomcat-4.0 : Servlet 2.3 and JSP 1.2 Reference Implementation >> - jakarta-tomcat-coyote-tomcat4 : Connectors to various web servers >> - tomcat-catalina : Servlet 2.3 and JSP 1.2 Reference Implementation >> >> >> Full details are available at: >> >> http://vmgump.apache.org/gump/public/jakarta-tomcat-4.0/tomcat-catalina/index.html >> >> (...) >> [javac] symbol : class HttpSessionAttributeListener >> [javac] location: class org.apache.catalina.session.StandardSession >> [javac] if (!(listeners[i] instanceof >> HttpSessionAttributeListener)) >> [javac] ^ >> [javac] >> /srv/gump/public/workspace/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/StandardSession.java:1142: >> cannot find symbol >>(...) > > If one looks at > http://vmgump.apache.org/gump/public-jars/jakarta-servletapi-4/jars/ > > there are the following versions of servletapi.jar: > [ ] servletapi-gump-02072009.jar 02-Jul-2009 01:40 76K > [ ] servletapi-gump-03072009.jar 03-Jul-2009 02:01 71K > [ ] servletapi-gump-05072009.jar 05-Jul-2009 04:22 71K > > Note, that the file of 2009-07-02 has different size. > The differences are: > 1) META-INF/MANIFEST.MF > The old one contains Specification-Title: and Implementation-Title: etc. > headers > > 2) The new ones do not contain the following three classes: > - javax.servlet.jsp.tagext.ValidationMessage > - javax.servlet.http.HttpSessionAttributeListener > - javax.servlet.ServletContextAttributeListener > but do contain the following two classes instead: > - javax.servlet.http.HttpSessionAttributesListener > - javax.servlet.ServletContextAttributesListener > > The class names are *Attribute* in the old jar, *Attributes* in the new jars. > > Thus the compilation errors that we are observing. > > 3) The new ones do not contain *_fr,properties and *_ja.properties files. > > > The servlet.jar from TC 4.1.40 matches the old one of July 2nd. > > > I wonder, what happened with Gump configuration. Have not dug further yet. > According to Gump metadata (http://svn.apache.org/repos/asf/gump/metadata/project/jakarta-servletapi-4.xml), the sources for the servletapi build were taken from tomcat/servletapi/branches/other/servlet2.3-jsp1.2-tc4.x/ASF That address is wrong. - It should point to tomcat/archive/tc4.1.x/trunk/servletapi (see http://svn.apache.org/viewvc?view=rev&revision=788407) (The old https://svn.apache.org/repos/asf/tomcat/current/tc4.1.x had the following in its svn:externals: servletapi https://svn.apache.org/repos/asf/tomcat/servletapi/branches/servlet2.3-jsp1.2-tc4.x ) Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791342 - /tomcat/current/tc5.5.x/STATUS.txt
Author: markt Date: Sun Jul 5 23:34:11 2009 New Revision: 791342 URL: http://svn.apache.org/viewvc?rev=791342&view=rev Log: Vote Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=791342&r1=791341&r2=791342&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Sun Jul 5 23:34:11 2009 @@ -68,7 +68,7 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47149 Explicitly specify encoding for the source files http://people.apache.org/~kkolinko/patches/2009-07-04_tc55_encodings.patch - +1: kkolinko + +1: kkolinko, markt -1: * Document minimum required Ant version to be 1.6.2, instead of 1.5.x @@ -78,6 +78,7 @@ Patch for BUILDING.txt: http://people.apache.org/~kkolinko/patches/2009-07-04_tc55_antversion.patch +1: kkolinko + +1: markt - min JRE version is 1.4, even with the compat package -1: * Patch for fixcrlf tasks: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791341 - /tomcat/current/tc5.5.x/STATUS.txt
Author: markt Date: Sun Jul 5 23:27:12 2009 New Revision: 791341 URL: http://svn.apache.org/viewvc?rev=791341&view=rev Log: Vote Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=791341&r1=791340&r2=791341&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Sun Jul 5 23:27:12 2009 @@ -87,12 +87,12 @@ (We have a License.rtf file) Note, that fixlast option for fixcrlf task is since Ant 1.6.1 only. http://people.apache.org/~kkolinko/patches/2009-07-04_tc55_fixcrlf.patch - +1: kkolinko + +1: kkolinko, markt -1: * Specify explicit encoding when performing filtering in copy and replace tasks http://people.apache.org/~kkolinko/patches/2009-07-04_tc55_copy-encodings.patch - +1: kkolinko + +1: kkolinko, markt -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47464 @@ -100,7 +100,7 @@ Also, I limited the scope of fixcrlf task in package-src-tgz target to process the sources dir only. http://people.apache.org/~kkolinko/patches/2009-07-05_tc55_packsources.patch - +1: kkolinko + +1: kkolinko, markt -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38797 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791339 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Sun Jul 5 23:17:33 2009 New Revision: 791339 URL: http://svn.apache.org/viewvc?rev=791339&view=rev Log: Vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=791339&r1=791338&r2=791339&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Jul 5 23:17:33 2009 @@ -143,24 +143,24 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47149 Explicitly specify encoding for the source files http://people.apache.org/~kkolinko/patches/2009-07-04_tc6_encodings.patch - +1: kkolinko + +1: kkolinko, markt -1: * Add *.rtf to the list of exclusions in fixcrlf task. http://svn.apache.org/viewvc?rev=791184&view=rev - +1: kkolinko + +1: kkolinko, markt -1: * Remove build-webapps-precompile target from dist.xml Discussion: http://markmail.org/thread/ymgbgqm3lav6rnjh Patch: http://people.apache.org/~kkolinko/patches/2009-07-04_tc6_remove-webapps-precompile.patch - +1: kkolinko + +1: kkolinko, markt -1: * Specify explicit encoding when performing replace task http://svn.apache.org/viewvc?rev=791194&view=rev - +1: kkolinko + +1: kkolinko, markt -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38797 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: [g...@vmgump]: Project tomcat-catalina (in module jakarta-tomcat-4.0) failed
2009/7/5 Stefan Bodewig : > To whom it may engage... > > This is an automated request, but not an unsolicited one. For > more information please visit http://gump.apache.org/nagged.html, > and/or contact the folk at gene...@gump.apache.org. > > Project tomcat-catalina has an issue affecting its community integration. > This issue affects 3 projects, > and has been outstanding for 3 runs. > The current state of this project is 'Failed', with reason 'Build Failed'. > For reference only, the following projects are affected by this: > - jakarta-tomcat-4.0 : Servlet 2.3 and JSP 1.2 Reference Implementation > - jakarta-tomcat-coyote-tomcat4 : Connectors to various web servers > - tomcat-catalina : Servlet 2.3 and JSP 1.2 Reference Implementation > > > Full details are available at: > > http://vmgump.apache.org/gump/public/jakarta-tomcat-4.0/tomcat-catalina/index.html > > (...) > [javac] symbol : class HttpSessionAttributeListener > [javac] location: class org.apache.catalina.session.StandardSession > [javac] if (!(listeners[i] instanceof > HttpSessionAttributeListener)) > [javac] ^ > [javac] > /srv/gump/public/workspace/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/StandardSession.java:1142: > cannot find symbol >(...) If one looks at http://vmgump.apache.org/gump/public-jars/jakarta-servletapi-4/jars/ there are the following versions of servletapi.jar: [ ] servletapi-gump-02072009.jar02-Jul-2009 01:4076K [ ] servletapi-gump-03072009.jar03-Jul-2009 02:01 71K [ ] servletapi-gump-05072009.jar05-Jul-2009 04:22 71K Note, that the file of 2009-07-02 has different size. The differences are: 1) META-INF/MANIFEST.MF The old one contains Specification-Title: and Implementation-Title: etc. headers 2) The new ones do not contain the following three classes: - javax.servlet.jsp.tagext.ValidationMessage - javax.servlet.http.HttpSessionAttributeListener - javax.servlet.ServletContextAttributeListener but do contain the following two classes instead: - javax.servlet.http.HttpSessionAttributesListener - javax.servlet.ServletContextAttributesListener The class names are *Attribute* in the old jar, *Attributes* in the new jars. Thus the compilation errors that we are observing. 3) The new ones do not contain *_fr,properties and *_ja.properties files. The servlet.jar from TC 4.1.40 matches the old one of July 2nd. I wonder, what happened with Gump configuration. Have not dug further yet. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 38352] Additional Entries for Default catalina.policy file.
https://issues.apache.org/bugzilla/show_bug.cgi?id=38352 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #10 from Mark Thomas 2009-07-05 16:09:11 PST --- This has been fixed in 5.5.x and will be included in 5.5.28 onwards -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791336 - /tomcat/current/tc5.5.x/STATUS.txt
Author: markt Date: Sun Jul 5 23:08:50 2009 New Revision: 791336 URL: http://svn.apache.org/viewvc?rev=791336&view=rev Log: Remove applied fixes Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=791336&r1=791335&r2=791336&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Sun Jul 5 23:08:50 2009 @@ -31,19 +31,6 @@ +1: markt, kkolinko -1: -* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37794 - Handle chunked POSTs. If maxPostSize is exceeded, a 500 results - http://svn.apache.org/viewvc?rev=785381&view=rev - http://svn.apache.org/viewvc?rev=786487&view=rev - +1: markt, rjung, kkolinko - -1: - -* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38352 - JSPs should have read/write access to the context's temp dir - http://svn.apache.org/viewvc?rev=786490&view=rev - +1: markt, rjung, kkolinko - -1: - * Make access log valves thread safe https://issues.apache.org/bugzilla/show_bug.cgi?id=38483 Patch for ExtendedAccessLogValve: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791335 - in /tomcat: container/tc5.5.x/webapps/docs/changelog.xml jasper/tc5.5.x/src/share/org/apache/jasper/compiler/JspRuntimeContext.java
Author: markt
Date: Sun Jul 5 23:08:11 2009
New Revision: 791335
URL: http://svn.apache.org/viewvc?rev=791335&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38352
Make temp dir writable to JSPs as well as servlets when running under a
security manager
Modified:
tomcat/container/tc5.5.x/webapps/docs/changelog.xml
tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/JspRuntimeContext.java
Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?rev=791335&r1=791334&r2=791335&view=diff
==
--- tomcat/container/tc5.5.x/webapps/docs/changelog.xml (original)
+++ tomcat/container/tc5.5.x/webapps/docs/changelog.xml Sun Jul 5 23:08:11 2009
@@ -205,6 +205,11 @@
(markt)
+38352: Make the directory defined by
+javax.servlet.context.tempdir readable for JSPs when running under a
+security manager as required by the specification. (markt)
+
+
41606: Fix double initialisation of JSPs. Patch provided by
Chris Halstead. (markt)
Modified:
tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/JspRuntimeContext.java
URL:
http://svn.apache.org/viewvc/tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/JspRuntimeContext.java?rev=791335&r1=791334&r2=791335&view=diff
==
---
tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/JspRuntimeContext.java
(original)
+++
tomcat/jasper/tc5.5.x/src/share/org/apache/jasper/compiler/JspRuntimeContext.java
Sun Jul 5 23:08:11 2009
@@ -384,16 +384,19 @@
docBase = docBase + "-";
permissionCollection.add(new FilePermission(docBase,"read"));
-// Create a file read permission for web app tempdir (work)
-// directory
+// Spec says apps should have read/write for their temp
+// directory. This is fine, as no security sensitive files, at
+// least any that the app doesn't have full control of anyway,
+// will be written here.
String workDir = options.getScratchDir().toString();
if (!workDir.endsWith(File.separator)){
permissionCollection.add
-(new FilePermission(workDir,"read"));
+(new FilePermission(workDir,"read,write"));
workDir = workDir + File.separator;
}
workDir = workDir + "-";
-permissionCollection.add(new FilePermission(workDir,"read"));
+permissionCollection.add(new FilePermission(
+workDir,"read,write,delete"));
// Allow the JSP to access
org.apache.jasper.runtime.HttpJspBase
permissionCollection.add( new RuntimePermission(
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 37794] getParameter() fails on POST with transfer-encoding: chunked
https://issues.apache.org/bugzilla/show_bug.cgi?id=37794 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #8 from Mark Thomas 2009-07-05 16:03:38 PST --- This has been fixed in 5.5.x and will be included in 5.5.28 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791334 - in /tomcat/container/tc5.5.x: catalina/src/share/org/apache/catalina/connector/LocalStrings.properties catalina/src/share/org/apache/catalina/connector/Request.java webapps/docs/
Author: markt
Date: Sun Jul 5 23:03:23 2009
New Revision: 791334
URL: http://svn.apache.org/viewvc?rev=791334&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37794
Add support for reading POST parameters when using chunked encoding
Modified:
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/LocalStrings.properties
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/Request.java
tomcat/container/tc5.5.x/webapps/docs/changelog.xml
Modified:
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/LocalStrings.properties?rev=791334&r1=791333&r2=791334&view=diff
==
---
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/LocalStrings.properties
(original)
+++
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/LocalStrings.properties
Sun Jul 5 23:03:23 2009
@@ -58,6 +58,8 @@
coyoteRequest.attributeEvent=Exception thrown by attributes event listener
coyoteRequest.parseParameters=Exception thrown whilst processing POSTed
parameters
coyoteRequest.postTooLarge=Parameters were not parsed because the size of the
posted data was too big. Use the maxPostSize attribute of the connector to
resolve this if the application should accept large POSTs.
+coyoteRequest.chunkedPostTooLarge=Parameters were not parsed because the size
of the posted data was too big. Because this request was a chunked request, it
could not be processed further. Use the maxPostSize attribute of the connector
to resolve this if the application should accept large POSTs.
+
requestFacade.nullRequest=Null request object
responseFacade.nullResponse=Null response object
Modified:
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/Request.java
URL:
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/Request.java?rev=791334&r1=791333&r2=791334&view=diff
==
---
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/Request.java
(original)
+++
tomcat/container/tc5.5.x/catalina/src/share/org/apache/catalina/connector/Request.java
Sun Jul 5 23:03:23 2009
@@ -46,6 +46,7 @@
import javax.servlet.http.HttpSession;
import org.apache.tomcat.util.buf.B2CConverter;
+import org.apache.tomcat.util.buf.ByteChunk;
import org.apache.tomcat.util.buf.MessageBytes;
import org.apache.tomcat.util.buf.StringCache;
import org.apache.tomcat.util.http.Cookies;
@@ -2403,6 +2404,20 @@
context.getLogger().warn
(sm.getString("coyoteRequest.parseParameters"), t);
}
+} else if ("chunked".equalsIgnoreCase(
+coyoteRequest.getHeader("transfer-encoding"))) {
+byte[] formData = null;
+try {
+formData = readChunkedPostBody();
+} catch (IOException e) {
+// Client disconnect
+if (context.getLogger().isDebugEnabled()) {
+context.getLogger().debug(
+sm.getString("coyoteRequest.parseParameters"), e);
+}
+return;
+}
+parameters.processParameters(formData, 0, formData.length);
}
}
@@ -2428,6 +2443,38 @@
/**
+ * Read chunked post body.
+ */
+protected byte[] readChunkedPostBody() throws IOException {
+ByteChunk body = new ByteChunk();
+
+byte[] buffer = new byte[CACHED_POST_LEN];
+
+int len = 0;
+while (len > -1) {
+len = getStream().read(buffer, 0, CACHED_POST_LEN);
+if (connector.getMaxPostSize() > 0 &&
+(body.getLength() + len) > connector.getMaxPostSize()) {
+// Too much data
+throw new IllegalArgumentException(
+sm.getString("coyoteRequest.chunkedPostTooLarge"));
+}
+if (len > 0) {
+body.append(buffer, 0, len);
+}
+}
+if (body.getLength() < body.getBuffer().length) {
+int length = body.getLength();
+byte[] result = new byte[length];
+System.arraycopy(body.getBuffer(), 0, result, 0, length);
+return result;
+} else {
+return body.getBuffer();
+}
+}
+
+
+/**
* Parse request locales.
*/
protected void parseLocales() {
Modified: tomcat/container/tc5.5.x/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/changelog.xml?rev=791334&r1=791333&r2=791334&view=diff
==
DO NOT REPLY [Bug 39194] classpath inconsistent between Windows and Unix for tools.jar
https://issues.apache.org/bugzilla/show_bug.cgi?id=39194 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #4 from Mark Thomas 2009-07-05 15:50:59 PST --- This has been fixed in trunk along with a handful of other script niggles. All the fixes have been proposed for 5.5.x and 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791332 - in /tomcat: current/tc5.5.x/STATUS.txt tc6.0.x/trunk/STATUS.txt
Author: markt Date: Sun Jul 5 22:50:35 2009 New Revision: 791332 URL: http://svn.apache.org/viewvc?rev=791332&view=rev Log: Propose script improvements Modified: tomcat/current/tc5.5.x/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=791332&r1=791331&r2=791332&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Sun Jul 5 22:50:35 2009 @@ -130,3 +130,10 @@ http://svn.apache.org/viewvc?rev=791243&view=rev +1: markt, kkolinko -1: + +* Various script improvements (free free to vote for them individually) + http://svn.apache.org/viewvc?rev=791326&view=rev (remove JSSE) + http://svn.apache.org/viewvc?rev=791328&view=rev (display classpath) + http://svn.apache.org/viewvc?rev=791331&view=rev (align platforms / bug 39194) + +1: markt + -1: Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=791332&r1=791331&r2=791332&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Jul 5 22:50:35 2009 @@ -176,3 +176,10 @@ http://svn.apache.org/viewvc?rev=791243&view=rev +1: markt, kkolinko -1: + +* Various script improvements (free free to vote for them individually) + http://svn.apache.org/viewvc?rev=791326&view=rev (remove JSSE) + http://svn.apache.org/viewvc?rev=791328&view=rev (display classpath) + http://svn.apache.org/viewvc?rev=791331&view=rev (align platforms / bug 39194) + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791331 - in /tomcat/trunk/bin: catalina.bat catalina.sh setclasspath.bat setclasspath.sh
Author: markt Date: Sun Jul 5 22:46:51 2009 New Revision: 791331 URL: http://svn.apache.org/viewvc?rev=791331&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=39194 Align classpath for all platforms: - only add tools.jar to the classpath when required - document optional javac argument for catalina.sh|bat - make sure javac without generating warnings on start Include a patch for setclasspath.sh by Jason Brittain Modified: tomcat/trunk/bin/catalina.bat tomcat/trunk/bin/catalina.sh tomcat/trunk/bin/setclasspath.bat tomcat/trunk/bin/setclasspath.sh Modified: tomcat/trunk/bin/catalina.bat URL: http://svn.apache.org/viewvc/tomcat/trunk/bin/catalina.bat?rev=791331&r1=791330&r2=791331&view=diff == --- tomcat/trunk/bin/catalina.bat (original) +++ tomcat/trunk/bin/catalina.bat Sun Jul 5 22:46:51 2009 @@ -106,8 +106,13 @@ call "%CATALINA_HOME%\bin\setclasspath.bat" %1 if errorlevel 1 goto end +if "%1" == "javac" shift + rem Add on extra jar files to CLASSPATH -set CLASSPATH=%CLASSPATH%;%CATALINA_HOME%\bin\bootstrap.jar +if "%CLASSPATH%" == "" goto emptyClasspath +set CLASSPATH=%CLASSPATH%; +:emptyClasspath +set CLASSPATH=%CLASSPATH%%CATALINA_HOME%\bin\bootstrap.jar if not "%CATALINA_BASE%" == "" goto gotBase set CATALINA_BASE=%CATALINA_HOME% @@ -172,7 +177,10 @@ if ""%1"" == ""stop"" goto doStop if ""%1"" == ""version"" goto doVersion -echo Usage: catalina ( commands ... ) +echo Usage: catalina [javac] ( commands ... ) +echo optional arguments: +echo javac Adds tools.jar to the classpath so javac is available +echo as a compiler echo commands: echo debug Start Catalina in a debugger echo debug -security Debug Catalina with a security manager Modified: tomcat/trunk/bin/catalina.sh URL: http://svn.apache.org/viewvc/tomcat/trunk/bin/catalina.sh?rev=791331&r1=791330&r2=791331&view=diff == --- tomcat/trunk/bin/catalina.sh (original) +++ tomcat/trunk/bin/catalina.sh Sun Jul 5 22:46:51 2009 @@ -150,7 +150,10 @@ fi # Add on extra jar files to CLASSPATH -CLASSPATH="$CLASSPATH":"$CATALINA_HOME"/bin/bootstrap.jar +if [ ! -z "$CLASSPATH" ] ; then + CLASSPATH="$CLASSPATH": +fi +CLASSPATH="$CLASSPATH""$CATALINA_HOME"/bin/bootstrap.jar if [ -z "$CATALINA_BASE" ] ; then CATALINA_BASE="$CATALINA_HOME" @@ -345,7 +348,10 @@ else - echo "Usage: catalina.sh ( commands ... )" + echo "Usage: catalina.sh [javac] ( commands ... )" + echo "optional arguments:" + echo " javac Adds tools.jar to the classpath so javac is" + echo " available as a compiler" echo "commands:" if $os400; then echo " debug Start Catalina in a debugger (not available on OS400)" Modified: tomcat/trunk/bin/setclasspath.bat URL: http://svn.apache.org/viewvc/tomcat/trunk/bin/setclasspath.bat?rev=791331&r1=791330&r2=791331&view=diff == --- tomcat/trunk/bin/setclasspath.bat (original) +++ tomcat/trunk/bin/setclasspath.bat Sun Jul 5 22:46:51 2009 @@ -70,9 +70,14 @@ rem Set standard CLASSPATH rem Note that there are no quotes as we do not want to introduce random rem quotes into the CLASSPATH -if not exist "%JAVA_HOME%\lib\tools.jar" goto noJavac +if not exist "%JAVA_HOME%\lib\tools.jar" goto noJavac2 +if not ""%1"" == ""debug"" goto noJavac1 set CLASSPATH=%JAVA_HOME%\lib\tools.jar -:noJavac +goto noJavac2 +:noJavac1 +if not ""%1"" == ""javac"" goto noJavac2 +set CLASSPATH=%JAVA_HOME%\lib\tools.jar +:noJavac2 rem Set standard command for invoking Java. rem Note that NT requires a window name argument when using start. Modified: tomcat/trunk/bin/setclasspath.sh URL: http://svn.apache.org/viewvc/tomcat/trunk/bin/setclasspath.sh?rev=791331&r1=791330&r2=791331&view=diff == --- tomcat/trunk/bin/setclasspath.sh (original) +++ tomcat/trunk/bin/setclasspath.sh Sun Jul 5 22:46:51 2009 @@ -112,6 +112,9 @@ if [ "$1" = "debug" -o "$1" = "javac" ] ; then if [ -f "$JAVA_HOME"/lib/tools.jar ]; then CLASSPATH="$JAVA_HOME"/lib/tools.jar +if [ "$1" = "javac" ] ; then + shift +fi fi fi - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: I find a bug in tomcat 4.1.x or later version(5.x,6.x)
Konstantin Kolinko wrote:
> 2009/7/5 jun ma :
>>
>>
>> <%
>>
>> Integer myElement = (Integer)element;
>>
>> List myList = (List)myMap.get(myElement);
>>
>> *if* (myList == *null* || myList.size() <= 1)
>>
>> {
>>
>> System.out.println("test!!!");
>>
>> *continue*;
>>
>> }
>>
>>%>
>>
>>
>
>
> The code is wrong.
>
> You cannot "continue" or "break" when you do not have a loop in *your*
> Java code, and the tag is not your code. It is just a coincidence
> that it worked before.
+1
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: I find a bug in tomcat 4.1.x or later version(5.x,6.x)
2009/7/5 jun ma :
>
>
> <%
>
> Integer myElement = (Integer)element;
>
> List myList = (List)myMap.get(myElement);
>
> *if* (myList == *null* || myList.size() <= 1)
>
> {
>
> System.out.println("test!!!");
>
> *continue*;
>
> }
>
> %>
>
>
The code is wrong.
You cannot "continue" or "break" when you do not have a loop in *your*
Java code, and the tag is not your code. It is just a coincidence
that it worked before.
I do not see any requirement in the JSP specification to support such tricks.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791328 - in /tomcat/trunk/bin: catalina.bat catalina.sh
Author: markt Date: Sun Jul 5 21:48:51 2009 New Revision: 791328 URL: http://svn.apache.org/viewvc?rev=791328&view=rev Log: Add the CLAASSPATH to the output (will be useful while working on 39194 as well as generally useful to see if it has been modified from the default) Fix a minor alignment niggle with JRE_HOME in cataina.sh Modified: tomcat/trunk/bin/catalina.bat tomcat/trunk/bin/catalina.sh Modified: tomcat/trunk/bin/catalina.bat URL: http://svn.apache.org/viewvc/tomcat/trunk/bin/catalina.bat?rev=791328&r1=791327&r2=791328&view=diff == --- tomcat/trunk/bin/catalina.bat (original) +++ tomcat/trunk/bin/catalina.bat Sun Jul 5 21:48:51 2009 @@ -140,6 +140,7 @@ :use_jdk echo Using JAVA_HOME: %JAVA_HOME% :java_dir_displayed +echo Using CLASSPATH: %CLASSPATH% set _EXECJAVA=%_RUNJAVA% set MAINCLASS=org.apache.catalina.startup.Bootstrap Modified: tomcat/trunk/bin/catalina.sh URL: http://svn.apache.org/viewvc/tomcat/trunk/bin/catalina.sh?rev=791328&r1=791327&r2=791328&view=diff == --- tomcat/trunk/bin/catalina.sh (original) +++ tomcat/trunk/bin/catalina.sh Sun Jul 5 21:48:51 2009 @@ -204,8 +204,9 @@ if [ "$1" = "debug" -o "$1" = "javac" ] ; then echo "Using JAVA_HOME: $JAVA_HOME" else -echo "Using JRE_HOME: $JRE_HOME" +echo "Using JRE_HOME:$JRE_HOME" fi + echo "Using CLASSPATH: $CLASSPATH" fi if [ "$1" = "jpda" ] ; then - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791326 - in /tomcat/trunk/bin: catalina.bat catalina.sh
Author: markt Date: Sun Jul 5 21:45:32 2009 New Revision: 791326 URL: http://svn.apache.org/viewvc?rev=791326&view=rev Log: As of JDK 1.4, JSSE was no longer a separate download No need to include it in the startup scripts Modified: tomcat/trunk/bin/catalina.bat tomcat/trunk/bin/catalina.sh Modified: tomcat/trunk/bin/catalina.bat URL: http://svn.apache.org/viewvc/tomcat/trunk/bin/catalina.bat?rev=791326&r1=791325&r2=791326&view=diff == --- tomcat/trunk/bin/catalina.bat (original) +++ tomcat/trunk/bin/catalina.bat Sun Jul 5 21:45:32 2009 @@ -42,10 +42,6 @@ rem JAVA_OPTS (Optional) Java runtime options used when the "start", rem "stop", or "run" command is executed. rem -rem JSSE_HOME (Optional) May point at your Java Secure Sockets Extension -rem (JSSE) installation, whose JAR files will be added to the -rem system class path used to start Tomcat. -rem rem JPDA_TRANSPORT (Optional) JPDA transport used when the "jpda start" rem command is executed. The default is "dt_shmem". rem @@ -111,9 +107,6 @@ if errorlevel 1 goto end rem Add on extra jar files to CLASSPATH -if "%JSSE_HOME%" == "" goto noJsse -set CLASSPATH=%CLASSPATH%;%JSSE_HOME%\lib\jcert.jar;%JSSE_HOME%\lib\jnet.jar;%JSSE_HOME%\lib\jsse.jar -:noJsse set CLASSPATH=%CLASSPATH%;%CATALINA_HOME%\bin\bootstrap.jar if not "%CATALINA_BASE%" == "" goto gotBase Modified: tomcat/trunk/bin/catalina.sh URL: http://svn.apache.org/viewvc/tomcat/trunk/bin/catalina.sh?rev=791326&r1=791325&r2=791326&view=diff == --- tomcat/trunk/bin/catalina.sh (original) +++ tomcat/trunk/bin/catalina.sh Sun Jul 5 21:45:32 2009 @@ -60,10 +60,6 @@ # -agentlib:jdwp=transport=$JPDA_TRANSPORT, # address=$JPDA_ADDRESS,server=y,suspend=$JPDA_SUSPEND # -# JSSE_HOME (Optional) May point at your Java Secure Sockets Extension -# (JSSE) installation, whose JAR files will be added to the -# system class path used to start Tomcat. -# # CATALINA_PID(Optional) Path of the file which should contains the pid # of catalina startup java process, when start (fork) is used # @@ -120,7 +116,6 @@ [ -n "$CATALINA_HOME" ] && CATALINA_HOME=`cygpath --unix "$CATALINA_HOME"` [ -n "$CATALINA_BASE" ] && CATALINA_BASE=`cygpath --unix "$CATALINA_BASE"` [ -n "$CLASSPATH" ] && CLASSPATH=`cygpath --path --unix "$CLASSPATH"` - [ -n "$JSSE_HOME" ] && JSSE_HOME=`cygpath --absolute --unix "$JSSE_HOME"` fi # For OS400 @@ -155,9 +150,6 @@ fi # Add on extra jar files to CLASSPATH -if [ -n "$JSSE_HOME" ]; then - CLASSPATH="$CLASSPATH":"$JSSE_HOME"/lib/jcert.jar:"$JSSE_HOME"/lib/jnet.jar:"$JSSE_HOME"/lib/jsse.jar -fi CLASSPATH="$CLASSPATH":"$CATALINA_HOME"/bin/bootstrap.jar if [ -z "$CATALINA_BASE" ] ; then @@ -183,7 +175,6 @@ CATALINA_BASE=`cygpath --absolute --windows "$CATALINA_BASE"` CATALINA_TMPDIR=`cygpath --absolute --windows "$CATALINA_TMPDIR"` CLASSPATH=`cygpath --path --windows "$CLASSPATH"` - [ -n "$JSSE_HOME" ] && JSSE_HOME=`cygpath --absolute --windows "$JSSE_HOME"` JAVA_ENDORSED_DIRS=`cygpath --path --windows "$JAVA_ENDORSED_DIRS"` fi - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: I find a bug in tomcat 4.1.x or later version(5.x,6.x)
jun ma wrote:
> Dear Tomcat organization:
>
>I think I find a bug in tomcat, I explain it in the document.The document
> is in the attachment. Or I paste it directly following:
I haven't looked at this at all but...
It is best if you create a Bugzilla entry for this so it doesn't get lost.
Create it for Tomcat 6 since that version is affected and add your test
case as an attachment.
Cheers,
Mark
>
> When I use logic:iterator(struts) labels in tomcat 4.1.x or later
> version(5.x,6.x), I find a problem. This problem don’t appear in tomcat
> 4.0.x.
>
>
>
> First of all,I will show you the test code:
>
>
>
>
>
>
>
> When I put the code in the a jsp file(index.jsp), start the tomcat 5.x
> server and access the page(index.jsp), the console prints the “test!!!”
> endlessly. But if I excute the same code in tomcat 4.0.1,the “test!!!” only
> prints one time.
>
>
>
> So I try to find out the reason, and finally I find that it is the JSP
> compiler that cause the problem. When I compare the java code generated by
> the two compilers,I find the result of compiling the logic:iterator(struts)
> is not the same.
>
> In tomcat 4.0.1, it like this:
>
> *code 1*
>
> *do{*
>
> *…….//omitted codes*
>
> *if** (myList == **null** || myList.size() <= 1)***
>
> *{***
>
> * System.out.println(**"test!!!"**);***
>
> * **continue**;***
>
> *}***
>
> *……//still omit*
>
> * *
>
> *} while (_jspx_th_logic_iterate_0.doAfterBody() ==
> javax.servlet.jsp.tagext.BodyTag.EVAL_BODY_AGAIN);*
>
>
>
> But in tomcat 5.x,it becomes:
>
> *code 2*
>
> *do{*
>
> *…….//omitted codes*
>
> *if** (myList == **null** || myList.size() <= 1)***
>
> *{***
>
> * System.out.println(**"test!!!"**);***
>
> * **continue**;***
>
> *}***
>
> *……//still omit*
>
> * *
>
> *if (evalDoAfterBody != javax.servlet.jsp.tagext.BodyTag.EVAL_BODY_AGAIN)*
>
> *break;*
>
> *} while (true);*
>
>
>
> In code 2,when the code is excuted the “*continue*” statement, it jumps to
> the “*while(true)*”. Again, the “*continue*” is excuted, angain the “*
> while(true)*”. So we encounters the Endless loop.
>
>
>
> But in code 1, the problem is noe exist. You see, when the “*continue*”
> statement is excuted, it jumps to the “*while
> (_jspx_th_logic_iterate_0.doAfterBody() ==
> javax.servlet.jsp.tagext.BodyTag.EVAL_BODY_AGAIN)*”. It then break the while
> loop.
>
>
> I test the code in tomcat 4.0.1, tomcat 4.1.40, tomcat 5.5.27, and tomcat
> 6.0.20. It seems that the code works normally only in tomcat 4.0.1.
>
>
> Thank you for reading my letter.Looking forward to hearing from you.
>
>
>
>
> Your sincerely, Ma Jun
>
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791322 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko
Date: Sun Jul 5 21:12:17 2009
New Revision: 791322
URL: http://svn.apache.org/viewvc?rev=791322&view=rev
Log:
votes
Modified:
tomcat/tc6.0.x/trunk/STATUS.txt
Modified: tomcat/tc6.0.x/trunk/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=791322&r1=791321&r2=791322&view=diff
==
--- tomcat/tc6.0.x/trunk/STATUS.txt (original)
+++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Jul 5 21:12:17 2009
@@ -90,7 +90,7 @@
* Dont try to report thread counts when using an executor from outside
http://people.apache.org/~fhanik/connector-thread-report.patch
- +1: fhanik
+ +1: fhanik, kkolinko
+1: markt - would 0 make more sense rather than -1? Happy with either
-1:
@@ -137,7 +137,7 @@
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37984
Strip {MD5} as well as {SHA} from digested passwords
http://svn.apache.org/viewvc?rev=790405&view=rev
- +1: markt
+ +1: markt, kkolinko
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47149
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791321 - /tomcat/current/tc5.5.x/STATUS.txt
Author: kkolinko
Date: Sun Jul 5 21:03:53 2009
New Revision: 791321
URL: http://svn.apache.org/viewvc?rev=791321&view=rev
Log:
votes
Modified:
tomcat/current/tc5.5.x/STATUS.txt
Modified: tomcat/current/tc5.5.x/STATUS.txt
URL:
http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=791321&r1=791320&r2=791321&view=diff
==
--- tomcat/current/tc5.5.x/STATUS.txt (original)
+++ tomcat/current/tc5.5.x/STATUS.txt Sun Jul 5 21:03:53 2009
@@ -62,13 +62,13 @@
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37869
Port extraction of client certs when using APR
http://people.apache.org/~markt/patches/2009-07-01-bug37869.patch
- +1: markt
+ +1: markt, kkolinko
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=37984
Strip {MD5} as well as {SHA} from digested passwords
http://svn.apache.org/viewvc?rev=790405&view=rev
- +1: markt
+ +1: markt, kkolinko
-1:
* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38743
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791318 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Sun Jul 5 20:41:53 2009 New Revision: 791318 URL: http://svn.apache.org/viewvc?rev=791318&view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=791318&r1=791317&r2=791318&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Jul 5 20:41:53 2009 @@ -174,5 +174,5 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38897 Add uri of broken TLD to error message to help debugging http://svn.apache.org/viewvc?rev=791243&view=rev - +1: markt + +1: markt, kkolinko -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791317 - /tomcat/current/tc5.5.x/STATUS.txt
Author: kkolinko Date: Sun Jul 5 20:40:59 2009 New Revision: 791317 URL: http://svn.apache.org/viewvc?rev=791317&view=rev Log: vote Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=791317&r1=791316&r2=791317&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Sun Jul 5 20:40:59 2009 @@ -128,5 +128,5 @@ * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38897 Add uri of broken TLD to error message to help debugging http://svn.apache.org/viewvc?rev=791243&view=rev - +1: markt + +1: markt, kkolinko -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791312 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Sun Jul 5 20:28:30 2009 New Revision: 791312 URL: http://svn.apache.org/viewvc?rev=791312&view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=791312&r1=791311&r2=791312&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Jul 5 20:28:30 2009 @@ -168,7 +168,7 @@ https://issues.apache.org/bugzilla/show_bug.cgi?id=37933 and implements an alternative that doesn't have the side effects described in 38797 http://svn.apache.org/viewvc?rev=791224&view=rev - +1: markt + +1: markt, kkolinko -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38897 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791311 - /tomcat/current/tc5.5.x/STATUS.txt
Author: kkolinko Date: Sun Jul 5 20:26:56 2009 New Revision: 791311 URL: http://svn.apache.org/viewvc?rev=791311&view=rev Log: vote Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=791311&r1=791310&r2=791311&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Sun Jul 5 20:26:56 2009 @@ -122,6 +122,7 @@ alternative that doesn't have the side effects described in 38797 http://svn.apache.org/viewvc?rev=791224&view=rev +1: markt + +1: kkolinko (of course w/o generics, and using StringBuffer for JDK 1.4 comp-ty) -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38897 - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791310 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
Author: kkolinko
Date: Sun Jul 5 20:26:13 2009
New Revision: 791310
URL: http://svn.apache.org/viewvc?rev=791310&view=rev
Log:
missprint
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
Modified: tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Generator.java?rev=791310&r1=791309&r2=791310&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Generator.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Generator.java Sun Jul 5
20:26:13 2009
@@ -1794,7 +1794,7 @@
out = outSave;
}
-// Add the named objects to the lits of 'introduced' names to
enable
+// Add the named objects to the list of 'introduced' names to
enable
// a later test as per JSP.5.3
VariableInfo[] infos = n.getVariableInfos();
if (infos != null && infos.length > 0) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791308 - /tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
Author: kkolinko
Date: Sun Jul 5 20:23:57 2009
New Revision: 791308
URL: http://svn.apache.org/viewvc?rev=791308&view=rev
Log:
add indent
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
Modified: tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Generator.java?rev=791308&r1=791307&r2=791308&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Generator.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Generator.java Sun Jul 5
20:23:57 2009
@@ -1801,7 +1801,7 @@
for (int i = 0; i < infos.length; i++) {
VariableInfo info = infos[i];
if (info != null && info.getVarName() != null)
-pageInfo.getVarInfoNames().add(info.getVarName());
+pageInfo.getVarInfoNames().add(info.getVarName());
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r791224 - in /tomcat/trunk/java/org/apache/jasper/compiler: Generator.java PageInfo.java
2009/7/5 Mark Thomas :
> Konstantin Kolinko wrote:
>> 2009/7/5 :
>>> Author: markt
>>> Date: Sun Jul 5 11:30:22 2009
>>> New Revision: 791224
>>>
>>> URL: http://svn.apache.org/viewvc?rev=791224&view=rev
>>> Log:
>>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38797
>>> Revert previous fix for
>>> https://issues.apache.org/bugzilla/show_bug.cgi?id=37933 and implement an
>>> alternative that doesn't have the side effects described in 38797
>>>
>>> Modified:
>>> tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
>>> tomcat/trunk/java/org/apache/jasper/compiler/PageInfo.java
>>>
>>> --- tomcat/trunk/java/org/apache/jasper/compiler/Generator.java (original)
>>> +++ tomcat/trunk/java/org/apache/jasper/compiler/Generator.java Sun Jul 5
>>> 11:30:22 2009
>>> ...
>>> + // Add the named objects to the lits of 'introduced' names to
>>> enable
>>> + // a later test as per JSP.5.3
>>> + VariableInfo[] infos = n.getVariableInfos();
>>> + if (infos != null && infos.length > 0) {
>>> + for (int i = 0; i < infos.length; i++) {
>>> + VariableInfo info = infos[i];
>>> + if (info != null && info.getVarName() != null)
>>> + pageInfo.getVarInfoNames().add(info.getVarName());
>>> + }
>>> + }
>>
>> I do not think that the above fragment is right.
>>
>> I have not tested it, but it looks like
>> 1. It does not take VariableInfo#scope into account
> What part of JSP.5.3 makes you think that it should?
>
>> 2. I think that it does not work for tag files that declare variables.
> Again, what part of JSP.5.3 makes you think that it should?
>
OK.
I just thought that it is strange, that only VariableInfo is
mentioned, and it is not the only way to introduce variables (there it
says "object").
but now looking at JSP 1.2 spec, the problem was already there: it
explicitly mentions VariableInfo, but not mentions TagVariableInfo.
Also, it is even more restrictive than 2.0 and 2.1 versions: it does
not mention that ignoring this error is allowed.
So, let's do it as written, verbatim. - as you did.
>> Also,
>> 3. Node.UseBean node does not add anything to that set of variable names.
> It doesn't need to. That is what the BeanRepository instance is for.
>
Oh, I see that now.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[g...@vmgump]: Project tomcat-catalina (in module jakarta-tomcat-4.0) failed
To whom it may engage... This is an automated request, but not an unsolicited one. For more information please visit http://gump.apache.org/nagged.html, and/or contact the folk at gene...@gump.apache.org. Project tomcat-catalina has an issue affecting its community integration. This issue affects 3 projects, and has been outstanding for 3 runs. The current state of this project is 'Failed', with reason 'Build Failed'. For reference only, the following projects are affected by this: - jakarta-tomcat-4.0 : Servlet 2.3 and JSP 1.2 Reference Implementation - jakarta-tomcat-coyote-tomcat4 : Connectors to various web servers - tomcat-catalina : Servlet 2.3 and JSP 1.2 Reference Implementation Full details are available at: http://vmgump.apache.org/gump/public/jakarta-tomcat-4.0/tomcat-catalina/index.html That said, some information snippets are provided here. The following annotations (debug/informational/warning/error messages) were provided: -DEBUG- Sole output [catalina.jar] identifier set to project name -DEBUG- Dependency on jakarta-servletapi-4 exists, no need to add for property servlet.jar. -DEBUG- Dependency on commons-logging exists, no need to add for property commons-logging-api.jar. -DEBUG- Dependency on jakarta-regexp exists, no need to add for property regexp.jar. -INFO- Failed with reason build failed -DEBUG- Extracted fallback artifacts from Gump Repository The following work was performed: http://vmgump.apache.org/gump/public/jakarta-tomcat-4.0/tomcat-catalina/gump_work/build_jakarta-tomcat-4.0_tomcat-catalina.html Work Name: build_jakarta-tomcat-4.0_tomcat-catalina (Type: Build) Work ended in a state of : Failed Elapsed: 21 secs Command Line: /usr/lib/jvm/java-6-sun/bin/java -Djava.awt.headless=true -Xbootclasspath/p:/srv/gump/public/workspace/xml-xerces2/build/xercesImpl.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis.jar org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml -Dbuild.sysclasspath=only -Dcommons-beanutils.jar=/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-05072009.jar -Djtc.home=/srv/gump/public/workspace/jakarta-tomcat-connectors -Dversion=4.1.25-dev -Dregexp.jar=/srv/gump/public/workspace/jakarta-regexp/build/jakarta-regexp-05072009.jar -Dcommons-logging-api.jar=/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-05072009.jar -Dservlet.jar=/srv/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar -Dcommons-logging.jar=/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-05072009.jar -Dcommons-collections.jar=/srv/gump/public/workspace/apache-commons/collection s/build/commons-collections-05072009.jar -Dcommons-digester.jar=/srv/gump/public/workspace/apache-commons/digester/dist/commons-digester.jar deploy-catalina [Working Directory: /srv/gump/public/workspace/jakarta-tomcat-4.0/catalina] CLASSPATH: /usr/lib/jvm/java-6-sun/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/ant/dist/lib/ant-trax.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-nodeps.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/xml-commons/java/external/build/xml-apis-ext.jar:/srv/gump/public/workspace/jakarta-tomcat-connectors/util/build/lib/tomcat-util.jar:/srv/gump/public/workspace/jakarta-servletapi-4/lib/servlet.jar:/srv/gump/public/workspace/jakarta-regexp/build/jakarta-regexp-05072009.jar:/srv/gump/public/workspace/apache-commons/fileupload/target/commons-fileupload-05072009.jar:/srv/gump/public/workspace/apache-commons/collecti ons/build/commons-collections-05072009.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-05072009.jar:/srv/gump/public/workspace/apache-commons/digester/dist/commons-digester.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-05072009.jar - [javac] symbol : class HttpSessionAttributeListener [javac] location: class org.apache.catalina.session.StandardSession [javac] if (!(listeners[i] instanceof HttpSessionAttributeListener)) [javac] ^ [javac] /srv/gump/public/workspace/jakarta-tomcat-4.0/catalina/src/share/org/apache/catalina/session/StandardSession.java:1142: cannot find symbol [javac] symbol : class HttpSessionAttributeListener [javac] location: class org.apache.catalina.session.StandardSession [javac] HttpSessionAttributeListener listener = [javac] ^ [javac] /srv/gump/public/workspace/jakarta-tomcat-4.0/cat
svn commit: r791268 - /tomcat/current/tc5.5.x/STATUS.txt
Author: kkolinko Date: Sun Jul 5 16:30:37 2009 New Revision: 791268 URL: http://svn.apache.org/viewvc?rev=791268&view=rev Log: votes Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=791268&r1=791267&r2=791268&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Sun Jul 5 16:30:37 2009 @@ -35,13 +35,13 @@ Handle chunked POSTs. If maxPostSize is exceeded, a 500 results http://svn.apache.org/viewvc?rev=785381&view=rev http://svn.apache.org/viewvc?rev=786487&view=rev - +1: markt, rjung + +1: markt, rjung, kkolinko -1: * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38352 JSPs should have read/write access to the context's temp dir http://svn.apache.org/viewvc?rev=786490&view=rev - +1: markt, rjung + +1: markt, rjung, kkolinko -1: * Make access log valves thread safe - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r791224 - in /tomcat/trunk/java/org/apache/jasper/compiler: Generator.java PageInfo.java
Konstantin Kolinko wrote:
> 2009/7/5 :
>> Author: markt
>> Date: Sun Jul 5 11:30:22 2009
>> New Revision: 791224
>>
>> URL: http://svn.apache.org/viewvc?rev=791224&view=rev
>> Log:
>> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38797
>> Revert previous fix for
>> https://issues.apache.org/bugzilla/show_bug.cgi?id=37933 and implement an
>> alternative that doesn't have the side effects described in 38797
>>
>> Modified:
>>tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
>>tomcat/trunk/java/org/apache/jasper/compiler/PageInfo.java
>>
>> --- tomcat/trunk/java/org/apache/jasper/compiler/Generator.java (original)
>> +++ tomcat/trunk/java/org/apache/jasper/compiler/Generator.java Sun Jul 5
>> 11:30:22 2009
>> ...
>> +// Add the named objects to the lits of 'introduced' names to
>> enable
>> +// a later test as per JSP.5.3
>> +VariableInfo[] infos = n.getVariableInfos();
>> +if (infos != null && infos.length > 0) {
>> +for (int i = 0; i < infos.length; i++) {
>> +VariableInfo info = infos[i];
>> +if (info != null && info.getVarName() != null)
>> +pageInfo.getVarInfoNames().add(info.getVarName());
>> +}
>> +}
>
> I do not think that the above fragment is right.
>
> I have not tested it, but it looks like
> 1. It does not take VariableInfo#scope into account
What part of JSP.5.3 makes you think that it should?
> 2. I think that it does not work for tag files that declare variables.
Again, what part of JSP.5.3 makes you think that it should?
> Also,
> 3. Node.UseBean node does not add anything to that set of variable names.
It doesn't need to. That is what the BeanRepository instance is for.
As an aside, the TCK passes with this patch applied. Then again, that
doesn't always mean much as it passes without the patch as well.
Mark
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47464] Do not include *.class files into src archives of TC 5.5
https://issues.apache.org/bugzilla/show_bug.cgi?id=47464 --- Comment #1 from Konstantin Kolinko 2009-07-05 08:33:39 PST --- I prepared patch and proposed it for 5.5. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791258 - /tomcat/current/tc5.5.x/STATUS.txt
Author: kkolinko Date: Sun Jul 5 15:32:38 2009 New Revision: 791258 URL: http://svn.apache.org/viewvc?rev=791258&view=rev Log: proposal Modified: tomcat/current/tc5.5.x/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=791258&r1=791257&r2=791258&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Sun Jul 5 15:32:38 2009 @@ -108,6 +108,14 @@ +1: kkolinko -1: +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47464 + Do not include *.class files into src archives of TC 5.5 + Also, I limited the scope of fixcrlf task in package-src-tgz target + to process the sources dir only. + http://people.apache.org/~kkolinko/patches/2009-07-05_tc55_packsources.patch + +1: kkolinko + -1: + * Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38797 Reverts previous fix for https://issues.apache.org/bugzilla/show_bug.cgi?id=37933 and implements an - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 37869] Cannot obtain client certificate with SSL / client certificate authentication using APR components
https://issues.apache.org/bugzilla/show_bug.cgi?id=37869 Andre Cruz changed: What|Removed |Added CC|andre.c...@co.sapo.pt | -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 37869] Cannot obtain client certificate with SSL / client certificate authentication using APR components
https://issues.apache.org/bugzilla/show_bug.cgi?id=37869 Mark Thomas changed: What|Removed |Added CC||schnellm...@switch.ch --- Comment #16 from Mark Thomas 2009-07-05 07:35:41 PST --- *** Bug 39637 has been marked as a duplicate of this bug. *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 39637] AJP13 connector does not handle chain of SSL client certificate
https://issues.apache.org/bugzilla/show_bug.cgi?id=39637 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||DUPLICATE --- Comment #7 from Mark Thomas 2009-07-05 07:35:41 PST --- *** This bug has been marked as a duplicate of bug 37869 *** -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 39396] OPTIONS request on directory with no default file reports an incorrect list of allowed HTTP verbs
https://issues.apache.org/bugzilla/show_bug.cgi?id=39396 Mark Thomas changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #7 from Mark Thomas 2009-07-05 07:28:52 PST --- This was fixed a few months ago in 5.5.x and will be included in 5.5.28 onwards -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r791224 - in /tomcat/trunk/java/org/apache/jasper/compiler: Generator.java PageInfo.java
2009/7/5 :
> Author: markt
> Date: Sun Jul 5 11:30:22 2009
> New Revision: 791224
>
> URL: http://svn.apache.org/viewvc?rev=791224&view=rev
> Log:
> Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38797
> Revert previous fix for
> https://issues.apache.org/bugzilla/show_bug.cgi?id=37933 and implement an
> alternative that doesn't have the side effects described in 38797
>
> Modified:
> tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
> tomcat/trunk/java/org/apache/jasper/compiler/PageInfo.java
>
> --- tomcat/trunk/java/org/apache/jasper/compiler/Generator.java (original)
> +++ tomcat/trunk/java/org/apache/jasper/compiler/Generator.java Sun Jul 5
> 11:30:22 2009
>...
> + // Add the named objects to the lits of 'introduced' names to
> enable
> + // a later test as per JSP.5.3
> + VariableInfo[] infos = n.getVariableInfos();
> + if (infos != null && infos.length > 0) {
> + for (int i = 0; i < infos.length; i++) {
> + VariableInfo info = infos[i];
> + if (info != null && info.getVarName() != null)
> + pageInfo.getVarInfoNames().add(info.getVarName());
> + }
> + }
I do not think that the above fragment is right.
I have not tested it, but it looks like
1. It does not take VariableInfo#scope into account
2. I think that it does not work for tag files that declare variables.
Also,
3. Node.UseBean node does not add anything to that set of variable names.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 39089] java.lang.InternalError: name is too long to represent
https://issues.apache.org/bugzilla/show_bug.cgi?id=39089 Mark Thomas changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||FIXED --- Comment #9 from Mark Thomas 2009-07-05 07:25:24 PST --- I have added a known issues section to the Jasper/JSP how-to that explains this issue and gives some options on how to work around it. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791254 - in /tomcat: container/tc5.5.x/webapps/docs/jasper-howto.xml tc6.0.x/trunk/webapps/docs/jasper-howto.xml trunk/webapps/docs/jasper-howto.xml
Author: markt Date: Sun Jul 5 14:24:43 2009 New Revision: 791254 URL: http://svn.apache.org/viewvc?rev=791254&view=rev Log: Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=39089 Add a know issues section to the Jasper docs detailing the error described in 39089 and providing some possible workarounds Modified: tomcat/container/tc5.5.x/webapps/docs/jasper-howto.xml tomcat/tc6.0.x/trunk/webapps/docs/jasper-howto.xml tomcat/trunk/webapps/docs/jasper-howto.xml Modified: tomcat/container/tc5.5.x/webapps/docs/jasper-howto.xml URL: http://svn.apache.org/viewvc/tomcat/container/tc5.5.x/webapps/docs/jasper-howto.xml?rev=791254&r1=791253&r2=791254&view=diff == --- tomcat/container/tc5.5.x/webapps/docs/jasper-howto.xml (original) +++ tomcat/container/tc5.5.x/webapps/docs/jasper-howto.xml Sun Jul 5 14:24:43 2009 @@ -181,6 +181,25 @@ + + +As described in +https://issues.apache.org/bugzilla/show_bug.cgi?id=39089";> +bug 39089, a known JVM issue, +http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6294277";> +bug 6294277, may cause a +java.lang.InternalError: name is too long to represent exception +when compiling very large JSPs. If this is observed then it may be worked around +by using one of the following: + +reduce the size of the JSP +disable SMAP generation and JSR-045 support by setting +suppressSmap to true. + + + + + The main JSP optimization which can be done is precompilation of JSPs. However, Modified: tomcat/tc6.0.x/trunk/webapps/docs/jasper-howto.xml URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/jasper-howto.xml?rev=791254&r1=791253&r2=791254&view=diff == --- tomcat/tc6.0.x/trunk/webapps/docs/jasper-howto.xml (original) +++ tomcat/tc6.0.x/trunk/webapps/docs/jasper-howto.xml Sun Jul 5 14:24:43 2009 @@ -200,6 +200,25 @@ + + +As described in +https://issues.apache.org/bugzilla/show_bug.cgi?id=39089";> +bug 39089, a known JVM issue, +http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6294277";> +bug 6294277, may cause a +java.lang.InternalError: name is too long to represent exception +when compiling very large JSPs. If this is observed then it may be worked around +by using one of the following: + +reduce the size of the JSP +disable SMAP generation and JSR-045 support by setting +suppressSmap to true. + + + + + The main JSP optimization which can be done is precompilation of JSPs. Modified: tomcat/trunk/webapps/docs/jasper-howto.xml URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/jasper-howto.xml?rev=791254&r1=791253&r2=791254&view=diff == --- tomcat/trunk/webapps/docs/jasper-howto.xml (original) +++ tomcat/trunk/webapps/docs/jasper-howto.xml Sun Jul 5 14:24:43 2009 @@ -200,6 +200,25 @@ + + +As described in +https://issues.apache.org/bugzilla/show_bug.cgi?id=39089";> +bug 39089, a known JVM issue, +http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6294277";> +bug 6294277, may cause a +java.lang.InternalError: name is too long to represent exception +when compiling very large JSPs. If this is observed then it may be worked around +by using one of the following: + +reduce the size of the JSP +disable SMAP generation and JSR-045 support by setting +suppressSmap to true. + + + + + The main JSP optimization which can be done is precompilation of JSPs. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 38997] install4iis.js doesn't work on Windows 2003 Server
https://issues.apache.org/bugzilla/show_bug.cgi?id=38997 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution||WONTFIX --- Comment #3 from Mark Thomas 2009-07-05 06:49:53 PST --- This was the mod_jk2 installer. mod)jk2 has been deprecated for some time and this fix no longer exists in the connectors/trunk repository -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 38897] Invalid TLDs receive cryptic error
https://issues.apache.org/bugzilla/show_bug.cgi?id=38897 Mark Thomas changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #7 from Mark Thomas 2009-07-05 06:44:29 PST --- Testing with the latest 5.5.x: Missing gets: Mandatory TLD element missing or empty: tlib-version Missing TLD files gives: The absolute uri: X cannot be resolved in either web.xml or the jar files deployed with this application This is much better than it was when this bug was first raised but the first message could tell you which TLD has the problem. I've patched trunk and proposed the fix for 5.5.x and 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791245 - in /tomcat: current/tc5.5.x/STATUS.txt tc6.0.x/trunk/STATUS.txt
Author: markt Date: Sun Jul 5 13:44:02 2009 New Revision: 791245 URL: http://svn.apache.org/viewvc?rev=791245&view=rev Log: Propose fix for 38897 Modified: tomcat/current/tc5.5.x/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=791245&r1=791244&r2=791245&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Sun Jul 5 13:44:02 2009 @@ -115,3 +115,9 @@ http://svn.apache.org/viewvc?rev=791224&view=rev +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38897 + Add uri of broken TLD to error message to help debugging + http://svn.apache.org/viewvc?rev=791243&view=rev + +1: markt + -1: Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=791245&r1=791244&r2=791245&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Jul 5 13:44:02 2009 @@ -170,3 +170,9 @@ http://svn.apache.org/viewvc?rev=791224&view=rev +1: markt -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38897 + Add uri of broken TLD to error message to help debugging + http://svn.apache.org/viewvc?rev=791243&view=rev + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791243 - in /tomcat/trunk/java/org/apache/jasper: compiler/TagLibraryInfoImpl.java resources/LocalStrings.properties
Author: markt
Date: Sun Jul 5 13:25:21 2009
New Revision: 791243
URL: http://svn.apache.org/viewvc?rev=791243&view=rev
Log:
Improve error message to include TDL uri when there is a problem with a tld so
user knows which TLD to look at
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/TagLibraryInfoImpl.java
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
Modified: tomcat/trunk/java/org/apache/jasper/compiler/TagLibraryInfoImpl.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/TagLibraryInfoImpl.java?rev=791243&r1=791242&r2=791243&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/TagLibraryInfoImpl.java
(original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/TagLibraryInfoImpl.java Sun
Jul 5 13:25:21 2009
@@ -278,11 +278,11 @@
if (tlibversion == null) {
err.jspError("jsp.error.tld.mandatory.element.missing",
-"tlib-version");
+"tlib-version", uri);
}
if (jspversion == null) {
err.jspError("jsp.error.tld.mandatory.element.missing",
-"jsp-version");
+"jsp-version", uri);
}
this.tags = new TagInfo[tagVector.size()];
Modified: tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties?rev=791243&r1=791242&r2=791243&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties Sun
Jul 5 13:25:21 2009
@@ -335,7 +335,7 @@
jsp.error.tld.fn.duplicate.name=Duplicate function name {0} in tag library {1}
jsp.error.tld.fn.invalid.signature.commaexpected=Invalid syntax for function
signature in TLD. Comma ',' expected. Tag Library: {0}, Function: {1}.
jsp.error.tld.fn.invalid.signature.parenexpected=Invalid syntax for function
signature in TLD. Parenthesis '(' expected. Tag Library: {0}, Function: {1}.
-jsp.error.tld.mandatory.element.missing=Mandatory TLD element missing or
empty: {0}
+jsp.error.tld.mandatory.element.missing=Mandatory TLD element {0} missing or
empty in TLD {1}
jsp.error.dynamic.attributes.not.implemented=The {0} tag declares that it
accepts dynamic attributes but does not implement the required interface
jsp.error.nomatching.fragment=Cannot find an attribute directive (with
name={0} and fragment=true) prior to the fragment directive.
jsp.error.attribute.noequal=equal symbol expected
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r791139 - in /tomcat/trunk/java/org/apache/jasper/el: ELContextWrapper.java ExpressionEvaluatorImpl.java
2009/7/5 Mark Thomas : > Konstantin Kolinko wrote: > >> Fixed it myself, in rev.791186. Don't worry. > > Thanks, but I am going to have to revert. Those are spec classes. I > should not have made my original change. > Oh, I see that now. Best regards, Konstantin Kolinko - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
I find a bug in tomcat 4.1.x or later version(5.x,6.x)
Dear Tomcat organization:
I think I find a bug in tomcat, I explain it in the document.The document
is in the attachment. Or I paste it directly following:
When I use logic:iterator(struts) labels in tomcat 4.1.x or later
version(5.x,6.x), I find a problem. This problem don’t appear in tomcat
4.0.x.
First of all,I will show you the test code:
When I put the code in the a jsp file(index.jsp), start the tomcat 5.x
server and access the page(index.jsp), the console prints the “test!!!”
endlessly. But if I excute the same code in tomcat 4.0.1,the “test!!!” only
prints one time.
So I try to find out the reason, and finally I find that it is the JSP
compiler that cause the problem. When I compare the java code generated by
the two compilers,I find the result of compiling the logic:iterator(struts)
is not the same.
In tomcat 4.0.1, it like this:
*code 1*
*do{*
*…….//omitted codes*
*if** (myList == **null** || myList.size() <= 1)***
*{***
* System.out.println(**"test!!!"**);***
* **continue**;***
*}***
*……//still omit*
* *
*} while (_jspx_th_logic_iterate_0.doAfterBody() ==
javax.servlet.jsp.tagext.BodyTag.EVAL_BODY_AGAIN);*
But in tomcat 5.x,it becomes:
*code 2*
*do{*
*…….//omitted codes*
*if** (myList == **null** || myList.size() <= 1)***
*{***
* System.out.println(**"test!!!"**);***
* **continue**;***
*}***
*……//still omit*
* *
*if (evalDoAfterBody != javax.servlet.jsp.tagext.BodyTag.EVAL_BODY_AGAIN)*
*break;*
*} while (true);*
In code 2,when the code is excuted the “*continue*” statement, it jumps to
the “*while(true)*”. Again, the “*continue*” is excuted, angain the “*
while(true)*”. So we encounters the Endless loop.
But in code 1, the problem is noe exist. You see, when the “*continue*”
statement is excuted, it jumps to the “*while
(_jspx_th_logic_iterate_0.doAfterBody() ==
javax.servlet.jsp.tagext.BodyTag.EVAL_BODY_AGAIN)*”. It then break the while
loop.
I test the code in tomcat 4.0.1, tomcat 4.1.40, tomcat 5.5.27, and tomcat
6.0.20. It seems that the code works normally only in tomcat 4.0.1.
Thank you for reading my letter.Looking forward to hearing from you.
Your sincerely, Ma Jun
svn commit: r791235 - /tomcat/trunk/java/org/apache/tomcat/util/modeler/Registry.java
Author: markt
Date: Sun Jul 5 12:38:17 2009
New Revision: 791235
URL: http://svn.apache.org/viewvc?rev=791235&view=rev
Log:
Remove deprecated methods that are no longer used
Modified:
tomcat/trunk/java/org/apache/tomcat/util/modeler/Registry.java
Modified: tomcat/trunk/java/org/apache/tomcat/util/modeler/Registry.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/modeler/Registry.java?rev=791235&r1=791234&r2=791235&view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/modeler/Registry.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/modeler/Registry.java Sun Jul 5
12:38:17 2009
@@ -879,14 +879,6 @@
// May still be used in tomcat
// Never part of an official release
-/** Called by a registry or by the container to unload a loader
- * @param loader
- */
-public void unregisterRegistry(ClassLoader loader ) {
-// XXX Cleanup ?
-perLoaderRegistries.remove(loader);
-}
-
public ManagedBean findManagedBean(Class beanClass, String type)
throws Exception
{
@@ -906,31 +898,5 @@
public void resetMetadata() {
stop();
}
-/**
- * Load the registry from the XML input found in the specified input
- * stream.
- *
- * @param source Source to be used to load. Can be an InputStream or URL.
- *
- * @exception Exception if any parsing or processing error occurs
- */
-public void loadDescriptors( Object source )
-throws Exception
-{
-loadDescriptors("MbeansDescriptorsDigesterSource", source, null );
-}
-
-// should be removed
-public void unregisterComponent( String domain, String name ) {
-try {
-ObjectName oname=new ObjectName( domain + ":" + name );
-
-// XXX remove from our tables.
-getMBeanServer().unregisterMBean( oname );
-} catch( Throwable t ) {
-log.error( "Error unregistering mbean ", t );
-}
-}
-
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 38797] 5.5.12 and 5.5.15 emit different code on
https://issues.apache.org/bugzilla/show_bug.cgi?id=38797 --- Comment #5 from Mark Thomas 2009-07-05 04:38:22 PST --- Thanks for the test case. I reverted the fix for 37933 and implemented an alternative that doesn't have the issue described here. It also throws an error at translation time rather than runtime. The fix has been made in trunk and proposed for 6.0.x and 5.5.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791228 - in /tomcat: current/tc5.5.x/STATUS.txt tc6.0.x/trunk/STATUS.txt
Author: markt Date: Sun Jul 5 11:38:15 2009 New Revision: 791228 URL: http://svn.apache.org/viewvc?rev=791228&view=rev Log: Propose fix for 38797 Modified: tomcat/current/tc5.5.x/STATUS.txt tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/current/tc5.5.x/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/current/tc5.5.x/STATUS.txt?rev=791228&r1=791227&r2=791228&view=diff == --- tomcat/current/tc5.5.x/STATUS.txt (original) +++ tomcat/current/tc5.5.x/STATUS.txt Sun Jul 5 11:38:15 2009 @@ -107,3 +107,11 @@ http://people.apache.org/~kkolinko/patches/2009-07-04_tc55_copy-encodings.patch +1: kkolinko -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38797 + Reverts previous fix for + https://issues.apache.org/bugzilla/show_bug.cgi?id=37933 and implements an + alternative that doesn't have the side effects described in 38797 + http://svn.apache.org/viewvc?rev=791224&view=rev + +1: markt + -1: Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=791228&r1=791227&r2=791228&view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Jul 5 11:38:15 2009 @@ -162,3 +162,11 @@ http://svn.apache.org/viewvc?rev=791194&view=rev +1: kkolinko -1: + +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38797 + Reverts previous fix for + https://issues.apache.org/bugzilla/show_bug.cgi?id=37933 and implements an + alternative that doesn't have the side effects described in 38797 + http://svn.apache.org/viewvc?rev=791224&view=rev + +1: markt + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r791224 - in /tomcat/trunk/java/org/apache/jasper/compiler: Generator.java PageInfo.java
Author: markt
Date: Sun Jul 5 11:30:22 2009
New Revision: 791224
URL: http://svn.apache.org/viewvc?rev=791224&view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=38797
Revert previous fix for
https://issues.apache.org/bugzilla/show_bug.cgi?id=37933 and implement an
alternative that doesn't have the side effects described in 38797
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
tomcat/trunk/java/org/apache/jasper/compiler/PageInfo.java
Modified: tomcat/trunk/java/org/apache/jasper/compiler/Generator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Generator.java?rev=791224&r1=791223&r2=791224&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Generator.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Generator.java Sun Jul 5
11:30:22 2009
@@ -31,6 +31,7 @@
import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
+import java.util.Set;
import java.util.Vector;
import javax.el.MethodExpression;
@@ -86,6 +87,8 @@
private ErrorDispatcher err;
private BeanRepository beanInfo;
+
+private Set varInfoNames;
private JspCompilationContext ctxt;
@@ -1107,18 +1110,26 @@
+ ")_jspx_page_context.findAttribute("
+ "\""
+ name + "\"))." + methodName + "(;");
-} else {
-// The object could be a custom action with an associated
+} else if (varInfoNames.contains(name)) {
+// The object is a custom action with an associated
// VariableInfo entry for this name.
// Get the class name and then introspect at runtime.
out
.printil("out.write(org.apache.jasper.runtime.JspRuntimeLibrary.toString"
+
"(org.apache.jasper.runtime.JspRuntimeLibrary.handleGetProperty"
-+ "(_jspx_page_context.getAttribute(\""
++ "(_jspx_page_context.findAttribute(\""
+ name
-+ "\", PageContext.PAGE_SCOPE), \""
++ "\"), \""
+ property
+ "\")));");
+} else {
+StringBuilder msg =
+new StringBuilder("jsp:getProperty for bean with name '");
+msg.append(name);
+msg.append(
+"'. Name was not previously introduced as per
JSP.5.3");
+
+throw new JasperException(msg.toString());
}
n.setEndJavaLine(out.getJavaLine());
@@ -1782,6 +1793,18 @@
// restore previous writer
out = outSave;
}
+
+// Add the named objects to the lits of 'introduced' names to
enable
+// a later test as per JSP.5.3
+VariableInfo[] infos = n.getVariableInfos();
+if (infos != null && infos.length > 0) {
+for (int i = 0; i < infos.length; i++) {
+VariableInfo info = infos[i];
+if (info != null && info.getVarName() != null)
+pageInfo.getVarInfoNames().add(info.getVarName());
+}
+}
+
}
private static final String DOUBLE_QUOTE = "\\\"";
@@ -3364,6 +3387,7 @@
isPoolingEnabled = false;
}
beanInfo = pageInfo.getBeanRepository();
+varInfoNames = pageInfo.getVarInfoNames();
breakAtLF = ctxt.getOptions().getMappedFile();
if (isPoolingEnabled) {
tagHandlerPoolNames = new Vector();
Modified: tomcat/trunk/java/org/apache/jasper/compiler/PageInfo.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/PageInfo.java?rev=791224&r1=791223&r2=791224&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/PageInfo.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/PageInfo.java Sun Jul 5
11:30:22 2009
@@ -21,6 +21,7 @@
import java.util.HashSet;
import java.util.LinkedList;
import java.util.List;
+import java.util.Set;
import java.util.Vector;
import org.apache.el.ExpressionFactoryImpl;
@@ -42,6 +43,7 @@
private Vector dependants;
private BeanRepository beanRepository;
+private Set varInfoNames;
private HashMap taglibsMap;
private HashMap jspPrefixMapper;
private HashMap> xmlPrefixMapper;
@@ -98,6 +100,7 @@
this.jspFile = jspFile;
this.beanRepository = beanRepository;
+this.varInfoNames = new HashSet();
this.taglibsMap
svn commit: r791219 - in /tomcat/trunk/java: javax/el/ELContext.java org/apache/el/lang/EvaluationContext.java org/apache/jasper/el/ELContextWrapper.java
Author: markt
Date: Sun Jul 5 11:11:57 2009
New Revision: 791219
URL: http://svn.apache.org/viewvc?rev=791219&view=rev
Log:
Revert generics changes that require changes in spec classes
Modified:
tomcat/trunk/java/javax/el/ELContext.java
tomcat/trunk/java/org/apache/el/lang/EvaluationContext.java
tomcat/trunk/java/org/apache/jasper/el/ELContextWrapper.java
Modified: tomcat/trunk/java/javax/el/ELContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/el/ELContext.java?rev=791219&r1=791218&r2=791219&view=diff
==
--- tomcat/trunk/java/javax/el/ELContext.java (original)
+++ tomcat/trunk/java/javax/el/ELContext.java Sun Jul 5 11:11:57 2009
@@ -39,14 +39,14 @@
this.resolved = false;
}
-public Object getContext(Class key) {
+public Object getContext(Class key) {
if (this.map == null) {
return null;
}
return this.map.get(key);
}
-public void putContext(Class key, Object contextObject) throws
NullPointerException {
+public void putContext(Class key, Object contextObject) throws
NullPointerException {
if (key == null || contextObject == null) {
throw new NullPointerException();
}
Modified: tomcat/trunk/java/org/apache/el/lang/EvaluationContext.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/el/lang/EvaluationContext.java?rev=791219&r1=791218&r2=791219&view=diff
==
--- tomcat/trunk/java/org/apache/el/lang/EvaluationContext.java (original)
+++ tomcat/trunk/java/org/apache/el/lang/EvaluationContext.java Sun Jul 5
11:11:57 2009
@@ -51,7 +51,7 @@
return this.varMapper;
}
-public Object getContext(Class key) {
+public Object getContext(Class key) {
return this.elContext.getContext(key);
}
@@ -63,7 +63,7 @@
return this.elContext.isPropertyResolved();
}
-public void putContext(Class key, Object contextObject) {
+public void putContext(Class key, Object contextObject) {
this.elContext.putContext(key, contextObject);
}
Modified: tomcat/trunk/java/org/apache/jasper/el/ELContextWrapper.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/el/ELContextWrapper.java?rev=791219&r1=791218&r2=791219&view=diff
==
--- tomcat/trunk/java/org/apache/jasper/el/ELContextWrapper.java (original)
+++ tomcat/trunk/java/org/apache/jasper/el/ELContextWrapper.java Sun Jul 5
11:11:57 2009
@@ -51,7 +51,7 @@
return this.target.getVariableMapper();
}
-public Object getContext(Class key) {
+public Object getContext(Class key) {
return this.target.getContext(key);
}
@@ -63,7 +63,7 @@
return this.target.isPropertyResolved();
}
-public void putContext(Class key, Object contextObject) throws
NullPointerException {
+public void putContext(Class key, Object contextObject) throws
NullPointerException {
this.target.putContext(key, contextObject);
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: svn commit: r791139 - in /tomcat/trunk/java/org/apache/jasper/el: ELContextWrapper.java ExpressionEvaluatorImpl.java
Konstantin Kolinko wrote: > Fixed it myself, in rev.791186. Don't worry. Thanks, but I am going to have to revert. Those are spec classes. I should not have made my original change. Mark - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
