svn commit: r831716 - /tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java
Author: markt
Date: Sun Nov 1 18:16:57 2009
New Revision: 831716
URL: http://svn.apache.org/viewvc?rev=831716view=rev
Log:
Add another feature to the Tomcat based unit tests.
Modified:
tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java
Modified: tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java?rev=831716r1=831715r2=831716view=diff
==
--- tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java (original)
+++ tomcat/trunk/test/org/apache/catalina/startup/TomcatBaseTest.java Sun Nov
1 18:16:57 2009
@@ -58,6 +58,14 @@
return port;
}
+/**
+ * Sub-classes may want to add connectors on a new port
+ */
+public int getNextPort() {
+port++;
+return getPort();
+}
+
public void setUp() throws Exception {
tempDir = new File(output/tmp);
tempDir.mkdir();
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47364] HttpServletRequest.getAttributeNames() does not return the names of all attributes
https://issues.apache.org/bugzilla/show_bug.cgi?id=47364 --- Comment #2 from Mark Thomas ma...@apache.org 2009-11-01 10:20:36 GMT --- Created an attachment (id=24451) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=24451) Patch that adds internal attributes but breaks TCK tests I looked at just including all the Tomcat internal attributes in the return from getAttributeNames() but this causes problems with the Servlet 2.5 TCK tests which expect that getAttributeNames() return only those attributes that have been set via setAttribute(). Therefore it looks like the doc change is the way I'll have to go. For completeness the patch I tried that returned all the attribute names is attached so you can patch Tomcat locally if you particularly need that functionality. I thought about making this a configurable option but I didn't want to add the complexity for something that I couldn't see causing any problems that can't be easily worked around by an app that needed to. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r831718 - /tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
Author: pero
Date: Sun Nov 1 18:29:14 2009
New Revision: 831718
URL: http://svn.apache.org/viewvc?rev=831718view=rev
Log:
Fix ReplicationValve crossContext support
Modified:
tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
Modified: tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java?rev=831718r1=831717r2=831718view=diff
==
--- tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java
(original)
+++ tomcat/trunk/java/org/apache/catalina/ha/session/DeltaSession.java Sun Nov
1 18:29:14 2009
@@ -361,6 +361,16 @@
return (this.isValid);
}
+/**
+ * End the access and register to ReplicationValve (crossContext support)
+ */
+public void endAccess() {
+ super.endAccess() ;
+ if(manager instanceof DeltaManager) {
+((DeltaManager)manager).registerSessionAtReplicationValve(this);
+ }
+}
+
// - Session Public Methods
/**
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r831720 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: pero Date: Sun Nov 1 18:34:04 2009 New Revision: 831720 URL: http://svn.apache.org/viewvc?rev=831720view=rev Log: Add ReplicationValve CrossContext support patch Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=831720r1=831719r2=831720view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Nov 1 18:34:04 2009 @@ -383,3 +383,9 @@ http://svn.apache.org/viewvc?rev=831106view=rev +1: fhanik, kkolinko -1: + +* Fix ReplicationValve CrossContext support + http://svn.apache.org/viewvc?rev=831718view=rev + +1: pero + -1: + - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r831722 - /tomcat/trunk/java/org/apache/catalina/connector/Request.java
Author: markt
Date: Sun Nov 1 18:35:02 2009
New Revision: 831722
URL: http://svn.apache.org/viewvc?rev=831722view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47364
Document that HttpServletRequest.getAttributeNames() does not return the names
of all attributes (internal Tomcat attributes are excluded)
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Request.java
Modified: tomcat/trunk/java/org/apache/catalina/connector/Request.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Request.java?rev=831722r1=831721r2=831722view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/Request.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Request.java Sun Nov 1
18:35:02 2009
@@ -919,7 +919,30 @@
/**
* Return the names of all request attributes for this Request, or an
- * empty codeEnumeration/code if there are none.
+ * empty codeEnumeration/code if there are none. Note that the
attribute
+ * names return will only be those for the attributes set via
+ * {...@link #setAttribute(String, Object)}. Tomcat internal attributes
will
+ * not be included although they are accessible via
+ * {...@link #getAttribute(String)}. The Tomcat internal attributes
include:
+ * ul
+ * li{...@link Globals.DISPATCHER_TYPE_ATTR}/li
+ * li{...@link Globals.DISPATCHER_REQUEST_PATH_ATTR}/li
+ * li{...@link Globals.ASYNC_SUPPORTED_ATTR}/li
+ * li{...@link Globals.CERTIFICATES_ATTR} (SSL connections only)/li
+ * li{...@link Globals.CIPHER_SUITE_ATTR} (SSL connections only)/li
+ * li{...@link Globals.KEY_SIZE_ATTR} (SSL connections only)/li
+ * li{...@link Globals.SSL_SESSION_ID_ATTR} (SSL connections only)/li
+ * li{...@link Globals.SSL_SESSION_MGR_ATTR} (SSL connections only)/li
+ * /ul
+ * The underlying connector may also expose request attributes. These all
+ * have names starting with org.apache.tomcat and include:
+ * ul
+ * liorg.apache.tomcat.sendfile.support/li
+ * liorg.apache.tomcat.comet.support/li
+ * liorg.apache.tomcat.comet.timeout.support/li
+ * /ul
+ * Connector implementations may return some, all or none of these
+ * attributes and may also support additional attributes.
*/
public EnumerationString getAttributeNames() {
if (isSecure()) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r831724 - in /tomcat/tc6.0.x/trunk: java/org/apache/catalina/connector/Request.java webapps/docs/changelog.xml
Author: markt
Date: Sun Nov 1 18:38:46 2009
New Revision: 831724
URL: http://svn.apache.org/viewvc?rev=831724view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47364
Document that HttpServletRequest.getAttributeNames() does not return the names
of all attributes (internal Tomcat attributes are excluded)
Modified:
tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java
tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
Modified: tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java?rev=831724r1=831723r2=831724view=diff
==
--- tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java
(original)
+++ tomcat/tc6.0.x/trunk/java/org/apache/catalina/connector/Request.java Sun
Nov 1 18:38:46 2009
@@ -930,7 +930,30 @@
/**
* Return the names of all request attributes for this Request, or an
- * empty codeEnumeration/code if there are none.
+ * empty codeEnumeration/code if there are none. Note that the
attribute
+ * names return will only be those for the attributes set via
+ * {...@link #setAttribute(String, Object)}. Tomcat internal attributes
will
+ * not be included although they are accessible via
+ * {...@link #getAttribute(String)}. The Tomcat internal attributes
include:
+ * ul
+ * li{...@link Globals.DISPATCHER_TYPE_ATTR}/li
+ * li{...@link Globals.DISPATCHER_REQUEST_PATH_ATTR}/li
+ * li{...@link Globals.ASYNC_SUPPORTED_ATTR}/li
+ * li{...@link Globals.CERTIFICATES_ATTR} (SSL connections only)/li
+ * li{...@link Globals.CIPHER_SUITE_ATTR} (SSL connections only)/li
+ * li{...@link Globals.KEY_SIZE_ATTR} (SSL connections only)/li
+ * li{...@link Globals.SSL_SESSION_ID_ATTR} (SSL connections only)/li
+ * li{...@link Globals.SSL_SESSION_MGR_ATTR} (SSL connections only)/li
+ * /ul
+ * The underlying connector may also expose request attributes. These all
+ * have names starting with org.apache.tomcat and include:
+ * ul
+ * liorg.apache.tomcat.sendfile.support/li
+ * liorg.apache.tomcat.comet.support/li
+ * liorg.apache.tomcat.comet.timeout.support/li
+ * /ul
+ * Connector implementations may return some, all or none of these
+ * attributes and may also support additional attributes.
*/
public Enumeration getAttributeNames() {
if (isSecure()) {
Modified: tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml
URL:
http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml?rev=831724r1=831723r2=831724view=diff
==
--- tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc6.0.x/trunk/webapps/docs/changelog.xml Sun Nov 1 18:38:46 2009
@@ -130,6 +130,12 @@
bug42747/bug. (markt)
/fix
fix
+bug47364/bug: Improve Javadoc for
+org.apache.catalina.connector.Request.getAttributeNames() to include
+information on the handling of Tomcat's interal request attributes.
+(markt)
+ /fix
+ fix
bug47518/bug: Correct reference in Valve Javadoc that referred to
an
old method. Patch provided by Christopher Schultz. (markt)
/fix
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47364] HttpServletRequest.getAttributeNames() does not return the names of all attributes
https://issues.apache.org/bugzilla/show_bug.cgi?id=47364 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|NEW |RESOLVED Resolution||FIXED --- Comment #3 from Mark Thomas ma...@apache.org 2009-11-01 10:39:08 GMT --- Trunk and 6.0.x now have updated Javadoc. Thsi will be included in 6.0.21 onwards. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48097] New: NoClassDefFoundError on first access of first jsp
https://issues.apache.org/bugzilla/show_bug.cgi?id=48097 Summary: NoClassDefFoundError on first access of first jsp Product: Tomcat 6 Version: 6.0.20 Platform: PC OS/Version: Linux Status: NEW Severity: normal Priority: P2 Component: Catalina AssignedTo: dev@tomcat.apache.org ReportedBy: amich...@amichais.net Created an attachment (id=24452) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=24452) simple webapp with one jsp and one class in one jar, reproducing the error I've had a strange situation getting NoClassDefFoundErrors on a particular jsp page (which happened to be the index.jsp page). The class it claimed to not find is a simple session bean class within a jar in the WEB-INF/lib folder. The strange thing is that it gave this error only when this page was the first one accessed after a tomcat restart. If any page was accessed before it, it would work properly. But if this page was accessed first, then no matter what pages were later accessed, the error remained in place. So the error/success state was determined by whichever page was accessed first ater the tomcat restart, and remained in the same error/success state for as long as tomcat was up, regardless of anything happening later on (until the next restart) This seems to be some sort of class-loading oder-of-initialization bug, but is entirely consistent when the pages are accessed in this order after a tomcat restart. It drove me nuts for a while, since the main application page was showing an error after every restart, but I eventually stumbled on a strange workaround: changing the order or a couple of lines in the jsp, involving the useBean directive and access to java's URI class. with the order changed, the error never happens. with the order returned, the error is reproduced as described above. I've managed to distill a simple scenario which reproduces this error - a short jsp and a trivial bean session class - attached. I reproduced this on a fresh installation of Kubuntu 9.10 in a virtual machine, with sun jre 6 and tomcat6 installed. I didn't change any configuration, just replaced the ROOT sample webapp with this one, restarted tomcat, and browsed to http://localhost:8080/index.jsp. Remember u have to restart tomcat after every change to the jsp if u want to recreate the bug, because simply changing it and refreshing the browser will always succeed. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48097] NoClassDefFoundError on first access of first jsp
https://issues.apache.org/bugzilla/show_bug.cgi?id=48097 Amichai amich...@amichais.net changed: What|Removed |Added CC||amich...@amichais.net -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r831751 - /tomcat/trunk/java/org/apache/catalina/startup/WebXml.java
Author: markt
Date: Sun Nov 1 19:58:24 2009
New Revision: 831751
URL: http://svn.apache.org/viewvc?rev=831751view=rev
Log:
Fix bug in display name merge
Modified:
tomcat/trunk/java/org/apache/catalina/startup/WebXml.java
Modified: tomcat/trunk/java/org/apache/catalina/startup/WebXml.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/WebXml.java?rev=831751r1=831750r2=831751view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/WebXml.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/WebXml.java Sun Nov 1
19:58:24 2009
@@ -620,8 +620,8 @@
}
}
}
+displayName = temp.getDisplayName();
}
-displayName = temp.getDisplayName();
if (distributable) {
for (WebXml fragment : fragments) {
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48097] NoClassDefFoundError on first access of first jsp
https://issues.apache.org/bugzilla/show_bug.cgi?id=48097 --- Comment #1 from Konstantin Kolinko knst.koli...@gmail.com 2009-11-01 12:44:49 UTC --- What is your configuration of JspServlet in conf/web.xml file? Its development option is set to true or false? Is your Tomcat version 6.0.20? Are you running with SecurityManager enabled? Can you provide any stack traces? From the error page and from the log files. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r831764 - in /tomcat/trunk/java/org/apache/catalina: deploy/FilterMap.java startup/WebXml.java
Author: markt
Date: Sun Nov 1 21:46:09 2009
New Revision: 831764
URL: http://svn.apache.org/viewvc?rev=831764view=rev
Log:
Trying to merge filter maps is a bad idea.
Modified:
tomcat/trunk/java/org/apache/catalina/deploy/FilterMap.java
tomcat/trunk/java/org/apache/catalina/startup/WebXml.java
Modified: tomcat/trunk/java/org/apache/catalina/deploy/FilterMap.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/deploy/FilterMap.java?rev=831764r1=831763r2=831764view=diff
==
--- tomcat/trunk/java/org/apache/catalina/deploy/FilterMap.java (original)
+++ tomcat/trunk/java/org/apache/catalina/deploy/FilterMap.java Sun Nov 1
21:46:09 2009
@@ -37,11 +37,12 @@
public class FilterMap implements Serializable {
-private static final long serialVersionUID = 1L;
-
+
// - Properties
+private static final long serialVersionUID = 1L;
+
/**
* The name of this filter to be executed when this mapping matches
* a particular request.
@@ -100,15 +101,6 @@
}
}
-public void addServletNames(String[] servletNames) {
-if (servletNames != null) {
-for (int i = 0; i servletNames.length; i++) {
-addServletName(servletNames[i]);
-}
-}
-}
-
-
/**
* The flag that indicates this mapping will match all url-patterns
@@ -150,14 +142,6 @@
}
}
-public void addUrlPatterns(String[] urlPatterns) {
-if (urlPatterns != null) {
-for (int i = 0; i urlPatterns.length; i++) {
-addURLPattern(urlPatterns[i]);
-}
-}
-}
-
/**
*
* This method will be used to set the current state of the FilterMap
@@ -240,10 +224,6 @@
else return dispatcherMapping;
}
-public void addDispatcherMapping(int dispatcherMapping) {
-// Merge the supplied mapping with the current mapping
-this.dispatcherMapping = getDispatcherMapping() | dispatcherMapping;
-}
// - Public Methods
Modified: tomcat/trunk/java/org/apache/catalina/startup/WebXml.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/WebXml.java?rev=831764r1=831763r2=831764view=diff
==
--- tomcat/trunk/java/org/apache/catalina/startup/WebXml.java (original)
+++ tomcat/trunk/java/org/apache/catalina/startup/WebXml.java Sun Nov 1
21:46:09 2009
@@ -184,11 +184,11 @@
public MapString,FilterDef getFilters() { return filters; }
// filter-mapping
-private MapString,FilterMap filterMaps = new HashMapString,FilterMap();
+private SetFilterMap filterMaps = new LinkedHashSetFilterMap();
public void addFilterMapping(FilterMap filterMap) {
-filterMaps.put(filterMap.getFilterName(),filterMap);
+filterMaps.add(filterMap);
}
-public MapString,FilterMap getFilterMappings() { return filterMaps; }
+public SetFilterMap getFilterMappings() { return filterMaps; }
// listener
// TODO: description (multiple with language) is ignored
@@ -470,7 +470,7 @@
for (FilterDef filter : filters.values()) {
context.addFilterDef(filter);
}
-for (FilterMap filterMap : filterMaps.values()) {
+for (FilterMap filterMap : filterMaps) {
context.addFilterMap(filterMap);
}
// jsp-property-group needs to be after servlet configuration
@@ -774,20 +774,9 @@
errorPages.putAll(temp.getErrorPages());
for (WebXml fragment : fragments) {
-for (String filterName : fragment.getFilterMappings().keySet()) {
-FilterMap filterMap =
-fragment.getFilterMappings().get(filterName);
+for (FilterMap filterMap : fragment.getFilterMappings()) {
// Always additive
-if (filterMaps.containsKey(filterName)) {
-FilterMap appFilterMap = filterMaps.get(filterName);
-
-appFilterMap.addDispatcherMapping(
-filterMap.getDispatcherMapping());
-appFilterMap.addServletNames(filterMap.getServletNames());
-appFilterMap.addUrlPatterns(filterMap.getURLPatterns());
-} else {
-addFilterMapping(filterMap);
-}
+addFilterMapping(filterMap);
}
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48097] NoClassDefFoundError on first access of first jsp
https://issues.apache.org/bugzilla/show_bug.cgi?id=48097 --- Comment #2 from Amichai amich...@amichais.net 2009-11-01 13:51:27 UTC --- Yes, it's version 6.0.20. As mentioned, I changed nothing at all in the default configuration from the distro's installation - simply overwrote the webapps/ROOT folder. The JspServlet configuration in web.xml: servlet servlet-namejsp/servlet-name servlet-classorg.apache.jasper.servlet.JspServlet/servlet-class init-param param-namefork/param-name param-valuefalse/param-value /init-param init-param param-namexpoweredBy/param-name param-valuefalse/param-value /init-param load-on-startup3/load-on-startup /servlet I don't see 'development' set anywhere in web.xml, so I guess it uses the default. I didn't explicitly set a SecurityManager, where can I check what the default is, or if it is set? There are two types of errors in the logs, from the first access after a restart, and a refresh after that: ov 1, 2009 8:50:11 PM org.apache.catalina.core.StandardWrapperValve invoke SEVERE: Servlet.service() for servlet jsp threw exception java.lang.NoClassDefFoundError: net/freeutils/web/SessionBean at org.apache.jsp.index_jsp._jspService(index_jsp.java:64) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:374) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:342) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:267) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:616) at org.apache.catalina.security.SecurityUtil$1.run(SecurityUtil.java:269) at java.security.AccessController.doPrivileged(Native Method) at javax.security.auth.Subject.doAsPrivileged(Subject.java:537) at org.apache.catalina.security.SecurityUtil.execute(SecurityUtil.java:301) at org.apache.catalina.security.SecurityUtil.doAsPrivilege(SecurityUtil.java:162) at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:283) at org.apache.catalina.core.ApplicationFilterChain.access$000(ApplicationFilterChain.java:56) at org.apache.catalina.core.ApplicationFilterChain$1.run(ApplicationFilterChain.java:189) at java.security.AccessController.doPrivileged(Native Method) at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:185) at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233) at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191) at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:128) at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102) at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109) at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:293) at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:849) at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:583) at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:454) at java.lang.Thread.run(Thread.java:636) Nov 1, 2009 8:50:30 PM org.apache.catalina.core.StandardWrapperValve invoke SEVERE: Servlet.service() for servlet jsp threw exception java.lang.ClassNotFoundException: net.freeutils.web.SessionBean at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1387) at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1233) at org.apache.jasper.servlet.JasperLoader.loadClass(JasperLoader.java:128) at org.apache.jasper.servlet.JasperLoader.loadClass(JasperLoader.java:66) at java.lang.ClassLoader.loadClassInternal(ClassLoader.java:336) at org.apache.jsp.index_jsp._jspService(index_jsp.java:64) at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70) at javax.servlet.http.HttpServlet.service(HttpServlet.java:717) at org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:374) at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:342) at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:267) at
DO NOT REPLY [Bug 48098] New: Cyrillyc(or any escaped with %) symbols inaccessible via WebDav servlet (fix proposed)
https://issues.apache.org/bugzilla/show_bug.cgi?id=48098
Summary: Cyrillyc(or any escaped with %) symbols inaccessible
via WebDav servlet (fix proposed)
Product: Tomcat 6
Version: 6.0.20
Platform: PC
OS/Version: Linux
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: niko...@ukr.net
When I create, read, update, delete any file|folder with symbols that are
escaped (' or any Cyrillic char ) - I got an error.
I've fixed it for me, patching WebdavServlet.java method getRelativePath(). On
each return I unescape symbols:
protected String getRelativePath(HttpServletRequest request) {
// Are we being processed by a RequestDispatcher.include()?
if (request.getAttribute(Globals.INCLUDE_REQUEST_URI_ATTR) != null) {
String result = (String) request
.getAttribute(Globals.INCLUDE_PATH_INFO_ATTR);
if ((result == null) || (result.equals()))
result = /;
return unescape(result);
}
// No, extract the desired path directly from the request
String result = request.getPathInfo();
if ((result == null) || (result.equals())) {
result = /;
}
return unescape(result);
}
This unescape() method is from official W3C site:
http://www.w3.org/International/unescape.java
Now it works excellent for me.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48098] Cyrillyc(or any escaped with %) symbols inaccessible via WebDav servlet (fix proposed)
https://issues.apache.org/bugzilla/show_bug.cgi?id=48098 Nikolay Zamosenchuk niko...@ukr.net changed: What|Removed |Added CC||niko...@ukr.net -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r831774 - /tomcat/trunk/java/org/apache/catalina/connector/Response.java
Author: markt
Date: Sun Nov 1 22:53:29 2009
New Revision: 831774
URL: http://svn.apache.org/viewvc?rev=831774view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47451
Don't trigger an NPE if headers with null or zero length name or set or if a
null value is specified. Silently ignore any such calls in the same way the
calls are ignored if the response has already been committed.
Modified:
tomcat/trunk/java/org/apache/catalina/connector/Response.java
Modified: tomcat/trunk/java/org/apache/catalina/connector/Response.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/Response.java?rev=831774r1=831773r2=831774view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/Response.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/Response.java Sun Nov 1
22:53:29 2009
@@ -1009,6 +1009,10 @@
*/
public void addDateHeader(String name, long value) {
+if (name == null || name.length() == 0) {
+return;
+}
+
if (isCommitted())
return;
@@ -1036,6 +1040,10 @@
*/
public void addHeader(String name, String value) {
+if (name == null || name.length() == 0 || value == null) {
+return;
+}
+
if (isCommitted())
return;
@@ -1056,6 +1064,10 @@
*/
public void addIntHeader(String name, int value) {
+if (name == null || name.length() == 0) {
+return;
+}
+
if (isCommitted())
return;
@@ -1281,6 +1293,10 @@
*/
public void setDateHeader(String name, long value) {
+if (name == null || name.length() == 0) {
+return;
+}
+
if (isCommitted())
return;
@@ -1308,6 +1324,10 @@
*/
public void setHeader(String name, String value) {
+if (name == null || name.length() == 0 || value == null) {
+return;
+}
+
if (isCommitted())
return;
@@ -1328,6 +1348,10 @@
*/
public void setIntHeader(String name, int value) {
+if (name == null || name.length() == 0) {
+return;
+}
+
if (isCommitted())
return;
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47451] NPE if response contains null content-encoding header
https://issues.apache.org/bugzilla/show_bug.cgi?id=47451 --- Comment #2 from Mark Thomas ma...@apache.org 2009-11-01 14:59:12 GMT --- Fixed in trunk and proposed for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r831777 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: markt Date: Sun Nov 1 23:01:15 2009 New Revision: 831777 URL: http://svn.apache.org/viewvc?rev=831777view=rev Log: Propose fix Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=831777r1=831776r2=831777view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Sun Nov 1 23:01:15 2009 @@ -389,3 +389,10 @@ +1: pero -1: +* Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47451 + Don't throw NPEs if the various response.setHeader() methods are called with + null header name, zero length header name or null value. Silently ignore the + calls the same way we do if the response has already been committed + http://svn.apache.org/viewvc?rev=831774view=rev + +1: mark + -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r831779 - /tomcat/trunk/java/javax/servlet/http/Cookie.java
Author: markt
Date: Sun Nov 1 23:04:33 2009
New Revision: 831779
URL: http://svn.apache.org/viewvc?rev=831779view=rev
Log:
Don't allow null or zero length cookie names.
Modified:
tomcat/trunk/java/javax/servlet/http/Cookie.java
Modified: tomcat/trunk/java/javax/servlet/http/Cookie.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/http/Cookie.java?rev=831779r1=831778r2=831779view=diff
==
--- tomcat/trunk/java/javax/servlet/http/Cookie.java (original)
+++ tomcat/trunk/java/javax/servlet/http/Cookie.java Sun Nov 1 23:04:33 2009
@@ -17,7 +17,6 @@
package javax.servlet.http;
import java.text.MessageFormat;
-import java.util.Date;
import java.util.ResourceBundle;
/**
@@ -124,26 +123,30 @@
*/
public Cookie(String name, String value) {
- if (!isToken(name)
- || name.equalsIgnoreCase(Comment) // rfc2019
- || name.equalsIgnoreCase(Discard) // 2019++
- || name.equalsIgnoreCase(Domain)
- || name.equalsIgnoreCase(Expires) // (old cookies)
- || name.equalsIgnoreCase(Max-Age) // rfc2019
- || name.equalsIgnoreCase(Path)
- || name.equalsIgnoreCase(Secure)
- || name.equalsIgnoreCase(Version)
- || name.startsWith($)
- ) {
- String errMsg = lStrings.getString(err.cookie_name_is_token);
- Object[] errArgs = new Object[1];
- errArgs[0] = name;
- errMsg = MessageFormat.format(errMsg, errArgs);
- throw new IllegalArgumentException(errMsg);
- }
+if (name == null || name.length() == 0) {
+throw new IllegalArgumentException(
+lStrings.getString(err.cookie_name_blank));
+}
+if (!isToken(name)
+|| name.equalsIgnoreCase(Comment) // rfc2019
+|| name.equalsIgnoreCase(Discard) // 2019++
+|| name.equalsIgnoreCase(Domain)
+|| name.equalsIgnoreCase(Expires) // (old cookies)
+|| name.equalsIgnoreCase(Max-Age) // rfc2019
+|| name.equalsIgnoreCase(Path)
+|| name.equalsIgnoreCase(Secure)
+|| name.equalsIgnoreCase(Version)
+|| name.startsWith($)
+) {
+String errMsg = lStrings.getString(err.cookie_name_is_token);
+Object[] errArgs = new Object[1];
+errArgs[0] = name;
+errMsg = MessageFormat.format(errMsg, errArgs);
+throw new IllegalArgumentException(errMsg);
+}
- this.name = name;
- this.value = value;
+this.name = name;
+this.value = value;
}
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r831780 - /tomcat/trunk/test/org/apache/tomcat/util/http/
Author: markt Date: Sun Nov 1 23:05:26 2009 New Revision: 831780 URL: http://svn.apache.org/viewvc?rev=831780view=rev Log: Add unit tests for blank/null cookie names Modified: tomcat/trunk/test/org/apache/tomcat/util/http/CookiesBaseTest.java tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesDefaultSysProps.java tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesNoFwdStrictSysProps.java tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesNoStrictNamingSysProps.java tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesStrictSysProps.java tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesSwitchSysProps.java Modified: tomcat/trunk/test/org/apache/tomcat/util/http/CookiesBaseTest.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/http/CookiesBaseTest.java?rev=831780r1=831779r2=831780view=diff == --- tomcat/trunk/test/org/apache/tomcat/util/http/CookiesBaseTest.java (original) +++ tomcat/trunk/test/org/apache/tomcat/util/http/CookiesBaseTest.java Sun Nov 1 23:05:26 2009 @@ -72,6 +72,10 @@ Tomcat.addServlet(ctx, invalid, new CookieServlet(na;me, value)); ctx.addServletMapping(/invalid, invalid); +Tomcat.addServlet(ctx, null, new CookieServlet(null, value)); +ctx.addServletMapping(/null, null); +Tomcat.addServlet(ctx, blank, new CookieServlet(, value)); +ctx.addServletMapping(/blank, blank); Tomcat.addServlet(ctx, invalidFwd, new CookieServlet(na/me, value)); ctx.addServletMapping(/invalidFwd, invalidFwd); Modified: tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesDefaultSysProps.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesDefaultSysProps.java?rev=831780r1=831779r2=831780view=diff == --- tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesDefaultSysProps.java (original) +++ tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesDefaultSysProps.java Sun Nov 1 23:05:26 2009 @@ -43,6 +43,10 @@ ByteChunk res = getUrl(http://localhost:; + getPort() + /invalid); assertEquals(Cookie name fail, res.toString()); +res = getUrl(http://localhost:; + getPort() + /null); +assertEquals(Cookie name fail, res.toString()); +res = getUrl(http://localhost:; + getPort() + /blank); +assertEquals(Cookie name fail, res.toString()); res = getUrl(http://localhost:; + getPort() + /invalidFwd); assertEquals(Cookie name ok, res.toString()); res = getUrl(http://localhost:; + getPort() + /invalidStrict); Modified: tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesNoFwdStrictSysProps.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesNoFwdStrictSysProps.java?rev=831780r1=831779r2=831780view=diff == --- tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesNoFwdStrictSysProps.java (original) +++ tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesNoFwdStrictSysProps.java Sun Nov 1 23:05:26 2009 @@ -43,6 +43,10 @@ ByteChunk res = getUrl(http://localhost:; + getPort() + /invalid); assertEquals(Cookie name fail, res.toString()); +res = getUrl(http://localhost:; + getPort() + /null); +assertEquals(Cookie name fail, res.toString()); +res = getUrl(http://localhost:; + getPort() + /blank); +assertEquals(Cookie name fail, res.toString()); res = getUrl(http://localhost:; + getPort() + /invalidFwd); assertEquals(Cookie name ok, res.toString()); res = getUrl(http://localhost:; + getPort() + /invalidStrict); Modified: tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesNoStrictNamingSysProps.java URL: http://svn.apache.org/viewvc/tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesNoStrictNamingSysProps.java?rev=831780r1=831779r2=831780view=diff == --- tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesNoStrictNamingSysProps.java (original) +++ tomcat/trunk/test/org/apache/tomcat/util/http/TestCookiesNoStrictNamingSysProps.java Sun Nov 1 23:05:26 2009 @@ -44,6 +44,10 @@ ByteChunk res = getUrl(http://localhost:; + getPort() + /invalid); assertEquals(Cookie name fail, res.toString()); +res = getUrl(http://localhost:; + getPort() + /null); +assertEquals(Cookie name fail, res.toString()); +res = getUrl(http://localhost:; + getPort() + /blank); +assertEquals(Cookie name fail, res.toString()); res = getUrl(http://localhost:; + getPort() + /invalidFwd); assertEquals(Cookie name
Bug report for Taglibs [2009/11/01]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | | 6347|New|Nor|2002-02-10|io:param should url encode| | 6390|New|Nor|2002-02-12|valueOf evaluates 's to amp; when the was part| | 6613|New|Nor|2002-02-21|cannot use xtags:style more than one time per page| | 8694|Ver|Maj|2002-05-01|Exception when trying to acces the Map.entry compo| | 8723|Ver|Nor|2002-05-02|use of xsltSystemID does not take effect if xslt a| | 9257|Ver|Nor|2002-05-20|ELParser doesn't parse non-ascii value| | 9581|Ver|Min|2002-06-03|update SQL examples to allow for the inputting of | | 9968|Ver|Maj|2002-06-18|c:url prepends path to page relative URLs | |10175|Ver|Nor|2002-06-24|Welcome file absent from standard-examples.war in | |11217|Unc|Blk|2002-07-26|Custom Tag Library Error: 'Tag library not found| |11347|New|Maj|2002-07-31|xtags:if test=position()!=last() - position() | |11361|New|Enh|2002-08-01|Allow user to create own URIResolver | |12133|New|Blk|2002-08-28|scrape not work for some urls the request for a co| |12618|New|Maj|2002-09-13|Mode attribute on xtags:template xtags:applyTemp| |12620|New|Nor|2002-09-13|position() and last() do not work in xtags:templat| |13794|New|Blk|2002-10-20|Unable to list the tag librairies in the custom ta| |13971|New|Maj|2002-10-25|Style tag does not work with Tomcat 4 with xml or | |14214|New|Maj|2002-11-04|[PATCH] io:http - can't invoke POS| |15129|New|Nor|2002-12-06|Distribution of this CTLX is unuseable| |15551|New|Nor|2002-12-19|error: output must have content-handler property | |17211|New|Blk|2003-02-19|FIX: Tomcat 4.1.x taglib pooling causes problems | |18198|New|Nor|2003-03-20|[PATCH] Cache - Overloading CacheUtil methods | |18499|New|Enh|2003-03-30|[cache] per cache entry lifetime | |18716|Inf|Nor|2003-04-04|XTAGS LIBRARY PROBLEM IN 4.1.18 | |19292|New|Enh|2003-04-24|request tag add the ability to store output in pag| |19754|New|Nor|2003-05-08|TLDParser web.xml and errorstag | |20725|New|Nor|2003-06-12|Incorrect property setter signature for Tag handle| |21928|New|Nor|2003-07-28|Extra space added in the return text of xtags | |22765|New|Nor|2003-08-27|Wrong values from position() and last() functions | |23363|New|Maj|2003-09-23|JNDI Taglib does not close context when using jnd| |24715|Opn|Maj|2003-11-14|Remote SMTP server fix| |25190|New|Enh|2003-12-04|waitUntilSent attribute for send tag | |26608|New|Maj|2004-02-02|strip=true causes exception when no tags availab| |26867|New|Maj|2004-02-11|Inconsistent behavior of io:request | |27323|New|Enh|2004-02-29|Remove useless tag setrecipient | |27597|New|Nor|2004-03-11|mt:attach: set Content-Type header | |27717|New|Maj|2004-03-16|x:forEach very slow in JSTL 1.1 | |27978|New|Nor|2004-03-26|URLTag nesting into BodyTag does not work more the| |28280|New|Nor|2004-04-08|bug in xtags:parse whith using a attribute reader | |28301|New|Nor|2004-04-08|XTags are not working for Tomcat 4.1.18 | |28814|New|Nor|2004-05-06|mt:header are ignored| |28913|New|Maj|2004-05-11|Content-Type not working properly | |29194|New|Nor|2004-05-25|xml-namespaces not supported | |30050|Ass|Maj|2004-07-12|Explicit dependency to Xalan breaks JSTL xml tags | |30427|New|Nor|2004-08-01|Response contents can be truncated prematurely| |31009|New|Nor|2004-09-02|io:http tag caches JSPWriter | |31859|New|Enh|2004-10-23|Add filename based Content-ID to attachments and u| |31869|New|Enh|2004-10-24|Allow DataHandler attachments in the attach tag | |33032|New|Nor|2005-01-11|string() works incorrectly in conjunction with sco| |33934|New|Cri|2005-03-09|[standard] memory leak in jstl c:set tag | |34137|New|Nor|2005-03-22|getAttribute using iterate reuses bodycontent on 2|
Bug report for Tomcat 5 [2009/11/01]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |27122|Opn|Enh|2004-02-20|IE plugins cannot access components through Tomcat| |28039|Opn|Enh|2004-03-30|Cluster Support for SingleSignOn | |29494|Inf|Enh|2004-06-10|No way to set PATH when running as a service on Wi| |33262|Inf|Enh|2005-01-27|Service Manager autostart should check for adminis| |33453|Opn|Enh|2005-02-08|Jasper should recompile JSP files whose datestamps| |33671|Opn|Enh|2005-02-21|Manual Windows service installation with custom na| |34801|New|Enh|2005-05-08|PATCH: CGIServlet does not terminate child after a| |34805|Ass|Enh|2005-05-08|warn about invalid security constraint url pattern| |34868|Ass|Enh|2005-05-11|allow to register a trust store for a session that| |35054|Inf|Enh|2005-05-25|warn if appBase is not existing as a File or direc| |36133|Inf|Enh|2005-08-10|Support JSS SSL implementation| |36362|New|Enh|2005-08-25|missing check for Java reserved keywords in tag fi| |36569|Inf|Enh|2005-09-09|Redirects produce illegal URL's | |36837|Inf|Enh|2005-09-28|Looking for ProxyHandler implementation of Http re| |36922|Inf|Enh|2005-10-04|setup.sh file mis-advertised and missing | |37018|Ass|Enh|2005-10-11|Document how to use tomcat-SSL with a pkcs11 token| |37334|Inf|Enh|2005-11-02|Realm digest property not aligned with the adminis| |37449|Opn|Enh|2005-11-10|Two UserDatabaseRealm break manager user | |37485|Inf|Enh|2005-11-14|I'd like to run init SQL after JDBC Connection cre| |37847|Ass|Enh|2005-12-09|Allow User To Optionally Specify Catalina Output F| |37848|Opn|Trv|2005-12-09|Inappropriate Output From catalina.sh When No Term| |38216|Inf|Enh|2006-01-10|Extend Jmxproxy to allow call of MBean Operations | |38217|Ver|Enh|2006-01-10|mention that private key password and keystore pas| |38268|Inf|Enh|2006-01-13|User friendly: Need submit button on adding/deleti| |38360|Inf|Enh|2006-01-24|Domain for session cookies| |38546|Inf|Enh|2006-02-07|Google bot sends invalid If-Modifed-Since Header, | |38577|Inf|Enh|2006-02-08|Enhance logging of security failures | |38743|New|Min|2006-02-21|when using APR, JKS options are silently ignored | |38797|Opn|Nor|2006-02-27|5.5.12 and 5.5.15 emit different code on jsp:getP| |38916|Inf|Enh|2006-03-10|HttpServletRequest cannot handle multipart request| |39053|Inf|Enh|2006-03-21|include Tomcat embedded sample| |39231|New|Nor|2006-04-06|The JAAS contract for LoginModule is broken | |39309|Opn|Enh|2006-04-14|tomcat can't compile big jsp, hitting a compiler l| |39740|New|Enh|2006-06-07|semi-colon ; isn't allowed as a query argument sep| |39832|Inf|Enh|2006-06-17|HTML Manager improvements | |39844|New|Nor|2006-06-20|non-HTTP forward will alway result NullPointerExce| |39862|Inf|Enh|2006-06-22|provide support for protocol-independent GenericSe| |40211|Inf|Enh|2006-08-08|Compiled JSP don't indent HTML code | |40218|New|Enh|2006-08-08|JNDI realm - recursive group/role matching| |40222|Inf|Enh|2006-08-09|Default Tomcat configuration alows easy session hi| |40402|New|Enh|2006-09-03|Manager should display Exceptions | |40510|New|Enh|2006-09-14|installer does not create shortcuts for all users | |40712|New|Enh|2006-10-10|Realm admin error.| |40728|Inf|Enh|2006-10-11|Catalina MBeans use non-serializable classes | |40766|New|Enh|2006-10-16|Using an unsecure jsessionid with mod_proxy_ajp ov| |40881|Opn|Enh|2006-11-02|Unable to receive message through TCP channel - | |41007|Opn|Enh|2006-11-20|Can't define customized 503 error page| |41179|New|Enh|2006-12-15|400 Bad Request response during auto re-deployment| |41227|Opn|Enh|2006-12-21|When the jasper compiler fails to compile a JSP, i| |41337|Opn|Enh|2007-01-10|Display an error page if no cert is available on C| |41496|New|Enh|2007-01-30|set a security provider for jsse in a connector co|
Bug report for Tomcat 7 [2009/11/01]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |47823|New|Enh|2009-09-11|Inconsistent naming of boolean getters in Standard| |47918|New|Nor|2009-09-30|Wrong description in o.a.c.startup.mbeans-desripto| |47939|New|Reg|2009-10-04|Jars added by VirtualWebappLoader are not scanned | |48059|New|Nor|2009-10-26|org.apache.catalina.startup.Bootstrap's main metho| |48066|New|Nor|2009-10-27|ant.jar is needless in build.xml | +-+---+---+--+--+ | Total5 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Bug report for Tomcat 6 [2009/11/01]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |39661|Opn|Enh|2006-05-25|Please document JULI FileHandler configuration pro| |41128|Inf|Enh|2006-12-07|Reference to java Thread name from RequestProcesso| |41679|New|Enh|2007-02-22|SemaphoreValve should be able to filter on url pat| |41791|New|Enh|2007-03-07|Tomcat behaves inconsistently concerning flush-pac| |41883|Ass|Enh|2007-03-18|use abstract wrapper instead of plain X509Certific| |41944|New|Enh|2007-03-25|Start running the RAT tool to see where we're miss| |41992|New|Enh|2007-03-30|Need ability to set OS process title | |42463|New|Enh|2007-05-20|crossContext and classloader issues - pls amend | |43001|New|Enh|2007-07-30|JspC lacks setMappedFile and setDie for use in Ant| |43003|New|Enh|2007-07-30|Separate dependent component download and build ta| |43154|New|Enh|2007-08-17|forward port from 5.5.x to 6.x about AccessLogValv| |43400|New|Enh|2007-09-14|enum support for tag libs | |43497|New|Enh|2007-09-26|Add ability to escape rendered output of JSP expre| |43548|Opn|Enh|2007-10-04|xml schema for tomcat-users.xml | |43642|New|Enh|2007-10-17|Add prestartminSpareThreads attribute for Executor| |43682|New|Enh|2007-10-23|JULI: web-inf/classes/logging.properties to suppor| |43742|New|Enh|2007-10-30|.tag compiles performed one at a time -- extremel| |43790|Ass|Enh|2007-11-03|concurrent access issue on TagHandlerPool | |43979|New|Enh|2007-11-27|Add abstraction for Java and Classfile output | |44047|New|Enh|2007-12-10|Provide a way for Tomcat to serve up error pages w| |44106|New|Enh|2007-12-19|autodeploy configures directories which do not con| |44199|New|Enh|2008-01-10|expose current backlog queue size | |44225|New|Enh|2008-01-14|SSL connector tries to load the private keystore f| |44264|New|Enh|2008-01-18|Clustering - Support for disabling multicasting an| |44265|New|Enh|2008-01-18|Improve JspWriterImpl performance with inline su| |44284|New|Enh|2008-01-23|Support java.lang.Iterable in c:forEach tag | |44294|New|Enh|2008-01-25|Support for EL functions with varargs | |44299|New|Enh|2008-01-26|Provider manager app with a log out button| |44312|New|Enh|2008-01-28|Warn when overwritting docBase of the default Host| |44598|New|Enh|2008-03-13|JAASRealm is suppressing Exceptions | |44645|New|Enh|2008-03-20|[Patch] JNDIRealm - Doesn't support JNDI java.nam| |44787|New|Enh|2008-04-09|provide more error context on java.lang.IllegalSt| |44818|New|Enh|2008-04-13|tomcat hangs with GET when content-length is defin| |45014|New|Enh|2008-05-15|Request and Response classes should have wrappers | |45255|New|Enh|2008-06-23|support disable jsessionid from url against sessio| |45282|New|Enh|2008-06-25|NioReceiver doesn't close cleanly, leaving sockets| |45283|Opn|Enh|2008-06-25|Allow multiple authenticators to be added to pipel| |45428|New|Enh|2008-07-18|warn if the tomcat stop doesn't complete | |45654|New|Enh|2008-08-19|use static methods and attributes in a direct way!| |45731|New|Enh|2008-09-02|Enhancement request : pluggable httpsession cache | |45794|New|Enh|2008-09-12|Patch causes JNDIRealm to bind with user entered c| |45832|New|Enh|2008-09-18|add DIGEST authentication support to Ant tasks| |45871|New|Enh|2008-09-23|Support for salted and digested patches in DataSou| |45878|New|Enh|2008-09-24|Generated jars do not contain proper manifests or | |45879|Opn|Enh|2008-09-24|Windows installer fails to install NOTICE and RELE| |45931|Opn|Enh|2008-10-01|trimSpaces incorrectly modifies output| |45995|New|Enh|2008-10-13|RFE - MIME type extension not case sensitive | |46173|New|Enh|2008-11-09|Small patch for manager app: Setting an optional c| |46263|New|Enh|2008-11-21|Tomcat reloading of context does not update contex| |46264|New|Enh|2008-11-21|Shutting down tomcat with large number of contexts| |46284|New|Enh|2008-11-24|Add flag to DeltaManager that blocks processing cl|
Bug report for Tomcat Connectors [2009/11/01]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |24427|New|Enh|2003-11-05|Tomcat mod_jk - Excludes in Redirection | |34526|Opn|Nor|2005-04-19|Truncated content in decompressed requests from mo| |35959|Opn|Enh|2005-08-01|mod_jk not independant of UseCanonicalName| |36155|Opn|Nor|2005-08-12|tomcat chooses wrong host if using mod_jk | |36169|New|Enh|2005-08-12|[PATCH] Enable chunked encoding for requests in II| |38895|Inf|Nor|2006-03-08|Http headers with an underscore _ change into hy| |39967|Inf|Nor|2006-07-05|mod_jk gives segmentation fault when apache is sta| |40208|Inf|Nor|2006-08-08|Request-Dump when ErrorDocument in httpd.conf is a| |41170|Inf|Nor|2006-12-13|single crlf in header termination crashes app.| |41430|New|Reg|2007-01-22|JkOptions +ForwardDirectories with Apache's Direct| |41695|New|Maj|2007-02-24|mod_jk with httpd 2.0.58 on Solaris-10 11/06 dumpi| |41923|Opn|Nor|2007-03-21|Tomcat doesnt recognized client abort | |42366|Inf|Nor|2007-05-09|Memory leak in newer mod_jk version when connectio| |42554|Opn|Nor|2007-05-31|mod_ssl + mod_jk with status_worker does not work | |43303|New|Enh|2007-09-04|Versioning under Windows not reported by many conn| |43821|New|Enh|2007-11-08|provide client AJP IP address | |43968|New|Enh|2007-11-26|[patch] support ipv6 with mod_jk | |44290|New|Nor|2008-01-24|mod_jk/1.2.26: retry is not useful for an importan| |44349|New|Maj|2008-02-04|mod_jk/1.2.26 module does not read worker.status.s| |44379|New|Enh|2008-02-07|convert the output of strftime into UTF-8 | |44454|New|Nor|2008-02-19|busy count reported in mod_jk inflated, causes inc| |44571|New|Enh|2008-03-10|Limits busy per worker to a threshold | |45063|New|Nor|2008-05-22|JK-1.2.26 IIS ISAPI filter issue when running diff| |45182|New|Enh|2008-06-10|Add functionality to automate the jkmanager disabl| |45313|New|Nor|2008-06-30|mod_jk 1.2.26 apache 2.2.9 static compiled on so| |45357|Opn|Enh|2008-07-07|Add property to specify custom maintenance page wh| |45395|New|Min|2008-07-14|MsgAjp dump method does not dump packet when being| |45610|New|Nor|2008-08-11|status-worker: Bug in request parameter parsing fo| |46337|New|Nor|2008-12-04|real worker name is wrong | |46406|New|Enh|2008-12-16|Supporting relative paths in isapi_redirect.proper| |46503|New|Nor|2009-01-09|Garbage characters in cluster domain field| |46632|New|Nor|2009-01-29|mod_jk's sockets close prematurely when the server| |46676|New|Enh|2009-02-09|Configurable test request for Watchdog thread | |46763|New|Enh|2009-02-24|Improve treatment of jk_log_lock. | |46767|New|Enh|2009-02-25|mod_jk to send DECLINED in case no fail-over tomca| |46862|New|Nor|2009-03-16|Status worker Properties output format (worker.wlb| |46893|New|Nor|2009-03-23|mod_jk statically compiled always outputs warning | |47038|New|Enh|2009-04-15|USE_FLOCK_LK redefined compiler warning when using| |47222|New|Nor|2009-05-19|Changes made to ping_timeout via Status Worker not| |47224|New|Nor|2009-05-19|Hostname and Port Changes from Status Worker do no| |47327|New|Enh|2009-06-07|remote_user not logged in apache logfile | |47617|New|Enh|2009-07-31|include time spent doing ajp_get_endpoint() in err| |47678|New|Nor|2009-08-11|Unable to allocate shared memory when using isapi_| |47679|New|Nor|2009-08-11|Not all headers get passed to Tomcat server from i| |47692|New|Blk|2009-08-12|Can not compile mod_jk with apache2.0.63 and tomca| |47714|New|Cri|2009-08-20|Reponse mixed between users | |47750|New|Maj|2009-08-27|Loss of worker settings when changing via jkstatus| |47795|New|Nor|2009-09-07|service sticky_session not being set correctly wit| |47806|New|Blk|2009-09-08|HTTP 500 internal server error| |47840|New|Min|2009-09-14|A broken worker name is written in the log file. | |47983|New|Nor|2009-10-12|typo in documentation |
Bug report for Tomcat Native [2009/11/01]
+---+ | Bugzilla Bug ID | | +-+ | | Status: UNC=Unconfirmed NEW=New ASS=Assigned| | | OPN=ReopenedVER=Verified(Skipped Closed/Resolved) | | | +-+ | | | Severity: BLK=Blocker CRI=Critical REG=Regression MAJ=Major | | | | MIN=Minor NOR=NormalENH=Enhancement TRV=Trivial | | | | +-+ | | | | Date Posted | | | | | +--+ | | | | | Description | | | | | | | |38372|Inf|Cri|2006-01-25|tcnative-1.dll response overflow corruption, parti| |41361|New|Nor|2007-01-14|Content lost when read by a slow client. | |42090|New|Cri|2007-04-11|tcnative badly handles some OpenSSL disconnections| |45392|New|Nor|2008-07-14|No OCSP support for client SSL verification | |46041|New|Cri|2008-10-20|Tomcat service is terminated unexpectedly (tcnativ| |46179|New|Maj|2008-11-10|apr ssl client authentication | |46571|New|Nor|2009-01-21|tcnative blocks in APR poll on Solaris| |47319|New|Nor|2009-06-05|With APR, getRemoteHost() returns NULL for unknown| |47851|New|Nor|2009-09-16|thread-safety issues in the TC native Java code | +-+---+---+--+--+ | Total9 bugs | +---+ - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r831781 - /tomcat/trunk/java/javax/servlet/http/LocalStrings.properties
Author: markt
Date: Sun Nov 1 23:20:53 2009
New Revision: 831781
URL: http://svn.apache.org/viewvc?rev=831781view=rev
Log:
Opps. Missed this file in cookie name/null/length patch
Modified:
tomcat/trunk/java/javax/servlet/http/LocalStrings.properties
Modified: tomcat/trunk/java/javax/servlet/http/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/javax/servlet/http/LocalStrings.properties?rev=831781r1=831780r2=831781view=diff
==
--- tomcat/trunk/java/javax/servlet/http/LocalStrings.properties (original)
+++ tomcat/trunk/java/javax/servlet/http/LocalStrings.properties Sun Nov 1
23:20:53 2009
@@ -17,6 +17,7 @@
# Localized for Locale en_US
err.cookie_name_is_token=Cookie name \{0}\ is a reserved token
+err.cookie_name_blank=Cookie name may not be null or zero length
err.io.negativelength=Negative Length given in write method
err.io.short_read=Short Read
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r831782 - in /tomcat/trunk: java/org/apache/tomcat/util/http/ServerCookie.java webapps/docs/config/systemprops.xml
Author: markt
Date: Sun Nov 1 23:22:18 2009
New Revision: 831782
URL: http://svn.apache.org/viewvc?rev=831782view=rev
Log:
As per Remy's feedback, auto-switching cookie version is OK and we should also
do it if a comment is specified
Modified:
tomcat/trunk/java/org/apache/tomcat/util/http/ServerCookie.java
tomcat/trunk/webapps/docs/config/systemprops.xml
Modified: tomcat/trunk/java/org/apache/tomcat/util/http/ServerCookie.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/http/ServerCookie.java?rev=831782r1=831781r2=831782view=diff
==
--- tomcat/trunk/java/org/apache/tomcat/util/http/ServerCookie.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/http/ServerCookie.java Sun Nov 1
23:22:18 2009
@@ -75,14 +75,6 @@
public static final boolean STRICT_SERVLET_COMPLIANCE;
/**
- * If set to false, we don't auto switch invalid v0 cookies to v1 and add
- * quotes to make them valid.
- * Default is usually true. If STRICT_SERVLET_COMPLIANCE==true then default
- * is false. Explicitly setting always takes priority.
- */
-public static final boolean ALLOW_VERSION_SWITCH;
-
-/**
* If set to false, we don't use the IE6/7 Max-Age/Expires work around.
* Default is usually true. If STRICT_SERVLET_COMPLIANCE==true then default
* is false. Explicitly setting always takes priority.
@@ -105,15 +97,6 @@
false)).booleanValue();
-String allowVersionSwitch = System.getProperty(
-
org.apache.tomcat.util.http.ServerCookie.ALLOW_VERSION_SWITCH);
-if (allowVersionSwitch == null) {
-ALLOW_VERSION_SWITCH = !STRICT_SERVLET_COMPLIANCE;
-} else {
-ALLOW_VERSION_SWITCH =
-Boolean.valueOf(allowVersionSwitch).booleanValue();
-}
-
String alwaysAddExpires = System.getProperty(
org.apache.tomcat.util.http.ServerCookie.ALWAYS_ADD_EXPIRES);
if (alwaysAddExpires == null) {
@@ -319,6 +302,11 @@
// Servlet implementation does not check anything else
version = maybeQuote2(version, buf, value,true);
+
+// Spec team clarified setting comment on a v0 cookie switches it to v1
+if (version == 0 comment != null) {
+version = 1;
+}
// Add version 1 specific information
if (version == 1) {
@@ -417,7 +405,7 @@
buf.append('');
buf.append(escapeDoubleQuotes(value,1,value.length()-1));
buf.append('');
-} else if (allowVersionSwitch ALLOW_VERSION_SWITCH version==0
!isToken2(value, literals)) {
+} else if (allowVersionSwitch version==0 !isToken2(value,
literals)) {
buf.append('');
buf.append(escapeDoubleQuotes(value,0,value.length()));
buf.append('');
Modified: tomcat/trunk/webapps/docs/config/systemprops.xml
URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/config/systemprops.xml?rev=831782r1=831781r2=831782view=diff
==
--- tomcat/trunk/webapps/docs/config/systemprops.xml (original)
+++ tomcat/trunk/webapps/docs/config/systemprops.xml Sun Nov 1 23:22:18 2009
@@ -241,7 +241,6 @@
/li
li
The default value will be changed for
-
codeorg.apache.tomcat.util.http.ServerCookie.ALLOW_VERSION_SWITCH/code.
codeorg.apache.tomcat.util.http.ServerCookie.ALWAYS_ADD_EXPIRES/code.
codeorg.apache.tomcat.util.http.ServerCookie.FWD_SLASH_IS_SEPARATOR/code.
codeorg.apache.tomcat.util.http.ServerCookie.STRICT_NAMING/code.
@@ -278,16 +277,6 @@
/property
property
-name=org.apache.tomcat.util.http. ServerCookie.ALLOW_VERSION_SWITCH
- pIf this is codetrue/code Tomcat will convert a v0 cookie that
- contains invalid characters (i.e. separators) to a v1 cookie and add
- quotes as required. If not specified, the default value will be used. If
- codeorg.apache.catalina.STRICT_SERVLET_COMPLIANCE/code is set to
- codetrue/code, the default of this setting will be
codefalse/code,
- else the default value will be codetrue/code./p
-/property
-
-property
name=org.apache.tomcat.util.http. ServerCookie.ALWAYS_ADD_EXPIRES
pIf this is codetrue/code Tomcat will always add an expires
parameter to a SetCookie header even for cookies with version greater
than
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
How do I setup Tomcat to refresh a directory faster than the default 5 seconds
I tried adding variations of the following to server.xml but it still takes 5 seconds for a newly modified file to appear. Anybody know what I am doing wrong? Context path=/usr/share/tomcat5.5-webapps/ROOT/status cacheTTL=1 WatchedResourcestatus/picture.png/WatchedResource /Context -- View this message in context: http://old.nabble.com/How-do-I-setup-Tomcat-to-refresh-a-directory-faster-than-the-default-5-seconds-tp26154649p26154649.html Sent from the Tomcat - Dev mailing list archive at Nabble.com. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
Re: How do I setup Tomcat to refresh a directory faster than the default 5 seconds
ed2003 wrote: I tried adding variations of the following to server.xml but it still takes 5 seconds for a newly modified file to appear. Anybody know what I am doing wrong? That would be a question for the users list. Mark Context path=/usr/share/tomcat5.5-webapps/ROOT/status cacheTTL=1 WatchedResourcestatus/picture.png/WatchedResource /Context - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48097] NoClassDefFoundError on first access of first jsp
https://issues.apache.org/bugzilla/show_bug.cgi?id=48097 --- Comment #3 from Konstantin Kolinko knst.koli...@gmail.com 2009-11-01 16:18:11 UTC --- Thank you for the information. I can see from the stacktraces that you run with SecurityManager enabled. (That is default in some re-distributions of Tomcat). The development flag of JspServlet defaults to true. Unfortunately, as of now I cannot reproduce your error neither on 6.0.20 nor on the latest tc6.0.x. While trying your app I saw an error once in latest tc6.0.x, but it was different from what you are observing, and it also is no more reproducible. As it is so hard to reproduce, I suppose it is a race condition. The error that you observed occurs in _jspService() method of compiled JSP page class. So the class was successfully compiled, loaded into memory, its instance created, _jspService method called, and then the error occurs. org.apache.jsp.index_jsp._jspService(index_jsp.java:64) Line 64 in my copy of the file, compiled by Tomcat 6.0.20, is bean = new net.freeutils.web.SessionBean(); It was WebappClassLoader's responsibility to load the class. Line 1387 there is the normal exit, when no classfile is found. org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1387) I do not see any clues to what could have caused this. Note, that requesting '/index.jsp' and requesting '/' might be different, because the latter involves more resource existence checks. Our usual question regarding re-distributions of Tomcat is whether an error is reproducible with our official distribution from tomcat.apache.org. Note, that to start with SecurityManager you run 'catalina.sh start -security', and that the default conf/catalina.policy file of TC 6.0.20 does not work with recent version of Sun JRE (starting with 6u14). You have to get the updated version of it from http://svn.apache.org/repos/asf/tomcat/tc6.0.x/trunk/conf/ -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r831784 - /tomcat/tc6.0.x/trunk/STATUS.txt
Author: kkolinko Date: Mon Nov 2 00:28:58 2009 New Revision: 831784 URL: http://svn.apache.org/viewvc?rev=831784view=rev Log: vote Modified: tomcat/tc6.0.x/trunk/STATUS.txt Modified: tomcat/tc6.0.x/trunk/STATUS.txt URL: http://svn.apache.org/viewvc/tomcat/tc6.0.x/trunk/STATUS.txt?rev=831784r1=831783r2=831784view=diff == --- tomcat/tc6.0.x/trunk/STATUS.txt (original) +++ tomcat/tc6.0.x/trunk/STATUS.txt Mon Nov 2 00:28:58 2009 @@ -394,5 +394,5 @@ null header name, zero length header name or null value. Silently ignore the calls the same way we do if the response has already been committed http://svn.apache.org/viewvc?rev=831774view=rev - +1: mark + +1: markt, kkolinko -1: - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
svn commit: r831785 - in /tomcat/trunk/java/org/apache/jasper: compiler/Validator.java resources/LocalStrings.properties
Author: markt
Date: Mon Nov 2 00:30:55 2009
New Revision: 831785
URL: http://svn.apache.org/viewvc?rev=831785view=rev
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=47331
Uninterpreted tags are essentially template text so apply the rules of JSp.2.2
there too.
Modified:
tomcat/trunk/java/org/apache/jasper/compiler/Validator.java
tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
Modified: tomcat/trunk/java/org/apache/jasper/compiler/Validator.java
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/compiler/Validator.java?rev=831785r1=831784r2=831785view=diff
==
--- tomcat/trunk/java/org/apache/jasper/compiler/Validator.java (original)
+++ tomcat/trunk/java/org/apache/jasper/compiler/Validator.java Mon Nov 2
00:30:55 2009
@@ -731,9 +731,16 @@
int attrSize = attrs.getLength();
Node.JspAttribute[] jspAttrs = new Node.JspAttribute[attrSize];
for (int i = 0; i attrSize; i++) {
+// JSP.2.2 - '#{' not allowed in template text
+String value = attrs.getValue(i);
+if (!pageInfo.isDeferredSyntaxAllowedAsLiteral()) {
+if (containsDeferredSyntax(value)) {
+err.jspError(n, jsp.error.el.template.deferred);
+}
+}
jspAttrs[i] = getJspAttribute(null, attrs.getQName(i),
-attrs.getURI(i), attrs.getLocalName(i), attrs
-.getValue(i), n, false);
+attrs.getURI(i), attrs.getLocalName(i), value, n,
+false);
}
n.setJspAttributes(jspAttrs);
}
@@ -741,6 +748,31 @@
visitBody(n);
}
+/*
+ * Look for a #{ sequence that isn't preceded by \.
+ */
+private boolean containsDeferredSyntax(String value) {
+if (value == null) {
+return false;
+}
+
+int i = 0;
+int len = value.length();
+boolean prevCharIsEscape = false;
+while (i value.length()) {
+char c = value.charAt(i);
+if (c == '#' (i+1) len value.charAt(i+1) == '{'
!prevCharIsEscape) {
+return true;
+} else if (c == '\\') {
+prevCharIsEscape = true;
+} else {
+prevCharIsEscape = false;
+}
+i++;
+}
+return false;
+}
+
public void visit(Node.CustomTag n) throws JasperException {
TagInfo tagInfo = n.getTagInfo();
@@ -1063,7 +1095,7 @@
String expectedType = null;
if (tldAttrs[j].isDeferredMethod()) {
-// The String litteral must be castable to
what is declared as type
+// The String literal must be castable to
what is declared as type
// for the attribute
String m =
tldAttrs[j].getMethodSignature();
if (m != null) {
Modified: tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties?rev=831785r1=831784r2=831785view=diff
==
--- tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties
(original)
+++ tomcat/trunk/java/org/apache/jasper/resources/LocalStrings.properties Mon
Nov 2 00:30:55 2009
@@ -443,7 +443,7 @@
jsp.exception=An exception occurred processing JSP page {0} at line {1}
# JSP 2.1
-jsp.error.el.template.deferred=#{..} is not allowed in template text
+jsp.error.el.template.deferred=#{...} is not allowed in template text
jsp.error.el.parse={0} : {1}
jsp.error.page.invalid.deferredsyntaxallowedasliteral=Page directive: invalid
value for deferredSyntaxAllowedAsLiteral
jsp.error.tag.invalid.deferredsyntaxallowedasliteral=Tag directive: invalid
value for deferredSyntaxAllowedAsLiteral
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47349] WAR file deployment doesn't work in WAN
https://issues.apache.org/bugzilla/show_bug.cgi?id=47349 Mark Thomas ma...@apache.org changed: What|Removed |Added Status|REOPENED|RESOLVED Resolution||WORKSFORME --- Comment #9 from Mark Thomas ma...@apache.org 2009-11-01 16:39:13 GMT --- This sounds like some form of network issue but it is hard to be sure. I can't reproduce this so I am closing it. If you see the issue again and can provide steps to reproduce or can work with us to track down the root cause please re-open and we'll take another look. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47330] proposal : port of mod_remoteip in Tomcat as RemoteIpValve
https://issues.apache.org/bugzilla/show_bug.cgi?id=47330 --- Comment #4 from Mark Thomas ma...@apache.org 2009-11-01 18:32:58 GMT --- Created an attachment (id=24455) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=24455) Tomcat 7 patch with completed TODOs and failing test case Many thanks for these patches. I'd like to add the valve and filter to Tomcat 7 and the valve to Tomcat 6. I have made the necessary changes to Tomcat 7 the valve can sit in the right package. When I applied the patch, I completed the TODOs and added some documentation. However, one of the test cases failed and my initial investigation suggests that the patch needs further work. I have attached my final Tomcat 7 patch. Please update as necessary to correct the failing test case and then I'll apply it. Once the valve is applied, I'll look a the filter which will probably be generated by porting the final version of the valve. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 47331] No translation error messag when using #{...} in template text
https://issues.apache.org/bugzilla/show_bug.cgi?id=47331 --- Comment #1 from Mark Thomas ma...@apache.org 2009-11-01 18:36:15 GMT --- This has been fixed in trunk and proposed for 6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48097] NoClassDefFoundError on first access of first jsp
https://issues.apache.org/bugzilla/show_bug.cgi?id=48097 --- Comment #5 from Konstantin Kolinko knst.koli...@gmail.com 2009-11-01 21:17:48 UTC --- Created an attachment (id=24456) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=24456) Patch for WebappClassLoader to do not swallow AccessControlException The patch is for the current tc6.0.x -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48097] NoClassDefFoundError on first access of first jsp
https://issues.apache.org/bugzilla/show_bug.cgi?id=48097
--- Comment #6 from Konstantin Kolinko knst.koli...@gmail.com 2009-11-01
22:15:14 UTC ---
Thank you for the recipe, I was able to reproduce the issue.
The issue is observable both in 6.0.20 and in current 6.0.x sources, and I was
able to do some debugging.
~ What is essential: ~
1). I updated my JDK to 6u16. I was using 6u15 previously.
I have not verified yet that it indeed works OK with 6u15, but it might be it.
2). It is essential to run with SecurityManager enabled.
The permissions are essential. If you add
grant {
permission java.security.AllPermission;
}
all starts working again.
3). I removed all applications from the webapps folder, except the ROOT
application that was replaced with the one from attachment 24452.
4). You need to precompile the JSP page. That is, start Tomcat, access the
page, shutdown Tomcat, and start it for the second time.
5). Access http://localhost:8080/
6). The stacktrace as in Comment #2 is observed.
~ Debugging showed the following: ~
The following line in WebappClassLoader#findResourceInternal(String) resulted
in AccessControlException:
2070: entry = new ResourceEntry();
The exception was caught by the caller (WebappClassLoader#findClass(String))
and wrapped into ClassNotFoundException.
The ClassNotFoundException was caught by the caller
(WebappClassLoader#loadClass(String,boolean)) and ignored. That is why we do
not see it in the logs.
The patch in attachment 24456 makes WebappClassLoader#findClass(String) to log
the AccessControlException when it is encountered.
The exception text and stacktrace are the following:
02.11.2009 7:53:51 org.apache.catalina.loader.WebappClassLoader findClass
SEVERE: findClassInternal(net.freeutils.web.SessionBean) failed
java.security.AccessControlException: access denied
(java.lang.RuntimePermission accessClassInPackage.org.apache.catalina.loader)
at java.security.AccessControlContext.checkPermission(Unknown Source)
at java.security.AccessController.checkPermission(Unknown Source)
at java.lang.SecurityManager.checkPermission(Unknown Source)
at java.lang.SecurityManager.checkPackageAccess(Unknown Source)
at sun.misc.Launcher$AppClassLoader.loadClass(Unknown Source)
at java.lang.ClassLoader.loadClass(Unknown Source)
at java.lang.ClassLoader.loadClass(Unknown Source)
at java.lang.ClassLoader.loadClassInternal(Unknown Source)
at
org.apache.catalina.loader.WebappClassLoader.findResourceInternal(WebappClassLoader.java:2070)
at
org.apache.catalina.loader.WebappClassLoader.findClassInternal(WebappClassLoader.java:1851)
at
org.apache.catalina.loader.WebappClassLoader.findClass(WebappClassLoader.java:887)
at
org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1352)
at
org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1231)
at org.apache.jasper.servlet.JasperLoader.loadClass(JasperLoader.java:128)
at org.apache.jasper.servlet.JasperLoader.loadClass(JasperLoader.java:66)
at java.lang.ClassLoader.loadClassInternal(Unknown Source)
at org.apache.jsp.index_jsp._jspService(index_jsp.java:64)
at org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:70)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
at
org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:374)
at org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:334)
at org.apache.jasper.servlet.JspServlet.service(JspServlet.java:259)
at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.apache.catalina.security.SecurityUtil$1.run(SecurityUtil.java:269)
at java.security.AccessController.doPrivileged(Native Method)
at javax.security.auth.Subject.doAsPrivileged(Unknown Source)
at org.apache.catalina.security.SecurityUtil.execute(SecurityUtil.java:301)
at
org.apache.catalina.security.SecurityUtil.doAsPrivilege(SecurityUtil.java:162)
at
org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:283)
at
org.apache.catalina.core.ApplicationFilterChain.access$000(ApplicationFilterChain.java:56)
at
org.apache.catalina.core.ApplicationFilterChain$1.run(ApplicationFilterChain.java:189)
at java.security.AccessController.doPrivileged(Native Method)
at
org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:185)
at
org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
at
org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
at
DO NOT REPLY [Bug 48100] New: jsp:directive.taglib parse error
https://issues.apache.org/bugzilla/show_bug.cgi?id=48100
Summary: jsp:directive.taglib parse error
Product: Tomcat 6
Version: 6.0.20
Platform: PC
OS/Version: Windows Server 2003
Status: NEW
Severity: normal
Priority: P2
Component: Jasper
AssignedTo: dev@tomcat.apache.org
ReportedBy: apei...@gmail.com
JSP 2.1 Special taglib directive: jsp:directive.taglib /
Tomcat 6.0.x's behavor is jsp:taglib.
Fix:
(base on tomcat 6.0.20)
org/apache/jasper/compiler/TagConstants.java
line 87-88:
public static final String TAGLIB_DIRECTIVE_ACTION = taglib;
public static final String JSP_TAGLIB_DIRECTIVE_ACTION = jsp:taglib;
should be:
public static final String TAGLIB_DIRECTIVE_ACTION = directive.taglib;
public static final String JSP_TAGLIB_DIRECTIVE_ACTION =
jsp:directive.taglib;
org/apache/jasper/compiler/Parser.java
[r...@localhost tomcat]# diff Parser.java.fix Parser.java
551,557d550
} else if (reader.matches(taglib)) {
eTag = jsp:directive.taglib;
if (isTagFile) {
err.jspError(reader.mark(), jsp.error.directive.istagfile,
lt; + eTag);
}
parseTaglibDirective(parent);
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48097] NoClassDefFoundError on first access of first jsp
https://issues.apache.org/bugzilla/show_bug.cgi?id=48097
--- Comment #7 from Konstantin Kolinko knst.koli...@gmail.com 2009-11-01
23:44:06 UTC ---
I debugged the case of the blank response.
The sequence of events is the following:
1) The index_jsp.class is successfully loaded, instantiated, and its _jspInit()
method was successfully called.
2) The error occurs in its _jspService(request, response) method.
The code there is the following:
try {
response.setContentType(text/html; charset=UTF-8);
pageContext = _jspxFactory.getPageContext(this, request, response,
null, true, 8192, true);
_jspx_page_context = pageContext;
(...)
} catch (Throwable t) {
if (!(t instanceof SkipPageException)){
out = _jspx_out;
if (out != null out.getBufferSize() != 0)
try { out.clearBuffer(); } catch (java.io.IOException e) {}
if (_jspx_page_context != null)
_jspx_page_context.handlePageException(t);
}
} finally {
_jspxFactory.releasePageContext(_jspx_page_context);
}
The exception occurs when calling response.setContentType(). The exception is:
java.security.AccessControlException: access denied
(java.lang.RuntimePermission
accessClassInPackage.org.apache.catalina.connector)
Because it occurs earlier than the _jspx_page_context variable is initialized,
the _jspx_page_context.handlePageException(t); line is not called and empty
response is returned to the client.
The failure in setContentType() method occurs in
ResponseFacade#setContentType(). It is caused by the attempt to load the
following class: ResponseFacade$SetContentTypePrivilegedAction
That class is listed in
o.a.catalina.security.SecurityClassLoad#loadCoyotePackage() but, because I used
org.apache.catalina.startup.Catalina class to start Tomcat in the IDE, that
method was not called at all. It is called from Bootstrap#init() only.
Jasper's SecurityClassLoad on the contrary is called, because that occurs in
another place.
The blank page issue disappeared when I used o.a.c.startup.Bootstrap class
instead of Catalina.
I do not know, whether we should fix this bootstrap issue. (Is anyone
concerned?)
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48097] NoClassDefFoundError on first access of first jsp
https://issues.apache.org/bugzilla/show_bug.cgi?id=48097 --- Comment #8 from Konstantin Kolinko knst.koli...@gmail.com 2009-11-01 23:56:14 UTC --- Created an attachment (id=24457) -- (https://issues.apache.org/bugzilla/attachment.cgi?id=24457) Patch for SecurityClassLoad to preload o.a.c.loader.ResourceEntry class This patch fixes the NoClassDefFoundError: net/freeutils/web/SessionBean issue. It is for the current tc6.0.x. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
