Re: [RESULT] (Was: [VOTE] C-T-R for any translation fixes)
On 03/17/2010 05:07 AM, Konstantin Kolinko wrote: Thank you for all your votes and feedback. I am tallying the results below. Perhaps you can put those that passed directly inside status.txt (somewhere near the top I presume) as a constant and clear reminder. However any other location is fine with me, but should be somewhere in the SVN. Regards -- ^TM - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[RESULT] (Was: [VOTE] C-T-R for any translation fixes)
Thank you for all your votes and feedback.
I am tallying the results below.
>> 1. Commit-Then-Review for any documentation, including JavaDoc and code
>> comments.
>
> Already decided. No need to vote.
>
> 2. Allow C-T-R for changes to svn properties:
>
+1: Konstantin, Tim
Mark: +1 for line endings, +0 for the rest
0: Rainer, Filip, Yoav
-1: Mladen, Bill: because the proposal is too wide ("it can mean
anything and nothing", and
because for some of those changes "one needs a good reason")
RESULT: Does not pass
> 3. Allow C-T-R for any whitespace changes:
> These are generally discouraged, but might be necessary to ease
> backporting of patches.
+1: Konstantin, Mladen, Rainer, Tim
Mark: +1. Only if required to ease back-porting.
-1: Filip: "makes tracing down when and how code changed a pain. It's
not beneficial."
0: Yoav, Bill
RESULT: Passes
> 4. Allow C-T-R for trivial fixes to English messages that are in resource
> files
> and those that are inline in the code. This includes typos and rephrasing,
> but does not include adding/removing message parameters.
+1: Konstantin, Mladen, Rainer, Yoav, Tim, Mark
0: Filip, Bill
RESULT: Passes
> 5. Allow C-T-R for any fixes for non-English resource files.
> The files must use 7-bit characters only. Other symbols must be
> escaped with \u, as does native2ascii.
+1: Konstantin, Mladen, Rainer, Yoav, Tim, Mark (providing that
native2ascii has been used), Bill
0: Filip
RESULT: Passes
> 6. Require some indication in the commit message for code that usually is
> covered by RTC, that this commit was done using C-T-R rule.
+1: Mladen, Rainer, Bill
+0: Mark: Putting CTR at the start works for me.
0: Konstantin, Filip, Yoav, Tim
RESULT: Passes
I did not count the votes by Henri Gomez (probably +1 to 2.,3.,4.,5.)
and by Jean-Frederic Clere (looks like -0 to all),
as those were not clear to me.
Best regards,
Konstantin Kolinko
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48925] ((ServletRequest) request).getLocalAddr() returns "null"
https://issues.apache.org/bugzilla/show_bug.cgi?id=48925 Paul Sipot changed: What|Removed |Added CC||p...@unnservice.com -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48925] New: ((ServletRequest) request).getLocalAddr() returns "null"
https://issues.apache.org/bugzilla/show_bug.cgi?id=48925 Summary: ((ServletRequest) request).getLocalAddr() returns "null" Product: Tomcat Connectors Version: unspecified Platform: PC OS/Version: Linux Status: NEW Severity: major Priority: P2 Component: mod_jk AssignedTo: dev@tomcat.apache.org ReportedBy: p...@unnservice.com The getLocalAddr() method returns null when using mod_jk. I've tried with both mod_jk version 1.2.28 and 1.2.30. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Trivial Update of "MemoryLeakProtection" by SylvainLaurent
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "MemoryLeakProtection" page has been changed by SylvainLaurent.
http://wiki.apache.org/tomcat/MemoryLeakProtection?action=diff&rev1=2&rev2=3
--
In this particular case, the leak is detected, a message is logged and
internal structures of the JDK ({{{ThreadLocalMap}}}) are modified to remove
the reference to the {{{ThreadLocal}}} instance.
- TODO: add an example of log
+ {{{
+ Mar 16, 2010 11:47:24 PM org.apache.catalina.loader.WebappClassLoader
clearThreadLocalMap
+ SEVERE: A web application created a ThreadLocal with key of type
[test.MyThreadLocal] (value [test.mythreadlo...@4dbb9a58]) and a value of type
[test.MyCounter] (value [test.mycoun...@57922f46]) but failed to remove it when
the web application was stopped. To prevent a memory leak, the ThreadLocal has
been forcibly removed.
+ }}}
- Note: this particular leak was actually already cured by previous versions of
tomcat, because static references of classes loaded by the webappclassloader
are nullified (see later).
+ '''Note''': this particular leak was actually already cured by previous
versions of tomcat, because static references of classes loaded by the
webappclassloader are nullified (see later).
=== Webapp class instance as ThreadLocal value ===
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Trivial Update of "MemoryLeakProtection" by SylvainLaurent
Dear Wiki user,
You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change
notification.
The "MemoryLeakProtection" page has been changed by SylvainLaurent.
http://wiki.apache.org/tomcat/MemoryLeakProtection?action=diff&rev1=1&rev2=2
--
This page tries to list them, and shows the situations where leaks can be
detected and fixed.
= Diagnose a classloader leak upon request =
+ Starting with tomcat 6.0.25, the manager webapp has a new "Find Leaks"
button. When triggered, it displays a list of webapps (their context path) that
have been stopped (this includes undeployed and redeployed ones) but whose
classloader failed to be GCed.
+
+ If a leaking webapp is redeployed several times, it will appear as many times
as it actually leaked.
+
+ '''Caution:''' This diagnosis calls {{{System.gc()}}} which may not be
desirable in production environments.
= Different types of leaks that Tomcat can detect (or not) =
+ When a webapp execution is stopped (this encompassed redeploy and undeploy),
tomcat tries to detect and fix leaks.
+
+ Starting with tomcat 6.0.24, messages are logged to indicate the kind of leak
that was detected.
+
== ThreadLocal leaks ==
+ Classloader leaks because of uncleaned {{{ThreadLocal}}} variables are quite
common.
+ Depending on the use cases, they can be detected or not.
=== Custom ThreadLocal class ===
+ Suppose we have the following 3 classes in our webapp :
+
+ {{{
+ public class MyCounter {
+ private int count = 0;
+
+ public void increment() {
+ count++;
+ }
+
+ public int getCount() {
+ return count;
+ }
+ }
+
+ public class MyThreadLocal extends ThreadLocal {
+ }
+
+ public class LeakingServlet extends HttpServlet {
+ private static MyThreadLocal myThreadLocal = new MyThreadLocal();
+
+ protected void doGet(HttpServletRequest request,
+ HttpServletResponse response) throws ServletException,
IOException {
+
+ MyCounter counter = myThreadLocal.get();
+ if (counter == null) {
+ counter = new MyCounter();
+ myThreadLocal.set(counter);
+ }
+
+ response.getWriter().println(
+ "The current thread served this servlet " +
counter.getCount()
+ + " times");
+ counter.increment();
+ }
+ }
+ }}}
+
+ If the {{{LeakingServlet}}} is invoked at least once and the Thread that
served it is not stopped, then we created a classloader leak !
+
+ The leak is caused because we have a custom class for the {{{ThreadLocal}}}
instance, and also a custom class for the value bound to the Thread. Actually
the important thing is that both classes were loaded by the webapp classloader.
+
+ Hopefully tomcat 6.0.24 can detect the leak when the application is stopped:
each Thread in the JVM is examined, and the internal structures of the Thread
and {{{ThreadLocal}}} classes are introspected to see if either the
{{{ThreadLocal}}} instance of the value bound to it were loaded by the
{{{WebAppClassLoader}}} of the application being stopped.
+
+ In this particular case, the leak is detected, a message is logged and
internal structures of the JDK ({{{ThreadLocalMap}}}) are modified to remove
the reference to the {{{ThreadLocal}}} instance.
+
+ TODO: add an example of log
+
+ Note: this particular leak was actually already cured by previous versions of
tomcat, because static references of classes loaded by the webappclassloader
are nullified (see later).
=== Webapp class instance as ThreadLocal value ===
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "MemoryLeakProtection" by Sylva inLaurent
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "MemoryLeakProtection" page has been changed by SylvainLaurent. http://wiki.apache.org/tomcat/MemoryLeakProtection -- New page: ''' !! This page is under construction !! ''' For some time Tomcat has had some means of protection against memory leaks when stopping or redeploying applications. This page tries to list them, and shows the situations where leaks can be detected and fixed. = Diagnose a classloader leak upon request = = Different types of leaks that Tomcat can detect (or not) = == ThreadLocal leaks == === Custom ThreadLocal class === === Webapp class instance as ThreadLocal value === === Webapp class instance indirectly held through a ThreadLocal value === == ThreadLocal pseudo-leak == == Threads ContextClassLoader == === Threads spawned by JRE classes === === Threads spawned by classes loaded by the common classloader === === Threads spawned by webapps === == Child classloaders == == static class variables == == LogFactory == == JavaBean Introspector cache == == JDBC driver registration == == RMI target == = Summary matrix = == References == [[http://java.dzone.com/articles/memory-leak-protection-tomcat|Mark Thomas interview on DZone]] Related issues * [[https://issues.apache.org/bugzilla/show_bug.cgi?id=48837|48837]] - Memory leaks protection does not cure leaks triggered by JSP pages code * - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48922] org.apache.catalina.connector.Request clone static SimpleDateFormat
https://issues.apache.org/bugzilla/show_bug.cgi?id=48922 Mark Thomas changed: What|Removed |Added Severity|minor |enhancement -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48737] JspCompilationContext assumes that tagfile with a path starting with META-INF are in jars without checking
https://issues.apache.org/bugzilla/show_bug.cgi?id=48737 --- Comment #3 from Mark Thomas 2010-03-16 15:15:57 UTC --- That would be what the 6.0.26 change log is for. -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48737] JspCompilationContext assumes that tagfile with a path starting with META-INF are in jars without checking
https://issues.apache.org/bugzilla/show_bug.cgi?id=48737 --- Comment #2 from Fabrizio Giustina 2010-03-16 14:42:10 UTC --- (In reply to comment #1) > Thanks for the patch. > > This has been fixed in trunk and proposed for 6.0.x great! Can you tell if it has been included in 6.0.26? I couldn't find a good way to guess this from bugzilla... -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48922] New: org.apache.catalina.connector.Request clone static SimpleDateFormat
https://issues.apache.org/bugzilla/show_bug.cgi?id=48922
Summary: org.apache.catalina.connector.Request clone static
SimpleDateFormat
Product: Tomcat 6
Version: unspecified
Platform: All
OS/Version: All
Status: NEW
Severity: minor
Priority: P2
Component: Catalina
AssignedTo: dev@tomcat.apache.org
ReportedBy: xmed...@gmail.com
Faster usage of the thread unsafe SimpleDateFormat is:
private static final SimpleDateFormat FORMAT_PROTOTYPE = new
SimpleDateFormat("...", Locale.ROOT);
static {
format.setTimeZone(GMT_ZONE);
}
protected SimpleDateFormat format = (SimpleDateFormat)FORMAT_PROTOTYPE.clone();
Please, apply this pattern to the formats[] field. It shoudl speed up the
request processing a little bit.
Thanks
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "TomcatTrackNA10_PMC_Sessions " by JeanFredericClere
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "TomcatTrackNA10_PMC_Sessions" page has been changed by JeanFredericClere. http://wiki.apache.org/tomcat/TomcatTrackNA10_PMC_Sessions?action=diff&rev1=1&rev2=2 -- + The idea is to have at least a day of Tomcat in the mean ApacheConNA10 track Additionally we will run BOFs or Meetups on one evening. - The idea is to have at least a day of Tomcat in the mean ApacheConNA10 track - Additionally we will run BOFs or Meetups on one evening. So something like (from the old http://wiki.apache.org/tomcat/TomcatTrackUs09_PMC_Sessions) - 1 - Have an introduction. + . 1 - Have an introduction. - 2 - Have more details presentation on the new tech (Tomcat7, Servlet 3.0) + . 2 - Have more details presentation on the new tech (Tomcat7, Servlet 3.0) - 3 - Have a remainder of the existing new stuff (Bayeux, Comet, jdbc-pool, tomcat-lite). + . 3 - Have a remainder of the existing new stuff (Bayeux, Comet, jdbc-pool, tomcat-lite). - 4 - Have well known stuff, like admin/conf stuff, mod_jk/mod_proxy and clustering. + . 4 - Have well known stuff, like admin/conf stuff, mod_jk/mod_proxy and clustering. - 5 - A bunch of more technical presentations. + . 5 - A bunch of more technical presentations. - Look to http://wiki.apache.org/tomcat/TomcatTrackUs09_PMC_Sessions to see how to write a proposal: Something like: + Look to http://wiki.apache.org/tomcat/TomcatTrackUs09_PMC_Sessions to see how to write a proposal. + + Something like: + TITLE + ABSTRACT + PRESENTER BIO. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
[Tomcat Wiki] Update of "TomcatTrackNA10_PMC_Sessions " by JeanFredericClere
Dear Wiki user, You have subscribed to a wiki page or wiki category on "Tomcat Wiki" for change notification. The "TomcatTrackNA10_PMC_Sessions" page has been changed by JeanFredericClere. http://wiki.apache.org/tomcat/TomcatTrackNA10_PMC_Sessions -- New page: The idea is to have at least a day of Tomcat in the mean ApacheConNA10 track Additionally we will run BOFs or Meetups on one evening. So something like (from the old http://wiki.apache.org/tomcat/TomcatTrackUs09_PMC_Sessions) 1 - Have an introduction. 2 - Have more details presentation on the new tech (Tomcat7, Servlet 3.0) 3 - Have a remainder of the existing new stuff (Bayeux, Comet, jdbc-pool, tomcat-lite). 4 - Have well known stuff, like admin/conf stuff, mod_jk/mod_proxy and clustering. 5 - A bunch of more technical presentations. Look to http://wiki.apache.org/tomcat/TomcatTrackUs09_PMC_Sessions to see how to write a proposal: Something like: TITLE ABSTRACT PRESENTER BIO. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48252] StackOverflowError in NioEndpoint.setProperty when setting jkHome
https://issues.apache.org/bugzilla/show_bug.cgi?id=48252 William Leung changed: What|Removed |Added CC||l...@21cn.com --- Comment #5 from William Leung 2010-03-16 08:08:29 UTC --- (In reply to comment #4) > Created an attachment (id=25134) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25134) [details] > Patch in other way > > We have this problem either. > > And unfortunately we use a JVM which generate a coredump while stack overflow. > -- Java VM: Java HotSpot(TM) Server VM (11.0-b16 mixed mode solaris-sparc) > > I patch the tomcat source in other way BTW, We found this issue in tomcat 6.0.16 SunOS 5.10 Generic_139555-08 sun4v sparc SUNW,SPARC-Enterprise-T5120 -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48252] StackOverflowError in NioEndpoint.setProperty when setting jkHome
https://issues.apache.org/bugzilla/show_bug.cgi?id=48252 William Leung changed: What|Removed |Added Attachment #24573|1 |0 is obsolete|| -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
DO NOT REPLY [Bug 48252] StackOverflowError in NioEndpoint.setProperty when setting jkHome
https://issues.apache.org/bugzilla/show_bug.cgi?id=48252 William Leung changed: What|Removed |Added Attachment #24573|0 |1 is obsolete|| --- Comment #4 from William Leung 2010-03-16 07:57:01 UTC --- Created an attachment (id=25134) --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25134) Patch in other way We have this problem either. And unfortunately we use a JVM which generate a coredump while stack overflow. -- Java VM: Java HotSpot(TM) Server VM (11.0-b16 mixed mode solaris-sparc) I patch the tomcat source in other way -- Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the assignee for the bug. - To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org
